<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>226905</bug_id>
          
          <creation_ts>2021-06-10 16:25:47 -0700</creation_ts>
          <short_desc>[CMake][GTK][WPE] Improve error message when libsoup3 is not found</short_desc>
          <delta_ts>2021-06-10 21:52:36 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Alberto Lopez Perez">clopez</reporter>
          <assigned_to name="Carlos Alberto Lopez Perez">clopez</assigned_to>
          <cc>annulen</cc>
    
    <cc>aperez</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>don.olmstead</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>kbr</cc>
    
    <cc>pnormand</cc>
    
    <cc>ryuan.choi</cc>
    
    <cc>sergio</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1768802</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2021-06-10 16:25:47 -0700</bug_when>
    <thetext>The packaging bots have been failing to build for a while because SOUP3 is enabled by default and this bots don&apos;t have libsoup3 installed on the local jhbuild or the local distro

CMake Error at /usr/share/cmake-3.16/Modules/FindPkgConfig.cmake:463 (message):
  A required package was not found
Call Stack (most recent call first):
  /usr/share/cmake-3.16/Modules/FindPkgConfig.cmake:643 (_pkg_check_modules_internal)
  Source/cmake/FindLibSoup.cmake:45 (pkg_check_modules)
  Source/cmake/WebKitFindPackage.cmake:105 (_find_package)
  Source/cmake/OptionsGTK.cmake:216 (find_package)
  Source/cmake/WebKitCommon.cmake:216 (include)
  CMakeLists.txt:20 (include)


https://build.webkit.org/#/builders/30/builds/127/steps/8/logs/stdio


I think it will be an improvement to be more clear with this error.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1768805</commentid>
    <comment_count>1</comment_count>
      <attachid>431159</attachid>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2021-06-10 16:28:39 -0700</bug_when>
    <thetext>Created attachment 431159
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1768877</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-06-10 21:52:31 -0700</bug_when>
    <thetext>Committed r278753 (238714@main): &lt;https://commits.webkit.org/238714@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431159.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>431159</attachid>
            <date>2021-06-10 16:28:39 -0700</date>
            <delta_ts>2021-06-10 21:52:34 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-226905-20210611012838.patch</filename>
            <type>text/plain</type>
            <size>2939</size>
            <attacher name="Carlos Alberto Lopez Perez">clopez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NzM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu
ZExpYlNvdXAuY21ha2UgYi9Tb3VyY2UvY21ha2UvRmluZExpYlNvdXAuY21ha2UKaW5kZXggNmMx
NDlhMzc3NzhmYmExNjc1NGNiNmUzZDY1NDljNTYwZmUxODg3MC4uY2ZjMjM2YjE0OTZhYWY1N2Ex
YmY3OTFmZGYzNTkxZjc3OGM2MWZhZiAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL0ZpbmRMaWJT
b3VwLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kTGliU291cC5jbWFrZQpAQCAtNDIsNyAr
NDIsNyBAQCBlbmRpZiAoKQogIyAucGMgZmlsZSwgc28gd2UgbmVlZCB0byByZWx5IG9uIFBDX0xJ
QlNPVVBfVkVSU0lPTiBhbmQgUkVRVUlSRSB0aGUgLnBjIGZpbGUKICMgdG8gYmUgZm91bmQuCiBm
aW5kX3BhY2thZ2UoUGtnQ29uZmlnIFFVSUVUKQotcGtnX2NoZWNrX21vZHVsZXMoUENfTElCU09V
UCBSRVFVSVJFRCBRVUlFVCAibGlic291cC0ke0xJQlNPVVBfQVBJX1ZFUlNJT059IikKK3BrZ19j
aGVja19tb2R1bGVzKFBDX0xJQlNPVVAgUVVJRVQgImxpYnNvdXAtJHtMSUJTT1VQX0FQSV9WRVJT
SU9OfSIpCiAKIGZpbmRfcGF0aChMSUJTT1VQX0lOQ0xVREVfRElSUwogICAgIE5BTUVTIGxpYnNv
dXAvc291cC5oCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZSBiL1Nv
dXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGZmNjI5ODdkNmVkNmUxMTNkNjAwZDI3
MmIzODkwOTI4N2IzYWNlZDAuLjdkZTJkNjA0NmE5ODgzOTY4N2VkMjc3MDA5YmQ5ZmQ0ZWI1YzJm
ZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCisrKyBiL1NvdXJj
ZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0yMTMsNyArMjEzLDE1IEBAIGVsc2UgKCkKICAg
ICBzZXQoU09VUF9BUElfVkVSU0lPTiAzLjApCiAgICAgc2V0KEVOQUJMRV9TRVJWRVJfUFJFQ09O
TkVDVCBPTikKIGVuZGlmICgpCi1maW5kX3BhY2thZ2UoTGliU291cCAke1NPVVBfTUlOSU1VTV9W
RVJTSU9OfSBSRVFVSVJFRCkKK2ZpbmRfcGFja2FnZShMaWJTb3VwICR7U09VUF9NSU5JTVVNX1ZF
UlNJT059KQorCitpZiAoTk9UIExpYlNvdXBfRk9VTkQpCitpZiAoVVNFX1NPVVAyKQorICAgIG1l
c3NhZ2UoRkFUQUxfRVJST1IgImxpYnNvdXAgaXMgcmVxdWlyZWQuIikKK2Vsc2UgKCkKKyAgICBt
ZXNzYWdlKEZBVEFMX0VSUk9SICJsaWJzb3VwIDMgaXMgcmVxdWlyZWQuIEVuYWJsZSBVU0VfU09V
UDIgdG8gdXNlIGxpYnNvdXAgMiAoZGlzYWJsZXMgSFRUUC8yKSIpCitlbmRpZiAoKQorZW5kaWYg
KCkKIAogaWYgKFVTRV9HVEs0KQogICAgIHNldChXRUJLSVRHVEtfQVBJX1ZFUlNJT04gNS4wKQpk
aWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21ha2UgYi9Tb3VyY2UvY21ha2Uv
T3B0aW9uc1dQRS5jbWFrZQppbmRleCA0ZDVhNmM2YWFkNGIxZDljOWYyNDE1NDc0YzI0ODRlOTA0
MWU3MTIyLi5hYWQ5N2YzNDcxMmY0NDliNDA5YTlhYjA2NTU4Zjg0NjNmY2E0OTdkIDEwMDY0NAot
LS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc1dQRS5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0
aW9uc1dQRS5jbWFrZQpAQCAtMTMyLDcgKzEzMiwxNSBAQCBlbHNlICgpCiAgICAgc2V0KFdQRV9B
UElfRE9DX1ZFUlNJT04gMS4wKQogICAgIHNldChFTkFCTEVfU0VSVkVSX1BSRUNPTk5FQ1QgT04p
CiBlbmRpZiAoKQotZmluZF9wYWNrYWdlKExpYlNvdXAgJHtTT1VQX01JTklNVU1fVkVSU0lPTn0g
UkVRVUlSRUQpCitmaW5kX3BhY2thZ2UoTGliU291cCAke1NPVVBfTUlOSU1VTV9WRVJTSU9OfSkK
KworaWYgKE5PVCBMaWJTb3VwX0ZPVU5EKQoraWYgKFVTRV9TT1VQMikKKyAgICBtZXNzYWdlKEZB
VEFMX0VSUk9SICJsaWJzb3VwIGlzIHJlcXVpcmVkLiIpCitlbHNlICgpCisgICAgbWVzc2FnZShG
QVRBTF9FUlJPUiAibGlic291cCAzIGlzIHJlcXVpcmVkLiBFbmFibGUgVVNFX1NPVVAyIHRvIHVz
ZSBsaWJzb3VwIDIgKGRpc2FibGVzIEhUVFAvMikiKQorZW5kaWYgKCkKK2VuZGlmICgpCiAKIGlm
IChXUEVfQVBJX1ZFUlNJT04gVkVSU0lPTl9FUVVBTCAiMS4wIikKICAgICBDQUxDVUxBVEVfTElC
UkFSWV9WRVJTSU9OU19GUk9NX0xJQlRPT0xfVFJJUExFKFdFQktJVCAxOCAwIDE1KQpkaWZmIC0t
Z2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGI3ZjdjMmI2M2FhYjIxNzI1MTZjMDk5
NDNlNzNmYjUwNzc3OThlOTcuLjJmMmQzNmFiMjhjZGVhNTQ2NGY2NmFiZjUwZTlhNTNkNzI5ZTA2
NjUgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBA
QAorMjAyMS0wNi0xMCAgQ2FybG9zIEFsYmVydG8gTG9wZXogUGVyZXogIDxjbG9wZXpAaWdhbGlh
LmNvbT4KKworICAgICAgICBbQ01ha2VdW0dUS11bV1BFXSBJbXByb3ZlIGVycm9yIG1lc3NhZ2Ug
d2hlbiBsaWJzb3VwMyBpcyBub3QgZm91bmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTIyNjkwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgIFdoZW4gbGlic291cCAzIGlzIG5vdCBmb3VuZCBiZSBtb3JlIGNs
ZWFyIGFib3V0IHRoZSBwcm9ibGVtIGFuZAorICAgICAgICBvZmZlciBwb3NzaWJsZSB3b3JrYXJv
dW5kIHRvIGNvbnRpbnVlIHRoZSBidWlsZC4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9GaW5k
TGliU291cC5jbWFrZToKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZToK
KyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc1dQRS5jbWFrZToKKwogMjAyMS0wNi0xMCAg
UGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dQRV0g
RW5hYmxlIENvZyBmb3IgZGV2ZWxvcGVyIGJ1aWxkcwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>