<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>226901</bug_id>
          
          <creation_ts>2021-06-10 15:06:01 -0700</creation_ts>
          <short_desc>[REGRESSION][Curl] Network::ResourceTiming are broken after r278391</short_desc>
          <delta_ts>2021-06-10 20:38:21 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yury Semikhatsky">yurys</reporter>
          <assigned_to name="Yury Semikhatsky">yurys</assigned_to>
          <cc>achristensen</cc>
    
    <cc>basuke</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>fujii</cc>
    
    <cc>galpeter</cc>
    
    <cc>inspector-bugzilla-changes</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1768760</commentid>
    <comment_count>0</comment_count>
    <who name="Yury Semikhatsky">yurys</who>
    <bug_when>2021-06-10 15:06:01 -0700</bug_when>
    <thetext>https://trac.webkit.org/changeset/278391/webkit changed how InspectorNetworkAgent::buildObjectForTiming serializes NetworkLoadMetrics to the inspector protocol. millisecondsSinceFetchStart subtracts fetchStart to get relative values for most of the metrics. In Curl implementation fetchStart is always 0 which results in incorrect values sent over the protocol.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1768814</commentid>
    <comment_count>1</comment_count>
      <attachid>431162</attachid>
    <who name="Yury Semikhatsky">yurys</who>
    <bug_when>2021-06-10 16:51:22 -0700</bug_when>
    <thetext>Created attachment 431162
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1768821</commentid>
    <comment_count>2</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2021-06-10 17:02:45 -0700</bug_when>
    <thetext>Don&apos;t you need to set redirectStart? Cocoa port does.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1768823</commentid>
    <comment_count>3</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2021-06-10 17:15:06 -0700</bug_when>
    <thetext>It would be great the following WinCairo test failures are fixed.

fast/dom/webtiming.html [ Failure ]
http/tests/misc/webtiming-cross-origin-redirect.py [ Failure ]
http/tests/misc/webtiming-one-redirect.py [ Failure ]
http/tests/misc/webtiming-two-redirects.py [ Failure ]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1768824</commentid>
    <comment_count>4</comment_count>
    <who name="Yury Semikhatsky">yurys</who>
    <bug_when>2021-06-10 17:24:08 -0700</bug_when>
    <thetext>(In reply to Fujii Hironori from comment #2)
&gt; Don&apos;t you need to set redirectStart? Cocoa port does.

I think you are write, I noticed that redirectSart was also missing but decided not to touch it since it was not a part of the regression, can add that too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1768864</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-06-10 20:37:26 -0700</bug_when>
    <thetext>Committed r278752 (238713@main): &lt;https://commits.webkit.org/238713@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431162.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1768865</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-06-10 20:38:21 -0700</bug_when>
    <thetext>&lt;rdar://problem/79176779&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>431162</attachid>
            <date>2021-06-10 16:51:22 -0700</date>
            <delta_ts>2021-06-10 20:37:28 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-226901-20210610165122.patch</filename>
            <type>text/plain</type>
            <size>1545</size>
            <attacher name="Yury Semikhatsky">yurys</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDlkNmFlYzMyMDY4Y2Uy
MDJhYjNlZTEzNjM0NzEzOTM0Njc0NGQwNS4uZWFmOWY5YmRmOGJhZjFhYWIxMTA5ZDdhZjVhYTc0
ZjQ0NWNkZmRjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA2LTEwICBZdXJ5
IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtSRUdSRVNTSU9O
XVtDdXJsXSBOZXR3b3JrOjpSZXNvdXJjZVRpbWluZyBhcmUgYnJva2VuIGFmdGVyIHIyNzgzOTEK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjkwMQor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluaXRpYWxp
emUgZmV0Y2hTdGFydCB3aXRoIHN0YXJ0VGltZSBpbiBDdXJsLgorCisgICAgICAgIE5vIG5ldyB0
ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsQ29udGV4dC5jcHA6
CisgICAgICAgIChXZWJDb3JlOjpDdXJsSGFuZGxlOjpnZXROZXR3b3JrTG9hZE1ldHJpY3MpOgor
CiAyMDIxLTA2LTEwICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+
CiAKICAgICAgICAgTW92ZSBUaW1pbmctQWxsb3ctT3JpZ2luIGNoZWNrcyB0byB0aGUgbmV0d29y
ayBwcm9jZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1
cmwvQ3VybENvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJs
L0N1cmxDb250ZXh0LmNwcAppbmRleCA4ZWQwOWIyYWJjNWQ2NDdmYWI2ZGMwMWI5ODYxNmUxNTNm
Njc4YjRlLi5lMWM2Y2M0M2E4NWVlN2JhYzM5MWNhNDk0YWRhNWY0YzA1ZDA5ZjZjIDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybENvbnRleHQuY3Bw
CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsQ29udGV4dC5j
cHAKQEAgLTc5Myw2ICs3OTMsNyBAQCBzdGQ6Om9wdGlvbmFsPE5ldHdvcmtMb2FkTWV0cmljcz4g
Q3VybEhhbmRsZTo6Z2V0TmV0d29ya0xvYWRNZXRyaWNzKE1vbm90b25pY1RpbQogCiAgICAgTmV0
d29ya0xvYWRNZXRyaWNzIG5ldHdvcmtMb2FkTWV0cmljczsKIAorICAgIG5ldHdvcmtMb2FkTWV0
cmljcy5mZXRjaFN0YXJ0ID0gc3RhcnRUaW1lOwogICAgIG5ldHdvcmtMb2FkTWV0cmljcy5kb21h
aW5Mb29rdXBTdGFydCA9IHN0YXJ0VGltZTsKICAgICBuZXR3b3JrTG9hZE1ldHJpY3MuZG9tYWlu
TG9va3VwRW5kID0gc3RhcnRUaW1lICsgU2Vjb25kcyhuYW1lTG9va3VwKTsKICAgICBuZXR3b3Jr
TG9hZE1ldHJpY3MuY29ubmVjdFN0YXJ0ID0gbmV0d29ya0xvYWRNZXRyaWNzLmRvbWFpbkxvb2t1
cEVuZDsK
</data>

          </attachment>
      

    </bug>

</bugzilla>