226896 2021-06-10 13:07:55 -0700 Some http/tests/ are crashing with ASSERTION FAILED: isInRoutingArbitrationForToken(token) || m_setupArbitrationOngoing 2021-06-16 15:22:15 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=226787 InRadar P2 Normal --- 1 tsavell peng.liu6 darin eric.carlson ews-watchlist glenn jer.noble peng.liu6 philipj sergio webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1768690 0 tsavell 2021-06-10 13:07:55 -0700 I have found 2 tests so far crashing with this assert, will add more as I find them: http/tests/media/media-source/mediasource-play-then-seek-back-with-remote-control.html http/tests/canvas/webgl/origin-clean-conformance.html History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=http%2Ftests%2Fmedia%2Fmedia-source%2Fmediasource-play-then-seek-back-with-remote-control.html&test=http%2Ftests%2Fcanvas%2Fwebgl%2Forigin-clean-conformance.html log: https://build.webkit.org/results/Apple-BigSur-Debug-WK2-Tests/r278699%20(2294)/http/tests/canvas/webgl/origin-clean-conformance-stderr.txt 1768691 1 webkit-bug-importer 2021-06-10 13:08:30 -0700 <rdar://problem/79156052> 1768696 2 ryanhaddad 2021-06-10 13:16:09 -0700 Maybe this started with https://trac.webkit.org/changeset/278374/webkit? 1768697 3 ryanhaddad 2021-06-10 13:16:42 -0700 ASSERTION FAILED: isInRoutingArbitrationForToken(token) || m_setupArbitrationOngoing ./platform/audio/mac/SharedRoutingArbitrator.mm(123) : void WebCore::SharedRoutingArbitrator::endRoutingArbitrationForToken(const WebCore::SharedRoutingArbitrator::Token &) 1 0x113791579 WTFCrash 2 0x12d45b1fb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x12f076cb1 WebCore::SharedRoutingArbitrator::endRoutingArbitrationForToken(WebCore::SharedRoutingArbitrator::Token const&) 4 0x11d1d329c WebKit::AudioSessionRoutingArbitratorProxy::endRoutingArbitration() 5 0x11bc44234 void IPC::callMemberFunctionImpl<WebKit::AudioSessionRoutingArbitratorProxy, void (WebKit::AudioSessionRoutingArbitratorProxy::*)(), std::__1::tuple<> >(WebKit::AudioSessionRoutingArbitratorProxy*, void (WebKit::AudioSessionRoutingArbitratorProxy::*)(), std::__1::tuple<>&&, std::__1::integer_sequence<unsigned long>) 6 0x11bc43e40 void IPC::callMemberFunction<WebKit::AudioSessionRoutingArbitratorProxy, void (WebKit::AudioSessionRoutingArbitratorProxy::*)(), std::__1::tuple<>, std::__1::integer_sequence<unsigned long> >(std::__1::tuple<>&&, WebKit::AudioSessionRoutingArbitratorProxy*, void (WebKit::AudioSessionRoutingArbitratorProxy::*)()) 7 0x11bc3f808 void IPC::handleMessage<Messages::AudioSessionRoutingArbitratorProxy::EndRoutingArbitration, WebKit::AudioSessionRoutingArbitratorProxy, void (WebKit::AudioSessionRoutingArbitratorProxy::*)()>(IPC::Decoder&, WebKit::AudioSessionRoutingArbitratorProxy*, void (WebKit::AudioSessionRoutingArbitratorProxy::*)()) 8 0x11bc3f573 WebKit::AudioSessionRoutingArbitratorProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 9 0x11c19f4e5 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) 10 0x11d0fafde WebKit::AuxiliaryProcessProxy::dispatchMessage(IPC::Connection&, IPC::Decoder&) 11 0x11d3d6ecf WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 1769168 4 ap 2021-06-11 19:45:34 -0700 Is this different from bug 226787? 1769985 5 peng.liu6 2021-06-15 15:47:02 -0700 (In reply to Alexey Proskuryakov from comment #4) > Is this different from bug 226787? I think so. 1770030 6 431502 peng.liu6 2021-06-15 17:16:03 -0700 Created attachment 431502 Patch 1770085 7 ews-feeder 2021-06-15 22:40:34 -0700 Committed r278922 (238853@main): <https://commits.webkit.org/238853@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431502. 1770212 8 431502 darin 2021-06-16 09:11:04 -0700 Comment on attachment 431502 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431502&action=review > Source/WebCore/platform/audio/mac/SharedRoutingArbitrator.mm:124 > + if (m_tokens.contains(token)) > + m_tokens.remove(token); Why check contains before calling remove? This adds an additional hash table lookup and has no other effect other than making the code run more slowly. The point of this patch was to remove an incorrect assertion. Why change the code outside the assertion at all? 1770232 9 431502 peng.liu6 2021-06-16 09:57:38 -0700 Comment on attachment 431502 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431502&action=review >> Source/WebCore/platform/audio/mac/SharedRoutingArbitrator.mm:124 >> + m_tokens.remove(token); > > Why check contains before calling remove? This adds an additional hash table lookup and has no other effect other than making the code run more slowly. > > The point of this patch was to remove an incorrect assertion. Why change the code outside the assertion at all? Oops. I thought the remove() function assumes the item must exist in the hash set. So I added the check. Will remove it. 1770265 10 peng.liu6 2021-06-16 10:41:01 -0700 Reopen this bug to land a follow-up fix. 1770298 11 431573 peng.liu6 2021-06-16 11:32:43 -0700 Created attachment 431573 A follow-up patch 1770432 12 ews-feeder 2021-06-16 15:22:13 -0700 Committed r278958 (238886@main): <https://commits.webkit.org/238886@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431573. 431502 2021-06-15 17:16:03 -0700 2021-06-15 22:40:35 -0700 Patch bug-226896-20210615171602.patch text/plain 1855 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4ODExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGNmYzFjM2JmNGIxNzU2 NWY3ZjQ2ZTljZDc2ZDEzOGEwYzI0YTEwZi4uNmFlYjZmY2M1NzM2Y2Y0ZmEzM2M3ZWQyMzEwNzI1 OTcxMmU0MTJkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA2LTE1ICBQZW5n IExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CisKKyAgICAgICAgc29tZSBodHRwL3Rlc3RzLyBh cmUgY3Jhc2hpbmcgd2l0aCBBU1NFUlRJT04gRkFJTEVEOiBpc0luUm91dGluZ0FyYml0cmF0aW9u Rm9yVG9rZW4odG9rZW4pIHx8IG1fc2V0dXBBcmJpdHJhdGlvbk9uZ29pbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjg5NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gdGhlIGBSb3V0aW5nQXJi aXRlcmAgZmFpbHMgdG8gYC1bYmVnaW5BcmJpdHJhdGlvbldpdGhDYXRlZ29yeTpjb21wbGV0aW9u SGFuZGxlcjpdYCwKKyAgICAgICAgYSB0b2tlbiB3b24ndCBiZSBhZGRlZCB0byBgbV90b2tlbnNg LiBUaGVyZWZvcmUsIHdlIHNob3VsZCByZW1vdmUgdGhlIGFzc2VydGlvbgorICAgICAgICBpbiBg U2hhcmVkUm91dGluZ0FyYml0cmF0b3I6OmVuZFJvdXRpbmdBcmJpdHJhdGlvbkZvclRva2VuKClg LgorCisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vbWFjL1NoYXJlZFJvdXRpbmdBcmJpdHJhdG9y Lm1tOgorICAgICAgICAoV2ViQ29yZTo6U2hhcmVkUm91dGluZ0FyYml0cmF0b3I6OmVuZFJvdXRp bmdBcmJpdHJhdGlvbkZvclRva2VuKToKKwogMjAyMS0wNi0xMSAgQ2hyaXMgRHVtZXogIDxjZHVt ZXpAYXBwbGUuY29tPgogCiAgICAgICAgIExhemlseSBjb21wdXRlIFNlY3VyaXR5T3JpZ2luOjpt X2lzUG90ZW50aWFsbHlUcnVzdHdvcnRoeSBmb3IgcGVyZm9ybWFuY2UKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL21hYy9TaGFyZWRSb3V0aW5nQXJiaXRyYXRvci5t bSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL21hYy9TaGFyZWRSb3V0aW5nQXJiaXRy YXRvci5tbQppbmRleCAwMGE4OTE1MTM1MTQ1NjAzNTAxMGJmYWVkMjFmZWIxZWI3MGI1NWM0Li5j ZjkxM2RlNjNmZDc4NjYzMDRmZjdlMGQzNDQxNWFhMDJlNDFlNGUyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9tYWMvU2hhcmVkUm91dGluZ0FyYml0cmF0b3IubW0K KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vbWFjL1NoYXJlZFJvdXRpbmdBcmJp dHJhdG9yLm1tCkBAIC0xMjAsOCArMTIwLDggQEAgdm9pZCBTaGFyZWRSb3V0aW5nQXJiaXRyYXRv cjo6YmVnaW5Sb3V0aW5nQXJiaXRyYXRpb25Gb3JUb2tlbihjb25zdCBUb2tlbiYgdG9rZW4KIAog dm9pZCBTaGFyZWRSb3V0aW5nQXJiaXRyYXRvcjo6ZW5kUm91dGluZ0FyYml0cmF0aW9uRm9yVG9r ZW4oY29uc3QgVG9rZW4mIHRva2VuKQogewotICAgIEFTU0VSVChpc0luUm91dGluZ0FyYml0cmF0 aW9uRm9yVG9rZW4odG9rZW4pIHx8IG1fc2V0dXBBcmJpdHJhdGlvbk9uZ29pbmcpOwotICAgIG1f dG9rZW5zLnJlbW92ZSh0b2tlbik7CisgICAgaWYgKG1fdG9rZW5zLmNvbnRhaW5zKHRva2VuKSkK KyAgICAgICAgbV90b2tlbnMucmVtb3ZlKHRva2VuKTsKIAogICAgIGlmICghbV90b2tlbnMuY29t cHV0ZXNFbXB0eSgpKQogICAgICAgICByZXR1cm47Cg== 431573 2021-06-16 11:32:43 -0700 2021-06-16 15:22:14 -0700 A follow-up patch bug-226896-20210616113242.patch text/plain 1642 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4OTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTYzYzkzYmU0NWU4ZGI2 NjUxYmM0YTAwOWI4NzliNzYyZWM2YjI2Ni4uYjNhOTQwNWEzZDFiYjEzYmE5ZGRlOTk3OGFmZjUy YjU4MTU3N2NkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA2LTE2ICBQZW5n IExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CisKKyAgICAgICAgU29tZSBodHRwL3Rlc3RzLyBh cmUgY3Jhc2hpbmcgd2l0aCBBU1NFUlRJT04gRkFJTEVEOiBpc0luUm91dGluZ0FyYml0cmF0aW9u Rm9yVG9rZW4odG9rZW4pIHx8IG1fc2V0dXBBcmJpdHJhdGlvbk9uZ29pbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjg5NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEEgZm9sbG93LXVwIHBhdGNoIHRv IGZpeCBhbiBpc3N1ZSBpbiByMjc4OTIyLiBSZW1vdmUgdGhlIGNhbGwgdG8gYGNvbnRhaW5zKClg CisgICAgICAgIGJlZm9yZSBgcmVtb3ZlKClgIG9uIGEgYFdlYWtIYXNoU2V0YC4KKworICAgICAg ICAqIHBsYXRmb3JtL2F1ZGlvL21hYy9TaGFyZWRSb3V0aW5nQXJiaXRyYXRvci5tbToKKyAgICAg ICAgKFdlYkNvcmU6OlNoYXJlZFJvdXRpbmdBcmJpdHJhdG9yOjplbmRSb3V0aW5nQXJiaXRyYXRp b25Gb3JUb2tlbik6CisKIDIwMjEtMDYtMTYgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBp Z2FsaWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdIGdzdF9lbGVtZW50X2dldF9yZXF1ZXN0 X3BhZCBkZXByZWNhdGVkIGluIDEuMjAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2F1ZGlvL21hYy9TaGFyZWRSb3V0aW5nQXJiaXRyYXRvci5tbSBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2F1ZGlvL21hYy9TaGFyZWRSb3V0aW5nQXJiaXRyYXRvci5tbQppbmRleCBjZjkx M2RlNjNmZDc4NjYzMDRmZjdlMGQzNDQxNWFhMDJlNDFlNGUyLi5kZDk0NWVjODA3ZTY3M2QwMWYy N2MxMmEyNTE2NzA5NTg4MzViODkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9hdWRpby9tYWMvU2hhcmVkUm91dGluZ0FyYml0cmF0b3IubW0KKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vYXVkaW8vbWFjL1NoYXJlZFJvdXRpbmdBcmJpdHJhdG9yLm1tCkBAIC0xMjAs OCArMTIwLDcgQEAgdm9pZCBTaGFyZWRSb3V0aW5nQXJiaXRyYXRvcjo6YmVnaW5Sb3V0aW5nQXJi aXRyYXRpb25Gb3JUb2tlbihjb25zdCBUb2tlbiYgdG9rZW4KIAogdm9pZCBTaGFyZWRSb3V0aW5n QXJiaXRyYXRvcjo6ZW5kUm91dGluZ0FyYml0cmF0aW9uRm9yVG9rZW4oY29uc3QgVG9rZW4mIHRv a2VuKQogewotICAgIGlmIChtX3Rva2Vucy5jb250YWlucyh0b2tlbikpCi0gICAgICAgIG1fdG9r ZW5zLnJlbW92ZSh0b2tlbik7CisgICAgbV90b2tlbnMucmVtb3ZlKHRva2VuKTsKIAogICAgIGlm ICghbV90b2tlbnMuY29tcHV0ZXNFbXB0eSgpKQogICAgICAgICByZXR1cm47Cg==