226891 2021-06-10 11:48:46 -0700 [webkitcorepy] 6x performance improvement in Memoized 2021-06-10 14:11:19 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=225616 InRadar P2 Normal --- 1 jbedard jbedard aakash_jain dean_johnson dewei_zhu slewis webkit-bug-importer oldest_to_newest 1768641 0 jbedard 2021-06-10 11:48:46 -0700 Dean originally noticed the high cost of inspect.getargspec, and if Memoized is on a hot code path, it can be pretty costly to tooling. 1768643 1 webkit-bug-importer 2021-06-10 11:49:10 -0700 <rdar://problem/79151940> 1768645 2 431103 jbedard 2021-06-10 11:50:44 -0700 Created attachment 431103 Patch 1768676 3 431103 dean_johnson 2021-06-10 12:49:46 -0700 Comment on attachment 431103 Patch Unofficial r+ 1768729 4 ews-feeder 2021-06-10 14:11:17 -0700 Committed r278732 (238695@main): <https://commits.webkit.org/238695@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431103. 431103 2021-06-10 11:50:44 -0700 2021-06-10 14:11:18 -0700 Patch bug-226891-20210610115043.patch text/plain 3352 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3ODcxMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDIxLTA2LTEwICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0Y29yZXB5XSA2eCBwZXJmb3JtYW5jZSBpbXByb3ZlbWVudCBp biBNZW1vaXplZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjI2ODkxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83OTE1MTk0MD4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvbGlicmFyaWVz L3dlYmtpdGNvcmVweS9zZXR1cC5weTogQnVtcCB2ZXJzaW9uLgorICAgICAgICAqIFNjcmlwdHMv bGlicmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkvX19pbml0X18ucHk6IERpdHRvLgor ICAgICAgICAqIFNjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkvZGVj b3JhdG9ycy5weToKKyAgICAgICAgKE1lbW9pemUuX19jYWxsX18uZGVjb3JhdG9yKTogaW5zcGVj dC5nZXRhcmdzcGVjIHJldHJpZXZlcyBtYW55IGJpdHMgb2YKKyAgICAgICAgaW5mb3JtYXRpb24g YWJvdXQgdGhlIGZ1bmN0aW9uIHdlIGRvbid0IGNhcmUgYWJvdXQuIFJldHJpZXZlIGFyZ3VtZW50 cyBtYW51YWxseQorICAgICAgICAoYW5kIG9ubHkgZG8gaXQgb25jZSkgdG8gaW5jcmVhc2UgcGVy Zm9ybWFuY2Ugb2YgTWVtb2l6ZWQgZnVuY3Rpb24gY2FsbHMuCisKIDIwMjEtMDYtMTAgIFRydWl0 dCBTYXZlbGwgIDx0c2F2ZWxsQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgRXdzMTc5IGFu ZCBib3QyNzkgZnJvbSBjb25maWdzCkluZGV4OiBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJr aXRjb3JlcHkvc2V0dXAucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMv d2Via2l0Y29yZXB5L3NldHVwLnB5CShyZXZpc2lvbiAyNzg3MTEpCisrKyBUb29scy9TY3JpcHRz L2xpYnJhcmllcy93ZWJraXRjb3JlcHkvc2V0dXAucHkJKHdvcmtpbmcgY29weSkKQEAgLTMwLDcg KzMwLDcgQEAgZGVmIHJlYWRtZSgpOgogCiBzZXR1cCgKICAgICBuYW1lPSd3ZWJraXRjb3JlcHkn LAotICAgIHZlcnNpb249JzAuNS4xNicsCisgICAgdmVyc2lvbj0nMC41LjE3JywKICAgICBkZXNj cmlwdGlvbj0nTGlicmFyeSBjb250YWluaW5nIHZhcmlvdXMgUHl0aG9uIHN1cHBvcnQgY2xhc3Nl cyBhbmQgZnVuY3Rpb25zLicsCiAgICAgbG9uZ19kZXNjcmlwdGlvbj1yZWFkbWUoKSwKICAgICBj bGFzc2lmaWVycz1bCkluZGV4OiBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkv d2Via2l0Y29yZXB5L19faW5pdF9fLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvbGli cmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkvX19pbml0X18ucHkJKHJldmlzaW9uIDI3 ODcxMSkKKysrIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3Jl cHkvX19pbml0X18ucHkJKHdvcmtpbmcgY29weSkKQEAgLTM3LDcgKzM3LDcgQEAgZnJvbSB3ZWJr aXRjb3JlcHkub3V0cHV0X2NhcHR1cmUgaW1wb3J0IAogZnJvbSB3ZWJraXRjb3JlcHkudGFza19w b29sIGltcG9ydCBUYXNrUG9vbAogZnJvbSB3ZWJraXRjb3JlcHkuY3JlZGVudGlhbHMgaW1wb3J0 IGNyZWRlbnRpYWxzCiAKLXZlcnNpb24gPSBWZXJzaW9uKDAsIDUsIDE2KQordmVyc2lvbiA9IFZl cnNpb24oMCwgNSwgMTcpCiAKIGZyb20gd2Via2l0Y29yZXB5LmF1dG9pbnN0YWxsIGltcG9ydCBQ YWNrYWdlLCBBdXRvSW5zdGFsbAogaWYgc3lzLnZlcnNpb25faW5mbyA+ICgzLCAwKToKSW5kZXg6 IFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkvZGVjb3Jh dG9ycy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3Jl cHkvd2Via2l0Y29yZXB5L2RlY29yYXRvcnMucHkJKHJldmlzaW9uIDI3ODcxMSkKKysrIFRvb2xz L1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkvZGVjb3JhdG9ycy5w eQkod29ya2luZyBjb3B5KQpAQCAtMjAsNyArMjAsNiBAQAogIyBPUiBUT1JUIChJTkNMVURJTkcg TkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVT RQogIyBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZ IE9GIFNVQ0ggREFNQUdFLgogCi1pbXBvcnQgaW5zcGVjdAogaW1wb3J0IHRpbWUKIGZyb20gY29s bGVjdGlvbnMgaW1wb3J0IGRlZmF1bHRkaWN0CiAKQEAgLTM0LDEyICszMywxNCBAQCBjbGFzcyBN ZW1vaXplKG9iamVjdCk6CiAKICAgICBkZWYgX19jYWxsX18oc2VsZiwgZnVuY3Rpb24pOgogICAg ICAgICBkZWYgZGVjb3JhdG9yKCphcmdzLCAqKmt3YXJncyk6CisgICAgICAgICAgICBmYXJncyA9 IGZ1bmN0aW9uLl9fY29kZV9fLmNvX3Zhcm5hbWVzWzpmdW5jdGlvbi5fX2NvZGVfXy5jb19hcmdj b3VudF0KKwogICAgICAgICAgICAgdGltZW91dCA9IHNlbGYudGltZW91dAotICAgICAgICAgICAg aWYgJ3RpbWVvdXQnIG5vdCBpbiBpbnNwZWN0LmdldGFyZ3NwZWMoZnVuY3Rpb24pLmFyZ3M6Cisg ICAgICAgICAgICBpZiAndGltZW91dCcgbm90IGluIGZhcmdzOgogICAgICAgICAgICAgICAgIHRp bWVvdXQgPSBrd2FyZ3MucG9wKCd0aW1lb3V0JywgdGltZW91dCkKIAogICAgICAgICAgICAgY2Fj aGVkID0gc2VsZi5jYWNoZWQKLSAgICAgICAgICAgIGlmICdjYWNoZWQnIG5vdCBpbiBpbnNwZWN0 LmdldGFyZ3NwZWMoZnVuY3Rpb24pLmFyZ3M6CisgICAgICAgICAgICBpZiAnY2FjaGVkJyBub3Qg aW4gZmFyZ3M6CiAgICAgICAgICAgICAgICAgY2FjaGVkID0ga3dhcmdzLnBvcCgnY2FjaGVkJywg Y2FjaGVkKQogCiAgICAgICAgICAgICBrZXlhcmdzID0gYXJncyArIHR1cGxlKHNvcnRlZChbKGtl eSwgdmFsdWUpIGZvciBrZXksIHZhbHVlIGluIGt3YXJncy5pdGVtcygpXSkpCg==