226880 2021-06-10 09:00:40 -0700 Another speculative build fix for Win32. 2021-06-10 10:19:25 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1768566 0 mark.lam 2021-06-10 09:00:40 -0700 We're getting reports of "warning C4206: nonstandard extension used: translation unit is empty" turning into a build error on Win32 ports. By design, we rely on #define flags to make some translation units empty. Hence, we don't want this warning to turn into an error. rdar://79124858 1768570 1 431088 mark.lam 2021-06-10 09:11:23 -0700 Created attachment 431088 proposed patch. 1768596 2 mark.lam 2021-06-10 10:19:25 -0700 Thanks for the review. Landed in r278711: <http://trac.webkit.org/r278711>. 431088 2021-06-10 09:11:23 -0700 2021-06-10 09:58:40 -0700 proposed patch. bug-226880.patch text/plain 1707 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc4NzAzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDIxLTA2LTEwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB bm90aGVyIHNwZWN1bGF0aXZlIGJ1aWxkIGZpeCBmb3IgV2luMzIuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjY4ODAKKyAgICAgICAgcmRhcjovLzc5 MTI0ODU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2UncmUgZ2V0dGluZyByZXBvcnRzIG9mICJ3YXJuaW5nIEM0MjA2OiBub25zdGFuZGFyZCBleHRl bnNpb24gdXNlZDogdHJhbnNsYXRpb24KKyAgICAgICAgdW5pdCBpcyBlbXB0eSIgdHVybmluZyBp bnRvIGEgYnVpbGQgZXJyb3Igb24gV2luMzIgcG9ydHMuICBCeSBkZXNpZ24sIHdlIHJlbHkgb24K KyAgICAgICAgI2RlZmluZSBmbGFncyB0byBtYWtlIHNvbWUgdHJhbnNsYXRpb24gdW5pdHMgZW1w dHkuICBIZW5jZSwgd2UgZG9uJ3Qgd2FudCB0aGlzCisgICAgICAgIHdhcm5pbmcgdG8gdHVybiBp bnRvIGFuIGVycm9yLgorCisgICAgICAgICogY29uZmlnLmg6CisKIDIwMjEtMDYtMTAgIFl1c3Vr ZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBSZW1vdmUgdXNl RGF0YUlDSW5PcHRpbWl6aW5nSklUIG9wdGlvbgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2NvbmZpZy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9jb25maWcuaAko cmV2aXNpb24gMjc4NjcxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2NvbmZpZy5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAwNi0yMDE5 IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAwNi0y MDIxIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqIENvcHlyaWdodCAoQykgMjAw NiBTYW11ZWwgV2VpbmlnIDxzYW0ud2VpbmlnQGdtYWlsLmNvbT4KICAqCiAgKiBUaGlzIGxpYnJh cnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCkBAIC0z OSwzICszOSwxMSBAQAogI2VuZGlmCiAKICNpbmNsdWRlIDx3dGYvRGlzYWxsb3dDVHlwZS5oPgor CisvKiBEaXNhYmxpbmcgd2FybmluZyBDNDIwNjogbm9uc3RhbmRhcmQgZXh0ZW5zaW9uIHVzZWQ6 IHRyYW5zbGF0aW9uIHVuaXQgaXMgZW1wdHkuCisgICBCeSBkZXNpZ24sIHdlIHJlbHkgb24gI2Rl ZmluZSBmbGFncyB0byBtYWtlIHNvbWUgdHJhbnNsYXRpb24gdW5pdHMgZW1wdHkuCisgICBNYWtl IHN1cmUgdGhpcyB3YXJuaW5nIGRvZXMgbm90IHR1cm4gaW50byBhbiBlcnJvci4KKyovCisjaWYg Q09NUElMRVIoTVNWQykKKyNwcmFnbWEgd2FybmluZyhkaXNhYmxlOjQyMDYpCisjZW5kaWYK