226867 2021-06-09 22:11:46 -0700 [MSE] When currentTime is a large value, it takes time to process SourceBufferPrivate::evictCodedFrames(). 2021-06-13 18:50:18 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 toshio.ogasawara webkit-unassigned calvaris don.olmstead eric.carlson ews-watchlist glenn jer.noble philipj sergio tomoki.imai webkit-bug-importer Yousuke.Kimoto oldest_to_newest 1768467 0 toshio.ogasawara 2021-06-09 22:11:46 -0700 SourceBufferPrivate::evictCodedFrames() loops to evict frames in a unit of 30 seconds from MediaTime::zeroTime() to "currentTime - thirtySeconds". In the case of that currentTime is very large (eg. 180,000,000), evictCodedFrames() loops huge times to complete the eviction process. (in the example, it loops 6,000,000 times.) To make matters worse, the looping process is executed even if there is no MediaSample to be evicted in a track buffer. That is a point which should be improved. 1768469 1 431050 toshio.ogasawara 2021-06-09 23:13:55 -0700 Created attachment 431050 patch 1768711 2 ews-feeder 2021-06-10 13:50:47 -0700 Committed r278728 (238691@main): <https://commits.webkit.org/238691@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431050. 1768713 3 webkit-bug-importer 2021-06-10 13:51:22 -0700 <rdar://problem/79158285> 1769314 4 toshio.ogasawara 2021-06-13 18:50:18 -0700 Thank you for the review. 431050 2021-06-09 23:13:55 -0700 2021-06-10 13:50:49 -0700 patch patch.diff text/plain 6650 toshio.ogasawara ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1NWRkMDEwZGJmMGUuLjhjZWU5NjliMmYzYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBA CisyMDIxLTA2LTA5ICBUb3NoaW8gT2dhc2F3YXJhICA8dG9zaGlvLm9nYXNhd2FyYUBhY2Nlc3Mt Y29tcGFueS5jb20+CisKKyAgICAgICAgW01TRV0gV2hlbiBjdXJyZW50VGltZSBpcyBhIGxhcmdl IHZhbHVlLCBpdCB0YWtlcyB0aW1lIHRvIHByb2Nlc3MgU291cmNlQnVmZmVyUHJpdmF0ZTo6ZXZp Y3RDb2RlZEZyYW1lcygpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjI2ODY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBtZWRpYS9tZWRpYS1zb3VyY2UvbWVkaWEtc291cmNlLWV2aWN0LWNvZGVkZnJh bWUtbGFyZ2UtY3VycmVudHRpbWUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBtZWRp YS9tZWRpYS1zb3VyY2UvbWVkaWEtc291cmNlLWV2aWN0LWNvZGVkZnJhbWUtbGFyZ2UtY3VycmVu dHRpbWUuaHRtbDogQWRkZWQuCisKIDIwMjEtMDYtMDkgIEFuZHJlcyBHb256YWxleiAgPGFuZHJl c2dfMjJAYXBwbGUuY29tPgogCiAgICAgICAgIGlPUyAtIFZvaWNlT3ZlciByZWFkcyB0aGUgb2xk IGhlYWRpbmcgdGV4dCB3aGVuIHVwZGF0ZWQgd2l0aCBoZWFkaW5nLmZpcnN0Q2hpbGQuZGF0YS4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL21lZGlhLXNvdXJjZS9tZWRpYS1zb3VyY2Ut ZXZpY3QtY29kZWRmcmFtZS1sYXJnZS1jdXJyZW50dGltZS1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9tZWRpYS9tZWRpYS1zb3VyY2UvbWVkaWEtc291cmNlLWV2aWN0LWNvZGVkZnJhbWUtbGFy Z2UtY3VycmVudHRpbWUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMC4uNzU3NDZmNDlkMzlmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv bWVkaWEvbWVkaWEtc291cmNlL21lZGlhLXNvdXJjZS1ldmljdC1jb2RlZGZyYW1lLWxhcmdlLWN1 cnJlbnR0aW1lLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDggQEAKKworRVZFTlQoc291cmNlb3Bl bikKK0VWRU5UKHVwZGF0ZWVuZCkKK0VYUEVDVEVEIChidWZmZXJlZFJhbmdlcygpID09ICdbIDIw MDAwMDAwMC4uLjIwMDAwMDA1NiBdJykgT0sKK0VYUEVDVEVEICh2aWRlby5jdXJyZW50VGltZSA9 PSAnMjAwMDAwMDQwJykgT0sKK0VYUEVDVEVEIChidWZmZXJlZFJhbmdlcygpID09ICdbIDIwMDAw MDAxMC4uLjIwMDAwMDA1NyBdJykgT0sKK0VORCBPRiBURVNUCisKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL21lZGlhL21lZGlhLXNvdXJjZS9tZWRpYS1zb3VyY2UtZXZpY3QtY29kZWRmcmFtZS1s YXJnZS1jdXJyZW50dGltZS5odG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtc291cmNlL21l ZGlhLXNvdXJjZS1ldmljdC1jb2RlZGZyYW1lLWxhcmdlLWN1cnJlbnR0aW1lLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwLi5jMjUxNjc4YjQxOTEKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1zb3VyY2UvbWVkaWEtc291cmNlLWV2 aWN0LWNvZGVkZnJhbWUtbGFyZ2UtY3VycmVudHRpbWUuaHRtbApAQCAtMCwwICsxLDc1IEBACis8 IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+CisgICAgPHRpdGxlPm1lZGlhLXNvdXJjZS1l dmljdC1jb2RlZGZyYW1lLWxhcmdlLWN1cnJlbnR0aW1lPC90aXRsZT4KKyAgICA8c2NyaXB0IHNy Yz0ibW9jay1tZWRpYS1zb3VyY2UuanMiPjwvc2NyaXB0PgorICAgIDxzY3JpcHQgc3JjPSIuLi92 aWRlby10ZXN0LmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0PgorICAgIHZhciBzb3VyY2U7Cisg ICAgdmFyIHNvdXJjZUJ1ZmZlcjsKKyAgICB2YXIgaW5pdFNlZ21lbnQ7CisKKyAgICBmdW5jdGlv biBidWZmZXJlZFJhbmdlcygpIHsKKyAgICAgICAgdmFyIGJ1ZmZlcmVkUmFuZ2VzID0gJ1sgJzsK KyAgICAgICAgdmFyIHRpbWVSYW5nZXMgPSBzb3VyY2VCdWZmZXIuYnVmZmVyZWQ7CisgICAgICAg IGZvciAodmFyIGkgPSAwIDsgaSA8IHRpbWVSYW5nZXMubGVuZ3RoIDsgaSsrKSB7CisgICAgICAg ICAgICBpZiAoaSkKKyAgICAgICAgICAgICAgICBidWZmZXJlZFJhbmdlcyArPSAnLCAnOworICAg ICAgICAgICAgYnVmZmVyZWRSYW5nZXMgKz0gdGltZVJhbmdlcy5zdGFydChpKSArICcuLi4nICsg dGltZVJhbmdlcy5lbmQoaSk7CisgICAgICAgIH0KKyAgICAgICAgYnVmZmVyZWRSYW5nZXMgKz0g JyBdJzsKKyAgICAgICAgcmV0dXJuIGJ1ZmZlcmVkUmFuZ2VzOworICAgIH0KKworICAgIGlmICh3 aW5kb3cuaW50ZXJuYWxzKQorICAgICAgICBpbnRlcm5hbHMuaW5pdGlhbGl6ZU1vY2tNZWRpYVNv dXJjZSgpOworCisgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBhc3luYygpID0+ IHsKKyAgICAgICAgZmluZE1lZGlhRWxlbWVudCgpOworICAgICAgICBzb3VyY2UgPSBuZXcgTWVk aWFTb3VyY2UoKTsKKworICAgICAgICBjb25zdCB2aWRlb1NvdXJjZSA9IGRvY3VtZW50LmNyZWF0 ZUVsZW1lbnQoJ3NvdXJjZScpOworICAgICAgICB2aWRlb1NvdXJjZS50eXBlID0gJ3ZpZGVvL21v Y2s7IGNvZGVjcz1tb2NrJzsKKyAgICAgICAgdmlkZW9Tb3VyY2Uuc3JjID0gVVJMLmNyZWF0ZU9i amVjdFVSTChzb3VyY2UpOworICAgICAgICB2aWRlby5hcHBlbmRDaGlsZCh2aWRlb1NvdXJjZSk7 CisKKyAgICAgICAgYXdhaXQgd2FpdEZvcihzb3VyY2UsICdzb3VyY2VvcGVuJyk7CisgICAgICAg IHNvdXJjZUJ1ZmZlciA9IHNvdXJjZS5hZGRTb3VyY2VCdWZmZXIoInZpZGVvL21vY2s7IGNvZGVj cz1tb2NrIik7CisgICAgICAgIGluaXRTZWdtZW50ID0gbWFrZUFJbml0KDM1MCwgW21ha2VBVHJh Y2soMSwgJ21vY2snLCBUUkFDS19LSU5ELlZJREVPKV0pOworICAgICAgICBzb3VyY2VCdWZmZXIu YXBwZW5kQnVmZmVyKGluaXRTZWdtZW50KTsKKyAgICAgICAgYXdhaXQgd2FpdEZvcihzb3VyY2VC dWZmZXIsICd1cGRhdGVlbmQnKTsKKyAgICAgICAgd2FpdEZvcihzb3VyY2VCdWZmZXIsICdlcnJv cicpOworCisgICAgICAgIHZhciBvZmZzZXQgPSAyMDAwMDAwMDA7CisgICAgICAgIHZhciBmaXJz dFB0cyA9IDAgKyBvZmZzZXQ7CisgICAgICAgIHZhciBsYXN0UHRzID0gNTUgKyBvZmZzZXQ7CisK KyAgICAgICAgaW50ZXJuYWxzLnNldHRpbmdzLnNldE1heGltdW1Tb3VyY2VCdWZmZXJTaXplKDQw MDApOworCisgICAgICAgIGZvciAodmFyIHB0cyA9IGZpcnN0UHRzOyBwdHMgPD0gbGFzdFB0czsg cHRzKyspIHsKKyAgICAgICAgICAgIHNvdXJjZUJ1ZmZlci5hcHBlbmRCdWZmZXIobWFrZUFTYW1w bGUocHRzLCBwdHMsIDEsIDEsIDEsIFNBTVBMRV9GTEFHLlNZTkMsIDEpKTsKKyAgICAgICAgICAg IGF3YWl0IHdhaXRGb3Ioc291cmNlQnVmZmVyLCAndXBkYXRlZW5kJywgdHJ1ZSk7CisgICAgICAg IH0KKyAgICAgICAgdGVzdEV4cGVjdGVkKCdidWZmZXJlZFJhbmdlcygpJywgJ1sgMjAwMDAwMDAw Li4uMjAwMDAwMDU2IF0nLCAnPT0nKTsKKworICAgICAgICB2aWRlby5jdXJyZW50VGltZSA9IDQw ICsgb2Zmc2V0OworICAgICAgICB0ZXN0RXhwZWN0ZWQoJ3ZpZGVvLmN1cnJlbnRUaW1lJywgNDAg KyBvZmZzZXQsICc9PScpOworCisgICAgICAgIHNvdXJjZUJ1ZmZlci5hZGRFdmVudExpc3RlbmVy KCd1cGRhdGVlbmQnLCBmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgnYnVm ZmVyZWRSYW5nZXMoKScsICdbIDIwMDAwMDAxMC4uLjIwMDAwMDA1NyBdJywgJz09Jyk7CisgICAg ICAgICAgICBlbmRUZXN0KCk7CisgICAgICAgIH0pOworCisgICAgICAgIHNldFRpbWVvdXQoZnVu Y3Rpb24oKSB7CisgICAgICAgICAgICBjb25zb2xlV3JpdGUoJyogVGltZW91dDogdGFraW5nIHRv byBsb25nIHRvIGV2aWN0IGNvZGVkIGZyYW1lcy4nKTsKKyAgICAgICAgICAgIGZhaWxUZXN0KCk7 CisgICAgICAgIH0sIDUwKTsKKworICAgICAgICBzb3VyY2VCdWZmZXIuYXBwZW5kQnVmZmVyKG1h a2VBU2FtcGxlKGxhc3RQdHMgKyAxLCBsYXN0UHRzICsgMSwgMSwgMSwgMSwgU0FNUExFX0ZMQUcu U1lOQywgMSkpOworICAgIH0pOworICAgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+CisgICAg PHZpZGVvPjwvdmlkZW8+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWViOWMxM2Y3 N2NjLi40NzRmNWZiMmNhZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAyMS0wNi0w OSAgVG9zaGlvIE9nYXNhd2FyYSAgPHRvc2hpby5vZ2FzYXdhcmFAYWNjZXNzLWNvbXBhbnkuY29t PgorCisgICAgICAgIFtNU0VdIFdoZW4gY3VycmVudFRpbWUgaXMgYSBsYXJnZSB2YWx1ZSwgaXQg dGFrZXMgdGltZSB0byBwcm9jZXNzIFNvdXJjZUJ1ZmZlclByaXZhdGU6OmV2aWN0Q29kZWRGcmFt ZXMoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIy Njg2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNv dXJjZUJ1ZmZlclByaXZhdGU6OmV2aWN0Q29kZWRGcmFtZXMoKSBub3cgc3RhcnRzIHdpdGggdGhl IGVhcmxpZXN0IFBUUyB2YWx1ZQorICAgICAgICBpbiB0cmFja0J1ZmZlciBpbnN0ZWFkIG9mIE1l ZGlhVGltZTo6emVyb1RpbWUoKSB0byBhdm9pZCB1bm5lY2Vzc2FyeSBsb29wcy4KKworICAgICAg ICBUZXN0OiBtZWRpYS9tZWRpYS1zb3VyY2UvbWVkaWEtc291cmNlLWV2aWN0LWNvZGVkZnJhbWUt bGFyZ2UtY3VycmVudHRpbWUuaHRtbAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvU291 cmNlQnVmZmVyUHJpdmF0ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTb3VyY2VCdWZmZXJQcml2 YXRlOjpldmljdENvZGVkRnJhbWVzKToKKwogMjAyMS0wNi0wOSAgQ2FtZXJvbiBNY0Nvcm1hY2sg IDxoZXljYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCB3aW5kb3cuaW50ZXJuYWxzLmxvZygp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Tb3VyY2VCdWZm ZXJQcml2YXRlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1NvdXJjZUJ1 ZmZlclByaXZhdGUuY3BwCmluZGV4IGNmNDg4NjhkMjllNi4uZGViNGM0NjIzOWRhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Tb3VyY2VCdWZmZXJQcml2YXRl LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Tb3VyY2VCdWZmZXJQ cml2YXRlLmNwcApAQCAtNjUzLDcgKzY1MywyMCBAQCB2b2lkIFNvdXJjZUJ1ZmZlclByaXZhdGU6 OmV2aWN0Q29kZWRGcmFtZXModWludDY0X3QgbmV3RGF0YVNpemUsIHVpbnQ2NF90IG1heGltdQog ICAgIERFQlVHX0xPRyhMT0dJREVOVElGSUVSLCAiY3VycmVudFRpbWUgPSAiLCBjdXJyZW50VGlt ZSwgIiwgcmVxdWlyZSAiLCBpbml0aWFsQnVmZmVyZWRTaXplICsgbmV3RGF0YVNpemUsICIgYnl0 ZXMsIG1heGltdW0gYnVmZmVyIHNpemUgaXMgIiwgbWF4aW11bUJ1ZmZlclNpemUpOwogI2VuZGlm CiAKLSAgICBNZWRpYVRpbWUgcmFuZ2VTdGFydCA9IE1lZGlhVGltZTo6emVyb1RpbWUoKTsKKyAg ICBNZWRpYVRpbWUgcmFuZ2VTdGFydCA9IE1lZGlhVGltZTo6aW52YWxpZFRpbWUoKTsKKworICAg IGZvciAoYXV0byYgdHJhY2tCdWZmZXIgOiBtX3RyYWNrQnVmZmVyTWFwLnZhbHVlcygpKSB7Cisg ICAgICAgIGF1dG8gaXRlciA9IHRyYWNrQnVmZmVyLmdldCgpLnNhbXBsZXMucHJlc2VudGF0aW9u T3JkZXIoKS5maW5kU2FtcGxlQ29udGFpbmluZ09yQWZ0ZXJQcmVzZW50YXRpb25UaW1lKE1lZGlh VGltZTo6emVyb1RpbWUoKSk7CisgICAgICAgIGlmIChpdGVyICE9IHRyYWNrQnVmZmVyLmdldCgp LnNhbXBsZXMucHJlc2VudGF0aW9uT3JkZXIoKS5lbmQoKSkgeworICAgICAgICAgICAgTWVkaWFU aW1lIHN0YXJ0VGltZSA9IGl0ZXItPmZpcnN0OworICAgICAgICAgICAgaWYgKHJhbmdlU3RhcnQu aXNJbnZhbGlkKCkgfHwgc3RhcnRUaW1lIDwgcmFuZ2VTdGFydCkKKyAgICAgICAgICAgICAgICBy YW5nZVN0YXJ0ID0gc3RhcnRUaW1lOworICAgICAgICB9CisgICAgfQorCisgICAgaWYgKHJhbmdl U3RhcnQuaXNJbnZhbGlkKCkpCisgICAgICAgIHJhbmdlU3RhcnQgPSBNZWRpYVRpbWU6Onplcm9U aW1lKCk7CisKICAgICBNZWRpYVRpbWUgcmFuZ2VFbmQgPSByYW5nZVN0YXJ0ICsgdGhpcnR5U2Vj b25kczsKICAgICB3aGlsZSAocmFuZ2VTdGFydCA8IG1heGltdW1SYW5nZUVuZCkgewogICAgICAg ICAvLyA0LiBGb3IgZWFjaCByYW5nZSBpbiByZW1vdmFsIHJhbmdlcywgcnVuIHRoZSBjb2RlZCBm cmFtZSByZW1vdmFsIGFsZ29yaXRobSB3aXRoIHN0YXJ0IGFuZAo=