226861 2021-06-09 18:16:58 -0700 [JSC] Ignore Intl.NumberFormat feature options when linked-ICU is old 2021-06-10 01:07:12 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff ross.kirsling saam tzagallo webkit-bug-importer oldest_to_newest 1768418 0 ysuzuki 2021-06-09 18:16:58 -0700 [JSC] Ignore Intl features when linked-ICU is old 1768421 1 431038 ysuzuki 2021-06-09 18:19:04 -0700 Created attachment 431038 Patch 1768422 2 ysuzuki 2021-06-09 18:19:07 -0700 <rdar://problem/77393100> 1768424 3 431038 ross.kirsling 2021-06-09 18:24:04 -0700 Comment on attachment 431038 Patch r=me. Seems unfortunate but necessary. 1768479 4 ews-feeder 2021-06-10 01:07:07 -0700 Committed r278697 (238669@main): <https://commits.webkit.org/238669@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431038. 431038 2021-06-09 18:19:04 -0700 2021-06-10 01:07:10 -0700 Patch bug-226861-20210609181903.patch text/plain 4412 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj YWVkZWEwNmYxMmQ2OGZlMWJhODcwNDBlZjAxMzdhMTRiYTIxNmIwLi43MDc1YWJhZjY0M2FjNzIz Y2NlZGY2MmYxMzc3MDgxMTI3NGNmZmVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMS0wNi0wOSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIElnbm9yZSBJbnRsLk51bWJlckZvcm1hdCBmZWF0dXJlIG9wdGlv bnMgd2hlbiBsaW5rZWQtSUNVIGlzIG9sZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjI2ODYxCisgICAgICAgIHJkYXI6Ly83NzM5MzEwMAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExldCdzIGp1c3QgaWdu b3JlIHRoZSBvcHRpb24gd2hlbiBJbnRsLk51bWJlckZvcm1hdCBmZWF0dXJlcyBjYW5ub3QgYmUg aW1wbGVtZW50ZWQgc2luY2UgdGhlIGxpbmtlZCBJQ1UgaXMgb2xkLgorICAgICAgICBUaGVyZSBp cyBubyB3YXkgbm90IHRvIGV4cG9zZSB0aGVzZSBmZWF0dXJlcyBzaW5jZSBJbnRsLk51bWJlckZv cm1hdCdzIHRoZXNlIGNoYW5nZXMgYXJlIGFkZGl0aW9uYWwgb25lcyBhbmQgSW50bC5OdW1iZXJG b3JtYXQgZXhpc3RlZCBiZWZvcmUuCisKKyAgICAgICAgKiBydW50aW1lL0ludGxOdW1iZXJGb3Jt YXQuY3BwOgorICAgICAgICAoSlNDOjpJbnRsTnVtYmVyRm9ybWF0Ojppbml0aWFsaXplTnVtYmVy Rm9ybWF0KToKKwogMjAyMS0wNi0wOSAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAK ICAgICAgICAgU3BlY3VsYXRpdmUgYnVpbGQgZml4IGZvciBXaW4zMi4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxOdW1iZXJGb3JtYXQuY3BwIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSW50bE51bWJlckZvcm1hdC5jcHAKaW5kZXggNDJhOGU5 NWZlZDE5NDgyMWJmNWJlODEwMDRlNmE0YjA0NjA2ZDVkNy4uM2Q5OWZiOTFhOWFjYmFiNjVjMDgx ZjMzMWQzMTU4NzAzZmI5Zjc0MCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvSW50bE51bWJlckZvcm1hdC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvSW50bE51bWJlckZvcm1hdC5jcHAKQEAgLTU0NSw4ICs1NDUsOCBAQCB2b2lkIEludGxO dW1iZXJGb3JtYXQ6OmluaXRpYWxpemVOdW1iZXJGb3JtYXQoSlNHbG9iYWxPYmplY3QqIGdsb2Jh bE9iamVjdCwgSlNWYQogICAgICAgICAgICAgc3R5bGUgPSBVTlVNX0NVUlJFTkNZOwogICAgICAg ICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgQ3VycmVuY3lEaXNwbGF5OjpOYXJyb3dTeW1ib2w6 Ci0gICAgICAgICAgICB0aHJvd1R5cGVFcnJvcihnbG9iYWxPYmplY3QsIHNjb3BlLCAiRmFpbGVk IHRvIGluaXRpYWxpemUgTnVtYmVyRm9ybWF0IHNpbmNlIHVzZWQgZmVhdHVyZSBpcyBub3Qgc3Vw cG9ydGVkIGluIHRoZSBsaW5rZWQgSUNVIHZlcnNpb24iX3MpOwotICAgICAgICAgICAgcmV0dXJu OworICAgICAgICAgICAgc3R5bGUgPSBVTlVNX0NVUlJFTkNZOyAvLyBVc2UgdGhlIHNhbWUgb3B0 aW9uIHRvICJzeW1ib2wiIHNpbmNlIGxpbmtlZC1JQ1UgZG9lcyBub3Qgc3VwcG9ydCBpdC4KKyAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIEN1cnJlbmN5RGlzcGxheTo6TmFtZToKICAg ICAgICAgICAgIHN0eWxlID0gVU5VTV9DVVJSRU5DWV9QTFVSQUw7CiAgICAgICAgICAgICBicmVh azsKQEAgLTU1NSwxMyArNTU1LDEzIEBAIHZvaWQgSW50bE51bWJlckZvcm1hdDo6aW5pdGlhbGl6 ZU51bWJlckZvcm1hdChKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBKU1ZhCiAgICAgICAg IGNhc2UgQ3VycmVuY3lTaWduOjpTdGFuZGFyZDoKICAgICAgICAgICAgIGJyZWFrOwogICAgICAg ICBjYXNlIEN1cnJlbmN5U2lnbjo6QWNjb3VudGluZzoKLSAgICAgICAgICAgIHRocm93VHlwZUVy cm9yKGdsb2JhbE9iamVjdCwgc2NvcGUsICJGYWlsZWQgdG8gaW5pdGlhbGl6ZSBOdW1iZXJGb3Jt YXQgc2luY2UgdXNlZCBmZWF0dXJlIGlzIG5vdCBzdXBwb3J0ZWQgaW4gdGhlIGxpbmtlZCBJQ1Ug dmVyc2lvbiJfcyk7Ci0gICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICAvLyBJZ25vcmUg dGhpcyBjYXNlIHNpbmNlIGxpbmtlZCBJQ1UgZG9lcyBub3Qgc3VwcG9ydCBpdC4KKyAgICAgICAg ICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgU3R5bGU6OlVu aXQ6Ci0gICAgICAgIHRocm93VHlwZUVycm9yKGdsb2JhbE9iamVjdCwgc2NvcGUsICJGYWlsZWQg dG8gaW5pdGlhbGl6ZSBOdW1iZXJGb3JtYXQgc2luY2UgdXNlZCBmZWF0dXJlIGlzIG5vdCBzdXBw b3J0ZWQgaW4gdGhlIGxpbmtlZCBJQ1UgdmVyc2lvbiJfcyk7Ci0gICAgICAgIHJldHVybjsKKyAg ICAgICAgLy8gSWdub3JlIHRoaXMgY2FzZSBzaW5jZSBsaW5rZWQgSUNVIGRvZXMgbm90IHN1cHBv cnQgaXQuCisgICAgICAgIGJyZWFrOwogICAgIH0KIAogICAgIHN3aXRjaCAobV9ub3RhdGlvbikg ewpAQCAtNTcwLDggKzU3MCw4IEBAIHZvaWQgSW50bE51bWJlckZvcm1hdDo6aW5pdGlhbGl6ZU51 bWJlckZvcm1hdChKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBKU1ZhCiAgICAgY2FzZSBJ bnRsTm90YXRpb246OlNjaWVudGlmaWM6CiAgICAgY2FzZSBJbnRsTm90YXRpb246OkVuZ2luZWVy aW5nOgogICAgIGNhc2UgSW50bE5vdGF0aW9uOjpDb21wYWN0OgotICAgICAgICB0aHJvd1R5cGVF cnJvcihnbG9iYWxPYmplY3QsIHNjb3BlLCAiRmFpbGVkIHRvIGluaXRpYWxpemUgTnVtYmVyRm9y bWF0IHNpbmNlIHVzZWQgZmVhdHVyZSBpcyBub3Qgc3VwcG9ydGVkIGluIHRoZSBsaW5rZWQgSUNV IHZlcnNpb24iX3MpOwotICAgICAgICByZXR1cm47CisgICAgICAgIC8vIElnbm9yZSB0aGlzIGNh c2Ugc2luY2UgbGlua2VkIElDVSBkb2VzIG5vdCBzdXBwb3J0IGl0LgorICAgICAgICBicmVhazsK ICAgICB9CiAKICAgICBzd2l0Y2ggKG1fc2lnbkRpc3BsYXkpIHsKQEAgLTU4MCw4ICs1ODAsOCBA QCB2b2lkIEludGxOdW1iZXJGb3JtYXQ6OmluaXRpYWxpemVOdW1iZXJGb3JtYXQoSlNHbG9iYWxP YmplY3QqIGdsb2JhbE9iamVjdCwgSlNWYQogICAgIGNhc2UgU2lnbkRpc3BsYXk6Ok5ldmVyOgog ICAgIGNhc2UgU2lnbkRpc3BsYXk6OkFsd2F5czoKICAgICBjYXNlIFNpZ25EaXNwbGF5OjpFeGNl cHRaZXJvOgotICAgICAgICB0aHJvd1R5cGVFcnJvcihnbG9iYWxPYmplY3QsIHNjb3BlLCAiRmFp bGVkIHRvIGluaXRpYWxpemUgTnVtYmVyRm9ybWF0IHNpbmNlIHVzZWQgZmVhdHVyZSBpcyBub3Qg c3VwcG9ydGVkIGluIHRoZSBsaW5rZWQgSUNVIHZlcnNpb24iX3MpOwotICAgICAgICByZXR1cm47 CisgICAgICAgIC8vIElnbm9yZSB0aGlzIGNhc2Ugc2luY2UgbGlua2VkIElDVSBkb2VzIG5vdCBz dXBwb3J0IGl0LgorICAgICAgICBicmVhazsKICAgICB9CiAKICAgICBVRXJyb3JDb2RlIHN0YXR1 cyA9IFVfWkVST19FUlJPUjsKQEAgLTYxMSw4ICs2MTEsOCBAQCB2b2lkIEludGxOdW1iZXJGb3Jt YXQ6OmluaXRpYWxpemVOdW1iZXJGb3JtYXQoSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwg SlNWYQogICAgICAgICB1bnVtX3NldEF0dHJpYnV0ZShtX251bWJlckZvcm1hdC5nZXQoKSwgVU5V TV9NQVhfU0lHTklGSUNBTlRfRElHSVRTLCBtX21heGltdW1TaWduaWZpY2FudERpZ2l0cyk7CiAg ICAgICAgIGJyZWFrOwogICAgIGNhc2UgSW50bFJvdW5kaW5nVHlwZTo6Q29tcGFjdFJvdW5kaW5n OgotICAgICAgICB0aHJvd1R5cGVFcnJvcihnbG9iYWxPYmplY3QsIHNjb3BlLCAiRmFpbGVkIHRv IGluaXRpYWxpemUgTnVtYmVyRm9ybWF0IHNpbmNlIHVzZWQgZmVhdHVyZSBpcyBub3Qgc3VwcG9y dGVkIGluIHRoZSBsaW5rZWQgSUNVIHZlcnNpb24iX3MpOwotICAgICAgICByZXR1cm47CisgICAg ICAgIC8vIElnbm9yZSB0aGlzIGNhc2Ugc2luY2UgbGlua2VkIElDVSBkb2VzIG5vdCBzdXBwb3J0 IGl0LgorICAgICAgICBicmVhazsKICAgICB9CiAgICAgdW51bV9zZXRBdHRyaWJ1dGUobV9udW1i ZXJGb3JtYXQuZ2V0KCksIFVOVU1fR1JPVVBJTkdfVVNFRCwgbV91c2VHcm91cGluZyk7CiAgICAg dW51bV9zZXRBdHRyaWJ1dGUobV9udW1iZXJGb3JtYXQuZ2V0KCksIFVOVU1fUk9VTkRJTkdfTU9E RSwgVU5VTV9ST1VORF9IQUxGVVApOwo=