226849 2021-06-09 13:43:10 -0700 Air ARM64 sub32 opcode should indicate that it zero-extends its result 2021-06-11 11:28:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam yijia_huang ews-watchlist keith_miller mark.lam msaboff tzagallo webkit-bug-importer oldest_to_newest 1768323 0 saam 2021-06-09 13:43:10 -0700 ... 1768403 1 431030 yijia_huang 2021-06-09 17:24:51 -0700 Created attachment 431030 Patch 1768410 2 431034 yijia_huang 2021-06-09 17:42:37 -0700 Created attachment 431034 Patch 1768718 3 431124 yijia_huang 2021-06-10 13:55:30 -0700 Created attachment 431124 Patch 1768727 4 431124 mark.lam 2021-06-10 14:09:30 -0700 Comment on attachment 431124 Patch This patch needs a ChangeLog. 1768728 5 431127 yijia_huang 2021-06-10 14:10:10 -0700 Created attachment 431127 Patch 1768730 6 431127 mark.lam 2021-06-10 14:15:57 -0700 Comment on attachment 431127 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431127&action=review > Source/JavaScriptCore/ChangeLog:8 > + * b3/air/AirOpcode.opcodes: Zero def the destination of arm64 sub32 This description is not accurate. You're not defining the destination register as zero. Instead, you're indicating that the opcode will zero extend the 32-bit result to full register length in the destination. Please also fix the title accordingly. Also to provide context for this patch, I indicate that this is in Air opcode. For example, something like "Air ARM64 sub32 opcode should indicate that it zero-extends its result". 1768768 7 431143 yijia_huang 2021-06-10 15:27:54 -0700 Created attachment 431143 Patch 1768775 8 431143 saam 2021-06-10 15:38:13 -0700 Comment on attachment 431143 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431143&action=review > Source/JavaScriptCore/ChangeLog:9 > + When the result of sub32 needs to be stored to a 64-sized register, > + the current Air optimizer will generate an extra Move32 instruction. I'd be more precise here. Maybe something like this: "Sub32 was previously not saying that its result is zero defined. However, sub32 on arm64 architectures zero defines its result, so the top 32 bits are zeroed. The issue with this is what we were not eliding provably redundant zero extend operations." > Source/JavaScriptCore/ChangeLog:19 > + // Optimized Air IR I'd say that this is the "Old optimized Air IR" > Source/JavaScriptCore/ChangeLog:25 > + To remove that redundant instruction (Move32), Air arm64 sub32 opcode > + should indicate that it zero-extends its result. "To remove that redundant instruction (Move32)" => "To remove that redundant zero extend instruction (Move32)" > Source/JavaScriptCore/ChangeLog:26 > + maybe also show what the new Optimized IR is here: > Source/JavaScriptCore/ChangeLog:28 > + * b3/air/AirOpcode.opcodes: Changed "D:G:32" to "ZD:G:32" in Air ARM64 > + sub32 opcode. No need for this here. We typically don't say "what" a patch does for a simple patch like this, since if you look at the file below, it already says that. 1768781 9 431150 yijia_huang 2021-06-10 15:52:53 -0700 Created attachment 431150 Patch 1768782 10 431151 yijia_huang 2021-06-10 15:57:30 -0700 Created attachment 431151 Patch 1768828 11 431151 saam 2021-06-10 17:37:15 -0700 Comment on attachment 431151 Patch NIce. r=me 1769000 12 ews-feeder 2021-06-11 11:27:04 -0700 Committed r278769 (238728@main): <https://commits.webkit.org/238728@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431151. 1769001 13 webkit-bug-importer 2021-06-11 11:28:20 -0700 <rdar://problem/79208100> 431030 2021-06-09 17:24:51 -0700 2021-06-09 17:42:36 -0700 Patch bug-226849-20210609192450.patch text/plain 232 yijia_huang U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4Njc2CmRpZmYgLS1naXQgYS90ZXN0LmpzIGIvdGVzdC5q cwpkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggZTA5NTAzMTc0ZjJmMzdiZDFjMjlhZjE0 OGRmMzBmYzZiZjc5YzRmMS4uMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MAotLS0gYS90ZXN0LmpzCisrKyAvZGV2L251bGwKQEAgLTEgKzAsMCBAQAotcHJpbnQoIkhlbGxv Iik7Cg== 431034 2021-06-09 17:42:37 -0700 2021-06-09 18:44:14 -0700 Patch bug-226849-20210609194237.patch text/plain 232 yijia_huang U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4Njc2CmRpZmYgLS1naXQgYS90ZXN0LmpzIGIvdGVzdC5q cwpkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggZTA5NTAzMTc0ZjJmMzdiZDFjMjlhZjE0 OGRmMzBmYzZiZjc5YzRmMS4uMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MAotLS0gYS90ZXN0LmpzCisrKyAvZGV2L251bGwKQEAgLTEgKzAsMCBAQAotcHJpbnQoIkhlbGxv Iik7Cg== 431124 2021-06-10 13:55:30 -0700 2021-06-10 14:10:07 -0700 Patch bug-226849-20210610155529.patch text/plain 548 yijia_huang U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4Njg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvYjMvYWlyL0Fpck9wY29kZS5vcGNvZGVzIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Iz L2Fpci9BaXJPcGNvZGUub3Bjb2RlcwppbmRleCA1M2QyOWRmNWY0YTNkOGYyNGZiZjlmOGI0Nzdi ZDM3YjM1MDI0M2UwLi5mODQzNmFkOTM0YWQ3NTZjYWY5YzViODUzYjk4NDRjMDU2MTIyNzA5IDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fpck9wY29kZS5vcGNvZGVz CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIvQWlyT3Bjb2RlLm9wY29kZXMKQEAg LTE3Nyw3ICsxNzcsNyBAQCBTdWIzMiBVOkc6MzIsIFVaRDpHOjMyCiAgICAgeDg2OiBUbXAsIEFk ZHIKICAgICB4ODY6IFRtcCwgSW5kZXgKIAotYXJtNjQ6IFN1YjMyIFU6RzozMiwgVTpHOjMyLCBE Okc6MzIKK2FybTY0OiBTdWIzMiBVOkc6MzIsIFU6RzozMiwgWkQ6RzozMgogICAgIFRtcCwgVG1w LCBUbXAKIAogNjQ6IFN1YjY0IFU6Rzo2NCwgVUQ6Rzo2NAo= 431127 2021-06-10 14:10:10 -0700 2021-06-10 15:27:51 -0700 Patch bug-226849-20210610161009.patch text/plain 1335 yijia_huang U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4Njg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz NGY3MzkwYmJhODY1ZWM4ZjNlMGZmY2ZjNzJkNTZiMjdmODcxM2U4Li5lYmVmMzI2NGU0NmQyNDhl ODBmZWQ4NzNlOWIzNjc3ZGVlN2M0ZmMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAyMS0wNi0xMCAgWWlqaWEgSHVhbmcgIDx5aWppYV9odWFuZ0BhcHBsZS5j b20+CisKKyAgICAgICAgQXJtNjQgc2hvdWxkIHplcm8gZGVmIHRoZSByZXN1bHQgZnJvbSBpdHMg MzItYml0IHN1YiBpbnN0cnVjdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjI2ODQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBiMy9haXIvQWlyT3Bjb2RlLm9wY29kZXM6IFplcm8gZGVmIHRoZSBk ZXN0aW5hdGlvbiBvZiBhcm02NCBzdWIzMiAKKwogMjAyMS0wNi0wOSAgRnVqaWkgSGlyb25vcmkg IDxIaXJvbm9yaS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBjbGFuZy1jbDogSklULmgoOTY2 LDY3KTogZXJyb3I6IG5vIHZpYWJsZSBjb252ZXJzaW9uIGZyb20gJ0pTQzo6QWJzdHJhY3RNYWNy b0Fzc2VtYmxlcjxKU0M6Olg4NkFzc2VtYmxlcj46OkFkZHJlc3MnIHRvICdGdW5jdGlvblB0cjxD RnVuY3Rpb25QdHJUYWc+JwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL2Fp ci9BaXJPcGNvZGUub3Bjb2RlcyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIvQWlyT3Bj b2RlLm9wY29kZXMKaW5kZXggNTNkMjlkZjVmNGEzZDhmMjRmYmY5ZjhiNDc3YmQzN2IzNTAyNDNl MC4uZjg0MzZhZDkzNGFkNzU2Y2FmOWM1Yjg1M2I5ODQ0YzA1NjEyMjcwOSAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2IzL2Fpci9BaXJPcGNvZGUub3Bjb2RlcworKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fpck9wY29kZS5vcGNvZGVzCkBAIC0xNzcsNyArMTc3 LDcgQEAgU3ViMzIgVTpHOjMyLCBVWkQ6RzozMgogICAgIHg4NjogVG1wLCBBZGRyCiAgICAgeDg2 OiBUbXAsIEluZGV4CiAKLWFybTY0OiBTdWIzMiBVOkc6MzIsIFU6RzozMiwgRDpHOjMyCithcm02 NDogU3ViMzIgVTpHOjMyLCBVOkc6MzIsIFpEOkc6MzIKICAgICBUbXAsIFRtcCwgVG1wCiAKIDY0 OiBTdWI2NCBVOkc6NjQsIFVEOkc6NjQK 431143 2021-06-10 15:27:54 -0700 2021-06-10 15:52:50 -0700 Patch bug-226849-20210610172753.patch text/plain 2020 yijia_huang U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4Njg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz NGY3MzkwYmJhODY1ZWM4ZjNlMGZmY2ZjNzJkNTZiMjdmODcxM2U4Li4yNTJkZTQwNWZiNjA5MzQ0 ZjJiMDAwYzlhZWE2NjIxYWZkZjMzMTQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzMiBAQAorMjAyMS0wNi0xMCAgWWlqaWEgSHVhbmcgIDx5aWppYV9odWFuZ0BhcHBsZS5j b20+CisKKyAgICAgICAgQWlyIEFSTTY0IHN1YjMyIG9wY29kZSBzaG91bGQgaW5kaWNhdGUgdGhh dCBpdCB6ZXJvLWV4dGVuZHMgaXRzIHJlc3VsdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2ODQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2hlbiB0aGUgcmVzdWx0IG9mIHN1YjMyIG5lZWRzIHRvIGJl IHN0b3JlZCB0byBhIDY0LXNpemVkIHJlZ2lzdGVyLCAKKyAgICAgICAgdGhlIGN1cnJlbnQgQWly IG9wdGltaXplciB3aWxsIGdlbmVyYXRlIGFuIGV4dHJhIE1vdmUzMiBpbnN0cnVjdGlvbi4KKwor ICAgICAgICBGb3IgZXhhbXBsZToKKyAgICAgICAgLy8gQjMgSVIKKyAgICAgICAgQDAgPSBUcnVu YyhBcmd1bWVudFJlZygwKSkKKyAgICAgICAgQDEgPSBUcnVuYyhBcmd1bWVudFJlZygxKSkKKyAg ICAgICAgQDIgPSBTdWIoQDAsIEAxKQorICAgICAgICBAMyA9IFpFeHQzMihAMikgLy8gaTY0Cisg ICAgICAgIEA0ID0gUmV0dXJuKEAzKSBvciBTdG9yZShAMywgQHgpCisKKyAgICAgICAgLy8gT3B0 aW1pemVkIEFpciBJUgorICAgICAgICBTdWIzMiAleDAsICV4MSwgJXgwLCBiQDIKKyAgICAgICAg TW92ZTMyICV4MCwgJXgwLCBiQDMKKyAgICAgICAgUmV0NjQgJXgwLCBiQDQgb3IgTW92ZSAleDAs ICgleCksIGJANAorCisgICAgICAgIFRvIHJlbW92ZSB0aGF0IHJlZHVuZGFudCBpbnN0cnVjdGlv biAoTW92ZTMyKSwgQWlyIGFybTY0IHN1YjMyIG9wY29kZSAKKyAgICAgICAgc2hvdWxkIGluZGlj YXRlIHRoYXQgaXQgemVyby1leHRlbmRzIGl0cyByZXN1bHQuCisKKyAgICAgICAgKiBiMy9haXIv QWlyT3Bjb2RlLm9wY29kZXM6IENoYW5nZWQgIkQ6RzozMiIgdG8gIlpEOkc6MzIiIGluIEFpciBB Uk02NAorICAgICAgICBzdWIzMiBvcGNvZGUuCisKIDIwMjEtMDYtMDkgIEZ1amlpIEhpcm9ub3Jp ICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAgICAgY2xhbmctY2w6IEpJVC5oKDk2 Niw2Nyk6IGVycm9yOiBubyB2aWFibGUgY29udmVyc2lvbiBmcm9tICdKU0M6OkFic3RyYWN0TWFj cm9Bc3NlbWJsZXI8SlNDOjpYODZBc3NlbWJsZXI+OjpBZGRyZXNzJyB0byAnRnVuY3Rpb25QdHI8 Q0Z1bmN0aW9uUHRyVGFnPicKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9h aXIvQWlyT3Bjb2RlLm9wY29kZXMgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fpck9w Y29kZS5vcGNvZGVzCmluZGV4IDUzZDI5ZGY1ZjRhM2Q4ZjI0ZmJmOWY4YjQ3N2JkMzdiMzUwMjQz ZTAuLmY4NDM2YWQ5MzRhZDc1NmNhZjljNWI4NTNiOTg0NGMwNTYxMjI3MDkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIvQWlyT3Bjb2RlLm9wY29kZXMKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2IzL2Fpci9BaXJPcGNvZGUub3Bjb2RlcwpAQCAtMTc3LDcgKzE3 Nyw3IEBAIFN1YjMyIFU6RzozMiwgVVpEOkc6MzIKICAgICB4ODY6IFRtcCwgQWRkcgogICAgIHg4 NjogVG1wLCBJbmRleAogCi1hcm02NDogU3ViMzIgVTpHOjMyLCBVOkc6MzIsIEQ6RzozMgorYXJt NjQ6IFN1YjMyIFU6RzozMiwgVTpHOjMyLCBaRDpHOjMyCiAgICAgVG1wLCBUbXAsIFRtcAogCiA2 NDogU3ViNjQgVTpHOjY0LCBVRDpHOjY0Cg== 431150 2021-06-10 15:52:53 -0700 2021-06-10 15:57:27 -0700 Patch bug-226849-20210610175252.patch text/plain 2216 yijia_huang U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4Njg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz NGY3MzkwYmJhODY1ZWM4ZjNlMGZmY2ZjNzJkNTZiMjdmODcxM2U4Li44ZDU4ZjZjYTc2N2NlNWI5 M2VkMjE2MWM3NDJkYmE3OWY5OGU2MWNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzNyBAQAorMjAyMS0wNi0xMCAgWWlqaWEgSHVhbmcgIDx5aWppYV9odWFuZ0BhcHBsZS5j b20+CisKKyAgICAgICAgQWlyIEFSTTY0IHN1YjMyIG9wY29kZSBzaG91bGQgaW5kaWNhdGUgdGhh dCBpdCB6ZXJvLWV4dGVuZHMgaXRzIHJlc3VsdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2ODQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU3ViMzIgd2FzIHByZXZpb3VzbHkgbm90IHNheWluZyB0aGF0 IGl0cyByZXN1bHQgaXMgemVybyBkZWZpbmVkLiBIb3dldmVyLAorICAgICAgICBzdWIzMiBvbiBh cm02NCBhcmNoaXRlY3R1cmVzIHplcm8gZGVmaW5lcyBpdHMgcmVzdWx0LCBzbyB0aGUgdG9wIDMy IGJpdHMKKyAgICAgICAgYXJlIHplcm9lZC4gVGhlIGlzc3VlIHdpdGggdGhpcyBpcyB3aGF0IHdl IHdlcmUgbm90IGVsaWRpbmcgcHJvdmFibHkKKyAgICAgICAgcmVkdW5kYW50IHplcm8gZXh0ZW5k IG9wZXJhdGlvbnMuCisKKyAgICAgICAgRm9yIGV4YW1wbGU6CisgICAgICAgIC8vIEIzIElSCisg ICAgICAgIEAwID0gVHJ1bmMoQXJndW1lbnRSZWcoMCkpCisgICAgICAgIEAxID0gVHJ1bmMoQXJn dW1lbnRSZWcoMSkpCisgICAgICAgIEAyID0gU3ViKEAwLCBAMSkKKyAgICAgICAgQDMgPSBaRXh0 MzIoQDIpIC8vIGk2NAorICAgICAgICBANCA9IFJldHVybihAMykgb3IgU3RvcmUoQDMsIEB4KQor CisgICAgICAgIC8vIE9sZCBvcHRpbWl6ZWQgQWlyIElSCisgICAgICAgIFN1YjMyICV4MCwgJXgx LCAleDAsIGJAMgorICAgICAgICBNb3ZlMzIgJXgwLCAleDAsIGJAMworICAgICAgICBSZXQ2NCAl eDAsIGJANCBvciBNb3ZlICV4MCwgKCV4KSwgYkA0CisKKyAgICAgICAgVG8gcmVtb3ZlIHRoYXQg cmVkdW5kYW50IHplcm8gZXh0ZW5kIGluc3RydWN0aW9uIChNb3ZlMzIpLCBBaXIgYXJtNjQgCisg ICAgICAgIHN1YjMyIG9wY29kZSBzaG91bGQgaW5kaWNhdGUgdGhhdCBpdCB6ZXJvLWV4dGVuZHMg aXRzIHJlc3VsdC4KKworICAgICAgICAvLyBOZXcgb3B0aW1pemVkIEFpciBJUgorICAgICAgICBT dWIzMiAleDAsICV4MSwgJXgwLCBiQDIKKyAgICAgICAgUmV0NjQgJXgwLCBiQDYgb3IgTW92ZSAl eDAsICgleCksIGJANAorCisgICAgICAgICogYjMvYWlyL0Fpck9wY29kZS5vcGNvZGVzOgorCiAy MDIxLTA2LTA5ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAg ICAgICAgIGNsYW5nLWNsOiBKSVQuaCg5NjYsNjcpOiBlcnJvcjogbm8gdmlhYmxlIGNvbnZlcnNp b24gZnJvbSAnSlNDOjpBYnN0cmFjdE1hY3JvQXNzZW1ibGVyPEpTQzo6WDg2QXNzZW1ibGVyPjo6 QWRkcmVzcycgdG8gJ0Z1bmN0aW9uUHRyPENGdW5jdGlvblB0clRhZz4nCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fpck9wY29kZS5vcGNvZGVzIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2IzL2Fpci9BaXJPcGNvZGUub3Bjb2RlcwppbmRleCA1M2QyOWRmNWY0YTNk OGYyNGZiZjlmOGI0NzdiZDM3YjM1MDI0M2UwLi5mODQzNmFkOTM0YWQ3NTZjYWY5YzViODUzYjk4 NDRjMDU2MTIyNzA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fp ck9wY29kZS5vcGNvZGVzCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIvQWlyT3Bj b2RlLm9wY29kZXMKQEAgLTE3Nyw3ICsxNzcsNyBAQCBTdWIzMiBVOkc6MzIsIFVaRDpHOjMyCiAg ICAgeDg2OiBUbXAsIEFkZHIKICAgICB4ODY6IFRtcCwgSW5kZXgKIAotYXJtNjQ6IFN1YjMyIFU6 RzozMiwgVTpHOjMyLCBEOkc6MzIKK2FybTY0OiBTdWIzMiBVOkc6MzIsIFU6RzozMiwgWkQ6Rzoz MgogICAgIFRtcCwgVG1wLCBUbXAKIAogNjQ6IFN1YjY0IFU6Rzo2NCwgVUQ6Rzo2NAo= 431151 2021-06-10 15:57:30 -0700 2021-06-11 11:27:04 -0700 Patch bug-226849-20210610175729.patch text/plain 2216 yijia_huang U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4Njg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz NGY3MzkwYmJhODY1ZWM4ZjNlMGZmY2ZjNzJkNTZiMjdmODcxM2U4Li44ZDU4ZjZjYTc2N2NlNWI5 M2VkMjE2MWM3NDJkYmE3OWY5OGU2MWNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzNyBAQAorMjAyMS0wNi0xMCAgWWlqaWEgSHVhbmcgIDx5aWppYV9odWFuZ0BhcHBsZS5j b20+CisKKyAgICAgICAgQWlyIEFSTTY0IHN1YjMyIG9wY29kZSBzaG91bGQgaW5kaWNhdGUgdGhh dCBpdCB6ZXJvLWV4dGVuZHMgaXRzIHJlc3VsdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2ODQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU3ViMzIgd2FzIHByZXZpb3VzbHkgbm90IHNheWluZyB0aGF0 IGl0cyByZXN1bHQgaXMgemVybyBkZWZpbmVkLiBIb3dldmVyLAorICAgICAgICBzdWIzMiBvbiBh cm02NCBhcmNoaXRlY3R1cmVzIHplcm8gZGVmaW5lcyBpdHMgcmVzdWx0LCBzbyB0aGUgdG9wIDMy IGJpdHMKKyAgICAgICAgYXJlIHplcm9lZC4gVGhlIGlzc3VlIHdpdGggdGhpcyBpcyB3aGF0IHdl IHdlcmUgbm90IGVsaWRpbmcgcHJvdmFibHkKKyAgICAgICAgcmVkdW5kYW50IHplcm8gZXh0ZW5k IG9wZXJhdGlvbnMuCisKKyAgICAgICAgRm9yIGV4YW1wbGU6CisgICAgICAgIC8vIEIzIElSCisg ICAgICAgIEAwID0gVHJ1bmMoQXJndW1lbnRSZWcoMCkpCisgICAgICAgIEAxID0gVHJ1bmMoQXJn dW1lbnRSZWcoMSkpCisgICAgICAgIEAyID0gU3ViKEAwLCBAMSkKKyAgICAgICAgQDMgPSBaRXh0 MzIoQDIpIC8vIGk2NAorICAgICAgICBANCA9IFJldHVybihAMykgb3IgU3RvcmUoQDMsIEB4KQor CisgICAgICAgIC8vIE9sZCBvcHRpbWl6ZWQgQWlyIElSCisgICAgICAgIFN1YjMyICV4MCwgJXgx LCAleDAsIGJAMgorICAgICAgICBNb3ZlMzIgJXgwLCAleDAsIGJAMworICAgICAgICBSZXQ2NCAl eDAsIGJANCBvciBNb3ZlICV4MCwgKCV4KSwgYkA0CisKKyAgICAgICAgVG8gcmVtb3ZlIHRoYXQg cmVkdW5kYW50IHplcm8gZXh0ZW5kIGluc3RydWN0aW9uIChNb3ZlMzIpLCBBaXIgYXJtNjQgCisg ICAgICAgIHN1YjMyIG9wY29kZSBzaG91bGQgaW5kaWNhdGUgdGhhdCBpdCB6ZXJvLWV4dGVuZHMg aXRzIHJlc3VsdC4KKworICAgICAgICAvLyBOZXcgb3B0aW1pemVkIEFpciBJUgorICAgICAgICBT dWIzMiAleDAsICV4MSwgJXgwLCBiQDIKKyAgICAgICAgUmV0NjQgJXgwLCBiQDYgb3IgTW92ZSAl eDAsICgleCksIGJANAorCisgICAgICAgICogYjMvYWlyL0Fpck9wY29kZS5vcGNvZGVzOgorCiAy MDIxLTA2LTA5ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAg ICAgICAgIGNsYW5nLWNsOiBKSVQuaCg5NjYsNjcpOiBlcnJvcjogbm8gdmlhYmxlIGNvbnZlcnNp b24gZnJvbSAnSlNDOjpBYnN0cmFjdE1hY3JvQXNzZW1ibGVyPEpTQzo6WDg2QXNzZW1ibGVyPjo6 QWRkcmVzcycgdG8gJ0Z1bmN0aW9uUHRyPENGdW5jdGlvblB0clRhZz4nCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fpck9wY29kZS5vcGNvZGVzIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2IzL2Fpci9BaXJPcGNvZGUub3Bjb2RlcwppbmRleCA1M2QyOWRmNWY0YTNk OGYyNGZiZjlmOGI0NzdiZDM3YjM1MDI0M2UwLi5mODQzNmFkOTM0YWQ3NTZjYWY5YzViODUzYjk4 NDRjMDU2MTIyNzA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fp ck9wY29kZS5vcGNvZGVzCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIvQWlyT3Bj b2RlLm9wY29kZXMKQEAgLTE3Nyw3ICsxNzcsNyBAQCBTdWIzMiBVOkc6MzIsIFVaRDpHOjMyCiAg ICAgeDg2OiBUbXAsIEFkZHIKICAgICB4ODY6IFRtcCwgSW5kZXgKIAotYXJtNjQ6IFN1YjMyIFU6 RzozMiwgVTpHOjMyLCBEOkc6MzIKK2FybTY0OiBTdWIzMiBVOkc6MzIsIFU6RzozMiwgWkQ6Rzoz MgogICAgIFRtcCwgVG1wLCBUbXAKIAogNjQ6IFN1YjY0IFU6Rzo2NCwgVUQ6Rzo2NAo=