226787 2021-06-08 16:18:25 -0700 REGRESSION (r278374): [Big Sur] ASSERTION FAILED: !isInRoutingArbitrationForToken(token) in WebCore::SharedRoutingArbitrator::beginRoutingArbitrationForToken() 2021-06-14 14:43:16 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=226104 https://bugs.webkit.org/show_bug.cgi?id=226896 InRadar P2 Normal --- 1 ryanhaddad peng.liu6 eric.carlson jer.noble peng.liu6 tsavell webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1767945 0 ryanhaddad 2021-06-08 16:18:25 -0700 TestWebKitAPI.GPUProcess.CrashWhilePlayingVideo ASSERTION FAILED: !isInRoutingArbitrationForToken(token) ./platform/audio/mac/SharedRoutingArbitrator.mm(55) : void WebCore::SharedRoutingArbitrator::beginRoutingArbitrationForToken(const WebCore::SharedRoutingArbitrator::Token &, AudioSession::CategoryType, WebCore::SharedRoutingArbitrator::ArbitrationCallback &&) 1 0x11053a999 WTFCrash 2 0x12d0f842b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x12ed13ff8 WebCore::SharedRoutingArbitrator::beginRoutingArbitrationForToken(WebCore::SharedRoutingArbitrator::Token const&, WebCore::AudioSession::CategoryType, WTF::CompletionHandler<void (WebCore::AudioSessionRoutingArbitrationClient::RoutingArbitrationError, WebCore::AudioSessionRoutingArbitrationClient::DefaultRouteChanged)>&&) 4 0x11b8d3559 WebKit::AudioSessionRoutingArbitratorProxy::beginRoutingArbitrationWithCategory(WebCore::AudioSession::CategoryType, WTF::CompletionHandler<void (WebCore::AudioSessionRoutingArbitrationClient::RoutingArbitrationError, WebCore::AudioSessionRoutingArbitrationClient::DefaultRouteChanged)>&&) 5 0x11a371398 void IPC::callMemberFunctionImpl<WebKit::AudioSessionRoutingArbitratorProxy, void (WebKit::AudioSessionRoutingArbitratorProxy::*)(WebCore::AudioSession::CategoryType, WTF::CompletionHandler<void (WebCore::AudioSessionRoutingArbitrationClient::RoutingArbitrationError, WebCore::AudioSessionRoutingArbitrationClient::DefaultRouteChanged)>&&), void (WebCore::AudioSessionRoutingArbitrationClient::RoutingArbitrationError, WebCore::AudioSessionRoutingArbitrationClient::DefaultRouteChanged), std::__1::tuple<WebCore::AudioSession::CategoryType>, 0ul>(WebKit::AudioSessionRoutingArbitratorProxy*, void (WebKit::AudioSessionRoutingArbitratorProxy::*)(WebCore::AudioSession::CategoryType, WTF::CompletionHandler<void (WebCore::AudioSessionRoutingArbitrationClient::RoutingArbitrationError, WebCore::AudioSessionRoutingArbitrationClient::DefaultRouteChanged)>&&), WTF::CompletionHandler<void (WebCore::AudioSessionRoutingArbitrationClient::RoutingArbitrationError, WebCore::AudioSessionRoutingArbitrationClient::DefaultRouteChanged)>&&, std::__1::tuple<WebCore::AudioSession::CategoryType>&&, std::__1::integer_sequence<unsigned long, 0ul>) 6 0x11a36ed45 void IPC::callMemberFunction<WebKit::AudioSessionRoutingArbitratorProxy, void (WebKit::AudioSessionRoutingArbitratorProxy::*)(WebCore::AudioSession::CategoryType, WTF::CompletionHandler<void (WebCore::AudioSessionRoutingArbitrationClient::RoutingArbitrationError, WebCore::AudioSessionRoutingArbitrationClient::DefaultRouteChanged)>&&), void (WebCore::AudioSessionRoutingArbitrationClient::RoutingArbitrationError, WebCore::AudioSessionRoutingArbitrationClient::DefaultRouteChanged), std::__1::tuple<WebCore::AudioSession::CategoryType>, std::__1::integer_sequence<unsigned long, 0ul> >(std::__1::tuple<WebCore::AudioSession::CategoryType>&&, WTF::CompletionHandler<void (WebCore::AudioSessionRoutingArbitrationClient::RoutingArbitrationError, WebCore::AudioSessionRoutingArbitrationClient::DefaultRouteChanged)>&&, WebKit::AudioSessionRoutingArbitratorProxy*, void (WebKit::AudioSessionRoutingArbitratorProxy::*)(WebCore::AudioSession::CategoryType, WTF::CompletionHandler<void (WebCore::AudioSessionRoutingArbitrationClient::RoutingArbitrationError, WebCore::AudioSessionRoutingArbitrationClient::DefaultRouteChanged)>&&)) 7 0x11a36ce1e void IPC::handleMessageAsync<Messages::AudioSessionRoutingArbitratorProxy::BeginRoutingArbitrationWithCategory, WebKit::AudioSessionRoutingArbitratorProxy, void (WebKit::AudioSessionRoutingArbitratorProxy::*)(WebCore::AudioSession::CategoryType, WTF::CompletionHandler<void (WebCore::AudioSessionRoutingArbitrationClient::RoutingArbitrationError, WebCore::AudioSessionRoutingArbitrationClient::DefaultRouteChanged)>&&)>(IPC::Connection&, IPC::Decoder&, WebKit::AudioSessionRoutingArbitratorProxy*, void (WebKit::AudioSessionRoutingArbitratorProxy::*)(WebCore::AudioSession::CategoryType, WTF::CompletionHandler<void (WebCore::AudioSessionRoutingArbitrationClient::RoutingArbitrationError, WebCore::AudioSessionRoutingArbitrationClient::DefaultRouteChanged)>&&)) 8 0x11a36cbe7 WebKit::AudioSessionRoutingArbitratorProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 9 0x11a8cf875 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) 10 0x11b8066fe WebKit::AuxiliaryProcessProxy::dispatchMessage(IPC::Connection&, IPC::Decoder&) 11 0x11bad73cf WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 12 0x11a3ce474 IPC::Connection::dispatchMessage(IPC::Decoder&) 13 0x11a3cec3f IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 14 0x11a3cd1da IPC::Connection::dispatchIncomingMessages() 15 0x11a3f05e2 IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_12::operator()() 16 0x11a3f04ee WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_12, void>::call() 17 0x110568582 WTF::Function<void ()>::operator()() const 18 0x1105f0880 WTF::RunLoop::performWork() 19 0x1105f5201 WTF::RunLoop::performWork(void*) 20 0x7fff205a097c __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 21 0x7fff205a08e4 __CFRunLoopDoSource0 22 0x7fff205a0664 __CFRunLoopDoSources0 23 0x7fff2059f08c __CFRunLoopRun 24 0x7fff2059e64c CFRunLoopRunSpecific 25 0x7fff2132c647 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 26 0x10d7a985e TestWebKitAPI::Util::run(bool*) 27 0x10d74f3ec -[WKWebView(TestWebKitAPI) objectByEvaluatingJavaScript:] 28 0x10d0fb546 GPUProcess_CrashWhilePlayingVideo_Test::TestBody()::$_0::operator()() const 29 0x10d0faff7 GPUProcess_CrashWhilePlayingVideo_Test::TestBody() 30 0x10da35324 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) 31 0x10d9f701b void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.GPUProcess.CrashWhilePlayingVideo 1767946 1 ryanhaddad 2021-06-08 16:19:18 -0700 It looks like this started with https://trac.webkit.org/changeset/278374/webkit 1767947 2 webkit-bug-importer 2021-06-08 16:19:28 -0700 <rdar://problem/79041423> 1769081 3 431233 peng.liu6 2021-06-11 14:38:05 -0700 Created attachment 431233 Patch 1769188 4 431252 peng.liu6 2021-06-11 23:50:37 -0700 Created attachment 431252 [fast-cq] Patch for landing 1769208 5 ews-feeder 2021-06-12 10:37:31 -0700 Committed r278811 (238766@main): <https://commits.webkit.org/238766@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431252. 1769525 6 tsavell 2021-06-14 13:31:54 -0700 It looks like this crash is still occurring found it for this test http/tests/cache/disk-cache/disk-cache-media-small.html on a run of r278821 History: https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fcache%2Fdisk-cache%2Fdisk-cache-media-small.html 1769526 7 tsavell 2021-06-14 13:33:19 -0700 also is seems this change caused TestWebKitAPI.GPUProcess.ExitsUnderMemoryPressureVideoCase to start crashing on debug queues for Big Sur with the same assert as the others: ASSERTION FAILED: isInRoutingArbitrationForToken(token) || m_setupArbitrationOngoing history: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.GPUProcess.ExitsUnderMemoryPressureVideoCase 1769528 8 tsavell 2021-06-14 13:41:39 -0700 (In reply to Truitt Savell from comment #6) > It looks like this crash is still occurring > > found it for this test > http/tests/cache/disk-cache/disk-cache-media-small.html > on a run of r278821 > > History: > https://results.webkit.org/?suite=layout- > tests&test=http%2Ftests%2Fcache%2Fdisk-cache%2Fdisk-cache-media-small.html Disregard this, this is a slightly different assert with isInRoutingArbitrationForToken(token) || m_setupArbitrationOngoing 1769555 9 peng.liu6 2021-06-14 14:43:16 -0700 (In reply to Truitt Savell from comment #8) > Disregard this, this is a slightly different assert with > isInRoutingArbitrationForToken(token) || m_setupArbitrationOngoing This assertion failure will be fixed in bug 226896. Let's close this bug. 431233 2021-06-11 14:38:05 -0700 2021-06-11 16:16:13 -0700 Patch bug-226787-20210611143804.patch text/plain 2089 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NzExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJkNjgxZGUzY2YyMTk2NWI1 YTM4N2ZkMGZmNDFjZjg5Zjk4NGRlODMuLjBjMzZiNTliNmY2Mzg2NjJiMjA3NjZiMDY1MGZhMjZl ZWJkYjIzOTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMjEtMDYtMTEgIFBlbmcgTGl1 ICA8cGVuZy5saXU2QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjc4Mzc0KTog W0JpZyBTdXJdIEFTU0VSVElPTiBGQUlMRUQ6ICFpc0luUm91dGluZ0FyYml0cmF0aW9uRm9yVG9r ZW4odG9rZW4pIGluIFdlYkNvcmU6OlNoYXJlZFJvdXRpbmdBcmJpdHJhdG9yOjpiZWdpblJvdXRp bmdBcmJpdHJhdGlvbkZvclRva2VuKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIyNjc4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEEgV2ViQ29udGVudCBwcm9jZXNzIHdpbGwgcmVzdW1lIGEgdmlkZW8g ZWxlbWVudCBwbGF5YmFjayBhZnRlciB0aGUgR1BVIHByb2Nlc3MgY3Jhc2hlcworICAgICAgICBh bmQgcmVzdGFydHMuIER1cmluZyB0aGF0IHByb2Nlc3MsIHRoZSBXZWJDb250ZW50IHByb2Nlc3Mg d2lsbCBzZXQgY2F0ZWdvcnkgb2YgdGhlIGF1ZGlvCisgICAgICAgIHNlc3Npb24sIGFuZCB0aGUg VUkgcHJvY2VzcyB3aWxsIGJlIGFza2VkIHRvIGJlZ2luIHJvdXRpbmcgYXJiaXRyYXRpb24gd2l0 aCB0aGUgbmV3CisgICAgICAgIGNhdGVnb3J5LiBIb3dldmVyLCB0aGUgYFNoYXJlZFJvdXRpbmdB cmJpdHJhdG9yYCBhdCB0aGUgVUkgcHJvY2VzcyB3aWxsIGhhdmUgc3RhbGUKKyAgICAgICAgcm91 dGluZyBhcmJpdHJhdG9yIHRva2Vucywgd2hpY2ggbGVhZCB0aGUgYXNzZXJ0aW9uIGZhaWx1cmUu CisKKyAgICAgICAgVG8gZml4IHRoaXMgaXNzdWUsIHRoaXMgcGF0Y2ggY2xlYW5zIHVwIHRoZSBg U2hhcmVkUm91dGluZ0FyYml0cmF0b3JgIHdoZW4gdGhlIEdQVQorICAgICAgICBwcm9jZXNzIGNy YXNoZXMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBGaXggYW4gQVBJIHRlc3Q6CisgICAgICAg IC0gVGVzdFdlYktpdEFQSS5HUFVQcm9jZXNzLkNyYXNoV2hpbGVQbGF5aW5nVmlkZW8KKworICAg ICAgICAqIFVJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJQcm9jZXNzUHJveHk6OmdwdVByb2Nlc3NFeGl0ZWQpOgorCiAyMDIxLTA2LTEwICBBZHJpYW4g UGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgTm9uLXVuaWZp ZWQgYnVpbGQgZml4ZXMsIGVhcmx5IE1heSAyMDIxIGVkaXRpb24KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwCmluZGV4IDQ0NzIxNmI1YzlmYTQyODY2MGYwMzBk N2E5NTk5YTJlMmM3OGZjNWYuLjcwZDExYzhjYWNkYjhmZmQ0NjkxODAzNGY5NWY2ZjI1YTJmNmZk MDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5j cHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcApAQCAt NzkwLDYgKzc5MCwxMCBAQCB2b2lkIFdlYlByb2Nlc3NQcm94eTo6Z3B1UHJvY2Vzc0V4aXRlZChH UFVQcm9jZXNzVGVybWluYXRpb25SZWFzb24gcmVhc29uKQogewogICAgIGZvciAoYXV0byYgcGFn ZSA6IGNvcHlUb1ZlY3Rvck9mPFJlZlB0cjxXZWJQYWdlUHJveHk+PihtX3BhZ2VNYXAudmFsdWVz KCkpKQogICAgICAgICBwYWdlLT5ncHVQcm9jZXNzRXhpdGVkKHJlYXNvbik7CisKKyNpZiBFTkFC TEUoUk9VVElOR19BUkJJVFJBVElPTikKKyAgICBtX3JvdXRpbmdBcmJpdHJhdG9yLT5wcm9jZXNz RGlkVGVybWluYXRlKCk7CisjZW5kaWYKIH0KICNlbmRpZgogCg== 431252 2021-06-11 23:50:37 -0700 2021-06-12 10:37:32 -0700 [fast-cq] Patch for landing bug-226787-20210611235036.patch text/plain 2090 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NzExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJkNjgxZGUzY2YyMTk2NWI1 YTM4N2ZkMGZmNDFjZjg5Zjk4NGRlODMuLmI2MzExYzY1MjgxNWJjMTI1NGE5NzBhYTM0OTgwYWNk ZDhhYzRhYzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMjEtMDYtMTEgIFBlbmcgTGl1 ICA8cGVuZy5saXU2QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjc4Mzc0KTog W0JpZyBTdXJdIEFTU0VSVElPTiBGQUlMRUQ6ICFpc0luUm91dGluZ0FyYml0cmF0aW9uRm9yVG9r ZW4odG9rZW4pIGluIFdlYkNvcmU6OlNoYXJlZFJvdXRpbmdBcmJpdHJhdG9yOjpiZWdpblJvdXRp bmdBcmJpdHJhdGlvbkZvclRva2VuKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIyNjc4NworCisgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgQ2FybHNv bi4KKworICAgICAgICBBIFdlYkNvbnRlbnQgcHJvY2VzcyB3aWxsIHJlc3VtZSBhIHZpZGVvIGVs ZW1lbnQgcGxheWJhY2sgYWZ0ZXIgdGhlIEdQVSBwcm9jZXNzIGNyYXNoZXMKKyAgICAgICAgYW5k IHJlc3RhcnRzLiBEdXJpbmcgdGhhdCBwcm9jZXNzLCB0aGUgV2ViQ29udGVudCBwcm9jZXNzIHdp bGwgc2V0IGNhdGVnb3J5IG9mIHRoZSBhdWRpbworICAgICAgICBzZXNzaW9uLCBhbmQgdGhlIFVJ IHByb2Nlc3Mgd2lsbCBiZSBhc2tlZCB0byBiZWdpbiByb3V0aW5nIGFyYml0cmF0aW9uIHdpdGgg dGhlIG5ldworICAgICAgICBjYXRlZ29yeS4gSG93ZXZlciwgdGhlIGBTaGFyZWRSb3V0aW5nQXJi aXRyYXRvcmAgYXQgdGhlIFVJIHByb2Nlc3Mgd2lsbCBoYXZlIHN0YWxlCisgICAgICAgIHJvdXRp bmcgYXJiaXRyYXRvciB0b2tlbnMsIHdoaWNoIGxlYWQgdG8gdGhlIGFzc2VydGlvbiBmYWlsdXJl LgorCisgICAgICAgIFRvIGZpeCB0aGlzIGlzc3VlLCB0aGlzIHBhdGNoIGNsZWFucyB1cCB0aGUg YFNoYXJlZFJvdXRpbmdBcmJpdHJhdG9yYCB3aGVuIHRoZSBHUFUKKyAgICAgICAgcHJvY2VzcyBj cmFzaGVzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gRml4IGFuIEFQSSB0ZXN0OgorICAgICAg ICAtIFRlc3RXZWJLaXRBUEkuR1BVUHJvY2Vzcy5DcmFzaFdoaWxlUGxheWluZ1ZpZGVvCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6 V2ViUHJvY2Vzc1Byb3h5OjpncHVQcm9jZXNzRXhpdGVkKToKKwogMjAyMS0wNi0xMCAgQWRyaWFu IFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIE5vbi11bmlm aWVkIGJ1aWxkIGZpeGVzLCBlYXJseSBNYXkgMjAyMSBlZGl0aW9uCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcAppbmRleCA0NDcyMTZiNWM5ZmE0Mjg2NjBmMDMw ZDdhOTU5OWEyZTJjNzhmYzVmLi43MGQxMWM4Y2FjZGI4ZmZkNDY5MTgwMzRmOTVmNmYyNWEyZjZm ZDA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHku Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAKQEAg LTc5MCw2ICs3OTAsMTAgQEAgdm9pZCBXZWJQcm9jZXNzUHJveHk6OmdwdVByb2Nlc3NFeGl0ZWQo R1BVUHJvY2Vzc1Rlcm1pbmF0aW9uUmVhc29uIHJlYXNvbikKIHsKICAgICBmb3IgKGF1dG8mIHBh Z2UgOiBjb3B5VG9WZWN0b3JPZjxSZWZQdHI8V2ViUGFnZVByb3h5Pj4obV9wYWdlTWFwLnZhbHVl cygpKSkKICAgICAgICAgcGFnZS0+Z3B1UHJvY2Vzc0V4aXRlZChyZWFzb24pOworCisjaWYgRU5B QkxFKFJPVVRJTkdfQVJCSVRSQVRJT04pCisgICAgbV9yb3V0aW5nQXJiaXRyYXRvci0+cHJvY2Vz c0RpZFRlcm1pbmF0ZSgpOworI2VuZGlmCiB9CiAjZW5kaWYKIAo=