226729 2021-06-07 07:27:41 -0700 [css-flexbox] Tables inside flexbox do not account for their borders correctly 2024-01-22 15:51:35 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 1 felipeerias webkit-unassigned ahmad.saleem792 bfulgham changseok esprehn+autocc ews-watchlist felipeerias glenn kondapallykalyan pdr simon.fraser svillar webkit-bug-importer zalan oldest_to_newest 1767438 0 felipeerias 2021-06-07 07:27:41 -0700 An empty table inside a flexbox tries to follow its overriding logical height. However, in so doing it may fail to account correctly for its border. This means that the final logical height of the element can be wrong when the border is not empty. Test case: imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-column-1.html 1767441 1 430745 felipeerias 2021-06-07 07:47:25 -0700 Created attachment 430745 Patch 1768883 2 431181 felipeerias 2021-06-10 22:38:56 -0700 Created attachment 431181 Patch 1768884 3 felipeerias 2021-06-10 22:46:53 -0700 Updated the title because this turned out to be a more general problem. When a table's height or width is set though an attribute of the <table> tag, that value will include borders and padding. When it is set through CSS, that will depend on the value of the table's "box-sizing" property. With the last patch, RenderTable will check for the presence of those attributes in the <table> tag as well as the value of "box-sizing" before deciding how to handle the table's border and padding. This fixes: imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-inflexible-in-row-2.html I suspect that table-as-item-inflexible-in-column-2.html also fails for a similar reason. 1769387 4 webkit-bug-importer 2021-06-14 07:28:15 -0700 <rdar://problem/79287201> 1859068 5 431181 ntim 2022-04-06 15:52:29 -0700 Comment on attachment 431181 Patch Cleaning r? flag, since it does not build, and it is quite old at this point. 1962304 6 ahmad.saleem792 2023-06-17 17:02:43 -0700 Safari Technology Preview 172 is passing both tests: https://wpt.fyi/results/css/css-flexbox?label=master&label=experimental&aligned=&q=table-as-item-inflexible-in-column Do we need to track this anymore? 2006704 7 bfulgham 2024-01-22 15:51:35 -0800 Closing based on Ahmad's testing. 430745 2021-06-07 07:47:25 -0700 2021-06-10 22:38:52 -0700 Patch bug-226729-20210607234724.patch text/plain 3772 felipeerias U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzNhNWZhOTllNTA0Mzg5 OTY2OTNhYzA2NjgzOTExYmJkMTU5ZThmNS4uMGM3OTRkNDRmNjVjNWI3ZDlmZGU0ZTA3NmYwMDll NDgyOWM0YTNjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA2LTA3ICBGZWxp cGUgRXJpYXMgIDxmZWxpcGVlcmlhc0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZmxleGJv eF0gRW1wdHkgdGFibGUgaW5zaWRlIGZsZXhib3ggZmFpbHMgdG8gYWNjb3VudCBmb3IgaXRzIGJv cmRlciB3aGVuIGNvbXB1dGluZyBpdHMgaGVpZ2h0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjY3MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGNhbGN1bGF0aW5nIHRoZSBoZWlnaHQgb2YgYW4g ZW1wdHkgdGFibGUsIGlmIGFuIG92ZXJyaWRpbmcgdmFsdWUgaGFzIGJlZW4gc2V0CisgICAgICAg IHdlIG5lZWQgdG8gc3Vic3RyYWN0IGZyb20gaXQgdGhlIHRoaWNrbmVzcyBvZiB0aGUgYm9yZGVy IHNvIGl0IGlzIG5vdCBjb3VudGVkIHR3aWNlLgorCisgICAgICAgIFRlc3Q6IGltcG9ydGVkL3cz Yy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mbGV4Ym94L3RhYmxlLWFzLWl0ZW0taW5mbGV4 aWJsZS1pbi1jb2x1bW4tMS5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGFibGUu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGFibGU6OmxheW91dCk6CisKIDIwMjEtMDYt MDEgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgQ2hl Y2tlZDo6dW5zYWZlR2V0KCkgdG8gQ2hlY2tlZDo6dmFsdWUoKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUYWJsZS5jcHAKaW5kZXggZjQ2Zjk4OTIyYjI0Nzg0MGVjOTY0ZWU2NGYzYTZk NzIzZWRlMjkzOC4uZGQ5ZjFjNDE3Y2IwZDdjYjRiOGMzMDZhMmRkMWEwMDc5ZDViODg4NiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGUuY3BwCkBAIC01MzIsNyArNTMyLDcg QEAgdm9pZCBSZW5kZXJUYWJsZTo6bGF5b3V0KCkKICAgICAgICAgICAgIC8vIENvbXBsZXRlbHkg ZW1wdHkgdGFibGVzICh3aXRoIG5vIHNlY3Rpb25zIG9yIGFueXRoaW5nKSBzaG91bGQgYXQgbGVh c3QgaG9ub3IgdGhlaXIKICAgICAgICAgICAgIC8vIG92ZXJyaWRpbmcgb3Igc3BlY2lmaWVkIGhl aWdodCBpbiBzdHJpY3QgbW9kZSwgYnV0IHRoaXMgdmFsdWUgd2lsbCBub3QgYmUgY2FjaGVkLgog ICAgICAgICAgICAgc2hvdWxkQ2FjaGVJbnRyaW5zaWNDb250ZW50TG9naWNhbEhlaWdodEZvckZs ZXhJdGVtID0gZmFsc2U7Ci0gICAgICAgICAgICBzZXRMb2dpY2FsSGVpZ2h0KGhhc092ZXJyaWRp bmdMb2dpY2FsSGVpZ2h0KCkgPyBvdmVycmlkaW5nTG9naWNhbEhlaWdodCgpIDogbG9naWNhbEhl aWdodCgpICsgY29tcHV0ZWRMb2dpY2FsSGVpZ2h0KTsKKyAgICAgICAgICAgIHNldExvZ2ljYWxI ZWlnaHQoaGFzT3ZlcnJpZGluZ0xvZ2ljYWxIZWlnaHQoKSA/IG92ZXJyaWRpbmdMb2dpY2FsSGVp Z2h0KCkgLSBib3JkZXJBbmRQYWRkaW5nQWZ0ZXIgOiBsb2dpY2FsSGVpZ2h0KCkgKyBjb21wdXRl ZExvZ2ljYWxIZWlnaHQpOwogICAgICAgICB9CiAKICAgICAgICAgTGF5b3V0VW5pdCBzZWN0aW9u TG9naWNhbExlZnQgPSBzdHlsZSgpLmlzTGVmdFRvUmlnaHREaXJlY3Rpb24oKSA/IGJvcmRlclN0 YXJ0KCkgOiBib3JkZXJFbmQoKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4ZTFlMGJhY2I4OWJjNjhhMmE5M2QwMDc2NzAw NmI0ZDkyZjBiYTE3Li5jNGJjYzY0MmI3NWRiZDg3MDhjYTVlN2FjYjc2NTkyOWRkMTg1MjJiIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjEtMDYtMDcgIEZlbGlwZSBFcmlhcyAgPGZlbGlwZWVy aWFzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW2Nzcy1mbGV4Ym94XSBFbXB0eSB0YWJsZSBpbnNp ZGUgZmxleGJveCBmYWlscyB0byBhY2NvdW50IGZvciBpdHMgYm9yZGVyIHdoZW4gY29tcHV0aW5n IGl0cyBoZWlnaHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIyNjcyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVGVzdEV4cGVjdGF0aW9uczogUmVtb3ZlIG9uZSBXUFQgdGVzdCB0aGF0IG5vdyBwYXNz ZXMuCisKIDIwMjEtMDYtMDEgIExhdXJvIE1vdXJhICA8bG1vdXJhQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW1dQRV0gR2FyZGVuIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9z ZW1hbnRpY3MvZW1iZWRkZWQtY29udGVudC90aGUtaW1nLWVsZW1lbnQvc291cmNlLW1lZGlhLW91 dHNpZGUtZG9jLmh0bWwgZmxha2luZXNzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9UZXN0RXhw ZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAxNDRlMGQzYjc5 ODI1OTg3OGI5ZGE3MTBmMDIxOWZmODYwZjI0ZmVkLi42ZWZiNmEwYmFlYjIwNzFhMTVlOGNjZDBm ZGU0ZDY0MzQ4YmM3YmU2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25z CisrKyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTM5MTAsNyArMzkxMCw2IEBA IHdlYmtpdC5vcmcvYi8yMjE0NzIgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3Mv Y3NzLWZsZXhib3gvYWJzcG9zL2ZsZXgtCiAKICMgVGFibGVzIGFzIGZsZXggaXRlbXMuCiB3ZWJr aXQub3JnL2IvMjIxNDczIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1m bGV4Ym94L3RhYmxlLWFzLWl0ZW0tZml4ZWQtbWluLXdpZHRoLTMuaHRtbCBbIEltYWdlT25seUZh aWx1cmUgXQotd2Via2l0Lm9yZy9iLzIyMTQ3MyBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL2Nzcy9jc3MtZmxleGJveC90YWJsZS1hcy1pdGVtLWluZmxleGlibGUtaW4tY29sdW1uLTEu aHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzIyMTQ3MyBpbXBvcnRlZC93 M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZmxleGJveC90YWJsZS1hcy1pdGVtLWluZmxl eGlibGUtaW4tY29sdW1uLTIuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQogd2Via2l0Lm9yZy9i LzIyMTQ3MyBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZmxleGJveC90 YWJsZS1hcy1pdGVtLWluZmxleGlibGUtaW4tcm93LTIuaHRtbCBbIEltYWdlT25seUZhaWx1cmUg XQogd2Via2l0Lm9yZy9iLzIyMTQ3MyBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nz cy9jc3MtZmxleGJveC90YWJsZS1hcy1pdGVtLW1pbi1oZWlnaHQtMS5odG1sIFsgSW1hZ2VPbmx5 RmFpbHVyZSBdCg== 431181 2021-06-10 22:38:56 -0700 2022-04-06 15:52:29 -0700 Patch bug-226729-20210611143855.patch text/plain 9067 felipeerias U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzNhNWZhOTllNTA0Mzg5 OTY2OTNhYzA2NjgzOTExYmJkMTU5ZThmNS4uY2NmZDY0NjFkM2YzM2I0ZmI4Y2MyNTY5ODE0OTUz NTc2ODljZjkzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDIxLTA2LTEwICBGZWxp cGUgRXJpYXMgIDxmZWxpcGVlcmlhc0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZmxleGJv eF0gVGFibGVzIGluc2lkZSBmbGV4Ym94IGRvIG5vdCBhY2NvdW50IGZvciB0aGVpciBib3JkZXJz IGNvcnJlY3RseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjI2NzI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2hlbiBhIHRhYmxlJ3MgaGVpZ2h0IG9yIHdpZHRoIGlzIHNldCB0aG91Z2ggYW4gYXR0cmli dXRlIG9mIHRoZSA8dGFibGU+IHRhZywgdGhhdCB2YWx1ZQorICAgICAgICB3aWxsIGluY2x1ZGUg Ym9yZGVycyBhbmQgcGFkZGluZy4gV2hlbiBpdCBpcyBzZXQgdGhyb3VnaCBDU1MsIHRoYXQgYmVo YXZpb3Igd2lsbCBkZXBlbmQgb24KKyAgICAgICAgdGhlIHZhbHVlIG9mIHRoZSB0YWJsZSdzICJi b3gtc2l6aW5nIiBwcm9wZXJ0eS4KKworICAgICAgICBXaGVuIGNhbGN1bGF0aW5nIHRoZSBoZWln aHQgb2YgYW4gZW1wdHkgdGFibGUsIGlmIGFuIG92ZXJyaWRpbmcgdmFsdWUgaGFzIGJlZW4gc2V0 CisgICAgICAgIHdlIG5lZWQgdG8gc3Vic3RyYWN0IGZyb20gaXQgdGhlIHRoaWNrbmVzcyBvZiB0 aGUgYm9yZGVyIHNvIGl0IGlzIG5vdCBjb3VudGVkIHR3aWNlLgorCisgICAgICAgIFRlc3Q6IGlt cG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mbGV4Ym94L3RhYmxlLWFzLWl0 ZW0taW5mbGV4aWJsZS1pbi1jb2x1bW4tMS5odG1sCisgICAgICAgICAgICAgIGltcG9ydGVkL3cz Yy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mbGV4Ym94L3RhYmxlLWFzLWl0ZW0taW5mbGV4 aWJsZS1pbi1yb3ctMi5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGFibGUuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGFibGU6OnVwZGF0ZUxvZ2ljYWxXaWR0aCk6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJUYWJsZTo6Y29udmVydFN0eWxlTG9naWNhbFdpZHRoVG9D b21wdXRlZFdpZHRoKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRhYmxlOjpjb252ZXJ0U3R5 bGVMb2dpY2FsSGVpZ2h0VG9Db21wdXRlZEhlaWdodCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJUYWJsZTo6bGF5b3V0KToKKwogMjAyMS0wNi0wMSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBw bGUuY29tPgogCiAgICAgICAgIFJlbmFtZSBDaGVja2VkOjp1bnNhZmVHZXQoKSB0byBDaGVja2Vk Ojp2YWx1ZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFi bGUuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcAppbmRleCBm NDZmOTg5MjJiMjQ3ODQwZWM5NjRlZTY0ZjNhNmQ3MjNlZGUyOTM4Li5kZTRiNjNhNGY2MmI4Zjk2 YjA2YjU4ZWJkNTc5NTZlMGNiNGI3ODkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGFibGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUYWJsZS5jcHAKQEAgLTI2Myw5ICsyNjMsMTMgQEAgdm9pZCBSZW5kZXJUYWJsZTo6dXBkYXRl TG9naWNhbFdpZHRoKCkKICAgICBMZW5ndGggc3R5bGVMb2dpY2FsV2lkdGggPSBzdHlsZSgpLmxv Z2ljYWxXaWR0aCgpOwogICAgIGlmIChoYXNPdmVycmlkaW5nTG9naWNhbFdpZHRoKCkpCiAgICAg ICAgIHNldExvZ2ljYWxXaWR0aChvdmVycmlkaW5nTG9naWNhbFdpZHRoKCkpOwotICAgIGVsc2Ug aWYgKChzdHlsZUxvZ2ljYWxXaWR0aC5pc1NwZWNpZmllZCgpICYmIHN0eWxlTG9naWNhbFdpZHRo LmlzUG9zaXRpdmUoKSkgfHwgc3R5bGVMb2dpY2FsV2lkdGguaXNJbnRyaW5zaWMoKSkKLSAgICAg ICAgc2V0TG9naWNhbFdpZHRoKGNvbnZlcnRTdHlsZUxvZ2ljYWxXaWR0aFRvQ29tcHV0ZWRXaWR0 aChzdHlsZUxvZ2ljYWxXaWR0aCwgY29udGFpbmVyV2lkdGhJbklubGluZURpcmVjdGlvbikpOwot ICAgIGVsc2UgeworICAgIGVsc2UgaWYgKHN0eWxlTG9naWNhbFdpZHRoLmlzSW50cmluc2ljKCkp IHsKKyAgICAgICAgc2V0TG9naWNhbFdpZHRoKGNvbXB1dGVJbnRyaW5zaWNMb2dpY2FsV2lkdGhV c2luZyhzdHlsZUxvZ2ljYWxXaWR0aCwgY29udGFpbmVyV2lkdGhJbklubGluZURpcmVjdGlvbiwg Ym9yZGVyc1BhZGRpbmdBbmRTcGFjaW5nSW5Sb3dEaXJlY3Rpb24oKSkpOworICAgIH0gZWxzZSBp ZiAoc3R5bGVMb2dpY2FsV2lkdGguaXNTcGVjaWZpZWQoKSAmJiBzdHlsZUxvZ2ljYWxXaWR0aC5p c1Bvc2l0aXZlKCkpIHsKKyAgICAgICAgTGF5b3V0VW5pdCBib3JkZXJzID0gYm9yZGVyU3RhcnQo KSArIGJvcmRlckVuZCgpICsgKGNvbGxhcHNlQm9yZGVycygpID8gMF9sdSA6IHBhZGRpbmdTdGFy dCgpICsgcGFkZGluZ0VuZCgpKTsKKworICAgICAgICBzZXRMb2dpY2FsV2lkdGgobWluaW11bVZh bHVlRm9yTGVuZ3RoKHN0eWxlTG9naWNhbFdpZHRoLCBjb250YWluZXJXaWR0aEluSW5saW5lRGly ZWN0aW9uKSArIGJvcmRlcnMpOworICAgIH0gZWxzZSB7CiAgICAgICAgIC8vIFN1YnRyYWN0IG91 dCBhbnkgZml4ZWQgbWFyZ2lucyBmcm9tIG91ciBhdmFpbGFibGUgd2lkdGggZm9yIGF1dG8gd2lk dGggdGFibGVzLgogICAgICAgICBMYXlvdXRVbml0IG1hcmdpblN0YXJ0ID0gbWluaW11bVZhbHVl Rm9yTGVuZ3RoKHN0eWxlKCkubWFyZ2luU3RhcnQoKSwgYXZhaWxhYmxlTG9naWNhbFdpZHRoKTsK ICAgICAgICAgTGF5b3V0VW5pdCBtYXJnaW5FbmQgPSBtaW5pbXVtVmFsdWVGb3JMZW5ndGgoc3R5 bGUoKS5tYXJnaW5FbmQoKSwgYXZhaWxhYmxlTG9naWNhbFdpZHRoKTsKQEAgLTMzMiwxMCArMzM2 LDE3IEBAIExheW91dFVuaXQgUmVuZGVyVGFibGU6OmNvbnZlcnRTdHlsZUxvZ2ljYWxXaWR0aFRv Q29tcHV0ZWRXaWR0aChjb25zdCBMZW5ndGgmIHN0CiAgICAgaWYgKHN0eWxlTG9naWNhbFdpZHRo LmlzSW50cmluc2ljKCkpCiAgICAgICAgIHJldHVybiBjb21wdXRlSW50cmluc2ljTG9naWNhbFdp ZHRoVXNpbmcoc3R5bGVMb2dpY2FsV2lkdGgsIGF2YWlsYWJsZVdpZHRoLCBib3JkZXJzUGFkZGlu Z0FuZFNwYWNpbmdJblJvd0RpcmVjdGlvbigpKTsKIAotICAgIC8vIEhUTUwgdGFibGVzJyB3aWR0 aCBzdHlsZXMgYWxyZWFkeSBpbmNsdWRlIGJvcmRlcnMgYW5kIHBhZGRpbmcsIGJ1dCBDU1MgdGFi bGVzJyB3aWR0aCBzdHlsZXMgZG8gbm90LgorICAgIC8vIFdoZW4gdGhlIHdpZHRoIGlzIHNldCB0 aG91Z2ggYW4gYXR0cmlidXRlIG9mIHRoZSA8dGFibGU+IHRhZywgaXQgd2lsbCBpbmNsdWRlIGJv cmRlcnMgYW5kIHBhZGRpbmc7CisgICAgLy8gaG93ZXZlciwgd2hlbiB0aGUgd2lkdGggaXMgc2V0 IHRocm91Z2ggQ1NTIHRoYXQgd2lsbCBkZXBlbmQgb24gdGhlIHZhbHVlIG9mIGJveC1zaXppbmcu CisgICAgYm9vbCBoYXNMb2dpY2FsV2lkdGhIaW50OworICAgIGlmIChpczxIVE1MVGFibGVFbGVt ZW50PihlbGVtZW50KCkpKSB7CisgICAgICAgIFN0eWxlZEVsZW1lbnQqIHN0eWxlZEVsZW1lbnQg PSBkb3duY2FzdDxTdHlsZWRFbGVtZW50PihlbGVtZW50KCkpOworCisgICAgICAgIGlmIChjb25z dCBTdHlsZVByb3BlcnRpZXMqIGhpbnRzID0gc3R5bGVkRWxlbWVudC0+cHJlc2VudGF0aW9uYWxI aW50U3R5bGUoKSkKKyAgICAgICAgICAgIGhhc0xvZ2ljYWxXaWR0aEhpbnQgPSBzdHlsZSgpLmlz SG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkgPyBoaW50cy0+Z2V0UHJvcGVydHlDU1NWYWx1ZShDU1NQ cm9wZXJ0eVdpZHRoKSA6IGhpbnRzLT5nZXRQcm9wZXJ0eUNTU1ZhbHVlKENTU1Byb3BlcnR5SGVp Z2h0KTsKKyAgICB9CiAgICAgTGF5b3V0VW5pdCBib3JkZXJzOwotICAgIGJvb2wgaXNDU1NUYWJs ZSA9ICFpczxIVE1MVGFibGVFbGVtZW50PihlbGVtZW50KCkpOwotICAgIGlmIChpc0NTU1RhYmxl ICYmIHN0eWxlTG9naWNhbFdpZHRoLmlzU3BlY2lmaWVkKCkgJiYgc3R5bGVMb2dpY2FsV2lkdGgu aXNQb3NpdGl2ZSgpICYmIHN0eWxlKCkuYm94U2l6aW5nKCkgPT0gQm94U2l6aW5nOjpDb250ZW50 Qm94KQorICAgIGlmIChoYXNMb2dpY2FsV2lkdGhIaW50IHx8IHN0eWxlKCkuYm94U2l6aW5nKCkg PT0gQm94U2l6aW5nOjpCb3JkZXJCb3gpCiAgICAgICAgIGJvcmRlcnMgPSBib3JkZXJTdGFydCgp ICsgYm9yZGVyRW5kKCkgKyAoY29sbGFwc2VCb3JkZXJzKCkgPyAwX2x1IDogcGFkZGluZ1N0YXJ0 KCkgKyBwYWRkaW5nRW5kKCkpOwogCiAgICAgcmV0dXJuIG1pbmltdW1WYWx1ZUZvckxlbmd0aChz dHlsZUxvZ2ljYWxXaWR0aCwgYXZhaWxhYmxlV2lkdGgpICsgYm9yZGVyczsKQEAgLTM0MywxNiAr MzU0LDIyIEBAIExheW91dFVuaXQgUmVuZGVyVGFibGU6OmNvbnZlcnRTdHlsZUxvZ2ljYWxXaWR0 aFRvQ29tcHV0ZWRXaWR0aChjb25zdCBMZW5ndGgmIHN0CiAKIExheW91dFVuaXQgUmVuZGVyVGFi bGU6OmNvbnZlcnRTdHlsZUxvZ2ljYWxIZWlnaHRUb0NvbXB1dGVkSGVpZ2h0KGNvbnN0IExlbmd0 aCYgc3R5bGVMb2dpY2FsSGVpZ2h0KQogewotICAgIExheW91dFVuaXQgYm9yZGVyQW5kUGFkZGlu Z0JlZm9yZSA9IGJvcmRlckJlZm9yZSgpICsgKGNvbGxhcHNlQm9yZGVycygpID8gMF9sdSA6IHBh ZGRpbmdCZWZvcmUoKSk7Ci0gICAgTGF5b3V0VW5pdCBib3JkZXJBbmRQYWRkaW5nQWZ0ZXIgPSBi b3JkZXJBZnRlcigpICsgKGNvbGxhcHNlQm9yZGVycygpID8gMF9sdSA6IHBhZGRpbmdBZnRlcigp KTsKLSAgICBMYXlvdXRVbml0IGJvcmRlckFuZFBhZGRpbmcgPSBib3JkZXJBbmRQYWRkaW5nQmVm b3JlICsgYm9yZGVyQW5kUGFkZGluZ0FmdGVyOworICAgIExheW91dFVuaXQgYm9yZGVyQW5kUGFk ZGluZyA9IGJvcmRlckJlZm9yZSgpICsgYm9yZGVyQWZ0ZXIoKSArIChjb2xsYXBzZUJvcmRlcnMo KSA/IDBfbHUgOiBwYWRkaW5nQmVmb3JlKCkgKyBwYWRkaW5nQWZ0ZXIoKSk7CisKICAgICBpZiAo c3R5bGVMb2dpY2FsSGVpZ2h0LmlzRml4ZWQoKSkgewotICAgICAgICAvLyBIVE1MIHRhYmxlcyBz aXplIGFzIHRob3VnaCBDU1MgaGVpZ2h0IGluY2x1ZGVzIGJvcmRlci9wYWRkaW5nLCBDU1MgdGFi bGVzIGRvIG5vdC4KKyAgICAgICAgLy8gV2hlbiB0aGUgaGVpZ2h0IGlzIHNldCB0aG91Z2ggYW4g YXR0cmlidXRlIG9mIHRoZSA8dGFibGU+IHRhZywgaXQgd2lsbCBpbmNsdWRlIGJvcmRlcnMgYW5k IHBhZGRpbmc7CisgICAgICAgIC8vIGhvd2V2ZXIsIHdoZW4gdGhlIGhlaWdodCBpcyBzZXQgdGhy b3VnaCBDU1MgdGhhdCB3aWxsIGRlcGVuZCBvbiB0aGUgdmFsdWUgb2YgYm94LXNpemluZy4KKyAg ICAgICAgYm9vbCBoYXNMb2dpY2FsSGVpZ2h0SGludDsKKyAgICAgICAgaWYgKGlzPEhUTUxUYWJs ZUVsZW1lbnQ+KGVsZW1lbnQoKSkpIHsKKyAgICAgICAgICAgIFN0eWxlZEVsZW1lbnQqIHN0eWxl ZEVsZW1lbnQgPSBkb3duY2FzdDxTdHlsZWRFbGVtZW50PihlbGVtZW50KCkpOworCisgICAgICAg ICAgICBpZiAoY29uc3QgU3R5bGVQcm9wZXJ0aWVzKiBoaW50cyA9IHN0eWxlZEVsZW1lbnQtPnBy ZXNlbnRhdGlvbmFsSGludFN0eWxlKCkpCisgICAgICAgICAgICAgICAgaGFzTG9naWNhbEhlaWdo dEhpbnQgPSBzdHlsZSgpLmlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkgPyBoaW50cy0+Z2V0UHJv cGVydHlDU1NWYWx1ZShDU1NQcm9wZXJ0eUhlaWdodCkgOiBoaW50cy0+Z2V0UHJvcGVydHlDU1NW YWx1ZShDU1NQcm9wZXJ0eVdpZHRoKTsKKyAgICAgICAgfQorCiAgICAgICAgIExheW91dFVuaXQg Ym9yZGVyczsKLSAgICAgICAgLy8gRklYTUU6IFdlIGNhbm5vdCBhcHBseSBib3gtc2l6aW5nOiBj b250ZW50LWJveCBvbiA8dGFibGU+IHdoaWNoIG90aGVyIGJyb3dzZXJzIGFsbG93LgotICAgICAg ICBpZiAoaXM8SFRNTFRhYmxlRWxlbWVudD4oZWxlbWVudCgpKSB8fCBzdHlsZSgpLmJveFNpemlu ZygpID09IEJveFNpemluZzo6Qm9yZGVyQm94KSB7CisgICAgICAgIGlmIChoYXNMb2dpY2FsSGVp Z2h0SGludCB8fCBzdHlsZSgpLmJveFNpemluZygpID09IEJveFNpemluZzo6Qm9yZGVyQm94KQog ICAgICAgICAgICAgYm9yZGVycyA9IGJvcmRlckFuZFBhZGRpbmc7Ci0gICAgICAgIH0KICAgICAg ICAgcmV0dXJuIExheW91dFVuaXQoc3R5bGVMb2dpY2FsSGVpZ2h0LnZhbHVlKCkgLSBib3JkZXJz KTsKICAgICB9IGVsc2UgaWYgKHN0eWxlTG9naWNhbEhlaWdodC5pc1BlcmNlbnRPckNhbGN1bGF0 ZWQoKSkKICAgICAgICAgcmV0dXJuIGNvbXB1dGVQZXJjZW50YWdlTG9naWNhbEhlaWdodChzdHls ZUxvZ2ljYWxIZWlnaHQpLnZhbHVlX29yKDApOwpAQCAtNTMyLDcgKzU0OSw3IEBAIHZvaWQgUmVu ZGVyVGFibGU6OmxheW91dCgpCiAgICAgICAgICAgICAvLyBDb21wbGV0ZWx5IGVtcHR5IHRhYmxl cyAod2l0aCBubyBzZWN0aW9ucyBvciBhbnl0aGluZykgc2hvdWxkIGF0IGxlYXN0IGhvbm9yIHRo ZWlyCiAgICAgICAgICAgICAvLyBvdmVycmlkaW5nIG9yIHNwZWNpZmllZCBoZWlnaHQgaW4gc3Ry aWN0IG1vZGUsIGJ1dCB0aGlzIHZhbHVlIHdpbGwgbm90IGJlIGNhY2hlZC4KICAgICAgICAgICAg IHNob3VsZENhY2hlSW50cmluc2ljQ29udGVudExvZ2ljYWxIZWlnaHRGb3JGbGV4SXRlbSA9IGZh bHNlOwotICAgICAgICAgICAgc2V0TG9naWNhbEhlaWdodChoYXNPdmVycmlkaW5nTG9naWNhbEhl aWdodCgpID8gb3ZlcnJpZGluZ0xvZ2ljYWxIZWlnaHQoKSA6IGxvZ2ljYWxIZWlnaHQoKSArIGNv bXB1dGVkTG9naWNhbEhlaWdodCk7CisgICAgICAgICAgICBzZXRMb2dpY2FsSGVpZ2h0KGhhc092 ZXJyaWRpbmdMb2dpY2FsSGVpZ2h0KCkgPyBvdmVycmlkaW5nTG9naWNhbEhlaWdodCgpIC0gYm9y ZGVyQW5kUGFkZGluZ0FmdGVyIDogbG9naWNhbEhlaWdodCgpICsgY29tcHV0ZWRMb2dpY2FsSGVp Z2h0KTsKICAgICAgICAgfQogCiAgICAgICAgIExheW91dFVuaXQgc2VjdGlvbkxvZ2ljYWxMZWZ0 ID0gc3R5bGUoKS5pc0xlZnRUb1JpZ2h0RGlyZWN0aW9uKCkgPyBib3JkZXJTdGFydCgpIDogYm9y ZGVyRW5kKCk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKaW5kZXggOGUxZTBiYWNiODliYzY4YTJhOTNkMDA3NjcwMDZiNGQ5MmYwYmEx Ny4uMGY2MjlmZjczZWZkMDA3OWRiZmVhYzdmODg5YmI2ZGU2ZTI1YjMzZSAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEyIEBACisyMDIxLTA2LTEwICBGZWxpcGUgRXJpYXMgIDxmZWxpcGVlcmlhc0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFtjc3MtZmxleGJveF0gVGFibGVzIGluc2lkZSBmbGV4Ym94IGRvIG5v dCBhY2NvdW50IGZvciB0aGVpciBib3JkZXJzIGNvcnJlY3RseQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2NzI5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0RXhwZWN0YXRpb25zOiBSZW1vdmUg dHdvIFdQVCB0ZXN0IHRoYXQgbm93IHBhc3Nlcy4KKwogMjAyMS0wNi0wMSAgTGF1cm8gTW91cmEg IDxsbW91cmFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV1BFXSBHYXJkZW4gaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9lbWJlZGRlZC1jb250ZW50L3RoZS1p bWctZWxlbWVudC9zb3VyY2UtbWVkaWEtb3V0c2lkZS1kb2MuaHRtbCBmbGFraW5lc3MKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9UZXN0RXhw ZWN0YXRpb25zCmluZGV4IDE0NGUwZDNiNzk4MjU5ODc4YjlkYTcxMGYwMjE5ZmY4NjBmMjRmZWQu LmMyMzRmYTdkMzNlMDFjYmQyMjEzMGZhZmU2ZjU5MmQ4M2M2NDg1ZTIgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0 aW9ucwpAQCAtMzkxMCw5ICszOTEwLDcgQEAgd2Via2l0Lm9yZy9iLzIyMTQ3MiBpbXBvcnRlZC93 M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZmxleGJveC9hYnNwb3MvZmxleC0KIAogIyBU YWJsZXMgYXMgZmxleCBpdGVtcy4KIHdlYmtpdC5vcmcvYi8yMjE0NzMgaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWZsZXhib3gvdGFibGUtYXMtaXRlbS1maXhlZC1taW4t d2lkdGgtMy5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMjIxNDczIGlt cG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mbGV4Ym94L3RhYmxlLWFzLWl0 ZW0taW5mbGV4aWJsZS1pbi1jb2x1bW4tMS5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJr aXQub3JnL2IvMjIxNDczIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1m bGV4Ym94L3RhYmxlLWFzLWl0ZW0taW5mbGV4aWJsZS1pbi1jb2x1bW4tMi5odG1sIFsgSW1hZ2VP bmx5RmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMjIxNDczIGltcG9ydGVkL3czYy93ZWItcGxhdGZv cm0tdGVzdHMvY3NzL2Nzcy1mbGV4Ym94L3RhYmxlLWFzLWl0ZW0taW5mbGV4aWJsZS1pbi1yb3ct Mi5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMjIxNDczIGltcG9ydGVk L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mbGV4Ym94L3RhYmxlLWFzLWl0ZW0tbWlu LWhlaWdodC0xLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIAogIyBTVkdzIGFzIGZsZXggaXRl bXMuCg==