226720 2021-06-07 02:17:01 -0700 [MSE] Assertion if attempting to perform eviction before an init segment was appended 2021-06-08 18:03:04 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=225800 InRadar, Regression P2 Normal --- 1 jean-yves.avenard jean-yves.avenard calvaris eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1767377 0 jean-yves.avenard 2021-06-07 02:17:01 -0700 Seen while browsing the SourceBufferPrivate::evictCodedFrames code. In SourceBufferPrivate::evictCodedFrames we have: ``` // NOTE: begin by removing data from the beginning of the buffered ranges, 30 seconds at // a time, up to 30 seconds before currentTime. MediaTime thirtySeconds = MediaTime(30, 1); MediaTime maximumRangeEnd = currentTime - thirtySeconds; #if !RELEASE_LOG_DISABLED uint64_t initialBufferedSize = totalTrackBufferSizeInBytes(); DEBUG_LOG(LOGIDENTIFIER, "currentTime = ", currentTime, ", require ", initialBufferedSize + newDataSize, " bytes, maximum buffer size is ", maximumBufferSize); #endif MediaTime rangeStart = MediaTime::zeroTime(); MediaTime rangeEnd = rangeStart + thirtySeconds; while (rangeStart < maximumRangeEnd) { // 4. For each range in removal ranges, run the coded frame removal algorithm with start and // end equal to the removal range start and end timestamp respectively. removeCodedFrames(rangeStart, std::min(rangeEnd, maximumRangeEnd), currentTime, isEnded); if (!isBufferFullFor(newDataSize, maximumBufferSize)) { break; } rangeStart += thirtySeconds; rangeEnd += thirtySeconds; } ``` removeCodedFrames will immediately assert that `ASSERT(start < end);` if we haven't started playback, or currentTime = 0 MediaTime maximumRangeEnd = currentTime - thirtySeconds = -30s MediaTime rangeStart = MediaTime::zeroTime() = 0s MediaTime rangeEnd = rangeStart + thirtySeconds = 30s so: removeCodedFrames(rangeStart, std::min(rangeEnd, maximumRangeEnd), currentTime, isEnded); is called with rangeState = 0 std::min(rangeEnd, maximumRangeEnd) = -30s which will assert. 1767391 1 jean-yves.avenard 2021-06-07 03:53:01 -0700 This is a regression from bug 225800 It removes the check to determine if the buffer range index were valid. so we attempt to call removeCodedFrames with invalid values. 1767395 2 jean-yves.avenard 2021-06-07 04:02:39 -0700 My analysis above was wrong, it does assert, but in a different spot. in the loop that check on what can be removed in the non-contiguous sections after currentTime 1767412 3 webkit-bug-importer 2021-06-07 04:56:55 -0700 <rdar://problem/78943223> 1767421 4 430738 jean-yves.avenard 2021-06-07 06:06:48 -0700 Created attachment 430738 Patch 1768008 5 ews-feeder 2021-06-08 18:03:02 -0700 Committed r278635 (238618@main): <https://commits.webkit.org/238618@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430738. 430738 2021-06-07 06:06:48 -0700 2021-06-08 18:03:03 -0700 Patch bug-226720-20210607230646.patch text/plain 5983 jean-yves.avenard U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MzM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjI2YTRlYjk0Y2VmMzQ2 ZmMwNzAwMzZlOTk5MTk5YjA4YTNiZjM4NS4uOTMzNmE3YmJiY2NhZDI0NzZiYzMxOTRiMDM0Zjky OWEyMDYwYzg2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA2LTA3ICBKZWFu LVl2ZXMgQXZlbmFyZCAgPGp5YUBhcHBsZS5jb20+CisKKyAgICAgICAgW01TRV0gQXNzZXJ0aW9u IGlmIGF0dGVtcHRpbmcgdG8gcGVyZm9ybSBldmljdGlvbiBiZWZvcmUgcGxheWJhY2sgc3RhcnRz LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2NzIw CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83ODk0MzIyMz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIYW5kbGUgdGhlIGNhc2Ugd2hlcmUgdGhlIGJ1 ZmZlcmVkIHJhbmdlIGRvZXNuJ3QgeWV0IGV4aXN0IGFzIHdlIGhhdmVuJ3QgcGFyc2VkCisgICAg ICAgIGFuIGluaXQgc2VnbWVudCB5ZXQuCisgICAgICAgIFRlc3Q6IG1lZGlhL21lZGlhLXNvdXJj ZS9tZWRpYS1zb3VyY2UtYXBwZW5kLWJ1ZmZlci1mdWxsLXF1b3RhLWV4Y2VlZGVkLWVycm9yLW9u c3RhcnQuaHRtbAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvU291cmNlQnVmZmVyUHJp dmF0ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTb3VyY2VCdWZmZXJQcml2YXRlOjpldmljdENv ZGVkRnJhbWVzKTogRXhpdCBlYXJseSBpZiB0aGUgYnVmZmVyZWQgcmFuZ2UgaXMgZW1wdHkKKyAg ICAgICAgYW5kIGhhbmRsZSB0aGUgY2FzZSB3aGVyZSBhIGJ1ZmZlcmVkIHJhbmdlIGluZGV4IHdh c24ndCBmb3VuZC4KKwogMjAyMS0wNi0wNyAgSmVhbi1ZdmVzIEF2ZW5hcmQgIDxqeWFAYXBwbGUu Y29tPgogCiAgICAgICAgIFtNU0VdIFJld29yayBoYW5kbGluZyBvZiBTb3VyY2VCdWZmZXIncyBi dWZmZXIgZnVsbC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L1NvdXJjZUJ1ZmZlclByaXZhdGUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvU291cmNlQnVmZmVyUHJpdmF0ZS5jcHAKaW5kZXggODc5YWZiMDRiM2U2NTUwODdjNmZhZGFj ZDYxZjNhNzU2NzhlNGYxYi4uNDQ5MzAzN2I4MzVjMzk3NjQ5NGJiZmJmNmRiNGUwODlmMjFjZmVj NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvU291cmNlQnVm ZmVyUHJpdmF0ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvU291 cmNlQnVmZmVyUHJpdmF0ZS5jcHAKQEAgLTY3OSwxNCArNjc5LDE1IEBAIHZvaWQgU291cmNlQnVm ZmVyUHJpdmF0ZTo6ZXZpY3RDb2RlZEZyYW1lcyh1aW50NjRfdCBuZXdEYXRhU2l6ZSwgdWludDY0 X3QgbWF4aW11CiAgICAgLy8gY3VycmVuVGltZSB3aGljaGV2ZXIgd2UgaGl0IGZpcnN0LgogICAg IGF1dG8gYnVmZmVyZWQgPSBtX2J1ZmZlcmVkLT5yYW5nZXMoKTsKICAgICB1aW50NjRfdCBjdXJy ZW50VGltZVJhbmdlID0gYnVmZmVyZWQuZmluZChjdXJyZW50VGltZSk7Ci0gICAgaWYgKGN1cnJl bnRUaW1lUmFuZ2UgPT0gYnVmZmVyZWQubGVuZ3RoKCkgLSAxKSB7CisgICAgaWYgKCFidWZmZXJl ZC5sZW5ndGgoKSB8fCBjdXJyZW50VGltZVJhbmdlID09IGJ1ZmZlcmVkLmxlbmd0aCgpIC0gMSkg ewogI2lmICFSRUxFQVNFX0xPR19ESVNBQkxFRAogICAgICAgICBFUlJPUl9MT0coTE9HSURFTlRJ RklFUiwgIkZBSUxFRCB0byBmcmVlIGVub3VnaCBhZnRlciBldmljdGluZyAiLCBpbml0aWFsQnVm ZmVyZWRTaXplIC0gdG90YWxUcmFja0J1ZmZlclNpemVJbkJ5dGVzKCkpOwogI2VuZGlmCiAgICAg ICAgIHJldHVybjsKICAgICB9CiAKLSAgICBNZWRpYVRpbWUgbWluaW11bVJhbmdlU3RhcnQgPSBz dGQ6Om1heChjdXJyZW50VGltZSArIHRoaXJ0eVNlY29uZHMsIGJ1ZmZlcmVkLmVuZChjdXJyZW50 VGltZVJhbmdlKSk7CisgICAgTWVkaWFUaW1lIG1pbmltdW1SYW5nZVN0YXJ0ID0KKyAgICAgICAg Y3VycmVudFRpbWVSYW5nZSA9PSBub3RGb3VuZCA/IGN1cnJlbnRUaW1lICsgdGhpcnR5U2Vjb25k cyA6IHN0ZDo6bWF4KGN1cnJlbnRUaW1lICsgdGhpcnR5U2Vjb25kcywgYnVmZmVyZWQuZW5kKGN1 cnJlbnRUaW1lUmFuZ2UpKTsKIAogICAgIHJhbmdlRW5kID0gZHVyYXRpb247CiAgICAgaWYgKCFy YW5nZUVuZC5pc0Zpbml0ZSgpKSB7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDU1Nzc3MTczYzNjNTA4OWNjZGNiOTg4NjQw MzRiODhhZWY2ODQ5MC4uNTk2NDJiNjcxNDM3NmYwZjA4ZDEzYzc5NjIwZTAzZjcyZWI4Y2JjYiAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA2LTA3ICBKZWFuLVl2ZXMgQXZlbmFyZCAgPGp5 YUBhcHBsZS5jb20+CisKKyAgICAgICAgW01TRV0gQXNzZXJ0aW9uIGlmIGF0dGVtcHRpbmcgdG8g cGVyZm9ybSBldmljdGlvbiBiZWZvcmUgcGxheWJhY2sgc3RhcnRzLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2NzIwCisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS83ODk0MzIyMz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIG1lZGlhL21lZGlhLXNvdXJjZS9tZWRpYS1zb3VyY2UtYXBwZW5kLWJ1ZmZl ci1mdWxsLXF1b3RhLWV4Y2VlZGVkLWVycm9yLW9uc3RhcnQtZXhwZWN0ZWQudHh0OiBBZGRlZC4K KyAgICAgICAgKiBtZWRpYS9tZWRpYS1zb3VyY2UvbWVkaWEtc291cmNlLWFwcGVuZC1idWZmZXIt ZnVsbC1xdW90YS1leGNlZWRlZC1lcnJvci1vbnN0YXJ0Lmh0bWw6IEFkZGVkLgorCiAyMDIxLTA1 LTI3ICBKZWFuLVl2ZXMgQXZlbmFyZCAgPGp5YUBhcHBsZS5jb20+CiAKICAgICAgICAgTWVkaWFT ZXNzaW9uLmNvb3JkaW5hdG9yIHNob3VsZCBub3QgYmUgb3B0aW9uYWwsIHJlbHlpbmcgb24gY29v cmRpbmF0b3IgcmVhZHlTdGF0ZSBjaGFuZ2UgaW5zdGVhZApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvbWVkaWEvbWVkaWEtc291cmNlL21lZGlhLXNvdXJjZS1hcHBlbmQtYnVmZmVyLWZ1bGwtcXVv dGEtZXhjZWVkZWQtZXJyb3Itb25zdGFydC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9tZWRp YS9tZWRpYS1zb3VyY2UvbWVkaWEtc291cmNlLWFwcGVuZC1idWZmZXItZnVsbC1xdW90YS1leGNl ZWRlZC1lcnJvci1vbnN0YXJ0LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41NWU5NTE4OGI1Njc5 OWNkZjk0ZjZiN2JhMTkxOTdlYzYwYWM2ZjA0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvbWVkaWEvbWVkaWEtc291cmNlL21lZGlhLXNvdXJjZS1hcHBlbmQtYnVmZmVyLWZ1bGwtcXVv dGEtZXhjZWVkZWQtZXJyb3Itb25zdGFydC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw2IEBACisK K0VWRU5UKHNvdXJjZW9wZW4pCitBcHBlbmRpbmcgYnVmZmVyCitFWFBFQ1RFRCAoZXhjZXB0aW9u ID09ICdRdW90YUV4Y2VlZGVkRXJyb3I6IFRoZSBxdW90YSBoYXMgYmVlbiBleGNlZWRlZC4nKSBP SworRU5EIE9GIFRFU1QKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtc291 cmNlL21lZGlhLXNvdXJjZS1hcHBlbmQtYnVmZmVyLWZ1bGwtcXVvdGEtZXhjZWVkZWQtZXJyb3It b25zdGFydC5odG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtc291cmNlL21lZGlhLXNvdXJj ZS1hcHBlbmQtYnVmZmVyLWZ1bGwtcXVvdGEtZXhjZWVkZWQtZXJyb3Itb25zdGFydC5odG1sCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLjFjYjY5OWEyNTk4YWU5YWVjNjEwMmQ3MTliNTRmM2IxMWY0MDk4NmMKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1zb3VyY2UvbWVkaWEtc291cmNl LWFwcGVuZC1idWZmZXItZnVsbC1xdW90YS1leGNlZWRlZC1lcnJvci1vbnN0YXJ0Lmh0bWwKQEAg LTAsMCArMSw1NCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorICAgIDx0aXRs ZT5tb2NrLW1lZGlhLXNvdXJjZTwvdGl0bGU+CisgICAgPHNjcmlwdCBzcmM9Im1vY2stbWVkaWEt c291cmNlLmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0iLi4vdmlkZW8tdGVzdC5qcyI+ PC9zY3JpcHQ+CisgICAgPHNjcmlwdD4KKyAgICB2YXIgc291cmNlOworICAgIHZhciBzb3VyY2VC dWZmZXI7CisgICAgdmFyIGluaXRTZWdtZW50OworICAgIHZhciBleGNlcHRpb247CisKKyAgICBh c3luYyBmdW5jdGlvbiBhcHBlbmRCdWZmZXIoYnVmZmVyKSB7CisgICAgICAgIHZhciByZXN1bHRF eGNlcHRpb24gPSBudWxsOworICAgICAgICB0cnkgeworICAgICAgICAgICAgY29uc29sZVdyaXRl KCdBcHBlbmRpbmcgYnVmZmVyJyk7CisgICAgICAgICAgICBzb3VyY2VCdWZmZXIuYXBwZW5kQnVm ZmVyKGJ1ZmZlcik7CisgICAgICAgICAgICBhd2FpdCB3YWl0Rm9yKHNvdXJjZUJ1ZmZlciwgJ3Vw ZGF0ZWVuZCcpOworICAgICAgICB9IGNhdGNoIChlKSB7CisgICAgICAgICAgICByZXN1bHRFeGNl cHRpb24gPSBlOworICAgICAgICAgICAgc291cmNlQnVmZmVyLmFib3J0KCk7CisgICAgICAgIH0K KyAgICAgICAgcmV0dXJuIHJlc3VsdEV4Y2VwdGlvbjsKKyAgICB9CisKKyAgICBpZiAod2luZG93 LmludGVybmFscykKKyAgICAgICAgaW50ZXJuYWxzLmluaXRpYWxpemVNb2NrTWVkaWFTb3VyY2Uo KTsKKworICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCdsb2FkJywgYXN5bmMoKSA9PiB7Cisg ICAgICAgIGZpbmRNZWRpYUVsZW1lbnQoKTsKKyAgICAgICAgc291cmNlID0gbmV3IE1lZGlhU291 cmNlKCk7CisKKyAgICAgICAgY29uc3QgdmlkZW9Tb3VyY2UgPSBkb2N1bWVudC5jcmVhdGVFbGVt ZW50KCdzb3VyY2UnKTsKKyAgICAgICAgdmlkZW9Tb3VyY2UudHlwZSA9ICd2aWRlby9tb2NrOyBj b2RlY3M9bW9jayc7CisgICAgICAgIHZpZGVvU291cmNlLnNyYyA9IFVSTC5jcmVhdGVPYmplY3RV Ukwoc291cmNlKTsKKyAgICAgICAgdmlkZW8uYXBwZW5kQ2hpbGQodmlkZW9Tb3VyY2UpOworCisg ICAgICAgIGF3YWl0IHdhaXRGb3Ioc291cmNlLCAnc291cmNlb3BlbicpOworICAgICAgICBzb3Vy Y2VCdWZmZXIgPSBzb3VyY2UuYWRkU291cmNlQnVmZmVyKCJ2aWRlby9tb2NrOyBjb2RlY3M9bW9j ayIpOworICAgICAgICBpbml0U2VnbWVudCA9IG1ha2VBSW5pdCgzNTAsIFttYWtlQVRyYWNrKDEs ICdtb2NrJywgVFJBQ0tfS0lORC5WSURFTyldKTsKKyAgICAgICAgLy8gU2V0IGEgYnVmZmVyIHNp emUgdGhhdCBpcyBsZXNzIHRoYW4gdGhlIGluaXQgc2VnbWVudCBsZW5ndGguCisgICAgICAgIGlu dGVybmFscy5zZXR0aW5ncy5zZXRNYXhpbXVtU291cmNlQnVmZmVyU2l6ZSgzMCk7CisgICAgICAg IGV4Y2VwdGlvbiA9IGF3YWl0IGFwcGVuZEJ1ZmZlcihpbml0U2VnbWVudCk7CisgICAgICAgIHdh aXRGb3Ioc291cmNlQnVmZmVyLCAnZXJyb3InKTsKKyAgICAgICAgdGVzdEV4cGVjdGVkKCdleGNl cHRpb24nLCAnUXVvdGFFeGNlZWRlZEVycm9yOiBUaGUgcXVvdGEgaGFzIGJlZW4gZXhjZWVkZWQu JywgJz09Jyk7CisKKyAgICAgICAgZW5kVGVzdCgpOworICAgIH0pOworICAgIDwvc2NyaXB0Pgor PC9oZWFkPgorPGJvZHk+CisgICAgPHZpZGVvPjwvdmlkZW8+Cis8L2JvZHk+Cis8L2h0bWw+Cg==