226719 2021-06-07 02:14:15 -0700 [WTF][GStreamer] Fix clang TSA warnings in WTF::DataMutex 2021-06-07 04:46:10 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya aboya benjamin bugs-noreply calvaris cdumez cmarcelo ews-watchlist oldest_to_newest 1767374 0 aboya 2021-06-07 02:14:15 -0700 Fix the remaning clang thread safety warnings in WTF::DataMutex. The goal of this patch is to reduce the number of warnings in the GStreamer codebase. Whether DataMutex should be deprecated in favor of Locker with the clang TSA annotations is outside of the scope of this patch. 1767375 1 430731 aboya 2021-06-07 02:15:10 -0700 Created attachment 430731 Patch 1767408 2 ews-feeder 2021-06-07 04:46:06 -0700 Committed r278558 (238556@main): <https://commits.webkit.org/238556@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430731. 430731 2021-06-07 02:15:10 -0700 2021-06-07 04:46:08 -0700 Patch bug-226719-20210607111509.patch text/plain 3025 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGYyZGU3M2UyYThmNzljMzhiMmFjYzM1 MTc0MzExOTkzMDVjYmU4MTIuLjBmMWQxYzNiZTJkZTYxMTY2ZDMwZjJjN2MyODBlOTVjZjhjZDRh NjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMDYtMDcgIEFsaWNpYSBCb3lhIEdhcmPDrWEg IDxhYm95YUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXVEZdW0dTdHJlYW1lcl0gRml4IGNsYW5n IFRTQSB3YXJuaW5ncyBpbiBXVEY6OkRhdGFNdXRleAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2NzE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHRoZSByZW1hbmluZyBjbGFuZyB0aHJlYWQgc2Fm ZXR5IHdhcm5pbmdzIGluIFdURjo6RGF0YU11dGV4LgorCisgICAgICAgIFRoZSBnb2FsIG9mIHRo aXMgcGF0Y2ggaXMgdG8gcmVkdWNlIHRoZSBudW1iZXIgb2Ygd2FybmluZ3MgaW4gdGhlCisgICAg ICAgIEdTdHJlYW1lciBjb2RlYmFzZS4gV2hldGhlciBEYXRhTXV0ZXggc2hvdWxkIGJlIGRlcHJl Y2F0ZWQgaW4gZmF2b3Igb2YKKyAgICAgICAgTG9ja2VyIHdpdGggdGhlIGNsYW5nIFRTQSBhbm5v dGF0aW9ucyBpcyBvdXRzaWRlIG9mIHRoZSBzY29wZSBvZiB0aGlzCisgICAgICAgIHBhdGNoLgor CisgICAgICAgICogd3RmL0RhdGFNdXRleC5oOgorCiAyMDIxLTA2LTA3ICBBbGljaWEgQm95YSBH YXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBSZW1vdmUg c3B1cmlvdXMgYXNzZXJ0IGluIFdURjo6RGF0YU11dGV4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RG L3d0Zi9EYXRhTXV0ZXguaCBiL1NvdXJjZS9XVEYvd3RmL0RhdGFNdXRleC5oCmluZGV4IGRkMDU1 OWQ5ODY2OGVhMDBmZTM3N2RmMjY4YjU3M2FlNWZjMTU5NzEuLmM2ZDI4Y2ZlZjFiNGEwMjQxZDZm ZDY5YWQzYTgyNzhkYTU1OGM0MjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0RhdGFNdXRl eC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0RhdGFNdXRleC5oCkBAIC02OSwyMiArNjksMjQgQEAg cHVibGljOgogICAgICAgICBtX2lzTG9ja2VkID0gdHJ1ZTsKICAgICB9CiAKLSAgICB+RGF0YU11 dGV4TG9ja2VyKCkgV1RGX1JFTEVBU0VTX0xPQ0sobV9kYXRhTXV0ZXgubV9tdXRleCkKKyAgICB+ RGF0YU11dGV4TG9ja2VyKCkgV1RGX1JFTEVBU0VTX0xPQ0soKQogICAgIHsKLSAgICAgICAgaWYg KG1faXNMb2NrZWQpCisgICAgICAgIGlmIChtX2lzTG9ja2VkKSB7CisgICAgICAgICAgICBhc3Nl cnRJc0hlbGQobV9kYXRhTXV0ZXgubV9tdXRleCk7CiAgICAgICAgICAgICBtdXRleCgpLnVubG9j aygpOworICAgICAgICB9CiAgICAgfQogCiAgICAgVCogb3BlcmF0b3ItPigpCiAgICAgewotICAg ICAgICBEQVRBX01VVEVYX0NIRUNLKG11dGV4KCkuaXNIZWxkKCkpOworICAgICAgICBEQVRBX01V VEVYX0NIRUNLKG1faXNMb2NrZWQgJiYgbXV0ZXgoKS5pc0hlbGQoKSk7CiAgICAgICAgIGFzc2Vy dElzSGVsZChtX2RhdGFNdXRleC5tX211dGV4KTsKICAgICAgICAgcmV0dXJuICZtX2RhdGFNdXRl eC5tX2RhdGE7CiAgICAgfQogCiAgICAgVCYgb3BlcmF0b3IqKCkKICAgICB7Ci0gICAgICAgIERB VEFfTVVURVhfQ0hFQ0sobXV0ZXgoKS5pc0hlbGQoKSk7CisgICAgICAgIERBVEFfTVVURVhfQ0hF Q0sobV9pc0xvY2tlZCAmJiBtdXRleCgpLmlzSGVsZCgpKTsKICAgICAgICAgYXNzZXJ0SXNIZWxk KG1fZGF0YU11dGV4Lm1fbXV0ZXgpOwogICAgICAgICByZXR1cm4gbV9kYXRhTXV0ZXgubV9kYXRh OwogICAgIH0KQEAgLTk0LDYgKzk2LDkgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gbV9kYXRh TXV0ZXgubV9tdXRleDsKICAgICB9CiAKKyAgICAvLyBOb3RlOiBEYXRhTXV0ZXhMb2NrZXIgc2hv dWxkbid0IGJlIHVzZWQgYWZ0ZXIgdGhpcy4gRHVlIHRvIGxpbWl0YXRpb25zIG9mIGNsYW5nIHRo cmVhZCBzYWZldHkgYW5hbHlzaXMgdGhpcyBjYW4ndAorICAgIC8vIGN1cnJlbnRseSBiZSBzdGF0 aWNseSBjaGVja2VkIChhZGRpbmcgV1RGX1JFUVVJUkVTX0xPQ0soKSB0byBvcGVyYXRvci0+KCkg ZG9lc24ndCB3b3JrLikKKyAgICAvLyBSdW4tdGltZSBjaGVja3MgYXJlIHN0aWxsIHBlcmZvcm1l ZCBpZiBlbmFibGVkLgogICAgIHZvaWQgdW5sb2NrRWFybHkoKSBXVEZfUkVMRUFTRVNfTE9DSyht X2RhdGFNdXRleC5tX211dGV4KQogICAgIHsKICAgICAgICAgREFUQV9NVVRFWF9DSEVDSyhtdXRl eCgpLmlzSGVsZCgpKTsKQEAgLTEwNCw3ICsxMDksNyBAQCBwdWJsaWM6CiAgICAgLy8gVXNlZCB0 byBhdm9pZCBleGNlc3NpdmUgYnJhY2Ugc2NvcGluZyB3aGVuIG9ubHkgc21hbGwgcGFydHMgb2Yg dGhlIGNvZGUgbmVlZCB0byBiZSBydW4gdW5sb2NrZWQuCiAgICAgLy8gUGxlYXNlIGJlIG1pbmRm dWwgdGhhdCBhY2Nlc3NpbmcgdGhlIHdyYXBwZWQgZGF0YSBmcm9tIHRoZSBjYWxsYmFjayBpcyB1 bnNhZmUgYW5kIHdpbGwgZmFpbCBvbiBhc3NlcnRpb25zLgogICAgIC8vIEl0J3MgaGVscGZ1bCB0 byB1c2UgYSBtaW5pbWFsIGxhbWJkYSBjYXB0dXJlIHRvIGJlIGNvbnNjaW91cyBvZiB3aGF0IGRh dGEgeW91J3JlIGhhdmluZyBhY2Nlc3MgdG8gaW4gdGhlc2Ugc2VjdGlvbnMuCi0gICAgdm9pZCBy dW5VbmxvY2tlZChjb25zdCBGdW5jdGlvbjx2b2lkKCk+JiBjYWxsYmFjaykKKyAgICB2b2lkIHJ1 blVubG9ja2VkKGNvbnN0IEZ1bmN0aW9uPHZvaWQoKT4mIGNhbGxiYWNrKSBXVEZfSUdOT1JFU19U SFJFQURfU0FGRVRZX0FOQUxZU0lTCiAgICAgewogICAgICAgICBEQVRBX01VVEVYX0NIRUNLKG11 dGV4KCkuaXNIZWxkKCkpOwogICAgICAgICBhc3NlcnRJc0hlbGQobV9kYXRhTXV0ZXgubV9tdXRl eCk7Cg==