226714 2021-06-07 01:44:08 -0700 [GStreamer] Remove spurious assert in WTF::DataMutex 2021-06-16 18:52:26 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya aboya benjamin bugs-noreply calvaris cdumez cmarcelo ews-watchlist fujii mcatanzaro oldest_to_newest 1767358 0 aboya 2021-06-07 01:44:08 -0700 Remove DATA_MUTEX_CHECK(!mutex().isHeld()); from the DataMutexLocker constructor, introduced in r278248. Trying to lock a currently held mutex is not an error condition that should crash the process, it will just wait for its turn to lock it. 1767359 1 430725 aboya 2021-06-07 01:44:52 -0700 Created attachment 430725 Patch 1767398 2 calvaris 2021-06-07 04:27:25 -0700 lgtm 1767404 3 ews-feeder 2021-06-07 04:40:57 -0700 Committed r278555 (238553@main): <https://commits.webkit.org/238553@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430725. 1770504 4 fujii 2021-06-16 18:52:26 -0700 This change causes a test failure. Bug 227021 – [GTK] TestWTF:WTF_DataMutex.DoubleLockDeathTest is timing out 430725 2021-06-07 01:44:52 -0700 2021-06-07 05:01:02 -0700 Patch bug-226714-20210607104452.patch text/plain 1375 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGUwZDhmZjMwN2EyOWM5NTY0NjgwM2Qz OTdmOWI4NjBkMTlmYWMyOGYuLmYyZGU3M2UyYThmNzljMzhiMmFjYzM1MTc0MzExOTkzMDVjYmU4 MTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjEtMDYtMDcgIEFsaWNpYSBCb3lhIEdhcmPDrWEg IDxhYm95YUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHU3RyZWFtZXJdIFJlbW92ZSBzcHVyaW91 cyBhc3NlcnQgaW4gV1RGOjpEYXRhTXV0ZXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIyNjcxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFJlbW92ZSBEQVRBX01VVEVYX0NIRUNLKCFtdXRleCgpLmlzSGVs ZCgpKTsgZnJvbSB0aGUgRGF0YU11dGV4TG9ja2VyCisgICAgICAgIGNvbnN0cnVjdG9yLCBpbnRy b2R1Y2VkIGluIHIyNzgyNDguCisKKyAgICAgICAgVHJ5aW5nIHRvIGxvY2sgYSBjdXJyZW50bHkg aGVsZCBtdXRleCBpcyBub3QgYW4gZXJyb3IgY29uZGl0aW9uIHRoYXQKKyAgICAgICAgc2hvdWxk IGNyYXNoIHRoZSBwcm9jZXNzLCBpdCB3aWxsIGp1c3Qgd2FpdCBmb3IgaXRzIHR1cm4gdG8gbG9j ayBpdC4KKworICAgICAgICAqIHd0Zi9EYXRhTXV0ZXguaDoKKwogMjAyMS0wNi0wNiAgQ2hyaXMg RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFN0b3AgdXNpbmcgbGVnYWN5IEV2 ZW50TG9vcERlZmVycmFibGVUYXNrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9EYXRhTXV0 ZXguaCBiL1NvdXJjZS9XVEYvd3RmL0RhdGFNdXRleC5oCmluZGV4IDc3YTFlZDc5YjEwOTRjM2Iz ZmMwNGFiOTFiMzEzNDQzYTUzZDNjYmYuLmRkMDU1OWQ5ODY2OGVhMDBmZTM3N2RmMjY4YjU3M2Fl NWZjMTU5NzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0RhdGFNdXRleC5oCisrKyBiL1Nv dXJjZS9XVEYvd3RmL0RhdGFNdXRleC5oCkBAIC02NSw3ICs2NSw2IEBAIHB1YmxpYzoKICAgICBl eHBsaWNpdCBEYXRhTXV0ZXhMb2NrZXIoRGF0YU11dGV4PFQ+JiBkYXRhTXV0ZXgpIFdURl9BQ1FV SVJFU19MT0NLKG1fZGF0YU11dGV4Lm1fbXV0ZXgpCiAgICAgICAgIDogbV9kYXRhTXV0ZXgoZGF0 YU11dGV4KQogICAgIHsKLSAgICAgICAgREFUQV9NVVRFWF9DSEVDSyghbXV0ZXgoKS5pc0hlbGQo KSk7CiAgICAgICAgIG11dGV4KCkubG9jaygpOwogICAgICAgICBtX2lzTG9ja2VkID0gdHJ1ZTsK ICAgICB9Cg==