226687 2021-06-05 14:54:06 -0700 [WebXR] WebXR on Cocoa doesn't work with multisampled contexts 2021-10-21 15:38:34 -0700 1 1 1 Unclassified WebKit WebXR WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino thorton webkit-bug-importer oldest_to_newest 1767153 0 dino 2021-06-05 14:54:06 -0700 Antialiased WebGL contexts currently do not work on the Cocoa port. 1767154 1 webkit-bug-importer 2021-06-05 14:54:17 -0700 <rdar://problem/78910868> 1807379 2 442067 dino 2021-10-21 14:55:49 -0700 Created attachment 442067 Patch 1807407 3 dino 2021-10-21 15:38:34 -0700 Committed r284650 (243370@main): <https://commits.webkit.org/243370@main> 442067 2021-10-21 14:55:49 -0700 2021-10-21 14:59:20 -0700 Patch bug-226687-20211022085548.patch text/plain 5858 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjg0NTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTJkMjhiZjBhZDA2Zjc3 MjcyMWZjYzBjNmVhNmI5YmVkZjlhMjRlMy4uNTdkZThlNDExMTNkZjM3NDhjNDdlNDBiZjZhOGIw N2Q3Y2JmODczYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIxLTEwLTIxICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViWFJdIFdlYlhSIG9uIENv Y29hIGRvZXNuJ3Qgd29yayB3aXRoIG11bHRpc2FtcGxlZCBjb250ZXh0cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2Njg3CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS83ODkxMDg2OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBJZiB0aGUgV2ViWFIgc2Vzc2lvbiByZXF1ZXN0ZWQgYW4gYW50aS1hbGlh c2VkIGNvbnRleHQsIHdlJ2QKKyAgICAgICAgZW5kIHVwIHdpdGggYW4gaW5jb21wbGV0ZSBmcmFt ZWJ1ZmZlciBiZWNhdXNlIHdlIHdlcmUgbmV2ZXIKKyAgICAgICAgaW5pdGlhbGlzaW5nIHRoZSBt dWx0aXNhbXBsZSBidWZmZXJzLiBUaGlzIHdvdWxkIGFzc2VydCBvbgorICAgICAgICBkZWJ1ZyBi dWlsZHMgYW5kIHByb2R1Y2Ugbm8gb3V0cHV0IG9uIHJlbGVhc2UgYnVpbGRzLgorCisgICAgICAg IEZpeCB0aGlzIGJ5IGluaXRpYWxpc2luZyB0aGUgbXVsdGlzYW1wbGUgYnVmZmVycywgZW5zdXJp bmcKKyAgICAgICAgd2UncmUgdGFyZ2V0aW5nIHRoZW0gaW4gc3RhcnRGcmFtZSwgYW5kIGRvIHRo ZSByZXNvbHV0aW9uCisgICAgICAgIGluIGVuZEZyYW1lLgorCisgICAgICAgICogTW9kdWxlcy93 ZWJ4ci9XZWJYUk9wYXF1ZUZyYW1lYnVmZmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYlhS T3BhcXVlRnJhbWVidWZmZXI6OnN0YXJ0RnJhbWUpOgorICAgICAgICAoV2ViQ29yZTo6V2ViWFJP cGFxdWVGcmFtZWJ1ZmZlcjo6ZW5kRnJhbWUpOiBXaGlsZSBoZXJlLCB1c2UgTkVBUkVTVAorICAg ICAgICBzYW1wbGluZyBvbiB0aGUgbXVsdGlzYW1wbGUgcmVzb2x1dGlvbiwgdGhlIHdheSB3ZSBk byBpbiBXZWJHTC4KKwogMjAyMS0xMC0xOSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFw cGxlLmNvbT4KIAogICAgICAgICBSZWdyZXNzaW9uKHIyODQzMzYpOiBbIGlPUyAxNSBdIHN5c3Rl bS1wcmV2aWV3L2JhZGdlLmh0bWwgaXMgaW1hZ2UgZmFpbGluZwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy93ZWJ4ci9XZWJYUk9wYXF1ZUZyYW1lYnVmZmVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvd2VieHIvV2ViWFJPcGFxdWVGcmFtZWJ1ZmZlci5jcHAKaW5kZXgg NTBjNTMyYjc2ODU4ZTYwNjFjODcwMWUwZTYzNDVlNzQ4MGU5NTBhYi4uNWU3NjU4MGZjNzMwMjdl NWE3ZWE2MDNjZGY2NTczNGFlYmVlZDk3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy93ZWJ4ci9XZWJYUk9wYXF1ZUZyYW1lYnVmZmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL3dlYnhyL1dlYlhST3BhcXVlRnJhbWVidWZmZXIuY3BwCkBAIC0xMjUsNyArMTI1 LDYgQEAgdm9pZCBXZWJYUk9wYXF1ZUZyYW1lYnVmZmVyOjpzdGFydEZyYW1lKGNvbnN0IFBsYXRm b3JtWFI6OkRldmljZTo6RnJhbWVEYXRhOjpMYXkKICAgICBhdXRvIGdDR0wgPSBzdGF0aWNfY2Fz dDxHcmFwaGljc0NvbnRleHRHTE9wZW5HTCo+KG1fY29udGV4dC5ncmFwaGljc0NvbnRleHRHTCgp KTsKICAgICBHQ0dMZW51bSB0ZXh0dXJlVGFyZ2V0ID0gZ0NHTC0+ZHJhd2luZ0J1ZmZlclRleHR1 cmVUYXJnZXQoKTsKIAotCiAgICAgaWYgKCFtX29wYXF1ZVRleHR1cmUpCiAgICAgICAgIG1fb3Bh cXVlVGV4dHVyZSA9IGdDR0wtPmNyZWF0ZVRleHR1cmUoKTsKIApAQCAtMTU3LDE0ICsxNTYsMTUg QEAgdm9pZCBXZWJYUk9wYXF1ZUZyYW1lYnVmZmVyOjpzdGFydEZyYW1lKGNvbnN0IFBsYXRmb3Jt WFI6OkRldmljZTo6RnJhbWVEYXRhOjpMYXkKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAg IC8vIE5vdyBzZXQgdXAgdGhlIGZyYW1lYnVmZmVyIHRvIHVzZSB0aGUgdGV4dHVyZSB0aGF0IHBv aW50cyB0byB0aGUgSU9TdXJmYWNlLiBUaGUgZGVwdGggYW5kCi0gICAgLy8gc3RlbmNpbCBidWZm ZXJzIHdlcmUgYXR0YWNoZWQgYnkgc3RhcnRGcmFtZS4KLSAgICBnbC5mcmFtZWJ1ZmZlclRleHR1 cmUyRChHTDo6RlJBTUVCVUZGRVIsIEdMOjpDT0xPUl9BVFRBQ0hNRU5UMCwgR0w6OlRFWFRVUkVf MkQsIG1fb3BhcXVlVGV4dHVyZSwgMCk7Ci0KLSAgICAvLyBGSVhNRTogVGhpcyBpcyBhc3N1bWlu ZyBtdWx0aXNhbXBsaW5nIGlzIHR1cm5lZCBvZmYgYW5kIHdlJ3JlIHJlbmRlcmluZyBkaXJlY3Rs eSBpbnRvIHRoZSBmcmFtZWJ1ZmZlci4KKyAgICAvLyBJZiB3ZSdyZSBub3QgbXVsdGlzYW1wbGlu Zywgc2V0IHVwIHRoZSBmcmFtZWJ1ZmZlciB0byB1c2UgdGhlIHRleHR1cmUgdGhhdCBwb2ludHMg dG8gdGhlIElPU3VyZmFjZS4gVGhlIGRlcHRoIGFuZAorICAgIC8vIHN0ZW5jaWwgYnVmZmVycyB3 ZXJlIGF0dGFjaGVkIGJ5IHNldHVwRnJhbWVidWZmZXIuIElmIHdlIGFyZSBtdWx0aXNhbXBsaW5n LCB0aGUgZnJhbWVidWZmZXIgd2FzIGluaXRpYWxpemVkIGluIHNldHVwRnJhbWVidWZmZXIsCisg ICAgLy8gYW5kIHdlJ2xsIHJlc29sdmUgaW50byB0aGUgbV9vcGFxdWVUZXh0dXJlIGluIGVuZEZy YW1lLgorICAgIGlmICghbV9tdWx0aXNhbXBsZUNvbG9yQnVmZmVyKQorICAgICAgICBnbC5mcmFt ZWJ1ZmZlclRleHR1cmUyRChHTDo6RlJBTUVCVUZGRVIsIEdMOjpDT0xPUl9BVFRBQ0hNRU5UMCwg R0w6OlRFWFRVUkVfMkQsIG1fb3BhcXVlVGV4dHVyZSwgMCk7CiAKICAgICAvLyBBdCB0aGlzIHBv aW50IHRoZSBmcmFtZWJ1ZmZlciBzaG91bGQgYmUgImNvbXBsZXRlIi4KICAgICBBU1NFUlQoZ2wu Y2hlY2tGcmFtZWJ1ZmZlclN0YXR1cyhHTDo6RlJBTUVCVUZGRVIpID09IEdMOjpGUkFNRUJVRkZF Ul9DT01QTEVURSk7CisKICNlbHNlCiAgICAgbV9vcGFxdWVUZXh0dXJlID0gZGF0YS5vcGFxdWVU ZXh0dXJlOwogCkBAIC0xOTAsMjggKzE5MCw2IEBAIHZvaWQgV2ViWFJPcGFxdWVGcmFtZWJ1ZmZl cjo6ZW5kRnJhbWUoKQogCiAgICAgYXV0byYgZ2wgPSAqbV9jb250ZXh0LmdyYXBoaWNzQ29udGV4 dEdMKCk7CiAKLSNpZiBVU0UoSU9TVVJGQUNFX0ZPUl9YUl9MQVlFUl9EQVRBKQotICAgIC8vIEZJ WE1FOiBXZSBoYXZlIHRvIGNhbGwgZmluaXNoIHJhdGhlciB0aGFuIGZsdXNoIGJlY2F1c2Ugd2Ug b25seSB3YW50IHRvIGRpc2Nvbm5lY3QKLSAgICAvLyB0aGUgSU9TdXJmYWNlIGFuZCBzaWduYWwg dGhlIERldmljZVByb3h5IHdoZW4gd2Uga25vdyB0aGUgY29udGVudCBoYXMgYmVlbiByZW5kZXJl ZC4KLSAgICAvLyBJdCBtaWdodCBiZSBwb3NzaWJsZSB0byBzZXQgdGhpcyB1cCBzbyB0aGUgY29t cGxldGlvbiBvZiB0aGUgcmVuZGVyaW5nIHRyaWdnZXJzCi0gICAgLy8gdGhlIGVuZEZyYW1lIGNh bGwuCi0gICAgZ2wuZmluaXNoKCk7Ci0KLSAgICBpZiAobV9pb1N1cmZhY2VUZXh0dXJlSGFuZGxl KSB7Ci0gICAgICAgIGF1dG8gZ0NHTCA9IHN0YXRpY19jYXN0PEdyYXBoaWNzQ29udGV4dEdMT3Bl bkdMKj4oJmdsKTsKLSAgICAgICAgaWYgKG1faW9TdXJmYWNlVGV4dHVyZUhhbmRsZUlzU2hhcmVk KSB7Ci0jaWYgIVBMQVRGT1JNKElPU19GQU1JTFlfU0lNVUxBVE9SKQotICAgICAgICAgICAgZ0NH TC0+ZGV0YWNoSU9TdXJmYWNlRnJvbVNoYXJlZFRleHR1cmUobV9pb1N1cmZhY2VUZXh0dXJlSGFu ZGxlKTsKLSNlbHNlCi0gICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSNlbmRpZgot ICAgICAgICB9IGVsc2UKLSAgICAgICAgICAgIGdDR0wtPmRlc3Ryb3lQYnVmZmVyQW5kRGV0YWNo SU9TdXJmYWNlKG1faW9TdXJmYWNlVGV4dHVyZUhhbmRsZSk7Ci0gICAgICAgIG1faW9TdXJmYWNl VGV4dHVyZUhhbmRsZSA9IG51bGxwdHI7Ci0gICAgICAgIG1faW9TdXJmYWNlVGV4dHVyZUhhbmRs ZUlzU2hhcmVkID0gZmFsc2U7Ci0gICAgfQotI2Vsc2UKLQogICAgIGlmIChtX211bHRpc2FtcGxl Q29sb3JCdWZmZXIpIHsKICNpZiAhVVNFKEFOR0xFKQogICAgICAgICAvLyBGSVhNRTogVGhlc2Ug bWF5IGJlIG5lZWRlZCB3aGVuIHVzaW5nIEFOR0xFLCBidXQgaXQgZGlkbid0IGNvbXBpbGUgaW4g dGhlIGluaXRpYWwgaW1wbGVtZW50YXRpb24uCkBAIC0yMzQsMTIgKzIxMiwzMCBAQCB2b2lkIFdl YlhST3BhcXVlRnJhbWVidWZmZXI6OmVuZEZyYW1lKCkKICAgICAgICAgZ2wuYmluZEZyYW1lYnVm ZmVyKEdMOjpEUkFXX0ZSQU1FQlVGRkVSLCBtX3Jlc29sdmVkRkJPKTsKICAgICAgICAgZ2wuZnJh bWVidWZmZXJUZXh0dXJlMkQoR0w6OkZSQU1FQlVGRkVSLCBHTDo6Q09MT1JfQVRUQUNITUVOVDAs IEdMOjpURVhUVVJFXzJELCBtX29wYXF1ZVRleHR1cmUsIDApOwogCi0gICAgICAgIC8vIFJlc29s dmUgbXVsdGlzYW1wbGUgZnJhbWVidWZmZXIKICAgICAgICAgZ2wuYmluZEZyYW1lYnVmZmVyKEdM OjpSRUFEX0ZSQU1FQlVGRkVSLCBtX2ZyYW1lYnVmZmVyLT5vYmplY3QoKSk7Ci0gICAgICAgIGds LmJsaXRGcmFtZWJ1ZmZlcigwLCAwLCBtX3dpZHRoLCBtX2hlaWdodCwgMCwgMCwgbV93aWR0aCwg bV9oZWlnaHQsIEdMOjpDT0xPUl9CVUZGRVJfQklULCBHTDo6TElORUFSKTsKKyAgICAgICAgZ2wu YmxpdEZyYW1lYnVmZmVyKDAsIDAsIG1fd2lkdGgsIG1faGVpZ2h0LCAwLCAwLCBtX3dpZHRoLCBt X2hlaWdodCwgR0w6OkNPTE9SX0JVRkZFUl9CSVQsIEdMOjpORUFSRVNUKTsKICAgICB9CiAKLSAg ICBnbC5mbHVzaCgpOworICAgIC8vIEZJWE1FOiBXZSBoYXZlIHRvIGNhbGwgZmluaXNoIHJhdGhl ciB0aGFuIGZsdXNoIGJlY2F1c2Ugd2Ugb25seSB3YW50IHRvIGRpc2Nvbm5lY3QKKyAgICAvLyB0 aGUgSU9TdXJmYWNlIGFuZCBzaWduYWwgdGhlIERldmljZVByb3h5IHdoZW4gd2Uga25vdyB0aGUg Y29udGVudCBoYXMgYmVlbiByZW5kZXJlZC4KKyAgICAvLyBJdCBtaWdodCBiZSBwb3NzaWJsZSB0 byBzZXQgdGhpcyB1cCBzbyB0aGUgY29tcGxldGlvbiBvZiB0aGUgcmVuZGVyaW5nIHRyaWdnZXJz CisgICAgLy8gdGhlIGVuZEZyYW1lIGNhbGwuCisgICAgZ2wuZmluaXNoKCk7CisKKyNpZiBVU0Uo SU9TVVJGQUNFX0ZPUl9YUl9MQVlFUl9EQVRBKQorICAgIGlmIChtX2lvU3VyZmFjZVRleHR1cmVI YW5kbGUpIHsKKyAgICAgICAgYXV0byBnQ0dMID0gc3RhdGljX2Nhc3Q8R3JhcGhpY3NDb250ZXh0 R0xPcGVuR0wqPigmZ2wpOworICAgICAgICBpZiAobV9pb1N1cmZhY2VUZXh0dXJlSGFuZGxlSXNT aGFyZWQpIHsKKyNpZiAhUExBVEZPUk0oSU9TX0ZBTUlMWV9TSU1VTEFUT1IpCisgICAgICAgICAg ICBnQ0dMLT5kZXRhY2hJT1N1cmZhY2VGcm9tU2hhcmVkVGV4dHVyZShtX2lvU3VyZmFjZVRleHR1 cmVIYW5kbGUpOworI2Vsc2UKKyAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworI2Vu ZGlmCisgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgZ0NHTC0+ZGVzdHJveVBidWZmZXJBbmRE ZXRhY2hJT1N1cmZhY2UobV9pb1N1cmZhY2VUZXh0dXJlSGFuZGxlKTsKKyAgICAgICAgbV9pb1N1 cmZhY2VUZXh0dXJlSGFuZGxlID0gbnVsbHB0cjsKKyAgICAgICAgbV9pb1N1cmZhY2VUZXh0dXJl SGFuZGxlSXNTaGFyZWQgPSBmYWxzZTsKKyAgICB9CiAjZW5kaWYKIH0KIAo=