226684 2021-06-05 08:28:02 -0700 Unexport llvm coverage symbols to fix build 2021-07-18 13:04:53 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 226562 228063 1 ddkilzer ddkilzer achristensen darin webkit-bug-importer oldest_to_newest 1767134 0 ddkilzer 2021-06-05 08:28:02 -0700 Unexport llvm coverage symbols to fix build Even after the fix in r278444 for Bug 226562, some internal projects still failed to build during the GenerateTAPI build phase: error: headers don't have symbol '(weak-def) ___llvm_profile_filename' error: headers don't have symbol '(weak-def) ___llvm_profile_raw_version' error: headers don't have symbol '(weak-def) _lprofDirMode' So instead of just ignoring these weak external symbols in check-for-weak-vtables-and-externals, we need to unexport them. 1767135 1 webkit-bug-importer 2021-06-05 08:28:26 -0700 <rdar://problem/78906691> 1767136 2 430650 ddkilzer 2021-06-05 08:33:16 -0700 Created attachment 430650 Patch v1 1767213 3 ews-feeder 2021-06-06 07:47:41 -0700 Committed r278536 (238534@main): <https://commits.webkit.org/238534@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430650. 1770654 4 ddkilzer 2021-06-17 08:55:08 -0700 (In reply to EWS from comment #3) > Committed r278536 (238534@main): <https://commits.webkit.org/238534@main> Follow-up fix for wrong comment character in Tools/coverage/coverage.xcconfig file: Committed r278536: <https://trac.webkit.org/r278536> 1770655 5 ddkilzer 2021-06-17 08:56:06 -0700 (In reply to David Kilzer (:ddkilzer) from comment #4) > (In reply to EWS from comment #3) > > Committed r278536 (238534@main): <https://commits.webkit.org/238534@main> > > Follow-up fix for wrong comment character in > Tools/coverage/coverage.xcconfig file: > > Committed r278536: <https://trac.webkit.org/r278536> Committed r278987: <https://trac.webkit.org/r278987> (Copied and pasted the wrong commit revision!) 430650 2021-06-05 08:33:16 -0700 2021-06-06 07:47:42 -0700 Patch v1 bug-226684-20210605083316.patch text/plain 2839 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NDYxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODAzYjMzZjhkYWQ4MDIwNWIwMDYxNzI3NWQxNjQxYTNk M2NmMDc3Yi4uZmY5OGZhYzJlYWE0MDMyYzFkYzc2NTk4ODkzMzhhMTA3ZTg5MTdmOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDIxLTA2LTA1ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgVW5leHBvcnQgbGx2bSBjb3ZlcmFnZSBzeW1ib2xzIHRvIGZpeCBidWlsZAorICAgICAg ICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMjI2Njg0PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0v Nzg5MDY2OTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBTY3JpcHRzL2NoZWNrLWZvci13ZWFrLXZ0YWJsZXMtYW5kLWV4dGVybmFsczoKKyAgICAg ICAgLSBSZXZlcnQgY2hhbmdlIGZyb20gcjI3ODQ0NC4gIFRoYXQgZml4ZXMgZXJyb3JzIHdoZW4K KyAgICAgICAgICB0aGlzIHNjcmlwdCBpcyBydW4sIGJ1dCB0aGUgR2VuZXJhdGUgVEFQSSBidWls ZCBwaGFzZQorICAgICAgICAgIGZvciBzb21lIHByb2plY3RzIHN0aWxsIGZhaWxzIGR1ZSB0byB0 aGUgbmV3IHdlYWsKKyAgICAgICAgICBleHRlcm5hbCBzeW1ib2xzLgorICAgICAgICAqIGNvdmVy YWdlL2NvdmVyYWdlLnhjY29uZmlnOgorICAgICAgICAoVU5FWFBPUlRFRF9TWU1CT0xfTERGTEFH U19GT1JfQ09WRVJBR0UpOiBBZGQuCisgICAgICAgIC0gTGlua2VyIGZsYWdzIHRvIHVuZXhwb3J0 IGxsdm0gc3ltYm9scyBhZGRlZCBieSB0aGUKKyAgICAgICAgICBjb21waWxlciBmb3IgY292ZXJh Z2UuCisgICAgICAgIChPVEhFUl9MREZMQUdTKToKKyAgICAgICAgLSBBZGQgJChVTkVYUE9SVEVE X1NZTUJPTF9MREZMQUdTX0ZPUl9DT1ZFUkFHRSkgdG8gbGlzdAorICAgICAgICAgIG9mIHN3aXRj aGVzIHRvIHVuZXhwb3J0IHRoZSBzeW1ib2xzIGR1cmluZyBsaW5raW5nLgorCiAyMDIxLTA2LTA0 ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25Ad2Via2l0Lm9yZz4KIAogICAgICAgICBUaGUg Q01ha2UgY2FjaGUgaXMgcmVtb3ZlZCB3aGVuIHNwZWNpZnlpbmcgYSBidWlsZCB0YXJnZXQKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvY2hlY2stZm9yLXdlYWstdnRhYmxlcy1hbmQtZXh0ZXJu YWxzIGIvVG9vbHMvU2NyaXB0cy9jaGVjay1mb3Itd2Vhay12dGFibGVzLWFuZC1leHRlcm5hbHMK aW5kZXggNDhkNjVmMTAzZGJkODMwMWQxOWVkNWI1YTI0YmUxZTRmMTA2NmEwYy4uOGJjZGVlMjg3 ODJlOWZmMmQ2Njk3ODU2YWNhNjAxNjA0ZjY2ODU5OCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0 cy9jaGVjay1mb3Itd2Vhay12dGFibGVzLWFuZC1leHRlcm5hbHMKKysrIGIvVG9vbHMvU2NyaXB0 cy9jaGVjay1mb3Itd2Vhay12dGFibGVzLWFuZC1leHRlcm5hbHMKQEAgLTY4LDkgKzY4LDYgQEAg aWYgKCFkZWZpbmVkICRleGVjdXRhYmxlUGF0aEFnZSB8fCAhZGVmaW5lZCAkYnVpbGRUaW1lc3Rh bXBBZ2UgfHwgJGV4ZWN1dGFibGVQYXQKICAgICAgICAgICAgICMgQVNhbiBjb21waWxlci1ydCBj YWxscyBpbnRvIF9fYXNhbl9tYXBwaW5nX29mZnNldCBhbmQgX19hc2FuX21hcHBpbmdfc2NhbGUK ICAgICAgICAgICAgIG5leHQgaWYgL1xiX19fYXNhbi87CiAKLSAgICAgICAgICAgICMgSWdub3Jl IHdlYWsgc3ltYm9scyBwcmVzZW50IHdoZW4gY29tcGlsaW5nIHdpdGggY292ZXJhZ2UgZW5hYmxl ZC4KLSAgICAgICAgICAgIG5leHQgaWYgL1xiKF9fX2xsdm1fcHJvZmlsZV9maWxlbmFtZXxfX19s bHZtX3Byb2ZpbGVfcmF3X3ZlcnNpb258X2xwcm9mRGlyTW9kZSkvICYmIGNvdmVyYWdlSXNFbmFi bGVkKCk7Ci0KICAgICAgICAgICAgIGlmICgvd2VhayBleHRlcm5hbCB2dGFibGUgZm9yICguKikk LykgewogICAgICAgICAgICAgICAgIHB1c2ggQHdlYWtWVGFibGVDbGFzc2VzLCAkMTsKICAgICAg ICAgICAgIH0gZWxzaWYgKC93ZWFrIGV4dGVybmFsICguKikkLykgewpkaWZmIC0tZ2l0IGEvVG9v bHMvY292ZXJhZ2UvY292ZXJhZ2UueGNjb25maWcgYi9Ub29scy9jb3ZlcmFnZS9jb3ZlcmFnZS54 Y2NvbmZpZwppbmRleCAwZWYyMmMxN2Y3MmY2MTg2NGY5YzJmMzg5ZWRiNDE4MGFiODFjN2E3Li5k NTg4YzRiOTkzYjA1MDgyNzc3NTVhYTA2YzQ3MTUwODE3ZjAyMjlkIDEwMDY0NAotLS0gYS9Ub29s cy9jb3ZlcmFnZS9jb3ZlcmFnZS54Y2NvbmZpZworKysgYi9Ub29scy9jb3ZlcmFnZS9jb3ZlcmFn ZS54Y2NvbmZpZwpAQCAtMSwyICsxLDUgQEAKKyMgVW5leHBvcnQgd2VhayBleHRlcm5hbCBzeW1i b2xzIGZyb20gbGx2bSBjb3ZlcmFnZS4KK1VORVhQT1JURURfU1lNQk9MX0xERkxBR1NfRk9SX0NP VkVSQUdFID0gLVdsLC11bmV4cG9ydGVkX3N5bWJvbCAtV2wsX19fbGx2bV9wcm9maWxlX2ZpbGVu YW1lIC1XbCwtdW5leHBvcnRlZF9zeW1ib2wgLVdsLF9fX2xsdm1fcHJvZmlsZV9yYXdfdmVyc2lv biAtV2wsLXVuZXhwb3J0ZWRfc3ltYm9sIC1XbCxfbHByb2ZEaXJNb2RlOworCiBPVEhFUl9DRkxB R1MgPSAkKGluaGVyaXRlZCkgLWZwcm9maWxlLWluc3RyLWdlbmVyYXRlIC1mY292ZXJhZ2UtbWFw cGluZzsKLU9USEVSX0xERkxBR1MgPSAkKGluaGVyaXRlZCkgLWZwcm9maWxlLWluc3RyLWdlbmVy YXRlOworT1RIRVJfTERGTEFHUyA9ICQoaW5oZXJpdGVkKSAtZnByb2ZpbGUtaW5zdHItZ2VuZXJh dGUgJChVTkVYUE9SVEVEX1NZTUJPTF9MREZMQUdTX0ZPUl9DT1ZFUkFHRSk7Cg==