226680 2021-06-05 05:02:05 -0700 [GTK] Kinetic scrolling interferes with gestures 2021-07-05 14:15:37 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alicem webkit-unassigned berto bugs-noreply carlosg cgarcia ews-watchlist gustavo mcatanzaro oldest_to_newest 1767125 0 alicem 2021-06-05 05:02:05 -0700 Haven't bisected, but probably a fallout from https://bugs.webkit.org/show_bug.cgi?id=212324 1774837 1 432895 alicem 2021-07-05 12:39:09 -0700 Created attachment 432895 Patch Patch. I'm not sure about the change in PageClientImpl.cpp, how important is it to have correct x/y for these? I"m also not sure where we get them from for scroll normally, as scroll events don't have coordinates on their own... 1774838 2 ews-watchlist 2021-07-05 12:39:52 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1774848 3 ews-feeder 2021-07-05 14:15:35 -0700 Committed r279571 (239402@main): <https://commits.webkit.org/239402@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432895. 432895 2021-07-05 12:39:09 -0700 2021-07-05 14:15:36 -0700 Patch 0001-Patch.patch text/plain 4648 alicem RnJvbSA5YmYyN2NmZDA3ZWRlN2MwZTU4ZGU0NWU2ZjE4YjRjODVmYmNiMTdlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4YW5kZXIgTWlraGF5bGVua28gPGFsZXhtQGdub21lLm9y Zz4KRGF0ZTogVHVlLCA2IEp1bCAyMDIxIDAwOjMzOjU1ICswNTAwClN1YmplY3Q6IFtQQVRDSF0g UGF0Y2gKCi0tLQogU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAg ICB8IDE4ICsrKysrKysrKysrKysrKysrKwogLi4uL1VJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGll bnRJbXBsLmNwcCAgICAgICB8ICAyICsrCiAuLi4vVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2Vi Vmlld0Jhc2UuY3BwICAgIHwgMTYgKysrKysrKysrKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCAz NiBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViS2l0L0NoYW5nZUxvZwppbmRleCA4MWY2MjBmZmFmNDMuLjkyM2M1MjM1Yzk3NSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9D aGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAyMS0wNy0wNSAgQWxleGFuZGVyIE1pa2hheWxl bmtvICA8YWxleG1AZ25vbWUub3JnPgorCisgICAgICAgIFtHVEtdIEtpbmV0aWMgc2Nyb2xsaW5n IGludGVyZmVyZXMgd2l0aCBnZXN0dXJlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjI2NjgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgU2ltdWxhdGUgc2Nyb2xsIGV2ZW50cyB0aGF0IHdvdWxkIHN0b3Ag c2Nyb2xsaW5nIHdoZW4gd2UncmUgc3RhcnRpbmcgYW55IHRvdWNoCisgICAgICAgIGdlc3R1cmUu IFNpbmNlIHdlIGRvbid0IGhhdmUgYSB3YXkgdG8gZG8gdGhhdCBvbiB0b3VjaHBhZCB5ZXQsIGp1 c3Qgc3RvcCBpdCB3aGVuCisgICAgICAgIHN0YXJ0aW5nIGEgem9vbSBvciBhIG5hdmlnYXRpb24g c3dpcGUgZ2VzdHVyZSBpbnN0ZWFkLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvUGFn ZUNsaWVudEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpQYWdlQ2xpZW50SW1wbDo6bmF2aWdh dGlvbkdlc3R1cmVEaWRCZWdpbik6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0 V2ViVmlld0Jhc2UuY3BwOgorICAgICAgICAod2Via2l0V2ViVmlld0Jhc2Vab29tQmVnaW4pOgor ICAgICAgICAod2Via2l0V2ViVmlld0Jhc2VUb3VjaERyYWdCZWdpbik6CisgICAgICAgICh3ZWJr aXRXZWJWaWV3QmFzZUNvbnN0cnVjdGVkKToKKwogMjAyMS0wNy0wNSAgQWxleGFuZGVyIE1pa2hh eWxlbmtvICA8YWxleG1AZ25vbWUub3JnPgogCiAgICAgICAgIFtHVEtdIE5hdmlnYXRpb24gc3dp cGUgZ2VzdHVyZSBjYW4gYmUgdHJpZ2dlcmVkIHdpdGggbW91c2UKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuY3BwIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5jcHAKaW5kZXggM2I1NjJiZDUz MjhkLi43ZGM3N2VlNWUwYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQ SS9ndGsvUGFnZUNsaWVudEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQ SS9ndGsvUGFnZUNsaWVudEltcGwuY3BwCkBAIC0zOSw2ICszOSw3IEBACiAjaW5jbHVkZSAiV2Vi RXZlbnRGYWN0b3J5LmgiCiAjaW5jbHVkZSAiV2ViS2l0Q29sb3JDaG9vc2VyLmgiCiAjaW5jbHVk ZSAiV2ViS2l0UG9wdXBNZW51LmgiCisjaW5jbHVkZSAiV2ViS2l0V2ViVmlld0Jhc2VJbnRlcm5h bC5oIgogI2luY2x1ZGUgIldlYktpdFdlYlZpZXdCYXNlUHJpdmF0ZS5oIgogI2luY2x1ZGUgIldl YktpdFdlYlZpZXdQcml2YXRlLmgiCiAjaW5jbHVkZSAiV2ViUGFnZVByb3h5LmgiCkBAIC00NTAs NiArNDUxLDcgQEAgdm9pZCBQYWdlQ2xpZW50SW1wbDo6ZGlkRmluaXNoTG9hZGluZ0RhdGFGb3JD dXN0b21Db250ZW50UHJvdmlkZXIoY29uc3QgU3RyaW5nJiwKIAogdm9pZCBQYWdlQ2xpZW50SW1w bDo6bmF2aWdhdGlvbkdlc3R1cmVEaWRCZWdpbigpCiB7CisgICAgd2Via2l0V2ViVmlld0Jhc2VT eW50aGVzaXplV2hlZWxFdmVudChXRUJLSVRfV0VCX1ZJRVdfQkFTRShtX3ZpZXdXaWRnZXQpLCAw LCAwLCAwLCAwLCBXaGVlbEV2ZW50UGhhc2U6OkJlZ2FuLCBXaGVlbEV2ZW50UGhhc2U6Ok5vUGhh c2UpOwogfQogCiB2b2lkIFBhZ2VDbGllbnRJbXBsOjpuYXZpZ2F0aW9uR2VzdHVyZVdpbGxFbmQo Ym9vbCwgV2ViQmFja0ZvcndhcmRMaXN0SXRlbSYpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcCBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCmluZGV4IDE3MmQzZDNmOTgx NC4uNWIwNzdkOTQ0MDc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv Z3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcApAQCAtMTg1OCw2ICsxODU4LDE5IEBAIHN0YXRp YyBnYm9vbGVhbiB3ZWJraXRXZWJWaWV3QmFzZUZvY3VzKEd0a1dpZGdldCogd2lkZ2V0LCBHdGtE aXJlY3Rpb25UeXBlIGRpcmVjCiAgICAgcmV0dXJuIEdUS19XSURHRVRfQ0xBU1Mod2Via2l0X3dl Yl92aWV3X2Jhc2VfcGFyZW50X2NsYXNzKS0+Zm9jdXMod2lkZ2V0LCBkaXJlY3Rpb24pOwogfQog CisKK3N0YXRpYyB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlWm9vbUJlZ2luKFdlYktpdFdlYlZpZXdC YXNlKiB3ZWJWaWV3QmFzZSwgR2RrRXZlbnRTZXF1ZW5jZSogc2VxdWVuY2UsIEd0a0dlc3R1cmUq IGdlc3R1cmUpCit7CisgICAgV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlKiBwcml2ID0gd2ViVmll d0Jhc2UtPnByaXY7CisgICAgaWYgKHByaXYtPnBhZ2VHcmFiYmVkVG91Y2gpCisgICAgICAgIHJl dHVybjsKKworICAgIGRvdWJsZSB4LCB5OworICAgIGd0a19nZXN0dXJlX2dldF9ib3VuZGluZ19i b3hfY2VudGVyKGdlc3R1cmUsICZ4LCAmeSk7CisKKyAgICB3ZWJraXRXZWJWaWV3QmFzZVN5bnRo ZXNpemVXaGVlbEV2ZW50KHdlYlZpZXdCYXNlLCAwLCAwLCB4LCB5LCBXaGVlbEV2ZW50UGhhc2U6 OkJlZ2FuLCBXaGVlbEV2ZW50UGhhc2U6Ok5vUGhhc2UpOworfQorCiBzdGF0aWMgdm9pZCB3ZWJr aXRXZWJWaWV3QmFzZVpvb21DaGFuZ2VkKFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJWaWV3QmFzZSwg Z2RvdWJsZSBzY2FsZSwgR3RrR2VzdHVyZSogZ2VzdHVyZSkKIHsKICAgICBXZWJLaXRXZWJWaWV3 QmFzZVByaXZhdGUqIHByaXYgPSB3ZWJWaWV3QmFzZS0+cHJpdjsKQEAgLTE5MzEsNiArMTk0NCw4 IEBAIHN0YXRpYyB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlVG91Y2hEcmFnQmVnaW4oV2ViS2l0V2Vi Vmlld0Jhc2UqIHdlYlZpZXdCYXNlLCBnZG91CiAgICAgV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRl KiBwcml2ID0gd2ViVmlld0Jhc2UtPnByaXY7CiAgICAgcHJpdi0+ZHJhZ09mZnNldC5zZXQoMCwg MCk7CiAgICAgcHJpdi0+aXNCZWluZ0RyYWdnZWQgPSBmYWxzZTsKKworICAgIHdlYmtpdFdlYlZp ZXdCYXNlU3ludGhlc2l6ZVdoZWVsRXZlbnQod2ViVmlld0Jhc2UsIDAsIDAsIHN0YXJ0WCwgc3Rh cnRZLCBXaGVlbEV2ZW50UGhhc2U6OkJlZ2FuLCBXaGVlbEV2ZW50UGhhc2U6Ok5vUGhhc2UpOwog fQogCiBzdGF0aWMgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZVRvdWNoRHJhZ1VwZGF0ZShXZWJLaXRX ZWJWaWV3QmFzZSogd2ViVmlld0Jhc2UsIGRvdWJsZSBvZmZzZXRYLCBkb3VibGUgb2Zmc2V0WSwg R3RrR2VzdHVyZSogZ2VzdHVyZSkKQEAgLTIwNzIsNiArMjA4Nyw3IEBAIHN0YXRpYyB2b2lkIHdl YmtpdFdlYlZpZXdCYXNlQ29uc3RydWN0ZWQoR09iamVjdCogb2JqZWN0KQogICAgIHByaXYtPnRv dWNoR2VzdHVyZUdyb3VwID0gZ3RrX2dlc3R1cmVfem9vbV9uZXcodmlld1dpZGdldCk7CiAgICAg Z19vYmplY3Rfc2V0X2RhdGFfZnVsbChHX09CSkVDVCh2aWV3V2lkZ2V0KSwgIndrLXZpZXctem9v bS1nZXN0dXJlIiwgcHJpdi0+dG91Y2hHZXN0dXJlR3JvdXAsIGdfb2JqZWN0X3VucmVmKTsKICNl bmRpZgorICAgIGdfc2lnbmFsX2Nvbm5lY3Rfb2JqZWN0KHByaXYtPnRvdWNoR2VzdHVyZUdyb3Vw LCAiYmVnaW4iLCBHX0NBTExCQUNLKHdlYmtpdFdlYlZpZXdCYXNlWm9vbUJlZ2luKSwgdmlld1dp ZGdldCwgR19DT05ORUNUX1NXQVBQRUQpOwogICAgIGdfc2lnbmFsX2Nvbm5lY3Rfb2JqZWN0KHBy aXYtPnRvdWNoR2VzdHVyZUdyb3VwLCAic2NhbGUtY2hhbmdlZCIsIEdfQ0FMTEJBQ0sod2Via2l0 V2ViVmlld0Jhc2Vab29tQ2hhbmdlZCksIHZpZXdXaWRnZXQsIEdfQ09OTkVDVF9TV0FQUEVEKTsK ICAgICBnX3NpZ25hbF9jb25uZWN0X29iamVjdChwcml2LT50b3VjaEdlc3R1cmVHcm91cCwgImVu ZCIsIEdfQ0FMTEJBQ0sod2Via2l0V2ViVmlld0Jhc2Vab29tRW5kKSwgdmlld1dpZGdldCwgR19D T05ORUNUX1NXQVBQRUQpOwogCi0tIAoyLjMxLjEKCg==