226670 2021-06-04 17:41:47 -0700 REGRESSION(r275765) When ignoring HSTS, sometimes loads fail 2021-06-04 21:10:53 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 224340 1 achristensen achristensen cdumez darin webkit-bug-importer oldest_to_newest 1767012 0 achristensen 2021-06-04 17:41:47 -0700 REGRESSION(r275765) When ignoring HSTS, sometimes loads fail 1767013 1 430635 achristensen 2021-06-04 17:42:41 -0700 Created attachment 430635 Patch 1767014 2 430636 achristensen 2021-06-04 17:43:20 -0700 Created attachment 430636 Patch 1767016 3 430636 cdumez 2021-06-04 17:44:06 -0700 Comment on attachment 430636 Patch Why don't we treat warnings as errors in WebKit2? Seems we should have gotten an unused parameter warning here.. 1767017 4 430636 achristensen 2021-06-04 17:45:30 -0700 Comment on attachment 430636 Patch We don't treat unused parameters as warnings in ObjC because the language requires unused parameters to be named in selector calls. We ought to be able to do it for non-selector functions like this, though. 1767018 5 cdumez 2021-06-04 17:50:04 -0700 <rdar://78066692> 1767031 6 ews-feeder 2021-06-04 19:16:05 -0700 Committed r278517 (238516@main): <https://commits.webkit.org/238516@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430636. 1767090 7 darin 2021-06-04 21:10:53 -0700 Alex is right. When I turned on unused parameter warnings, I didn’t do it for Objective-C because we’d have to add UNUSED_PARAM in so many places. And I really prefer the "leave out the variable name" over the "use the UNUSED_PARAM macro" style. But that wasn’t a great decision for the ages. I’d love to turn it on now even for the Objective-C files. 430635 2021-06-04 17:42:41 -0700 2021-06-04 17:43:19 -0700 Patch bug-226670-20210604174240.patch text/plain 1348 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNzg1MTQpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA2LTA0ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihy Mjc1NzY1KSBXaGVuIGlnbm9yaW5nIEhTVFMsIHNvbWV0aW1lcyBsb2FkcyBmYWlsCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjY2NzAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNz L2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW06CisgICAgICAgIChzZXRJZ25vcmVIU1RTKToK KyAgICAgICAgVXNlIHRoZSB2YWx1ZSBwYXNzZWQgaW4gdG8gdGhlIGZ1bmN0aW9uIGluc3RlYWQg b2YgYWx3YXlzIGZhbHNlLgorCiAyMDIxLTA2LTA0ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJr aXQub3JnPgogCiAgICAgICAgIFN0b3JlIE1lZGlhUGxheWVyIHVzaW5nIFdlYWtQdHIgaW4gTWVk aWFQbGF5ZXJQcml2YXRlUmVtb3RlCkluZGV4OiBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNz L2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1tCShyZXZpc2lvbiAy Nzg0NzcpCisrKyBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtTZXNz aW9uQ29jb2EubW0JKHdvcmtpbmcgY29weSkKQEAgLTUxMSw3ICs1MTEsNyBAQCBzdGF0aWMgdm9p ZCBzZXRJZ25vcmVIU1RTKE5TTXV0YWJsZVVSTFJlCiBzdGF0aWMgdm9pZCBzZXRJZ25vcmVIU1RT KFJldGFpblB0cjxOU1VSTFJlcXVlc3Q+JiByZXF1ZXN0LCBib29sIHNob3VsZElnbm9yZUhTVFMp CiB7CiAgICAgYXV0byBtdXRhYmxlUmVxdWVzdCA9IGFkb3B0TlMoW3JlcXVlc3QgbXV0YWJsZUNv cHldKTsKLSAgICBzZXRJZ25vcmVIU1RTKG11dGFibGVSZXF1ZXN0LmdldCgpLCBmYWxzZSk7Cisg ICAgc2V0SWdub3JlSFNUUyhtdXRhYmxlUmVxdWVzdC5nZXQoKSwgc2hvdWxkSWdub3JlSFNUUyk7 CiAgICAgcmVxdWVzdCA9IG11dGFibGVSZXF1ZXN0OwogfQogCg== 430636 2021-06-04 17:43:20 -0700 2021-06-04 19:16:06 -0700 Patch bug-226670-20210604174319.patch text/plain 1383 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNzg1MTQpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDIxLTA2LTA0ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihy Mjc1NzY1KSBXaGVuIGlnbm9yaW5nIEhTVFMsIHNvbWV0aW1lcyBsb2FkcyBmYWlsCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjY2NzAKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzc4MDY2NjkyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25D b2NvYS5tbToKKyAgICAgICAgKHNldElnbm9yZUhTVFMpOgorICAgICAgICBVc2UgdGhlIHZhbHVl IHBhc3NlZCBpbiB0byB0aGUgZnVuY3Rpb24gaW5zdGVhZCBvZiBhbHdheXMgZmFsc2UuCisKIDIw MjEtMDYtMDQgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgU3Rv cmUgTWVkaWFQbGF5ZXIgdXNpbmcgV2Vha1B0ciBpbiBNZWRpYVBsYXllclByaXZhdGVSZW1vdGUK SW5kZXg6IFNvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25D b2NvYS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29h L05ldHdvcmtTZXNzaW9uQ29jb2EubW0JKHJldmlzaW9uIDI3ODQ3NykKKysrIFNvdXJjZS9XZWJL aXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5tbQkod29ya2luZyBj b3B5KQpAQCAtNTExLDcgKzUxMSw3IEBAIHN0YXRpYyB2b2lkIHNldElnbm9yZUhTVFMoTlNNdXRh YmxlVVJMUmUKIHN0YXRpYyB2b2lkIHNldElnbm9yZUhTVFMoUmV0YWluUHRyPE5TVVJMUmVxdWVz dD4mIHJlcXVlc3QsIGJvb2wgc2hvdWxkSWdub3JlSFNUUykKIHsKICAgICBhdXRvIG11dGFibGVS ZXF1ZXN0ID0gYWRvcHROUyhbcmVxdWVzdCBtdXRhYmxlQ29weV0pOwotICAgIHNldElnbm9yZUhT VFMobXV0YWJsZVJlcXVlc3QuZ2V0KCksIGZhbHNlKTsKKyAgICBzZXRJZ25vcmVIU1RTKG11dGFi bGVSZXF1ZXN0LmdldCgpLCBzaG91bGRJZ25vcmVIU1RTKTsKICAgICByZXF1ZXN0ID0gbXV0YWJs ZVJlcXVlc3Q7CiB9CiAK