226661 2021-06-04 13:34:19 -0700 Web Inspector: mark recently added protocol commands/events as page-only 2021-06-11 10:48:34 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 207446 218964 221228 221449 1 hi hi bburg ews-watchlist hi inspector-bugzilla-changes joepeck keith_miller mark.lam msaboff pangle rcaliman saam timothy tzagallo webkit-bug-importer yusufalaaothman001 oldest_to_newest 1766909 0 hi 2021-06-04 13:34:19 -0700 . 1766917 1 430609 hi 2021-06-04 13:46:55 -0700 Created attachment 430609 Patch 1766919 2 ews-watchlist 2021-06-04 13:47:58 -0700 This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features. 1766920 3 430609 joepeck 2021-06-04 13:50:40 -0700 Comment on attachment 430609 Patch rs=me, Can a Service Worker debugger do intercepts? 1766921 4 430609 joepeck 2021-06-04 13:52:14 -0700 Comment on attachment 430609 Patch Given existing intercept methods are only for "page" this seems good! r=me 1766949 5 hi 2021-06-04 15:04:25 -0700 (In reply to Joseph Pecoraro from comment #3) Can a Service Worker debugger do intercepts? I tried enabling all the intercept commands for `"service-worker"` targets too, but it didn't work. Also, most "resources" are actually `WI.Script` that don't have a `WI.Resource` and therefore don't go through the `Network` agent. 1766997 6 ews-feeder 2021-06-04 16:57:46 -0700 Committed r278511 (238510@main): <https://commits.webkit.org/238510@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430609. 1766998 7 webkit-bug-importer 2021-06-04 16:58:19 -0700 <rdar://problem/78892294> 430609 2021-06-04 13:46:55 -0700 2021-06-04 16:57:47 -0700 Patch bug-226661-20210604144655.patch text/plain 5439 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDRhNmFkNWVlNjBjMzgzNjU1MDYyZjQ0YWQzYzJl ZTFiMmVmMjhkMzMuLmI3ZGUyZjcyOTM4MTJkZGFlOWQ2NDZmNGQ2NTVjYzNjNmI2MzZlMTkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA2LTA0ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBt YXJrIHJlY2VudGx5IGFkZGVkIHByb3RvY29sIGNvbW1hbmRzL2V2ZW50cyBhcyBwYWdlLW9ubHkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjY2MQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVj dG9yL3Byb3RvY29sL0NTUy5qc29uOgorICAgICAgICAqIGluc3BlY3Rvci9wcm90b2NvbC9OZXR3 b3JrLmpzb246CisgICAgICAgIFRoZXNlIGNvbW1hbmRzIGFyZSBub3QgaW1wbGVtZW50ZWQgaW4g SVRNTC4gQnkgbm90IHNwZWNpZnlpbmcgYCJ0YXJnZXRUeXBlcyI6IFsicGFnZSJdYCBpdCdzCisg ICAgICAgIGltcGxpY2l0bHkgc2F5aW5nIHRoYXQgdGhlIGNvbW1hbmQvZXZlbnQgaXMgc3VwcG9y dGVkIGJ5IElUTUwgc2luY2UgdGhlIGNvbW1hbmQvZXZlbnQgd2lsbAorICAgICAgICBmYWxsIGJh Y2sgdG8gdGhlIGRvbWFpbidzIGAidGFyZ2V0VHlwZXMiYCwgd2hpY2ggaW5jbHVkZXMgSVRNTC4K KwogMjAyMS0wNi0wNCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAg UGxhY2F0ZSBleGNlcHRpb24gY2hlY2tlciB2YWxpZGF0aW9uIGluIG9iamVjdFByb3RvdHlwZUhh c093blByb3BlcnR5LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rv ci9wcm90b2NvbC9DU1MuanNvbiBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcHJv dG9jb2wvQ1NTLmpzb24KaW5kZXggZmM3ZjJlNWUxOGIyOTA0ODFjZDRmM2RhZGU1NDM0YWYwOTZm NDUxZC4uYzllYjU3NmJkN2MyNTkzNGFhNTljYmYzMmUxY2NjZjkzMzkxN2NlOCAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9wcm90b2NvbC9DU1MuanNvbgorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29sL0NTUy5qc29uCkBAIC0z MTMsNiArMzEzLDcgQEAKICAgICAgICAgewogICAgICAgICAgICAgIm5hbWUiOiAiZ2V0Rm9udERh dGFGb3JOb2RlIiwKICAgICAgICAgICAgICJkZXNjcmlwdGlvbiI6ICJSZXR1cm5zIHRoZSBwcmlt YXJ5IGZvbnQgb2YgdGhlIGNvbXB1dGVkIGZvbnQgY2FzY2FkZSBmb3IgYSBET00gbm9kZSBpZGVu dGlmaWVkIGJ5IDxjb2RlPm5vZGVJZDwvY29kZT4uIiwKKyAgICAgICAgICAgICJ0YXJnZXRUeXBl cyI6IFsicGFnZSJdLAogICAgICAgICAgICAgInBhcmFtZXRlcnMiOiBbCiAgICAgICAgICAgICAg ICAgeyAibmFtZSI6ICJub2RlSWQiLCAiJHJlZiI6ICJET00uTm9kZUlkIiB9CiAgICAgICAgICAg ICBdLApAQCAtNDI4LDYgKzQyOSw3IEBACiAgICAgICAgIHsKICAgICAgICAgICAgICJuYW1lIjog InNldExheW91dENvbnRleHRUeXBlQ2hhbmdlZE1vZGUiLAogICAgICAgICAgICAgImRlc2NyaXB0 aW9uIjogIkNoYW5nZSBob3cgbGF5b3V0IGNvbnRleHQgdHlwZSBjaGFuZ2VzIGFyZSBoYW5kbGVk IGZvciBub2Rlcy4gV2hlbiB0aGUgbmV3IG1vZGUgd291bGQgb2JzZXJ2ZSBub2RlcyB0aGUgZnJv bnRlbmQgaGFzIG5vdCB5ZXQgcmVjaWV2ZWQsIHRob3NlIG5vZGVzIHdpbGwgYmUgc2VudCB0byB0 aGUgZnJvbnRlbmQgaW1tZWRpYXRlbHkuIiwKKyAgICAgICAgICAgICJ0YXJnZXRUeXBlcyI6IFsi cGFnZSJdLAogICAgICAgICAgICAgInBhcmFtZXRlcnMiOiBbCiAgICAgICAgICAgICAgICAgeyAi bmFtZSI6ICJtb2RlIiwgIiRyZWYiOiAiTGF5b3V0Q29udGV4dFR5cGVDaGFuZ2VkTW9kZSIsICJk ZXNjcmlwdGlvbiI6ICJUaGUgbW9kZSBmb3IgaG93IGxheW91dCBjb250ZXh0IHR5cGUgY2hhbmdl cyBhcmUgaGFuZGxlZC4iIH0KICAgICAgICAgICAgIF0KQEAgLTQ2NCw2ICs0NjYsNyBAQAogICAg ICAgICB7CiAgICAgICAgICAgICAibmFtZSI6ICJub2RlTGF5b3V0Q29udGV4dFR5cGVDaGFuZ2Vk IiwKICAgICAgICAgICAgICJkZXNjcmlwdGlvbiI6ICJDYWxsZWQgd2hlbiBhIG5vZGUncyBsYXlv dXQgY29udGV4dCB0eXBlIGhhcyBjaGFuZ2VkLiIsCisgICAgICAgICAgICAidGFyZ2V0VHlwZXMi OiBbInBhZ2UiXSwKICAgICAgICAgICAgICJwYXJhbWV0ZXJzIjogWwogICAgICAgICAgICAgICAg IHsgIm5hbWUiOiAibm9kZUlkIiwgIiRyZWYiOiAiRE9NLk5vZGVJZCIsICJkZXNjcmlwdGlvbiI6 ICJJZGVudGlmaWVyIG9mIHRoZSBub2RlIHdob3NlIGxheW91dCBjb250ZXh0IHR5cGUgY2hhbmdl ZC4iIH0sCiAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJsYXlvdXRDb250ZXh0VHlwZSIsICIk cmVmIjogIkxheW91dENvbnRleHRUeXBlIiwgIm9wdGlvbmFsIjogdHJ1ZSwgImRlc2NyaXB0aW9u IjogIlRoZSBuZXcgbGF5b3V0IGNvbnRleHQgdHlwZSBvZiB0aGUgbm9kZS4gV2hlbiBub3QgcHJv dmlkZWQsIHRoZSA8Y29kZT5MYXlvdXRDb250ZXh0VHlwZTwvY29kZT4gb2YgdGhlIG5vZGUgaXMg bm90IGEgY29udGV4dCBmb3Igd2hpY2ggV2ViIEluc3BlY3RvciBoYXMgc3BlY2lmaWMgZnVuY3Rp b25hbGl0eS4iIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Iv cHJvdG9jb2wvTmV0d29yay5qc29uIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9w cm90b2NvbC9OZXR3b3JrLmpzb24KaW5kZXggNjVhYjIwOTJiMGZmZDBlYWQzZGExZGRjY2QzOThk NGY0MTc5ZjUxYS4uODgyYTJkNTZiZWZlZjBhYmE0NjBjYzhmZjA0MTk2OWUwZDJjMWVkMyAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9wcm90b2NvbC9OZXR3b3Jr Lmpzb24KKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9wcm90b2NvbC9OZXR3 b3JrLmpzb24KQEAgLTI3OSw2ICsyNzksNyBAQAogICAgICAgICB7CiAgICAgICAgICAgICAibmFt ZSI6ICJpbnRlcmNlcHRXaXRoUmVxdWVzdCIsCiAgICAgICAgICAgICAiZGVzY3JpcHRpb24iOiAi UmVwbGFjZSBpbnRlcmNlcHRlZCByZXF1ZXN0IHdpdGggdGhlIHByb3ZpZGVkIG9uZS4iLAorICAg ICAgICAgICAgInRhcmdldFR5cGVzIjogWyJwYWdlIl0sCiAgICAgICAgICAgICAicGFyYW1ldGVy cyI6IFsKICAgICAgICAgICAgICAgICB7ICJuYW1lIjogInJlcXVlc3RJZCIsICIkcmVmIjogIlJl cXVlc3RJZCIsICJkZXNjcmlwdGlvbiI6ICJJZGVudGlmaWVyIGZvciB0aGUgaW50ZXJjZXB0ZWQg TmV0d29yayByZXF1ZXN0IG9yIHJlc3BvbnNlIHRvIGNvbnRpbnVlLiIgfSwKICAgICAgICAgICAg ICAgICB7ICJuYW1lIjogInVybCIsICJ0eXBlIjogInN0cmluZyIsICJvcHRpb25hbCI6IHRydWUs ImRlc2NyaXB0aW9uIjogIkhUVFAgcmVxdWVzdCB1cmwuIiB9LApAQCAtMzA0LDYgKzMwNSw3IEBA CiAgICAgICAgIHsKICAgICAgICAgICAgICJuYW1lIjogImludGVyY2VwdFJlcXVlc3RXaXRoUmVz cG9uc2UiLAogICAgICAgICAgICAgImRlc2NyaXB0aW9uIjogIlByb3ZpZGUgcmVzcG9uc2UgZm9y IGFuIGludGVyY2VwdGVkIHJlcXVlc3QuIFJlcXVlc3QgY29tcGxldGVseSBieXBhc3NlcyB0aGUg bmV0d29yayBpbiB0aGlzIGNhc2UgYW5kIGlzIGltbWVkaWF0ZWx5IGZ1bGZpbGxlZCB3aXRoIHRo ZSBwcm92aWRlZCBkYXRhLiIsCisgICAgICAgICAgICAidGFyZ2V0VHlwZXMiOiBbInBhZ2UiXSwK ICAgICAgICAgICAgICJwYXJhbWV0ZXJzIjogWwogICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAi cmVxdWVzdElkIiwgIiRyZWYiOiAiUmVxdWVzdElkIiwgImRlc2NyaXB0aW9uIjogIklkZW50aWZp ZXIgZm9yIHRoZSBpbnRlcmNlcHRlZCBOZXR3b3JrIHJlc3BvbnNlIHRvIG1vZGlmeS4iIH0sCiAg ICAgICAgICAgICAgICAgeyAibmFtZSI6ICJjb250ZW50IiwgInR5cGUiOiAic3RyaW5nIiB9LApA QCAtMzE3LDYgKzMxOSw3IEBACiAgICAgICAgIHsKICAgICAgICAgICAgICJuYW1lIjogImludGVy Y2VwdFJlcXVlc3RXaXRoRXJyb3IiLAogICAgICAgICAgICAgImRlc2NyaXB0aW9uIjogIkZhaWwg cmVxdWVzdCB3aXRoIGdpdmVuIGVycm9yIHR5cGUuIiwKKyAgICAgICAgICAgICJ0YXJnZXRUeXBl cyI6IFsicGFnZSJdLAogICAgICAgICAgICAgInBhcmFtZXRlcnMiOiBbCiAgICAgICAgICAgICAg ICAgeyAibmFtZSI6ICJyZXF1ZXN0SWQiLCAiJHJlZiI6ICJSZXF1ZXN0SWQiLCAiZGVzY3JpcHRp b24iOiAiSWRlbnRpZmllciBmb3IgdGhlIGludGVyY2VwdGVkIE5ldHdvcmsgcmVxdWVzdCB0byBm YWlsLiIgfSwKICAgICAgICAgICAgICAgICB7ICJuYW1lIjogImVycm9yVHlwZSIsICIkcmVmIjog IlJlc291cmNlRXJyb3JUeXBlIiwgImRlc2NyaXB0aW9uIjogIkRlbGl2ZXIgZXJyb3IgcmVhc29u IGZvciB0aGUgcmVxdWVzdCBmYWlsdXJlLiIgfQpAQCAtMzk5LDYgKzQwMiw3IEBACiAgICAgICAg IHsKICAgICAgICAgICAgICJuYW1lIjogInJlcXVlc3RJbnRlcmNlcHRlZCIsCiAgICAgICAgICAg ICAiZGVzY3JpcHRpb24iOiAiRmlyZWQgd2hlbiBIVFRQIHJlcXVlc3QgaGFzIGJlZW4gaW50ZXJj ZXB0ZWQuIFRoZSBmcm9udGVuZCBtdXN0IHJlc3BvbmQgd2l0aCA8Y29kZT5OZXR3b3JrLmludGVy Y2VwdENvbnRpbnVlPC9jb2RlPiwgPGNvZGU+TmV0d29yay5pbnRlcmNlcHRXaXRoUmVxdWVzdDwv Y29kZT5gIG9yIDxjb2RlPk5ldHdvcmsuaW50ZXJjZXB0V2l0aFJlc3BvbnNlPC9jb2RlPmAgdG8g cmVzb2x2ZSB0aGlzIHJlcXVlc3QuIiwKKyAgICAgICAgICAgICJ0YXJnZXRUeXBlcyI6IFsicGFn ZSJdLAogICAgICAgICAgICAgInBhcmFtZXRlcnMiOiBbCiAgICAgICAgICAgICAgICAgeyAibmFt ZSI6ICJyZXF1ZXN0SWQiLCAiJHJlZiI6ICJSZXF1ZXN0SWQiLCAiZGVzY3JpcHRpb24iOiAiSWRl bnRpZmllciBmb3IgdGhpcyBpbnRlcmNlcHRlZCBuZXR3b3JrLiBDb3JyZXNwb25kcyB3aXRoIGFu IGVhcmxpZXIgPGNvZGU+TmV0d29yay5yZXF1ZXN0V2lsbEJlU2VudDwvY29kZT4uIiB9LAogICAg ICAgICAgICAgICAgIHsgIm5hbWUiOiAicmVxdWVzdCIsICIkcmVmIjogIlJlcXVlc3QiLCAiZGVz Y3JpcHRpb24iOiAiT3JpZ2luYWwgcmVxdWVzdCBjb250ZW50IHRoYXQgd291bGQgcHJvY2VlZCBp ZiB0aGlzIGlzIGNvbnRpbnVlZC4iIH0K