226656 2021-06-04 12:33:48 -0700 [JSC] Private static method should define privateClassBrandIdentifier in class-scope 2021-06-07 12:25:57 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam ticaiolima tzagallo webkit-bug-importer oldest_to_newest 1766880 0 ysuzuki 2021-06-04 12:33:48 -0700 [JSC] Private static method should define privateClassBrandIdentifier in class-scope 1766882 1 430598 ysuzuki 2021-06-04 12:34:57 -0700 Created attachment 430598 Patch 1766883 2 ysuzuki 2021-06-04 12:34:59 -0700 <rdar://problem/78313139> 1766995 3 ews-feeder 2021-06-04 16:44:30 -0700 Committed r278510 (238509@main): <https://commits.webkit.org/238509@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430598. 1767511 4 430598 ticaiolima 2021-06-07 12:25:57 -0700 Comment on attachment 430598 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430598&action=review > Source/JavaScriptCore/parser/Parser.cpp:3036 > + declaresStaticPrivateMethod = true; OOPS, nice catch there. 430598 2021-06-04 12:34:57 -0700 2021-06-04 16:44:31 -0700 Patch bug-226656-20210604123456.patch text/plain 4605 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 NzI4ODkwZDUxNGI5MDU4MWFjMjM4Y2U5Mjc4YzA5ZGNhZjljMjM1Li40MDIyNzQ2NWJmZDVlYzFi ZDk1YjA4MjhmZjgwMmFhMThlMjgxNWY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMS0wNi0wNCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFByaXZhdGUgc3RhdGljIG1ldGhvZCBzaG91bGQgZGVmaW5lIHBy aXZhdGVDbGFzc0JyYW5kSWRlbnRpZmllciBpbiBjbGFzcy1zY29wZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2NjU2CisgICAgICAgIHJkYXI6Ly83 ODMxMzEzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdlIGFjY2lkZW50YWxseSBtYWRlIGBkZWNsYXJlc1N0YXRpY1ByaXZhdGVNZXRob2RgIGFsd2F5 cyBgZmFsc2VgLgorICAgICAgICBUaGlzIHBhdGNoIGZpeGVzIHRoYXQgc28gdGhhdCB3ZSBwcm9w ZXJseSBkZWZpbmUgcHJpdmF0ZUNsYXNzQnJhbmRJZGVudGlmaWVyIGZpZWxkIGluIHRoZSBjbGFz cy1zY29wZSBpZiBzdGF0aWMtcHJpdmF0ZS1tZXRob2QgaXMgZGVmaW5lZC4KKworICAgICAgICAq IHBhcnNlci9QYXJzZXIuY3BwOgorICAgICAgICAoSlNDOjpQYXJzZXI8TGV4ZXJUeXBlPjo6cGFy c2VDbGFzcyk6CisKIDIwMjEtMDYtMDQgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4K IAogICAgICAgICBEb24ndCBlbWl0IHRoZSBOb3REb3VibGUgY2hlY2tzIGlmIHdlJ3JlIGFscmVh ZHkgTm90RG91YmxlLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9Q YXJzZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCmluZGV4 IDdjZGYxYzkwNzNmMGQ1ZTk4ZWU2NTBiZWQ4ZWM0Mzg1ZDdiMDMwZGEuLmUxZGY5NGRlM2NmNGYw OTk0ODhlZjA3ZDYxNzg0MDk4YzA3NGQ5ZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9wYXJzZXIvUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2Vy L1BhcnNlci5jcHAKQEAgLTMwMzMsNyArMzAzMyw3IEBAIHRlbXBsYXRlIDxjbGFzcyBUcmVlQnVp bGRlcj4gVHJlZUNsYXNzRXhwcmVzc2lvbiBQYXJzZXI8TGV4ZXJUeXBlPjo6cGFyc2VDbGFzcyhU CiAgICAgICAgICAgICAgICAgc2VtYW50aWNGYWlsSWZUcnVlKCppZGVudCA9PSBwcm9wZXJ0eU5h bWVzLmNvbnN0cnVjdG9yUHJpdmF0ZUZpZWxkLCAiQ2Fubm90IGRlY2xhcmUgYSBwcml2YXRlIG1l dGhvZCBuYW1lZCAnI2NvbnN0cnVjdG9yJyIpOwogCiAgICAgICAgICAgICAgICAgaWYgKHRhZyA9 PSBDbGFzc0VsZW1lbnRUYWc6OlN0YXRpYykKLSAgICAgICAgICAgICAgICAgICAgZGVjbGFyZXNT dGF0aWNQcml2YXRlQWNjZXNzb3IgPSB0cnVlOworICAgICAgICAgICAgICAgICAgICBkZWNsYXJl c1N0YXRpY1ByaXZhdGVNZXRob2QgPSB0cnVlOwogICAgICAgICAgICAgICAgIGVsc2UKICAgICAg ICAgICAgICAgICAgICAgZGVjbGFyZXNQcml2YXRlTWV0aG9kID0gdHJ1ZTsKIApkaWZmIC0tZ2l0 IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCA1MjEwYjliMDdh OTYwZWYzZDYzNzk4M2MyMWMyYTcxMzAwNDMzZmZhLi5hNmU3MmQyZTk5NWUwNDAwOTNkMGM3M2I4 M2Y2YmM5OGRlODUzOWE4IDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rl c3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTA2LTA0ICBZdXN1a2UgU3V6dWtp ICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgW0pTQ10gUHJpdmF0ZSBzdGF0aWMgbWV0 aG9kIHNob3VsZCBkZWZpbmUgcHJpdmF0ZUNsYXNzQnJhbmRJZGVudGlmaWVyIGluIGNsYXNzLXNj b3BlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjY2 NTYKKyAgICAgICAgcmRhcjovLzc4MzEzMTM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvcHJpdmF0ZS1pbi1lcnJvci5qczogQWRkZWQu CisgICAgICAgIChzaG91bGRUaHJvdyk6CisgICAgICAgICh4KToKKyAgICAgICAgKHByb3RvdHlw ZS5mb28pOgorICAgICAgICAqIHN0cmVzcy9wcml2YXRlLXN0YXRpYy1tZXRob2QtZGVjbGFyYXRp b24tZXJyb3IuanM6IEFkZGVkLgorICAgICAgICAoc2hvdWxkVGhyb3cpOgorICAgICAgICAocHJv dG90eXBlLmdldCB4KToKKyAgICAgICAgKHByb3RvdHlwZS5mb28uRC5hKToKKyAgICAgICAgKHBy b3RvdHlwZS5mb28uRC5wcm90b3R5cGUuYik6CisgICAgICAgIChwcm90b3R5cGUuZm9vLkQpOgor ICAgICAgICAocHJvdG90eXBlLmZvbyk6CisKIDIwMjEtMDYtMDQgIE1hcmsgTGFtICA8bWFyay5s YW1AYXBwbGUuY29tPgogCiAgICAgICAgIFBsYWNhdGUgZXhjZXB0aW9uIGNoZWNrZXIgdmFsaWRh dGlvbiBpbiBvYmplY3RQcm90b3R5cGVIYXNPd25Qcm9wZXJ0eS4KZGlmZiAtLWdpdCBhL0pTVGVz dHMvc3RyZXNzL3ByaXZhdGUtaW4tZXJyb3IuanMgYi9KU1Rlc3RzL3N0cmVzcy9wcml2YXRlLWlu LWVycm9yLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjJkNzZhNGMxYTdkYjc3ODhjYzRkODYxMTEyYWMzNTJiYmVi ODk5Y2EKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0cmVzcy9wcml2YXRlLWluLWVycm9y LmpzCkBAIC0wLDAgKzEsMjggQEAKKy8vQCByZXF1aXJlT3B0aW9ucygiLS11c2VQcml2YXRlSW49 MSIpCitmdW5jdGlvbiBzaG91bGRUaHJvdyhmdW5jLCBlcnJvck1lc3NhZ2UpIHsKKyAgICB2YXIg ZXJyb3JUaHJvd24gPSBmYWxzZTsKKyAgICB2YXIgZXJyb3IgPSBudWxsOworICAgIHRyeSB7Cisg ICAgICAgIGZ1bmMoKTsKKyAgICB9IGNhdGNoIChlKSB7CisgICAgICAgIGVycm9yVGhyb3duID0g dHJ1ZTsKKyAgICAgICAgZXJyb3IgPSBlOworICAgIH0KKyAgICBpZiAoIWVycm9yVGhyb3duKQor ICAgICAgICB0aHJvdyBuZXcgRXJyb3IoJ25vdCB0aHJvd24nKTsKKyAgICBpZiAoU3RyaW5nKGVy cm9yKSAhPT0gZXJyb3JNZXNzYWdlKQorICAgICAgICB0aHJvdyBuZXcgRXJyb3IoYGJhZCBlcnJv cjogJHtTdHJpbmcoZXJyb3IpfWApOworfQorCitjbGFzcyBDIHsKKyAgc3RhdGljICN4KCkge30K KworICBmb28oKSB7CisgICAgICByZXR1cm4gI3ggaW4gNDI7CisgIH0KK30KKworc2hvdWxkVGhy b3coKCkgPT4geworICAgIGxldCBjID0gbmV3IEMoKTsKKyAgICBjLmZvbygpOworfSwgYFR5cGVF cnJvcjogQ2Fubm90IGFjY2VzcyBzdGF0aWMgcHJpdmF0ZSBtZXRob2Qgb3IgYWNjZXNzb3Igb2Yg YSBub24tT2JqZWN0YCk7CmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9wcml2YXRlLXN0YXRp Yy1tZXRob2QtZGVjbGFyYXRpb24tZXJyb3IuanMgYi9KU1Rlc3RzL3N0cmVzcy9wcml2YXRlLXN0 YXRpYy1tZXRob2QtZGVjbGFyYXRpb24tZXJyb3IuanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZjA4NDAxMzIxNzcz YzY1NWU2NmE2Y2ExYWI2NzkwNTUwZmIxODY4MgotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMv c3RyZXNzL3ByaXZhdGUtc3RhdGljLW1ldGhvZC1kZWNsYXJhdGlvbi1lcnJvci5qcwpAQCAtMCww ICsxLDM0IEBACitmdW5jdGlvbiBzaG91bGRUaHJvdyhmdW5jLCBlcnJvck1lc3NhZ2UpIHsKKyAg ICB2YXIgZXJyb3JUaHJvd24gPSBmYWxzZTsKKyAgICB2YXIgZXJyb3IgPSBudWxsOworICAgIHRy eSB7CisgICAgICAgIGZ1bmMoKTsKKyAgICB9IGNhdGNoIChlKSB7CisgICAgICAgIGVycm9yVGhy b3duID0gdHJ1ZTsKKyAgICAgICAgZXJyb3IgPSBlOworICAgIH0KKyAgICBpZiAoIWVycm9yVGhy b3duKQorICAgICAgICB0aHJvdyBuZXcgRXJyb3IoJ25vdCB0aHJvd24nKTsKKyAgICBpZiAoU3Ry aW5nKGVycm9yKSAhPT0gZXJyb3JNZXNzYWdlKQorICAgICAgICB0aHJvdyBuZXcgRXJyb3IoYGJh ZCBlcnJvcjogJHtTdHJpbmcoZXJyb3IpfWApOworfQorCitjbGFzcyBDIHsKKyAgZ2V0ICN4KCkg e30KKworICBmb28oKSB7CisgICAgY2xhc3MgRCB7CisgICAgICBzdGF0aWMgI2EoKSB7fQorICAg ICAgYigpIHsKKyAgICAgICAgcmV0dXJuICcnLiNhOworICAgICAgfQorICAgIH0KKyAgICBsZXQg ZCA9IG5ldyBEKCk7CisgICAgZC5iKCk7CisgIH0KK30KKworc2hvdWxkVGhyb3coKCkgPT4gewor ICAgIGxldCBjID0gbmV3IEMoKTsKKyAgICBjLmZvbygpOworfSwgYFR5cGVFcnJvcjogQ2Fubm90 IGFjY2VzcyBzdGF0aWMgcHJpdmF0ZSBtZXRob2Qgb3IgYWNjZXNzb3JgKTsK