226644 2021-06-04 08:41:58 -0700 Avoid wasteful large allocation in SpeechRecognitionRemoteRealtimeMediaSource::setStorage() 2021-06-04 10:15:21 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=226253 InRadar P2 Normal --- 1 cdumez cdumez eric.carlson ews-watchlist glenn jer.noble peng.liu6 philipj rbuis sergio sihui_liu webkit-bug-importer youennf oldest_to_newest 1766780 0 cdumez 2021-06-04 08:41:58 -0700 Avoid wasteful large allocation in SpeechRecognitionRemoteRealtimeMediaSource::setStorage(). setStorage() sets m_buffer's size to the same size as the RingBuffer (2*sampleRate), only to resize it to the size of the rendering quantum (512) later in SpeechRecognitionRemoteRealtimeMediaSource::remoteAudioSamplesAvailable(). 1766782 1 430582 cdumez 2021-06-04 08:43:48 -0700 Created attachment 430582 Patch 1766819 2 ews-feeder 2021-06-04 10:14:31 -0700 Committed r278471 (238489@main): <https://commits.webkit.org/238489@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430582. 1766820 3 webkit-bug-importer 2021-06-04 10:15:21 -0700 <rdar://problem/78874517> 430582 2021-06-04 08:43:48 -0700 2021-06-04 10:14:32 -0700 Patch bug-226644-20210604084347.patch text/plain 2025 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NDQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDY5OGRjOWFlOGRiZDFjZDdm NzFhMmUzZTZhNGUwYTRkODViODY1MzIuLjMyYmI0NjE1YjlhZjdjOWFmMWU5Y2Y5NzEwMTc5MmVh YzU1ZDYzZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjEtMDYtMDQgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBBdm9pZCB3YXN0ZWZ1bCBsYXJnZSBh bGxvY2F0aW9uIGluIFNwZWVjaFJlY29nbml0aW9uUmVtb3RlUmVhbHRpbWVNZWRpYVNvdXJjZTo6 c2V0U3RvcmFnZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjY2NDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBdm9pZCB3YXN0ZWZ1bCBsYXJnZSBhbGxvY2F0aW9uIGluIFNwZWVjaFJlY29nbml0aW9u UmVtb3RlUmVhbHRpbWVNZWRpYVNvdXJjZTo6c2V0U3RvcmFnZSgpLgorICAgICAgICBzZXRTdG9y YWdlKCkgd2FzIHNldHRpbmcgbV9idWZmZXIncyBzaXplIHRvIHRoZSBzYW1lIHNpemUgYXMgdGhl IFJpbmdCdWZmZXIgKDIqc2FtcGxlUmF0ZSksCisgICAgICAgIG9ubHkgdG8gcmVzaXplIGl0IHRv IHRoZSBzaXplIG9mIHRoZSByZW5kZXJpbmcgcXVhbnR1bSAoNTEyKSBsYXRlciBpbgorICAgICAg ICBTcGVlY2hSZWNvZ25pdGlvblJlbW90ZVJlYWx0aW1lTWVkaWFTb3VyY2U6OnJlbW90ZUF1ZGlv U2FtcGxlc0F2YWlsYWJsZSgpLgorCisgICAgICAgICogVUlQcm9jZXNzL1NwZWVjaFJlY29nbml0 aW9uUmVtb3RlUmVhbHRpbWVNZWRpYVNvdXJjZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OlNwZWVj aFJlY29nbml0aW9uUmVtb3RlUmVhbHRpbWVNZWRpYVNvdXJjZTo6c2V0U3RvcmFnZSk6CisKIDIw MjEtMDYtMDMgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBVc2Ug VmVjdG9yPHVpbnQ4X3Q+IGluc3RlYWQgb2YgVmVjdG9yPGNoYXI+IHRvIHN0b3JlIGJ5dGVzIGlu IFNoYXJlZEJ1ZmZlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvU3BlZWNo UmVjb2duaXRpb25SZW1vdGVSZWFsdGltZU1lZGlhU291cmNlLmNwcCBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL1NwZWVjaFJlY29nbml0aW9uUmVtb3RlUmVhbHRpbWVNZWRpYVNvdXJjZS5jcHAK aW5kZXggMDRjOTg0ZjY1ZmRlZTVhODdjOGUyN2Q5NjBiMTZhYmVmYTEzYWFjZS4uZTQyZGJmMTI4 MWQzNmZlZjJlMzAzZTcwN2Q1YjViYWYxNjZlZTE1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvU3BlZWNoUmVjb2duaXRpb25SZW1vdGVSZWFsdGltZU1lZGlhU291cmNlLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9TcGVlY2hSZWNvZ25pdGlvblJlbW90ZVJl YWx0aW1lTWVkaWFTb3VyY2UuY3BwCkBAIC04MCw3ICs4MCw3IEBAIHZvaWQgU3BlZWNoUmVjb2du aXRpb25SZW1vdGVSZWFsdGltZU1lZGlhU291cmNlOjpzZXRTdG9yYWdlKGNvbnN0IFNoYXJlZE1l bW9yeTo6CiAgICAgbV9kZXNjcmlwdGlvbiA9IGRlc2NyaXB0aW9uOwogCiAgICAgbV9yaW5nQnVm ZmVyID0gV2ViQ29yZTo6Q0FSaW5nQnVmZmVyOjphZG9wdFN0b3JhZ2UobWFrZVVuaXF1ZVJlZjxS ZWFkT25seVNoYXJlZFJpbmdCdWZmZXJTdG9yYWdlPihoYW5kbGUpLCBkZXNjcmlwdGlvbiwgbnVt YmVyT2ZGcmFtZXMpLm1vdmVUb1VuaXF1ZVB0cigpOwotICAgIG1fYnVmZmVyID0gbWFrZVVuaXF1 ZTxXZWJDb3JlOjpXZWJBdWRpb0J1ZmZlckxpc3Q+KGRlc2NyaXB0aW9uLCBudW1iZXJPZkZyYW1l cyk7CisgICAgbV9idWZmZXIgPSBtYWtlVW5pcXVlPFdlYkNvcmU6OldlYkF1ZGlvQnVmZmVyTGlz dD4oZGVzY3JpcHRpb24pOwogfQogCiAjZW5kaWYK