226642 2021-06-04 06:12:14 -0700 The CMake cache is removed when specifying a build target 2021-06-04 10:45:14 -0700 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrobinson mrobinson ews-watchlist jbedard oldest_to_newest 1766743 0 mrobinson 2021-06-04 06:12:14 -0700 When specifying a build target to build-webkit, for example running `build-webkit --gtk --release bin/MiniBrowser`, the addition of the build target causes build-webkit to delete the CMake cache. In this case, it really shouldn't be doing that. Only arguments which change the build configuration should trigger the removal of the cache. 1766744 1 430571 mrobinson 2021-06-04 06:13:07 -0700 Created attachment 430571 Patch 1766745 2 430572 mrobinson 2021-06-04 06:35:45 -0700 Created attachment 430572 Patch 1766775 3 ews-feeder 2021-06-04 08:35:37 -0700 Committed r278460 (238480@main): <https://commits.webkit.org/238480@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430572. 430571 2021-06-04 06:13:07 -0700 2021-06-04 06:35:40 -0700 Patch bug-226642-20210604151305.patch text/plain 1548 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NDUzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTg5OTFhN2NmMDQzNjJiOWU0OGNhMDBmODM4ZTgyZmNm NWQ5MDAwZS4uYmNiMThlYWVlY2U2NTVhNjNiOTM2MjRhNWJiYmMxNDc1YzY4MDA3MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIxLTA2LTA0ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4K KworICAgICAgICBUaGUgQ01ha2UgY2FjaGUgaXMgcmVtb3ZlZCB3aGVuIHNwZWNpZnlpbmcgYSBi dWlsZCB0YXJnZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIyNjY0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoc2hvdWxkUmVtb3ZlQ01ha2VD YWNoZSk6IE9ubHkgcmVtb3ZlIHRoZSBDTWFrZSBjYWNoZSB3aGVuIGFyZ3VtZW50cworICAgICAg ICB0aGF0IHN0YXJ0IHdpdGggYSBkYXNoIGNoYW5nZS4KKwogMjAyMS0wNi0wNCAgQ2FybG9zIEdh cmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gTWluaUJy b3dzZXI6IGFkZCBzdXBwb3J0IGZvciBzYXZpbmcgbXVsdGlwbGUgdGFicyBpbiBzZXNzaW9uIHN0 YXRlCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3Jp cHRzL3dlYmtpdGRpcnMucG0KaW5kZXggZWFkMDAxMDgyODRmMDk2NDljMGYwOTUxMWQzODhlZWYw ZDdlYTE0Ni4uNGQ5YjA5Zjg3YTYzOGI0NzFhMjM5ZmNiNGRhYzJkNjliY2E1MWVkNiAxMDA3NTUK LS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbQpAQCAtMjM2NSw3ICsyMzY1LDEwIEBAIHN1YiBjbWFrZUZpbGVzUGF0aCgpCiAK IHN1YiBzaG91bGRSZW1vdmVDTWFrZUNhY2hlKEApCiB7Ci0gICAgbXkgKEBidWlsZEFyZ3MpID0g c29ydCAoQF8sIEBvcmlnaW5hbEFyZ3YpOworICAgICMgRm9yIHRoaXMgY2hlY2ssIGlnbm9yZSBh bGwgYXJndW1lbnRzIHRoYXQgZG8gbm90IGJlZ2luIHdpdGggYSBkYXNoLiBUaGVzZQorICAgICMg YXJlIHByb2JhYmx5IGFyZ3VtZW50cyBzcGVjaWZ5aW5nIGJ1aWxkIHRhcmdldHMuIENoYW5naW5n IHRob3NlIHNob3VsZAorICAgICMgbm90IHRyaWdnZXIgYSByZWNvbmZpZ3VyYXRpb24gb2YgdGhl IGJ1aWxkLgorICAgIG15IChAYnVpbGRBcmdzKSA9IGdyZXAoL14tLywgc29ydChAXywgQG9yaWdp bmFsQXJndikpOwogCiAgICAgIyBXZSBjaGVjayB0aGlzIGZpcnN0LCBiZWNhdXNlIHdlIGFsd2F5 cyB3YW50IHRvIGNyZWF0ZSB0aGlzIGZpbGUgZm9yIGEgZnJlc2ggYnVpbGQuCiAgICAgbXkgJHBy b2R1Y3REaXIgPSBGaWxlOjpTcGVjLT5jYXRkaXIoYmFzZVByb2R1Y3REaXIoKSwgY29uZmlndXJh dGlvbigpKTsK 430572 2021-06-04 06:35:45 -0700 2021-06-04 10:45:14 -0700 Patch bug-226642-20210604153543.patch text/plain 1548 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NDUzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTg5OTFhN2NmMDQzNjJiOWU0OGNhMDBmODM4ZTgyZmNm NWQ5MDAwZS4uMzc4MzJhNmQyNGMwMmZhN2FiMjg5NjlkYTY4ZmJiYjVjN2FlMzdkYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIxLTA2LTA0ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25Ad2Via2l0Lm9yZz4K KworICAgICAgICBUaGUgQ01ha2UgY2FjaGUgaXMgcmVtb3ZlZCB3aGVuIHNwZWNpZnlpbmcgYSBi dWlsZCB0YXJnZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIyNjY0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoc2hvdWxkUmVtb3ZlQ01ha2VD YWNoZSk6IE9ubHkgcmVtb3ZlIHRoZSBDTWFrZSBjYWNoZSB3aGVuIGFyZ3VtZW50cworICAgICAg ICB0aGF0IHN0YXJ0IHdpdGggYSBkYXNoIGNoYW5nZS4KKwogMjAyMS0wNi0wNCAgQ2FybG9zIEdh cmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gTWluaUJy b3dzZXI6IGFkZCBzdXBwb3J0IGZvciBzYXZpbmcgbXVsdGlwbGUgdGFicyBpbiBzZXNzaW9uIHN0 YXRlCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3Jp cHRzL3dlYmtpdGRpcnMucG0KaW5kZXggZWFkMDAxMDgyODRmMDk2NDljMGYwOTUxMWQzODhlZWYw ZDdlYTE0Ni4uNGQ5YjA5Zjg3YTYzOGI0NzFhMjM5ZmNiNGRhYzJkNjliY2E1MWVkNiAxMDA3NTUK LS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbQpAQCAtMjM2NSw3ICsyMzY1LDEwIEBAIHN1YiBjbWFrZUZpbGVzUGF0aCgpCiAK IHN1YiBzaG91bGRSZW1vdmVDTWFrZUNhY2hlKEApCiB7Ci0gICAgbXkgKEBidWlsZEFyZ3MpID0g c29ydCAoQF8sIEBvcmlnaW5hbEFyZ3YpOworICAgICMgRm9yIHRoaXMgY2hlY2ssIGlnbm9yZSBh bGwgYXJndW1lbnRzIHRoYXQgZG8gbm90IGJlZ2luIHdpdGggYSBkYXNoLiBUaGVzZQorICAgICMg YXJlIHByb2JhYmx5IGFyZ3VtZW50cyBzcGVjaWZ5aW5nIGJ1aWxkIHRhcmdldHMuIENoYW5naW5n IHRob3NlIHNob3VsZAorICAgICMgbm90IHRyaWdnZXIgYSByZWNvbmZpZ3VyYXRpb24gb2YgdGhl IGJ1aWxkLgorICAgIG15IChAYnVpbGRBcmdzKSA9IGdyZXAoL14tLywgc29ydChAXywgQG9yaWdp bmFsQXJndikpOwogCiAgICAgIyBXZSBjaGVjayB0aGlzIGZpcnN0LCBiZWNhdXNlIHdlIGFsd2F5 cyB3YW50IHRvIGNyZWF0ZSB0aGlzIGZpbGUgZm9yIGEgZnJlc2ggYnVpbGQuCiAgICAgbXkgJHBy b2R1Y3REaXIgPSBGaWxlOjpTcGVjLT5jYXRkaXIoYmFzZVByb2R1Y3REaXIoKSwgY29uZmlndXJh dGlvbigpKTsK