226639 2021-06-04 04:08:13 -0700 Compile errors by unexpected values in ANGLE functions 2021-06-07 13:28:19 -0700 1 1 1 Unclassified WebKit WebGL WebKit Local Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 estea webkit-unassigned bugs-noreply dino ews-watchlist fujii graouts kbr kkinnunen kondapallykalyan webkit-bug-importer oldest_to_newest 1766730 0 estea 2021-06-04 04:08:13 -0700 ANGLE functions GetInteger64vRobustANGLE and GetInteger64i_vRobustANGLE expect a value of GLint64* aka long int * but we try to fit a pointer to a long long int. We need to fix the compile errors. 1766733 1 430567 estea 2021-06-04 04:16:40 -0700 Created attachment 430567 Patch 1767276 2 fujii 2021-06-06 18:50:15 -0700 ANGLE seems to use int64_t and uint64_t. What about changing GCGLint64 and GCGLuint64? typedef int64_t GCGLint64; typedef uint64_t GCGLuint64; 1767379 3 kkinnunen 2021-06-07 02:21:47 -0700 (In reply to Fujii Hironori from comment #2) > ANGLE seems to use int64_t and uint64_t. > What about changing GCGLint64 and GCGLuint64? > > typedef int64_t GCGLint64; > typedef uint64_t GCGLuint64; This sounds like a good solution 1767392 4 estea 2021-06-07 03:56:57 -0700 sure, I am going to update it 1767397 5 430735 estea 2021-06-07 04:25:28 -0700 Created attachment 430735 Patch 1767464 6 kbr 2021-06-07 08:53:27 -0700 The failures on mac-AS-debug-wk2 look unrelated: Application Specific Information: CRASHING TEST: /canvas/webgl/origin-clean-conformance.html Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x0000000103235374 WTFCrash + 20 1 com.apple.WebCore 0x00000001200c0e70 WTFCrashWithInfo(int, char const*, char const*, int) + 32 2 com.apple.WebCore 0x0000000121559bd4 WebCore::SharedRoutingArbitrator::endRoutingArbitrationForToken(WebCore::SharedRoutingArbitrator::Token const&) + 124 3 com.apple.WebKit 0x000000010ce7a068 WebKit::AudioSessionRoutingArbitratorProxy::endRoutingArbitration() + 68 4 com.apple.WebKit 0x000000010b7c64b4 void IPC::callMemberFunctionImpl<WebKit::AudioSessionRoutingArbitratorProxy, void (WebKit::AudioSessionRoutingArbitratorProxy::*)(), std::__1::tuple<> >(WebKit::AudioSessionRoutingArbitratorProxy*, void (WebKit::AudioSessionRoutingArbitratorProxy::*)(), std::__1::tuple<>&&, std::__1::integer_sequence<unsigned long>) + 124 5 com.apple.WebKit 0x000000010b7c5fe0 void IPC::callMemberFunction<WebKit::AudioSessionRoutingArbitratorProxy, void (WebKit::AudioSessionRoutingArbitratorProxy::*)(), std::__1::tuple<>, std::__1::integer_sequence<unsigned long> >(std::__1::tuple<>&&, WebKit::AudioSessionRoutingArbitratorProxy*, void (WebKit::AudioSessionRoutingArbitratorProxy::*)()) + 124 6 com.apple.WebKit 0x000000010b7c2a14 void IPC::handleMessage<Messages::AudioSessionRoutingArbitratorProxy::EndRoutingArbitration, WebKit::AudioSessionRoutingArbitratorProxy, void (WebKit::AudioSessionRoutingArbitratorProxy::*)()>(IPC::Decoder&, WebKit::AudioSessionRoutingArbitratorProxy*, void (WebKit::AudioSessionRoutingArbitratorProxy::*)()) + 160 7 com.apple.WebKit 0x000000010b7c2778 WebKit::AudioSessionRoutingArbitratorProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 200 8 com.apple.WebKit 0x000000010bd5f6cc IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) + 384 9 com.apple.WebKit 0x000000010cd96ac8 WebKit::AuxiliaryProcessProxy::dispatchMessage(IPC::Connection&, IPC::Decoder&) + 44 10 com.apple.WebKit 0x000000010d09600c WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 48 1767465 7 430735 kbr 2021-06-07 08:54:29 -0700 Comment on attachment 430735 Patch Looks good to me given that this change compiles. r+ 1767534 8 ews-feeder 2021-06-07 13:27:57 -0700 Committed r278571 (238569@main): <https://commits.webkit.org/238569@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430735. 1767535 9 webkit-bug-importer 2021-06-07 13:28:19 -0700 <rdar://problem/78960589> 430567 2021-06-04 04:16:40 -0700 2021-06-07 04:25:20 -0700 Patch bug-226639-20210604141638.patch text/plain 2082 estea U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NDUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTI0ZGVmMTQzMWNlNWFh ZDEwNmNjZDMwNTUyNGRmNjMxMTMzYTAyMS4uMzAxMmNlODhlYzNkY2NjMGY5YzgyYjkxNGQ1ZTZl MzgwZGRlYjc0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA2LTA0ICBFbGVu aSBNYXJpYSBTdGVhICA8ZXN0ZWFAaWdhbGlhLmNvbT4KKworICAgICAgICBDb21waWxlIGVycm9y IGJ5IHRyeWluZyB0byBmaXQgYSBHQ0dMaW50NjQqIHRvIGEgR0xpbnQ2NCoKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjYzOQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFOR0xFIGZ1bmN0aW9ucyBHZXRJ bnRlZ2VyNjR2Um9idXN0QU5HTEUgYW5kCisgICAgICAgIEdldEludGVnZXI2NGlfdlJvYnVzdEFO R0xFIGV4cGVjdCBhIHZhbHVlIG9mIEdMaW50NjQqIGFrYQorICAgICAgICBsb25nIGludCAqIGJ1 dCB3ZSB0cnkgdG8gZml0IGEgcG9pbnRlciB0byBhIGxvbmcgbG9uZyBpbnQuCisgICAgICAgIEZp eGVkIGNvbXBpbGUgZXJyb3JzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYW5nbGUv R3JhcGhpY3NDb250ZXh0R0xBTkdMRS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0Nv bnRleHRHTE9wZW5HTDo6Z2V0SW50ZWdlcjY0KToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNz Q29udGV4dEdMT3BlbkdMOjpnZXRJbnRlZ2VyNjRpKToKKwogMjAyMS0wNS0yNyAgU2VyZ2lvIFZp bGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBbY3NzLWZsZXhib3hd IFNhbml0aXplIHRoZSBhc3BlY3QgcmF0aW8gaGFuZGxpbmcgY29kZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYW5nbGUvR3JhcGhpY3NDb250ZXh0R0xBTkdM RS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hbmdsZS9HcmFwaGljc0Nv bnRleHRHTEFOR0xFLmNwcAppbmRleCBmMDViMGU1MDQzNjAyODJkZGRlMjg2YjRhZWQzYjI5Yjgw NGE0MzgwLi4yOTljNGJmZGMwOTY0ZDg4YjkzZjU4YTMyNDVkYjk1ZWZjOTIwNGNmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hbmdsZS9HcmFwaGljc0NvbnRl eHRHTEFOR0xFLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hbmds ZS9HcmFwaGljc0NvbnRleHRHTEFOR0xFLmNwcApAQCAtMTc4Myw3ICsxNzgzLDcgQEAgR0NHTGlu dDY0IEdyYXBoaWNzQ29udGV4dEdMT3BlbkdMOjpnZXRJbnRlZ2VyNjQoR0NHTGVudW0gcG5hbWUp CiAgICAgR0NHTGludDY0IHZhbHVlID0gMDsKICAgICBpZiAoIW1ha2VDb250ZXh0Q3VycmVudCgp KQogICAgICAgICByZXR1cm4gdmFsdWU7Ci0gICAgZ2w6OkdldEludGVnZXI2NHZSb2J1c3RBTkdM RShwbmFtZSwgMSwgbnVsbHB0ciwgJnZhbHVlKTsKKyAgICBnbDo6R2V0SW50ZWdlcjY0dlJvYnVz dEFOR0xFKHBuYW1lLCAxLCBudWxscHRyLCAoR0xpbnQ2NCopJnZhbHVlKTsKICAgICByZXR1cm4g dmFsdWU7CiB9CiAKQEAgLTE3OTIsNyArMTc5Miw3IEBAIEdDR0xpbnQ2NCBHcmFwaGljc0NvbnRl eHRHTE9wZW5HTDo6Z2V0SW50ZWdlcjY0aShHQ0dMZW51bSBwbmFtZSwgR0NHTHVpbnQgaW5kZXgp CiAgICAgR0NHTGludDY0IHZhbHVlID0gMDsKICAgICBpZiAoIW1ha2VDb250ZXh0Q3VycmVudCgp KQogICAgICAgICByZXR1cm4gdmFsdWU7Ci0gICAgZ2w6OkdldEludGVnZXI2NGlfdlJvYnVzdEFO R0xFKHBuYW1lLCBpbmRleCwgMSwgbnVsbHB0ciwgJnZhbHVlKTsKKyAgICBnbDo6R2V0SW50ZWdl cjY0aV92Um9idXN0QU5HTEUocG5hbWUsIGluZGV4LCAxLCBudWxscHRyLCAoR0xpbnQ2NCopJnZh bHVlKTsKICAgICByZXR1cm4gdmFsdWU7CiB9CiAK 430735 2021-06-07 04:25:28 -0700 2021-06-07 13:27:59 -0700 Patch bug-226639-20210607142526.patch text/plain 1505 estea U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NDUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTI0ZGVmMTQzMWNlNWFh ZDEwNmNjZDMwNTUyNGRmNjMxMTMzYTAyMS4uZGI5NzdlNTZhOTUxNWRhOTRiOTgzZjMxMjI4NGEx MjI1YWMxNjcwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA2LTA3ICBFbGVu aSBNYXJpYSBTdGVhICA8ZXN0ZWFAaWdhbGlhLmNvbT4KKworICAgICAgICBDb21waWxlIGVycm9y IGJ5IHRyeWluZyB0byBmaXQgYSBHQ0dMaW50NjQqIHRvIGEgR0xpbnQ2NCoKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjYzOQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFOR0xFIGZ1bmN0aW9ucyBHZXRJ bnRlZ2VyNjR2Um9idXN0QU5HTEUgYW5kCisgICAgICAgIEdldEludGVnZXI2NGlfdlJvYnVzdEFO R0xFIGV4cGVjdCBhIHZhbHVlIG9mIEdMaW50NjQqIGFrYQorICAgICAgICBsb25nIGludCAqIGJ1 dCB3ZSB0cnkgdG8gZml0IGEgcG9pbnRlciB0byBhIGxvbmcgbG9uZyBpbnQuCisgICAgICAgIEZp eGVkIGNvbXBpbGUgZXJyb3JzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhp Y3NUeXBlc0dMLmg6CisKIDIwMjEtMDUtMjcgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFy QGlnYWxpYS5jb20+CiAKICAgICAgICAgW2Nzcy1mbGV4Ym94XSBTYW5pdGl6ZSB0aGUgYXNwZWN0 IHJhdGlvIGhhbmRsaW5nIGNvZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0dyYXBoaWNzVHlwZXNHTC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvR3JhcGhpY3NUeXBlc0dMLmgKaW5kZXggM2IwNjRjM2U3NjhlY2M0YmYwMmI3NjI1YTZm MWVkYmNjODA4NzRkZC4uNTAxOTlkZGZhNTZhNmNhMWU2ZDI2MmM5OGM0NzkxNTMyMTAwY2QxOSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NUeXBl c0dMLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NUeXBl c0dMLmgKQEAgLTU1LDggKzU1LDggQEAgdHlwZWRlZiB2b2lkIEdDR0x2b2lkOwogdHlwZWRlZiBp bnRwdHJfdCBHQ0dMaW50cHRyOwogdHlwZWRlZiBpbnRwdHJfdCBHQ0dMc2l6ZWlwdHI7CiB0eXBl ZGVmIGludHB0cl90IEdDR0x2b2lkcHRyOwotdHlwZWRlZiBsb25nIGxvbmcgR0NHTGludDY0Owot dHlwZWRlZiB1bnNpZ25lZCBsb25nIGxvbmcgR0NHTHVpbnQ2NDsKK3R5cGVkZWYgaW50NjRfdCBH Q0dMaW50NjQ7Cit0eXBlZGVmIHVpbnQ2NF90IEdDR0x1aW50NjQ7CiAKIHR5cGVkZWYgR0NHTHVp bnQgUGxhdGZvcm1HTE9iamVjdDsKIAo=