226638 2021-06-04 03:01:55 -0700 Implement FetchEvent.replacesClientId 2023-11-12 07:16:57 -0800 1 1 1 Unclassified WebKit Service Workers Safari Technology Preview Unspecified Unspecified NEW InRadar, WPTImpact P2 Normal --- 1 jaffathecake webkit-unassigned ahmad.saleem792 gregory.terzian mail philip simon.fraser webkit-bug-importer youennf oldest_to_newest 1766725 0 jaffathecake 2021-06-04 03:01:55 -0700 This was renamed in 2018 (https://github.com/w3c/ServiceWorker/pull/1333) but no bug was filed with WebKit, sorry about that. Anyway, this is that bug. I don't expect the rename to cause problems in the wild. Test to fail if targetClientId is present https://github.com/web-platform-tests/wpt/pull/29213. 1766752 1 philip 2021-06-04 07:08:23 -0700 As part of sorting out many errors in the browser compat data for FetchEvent in https://github.com/mdn/browser-compat-data/pull/10774, I noticed that no browser has shipped replacesClientId yet. 1768902 2 webkit-bug-importer 2021-06-11 03:02:29 -0700 <rdar://problem/79189580> 1829760 3 youennf 2022-01-11 04:21:08 -0800 WebKit exposes targetClientId so I guess we should do the migration to replacesClientId even if no other browser supports it. We can deal with this as part of bug 190313 1874290 4 gsnedders 2022-06-06 06:44:34 -0700 targetClientId was removed in bug 235107, but replacesClientId wasn't implemented. 1949409 5 gregory.terzian 2023-04-18 02:27:48 -0700 Can I please tackle this one? I've tried to follow the flow; is it correct that one should add a String, say "m_replacesClientIdentifier", to the "NetworkResourceLoader" in the network process, and do something similar to what is currently done with "m_resultingClientIdentifier"(propagate it all the way to where the "FetchEvent" is created in "ServiceWorkerFetch" within WebCore)? 1949410 6 youennf 2023-04-18 02:36:53 -0700 You are more than welcome to contribute :) This bug might not be the easiest bug to tackle if this is your first WebKit contribution given there is probably few existing tests and no browser is implementing it yet: https://wpt.fyi/results/service-workers/idlharness.https.any.serviceworker.html?label=experimental&label=master&aligned The principle would be to add to new ScriptExecutionContextIdentifier member to either FetchOptions or ResourceLoaderOptions. See resultingClientId as an example. 1949658 7 gregory.terzian 2023-04-18 22:04:33 -0700 Great! A quick search indeed did not reveal any wpt test, but there is again the example of testing for the presence of resultingClientId(https://github.com/web-platform-tests/wpt/blob/0a40de7a4db9e52cdb0fc436173640756740c9e3/service-workers/service-worker/fetch-event.https.html#L129) Thanks for the additional info, I will start looking into this. 1950935 8 gregory.terzian 2023-04-24 20:38:25 -0700 Pull request: https://github.com/WebKit/WebKit/pull/13130