226635 2021-06-04 02:46:36 -0700 EventSource.constructor throws an exception when the url param is an empty string 2021-06-11 09:15:24 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zyscoder achristensen achristensen bugs-noreply darin mcatanzaro sam webkit-bug-importer youennf ysuzuki oldest_to_newest 1766722 0 zyscoder 2021-06-04 02:46:36 -0700 Steps to reproduce: (1) Open a tab and navigate to any URL; (2) Run the following code in the Console of Devtools: ``` new EventSource("") ``` (3) Then this code would throw a SyntaxError exception. Actual results: This code would throw a SyntaxError exception: `SyntaxError: The string did not match the expected pattern.` Expected results: As https://html.spec.whatwg.org/multipage/server-sent-events.html#dom-eventsource says, when the URL param is an empty string, it should be parsed as a relative URL to the API's URL. In fact, Firefox works as the spec says, and Chrome has fixed this problem following the spec nowadays too. 1766868 1 430597 achristensen 2021-06-04 12:08:52 -0700 Created attachment 430597 Patch 1766869 2 achristensen 2021-06-04 12:09:11 -0700 Seems like an easy enough fix. Let's see if we already have tests that cover this. 1766872 3 430597 ysuzuki 2021-06-04 12:16:11 -0700 Comment on attachment 430597 Patch r=me 1766969 4 430626 achristensen 2021-06-04 15:56:50 -0700 Created attachment 430626 Patch 1767325 5 darin 2021-06-06 23:55:47 -0700 Looks like Yusuke already reviews, so don’t really need my review too, but I saw a review? 1768898 6 webkit-bug-importer 2021-06-11 02:47:16 -0700 <rdar://problem/79189234> 1768960 7 achristensen 2021-06-11 09:15:24 -0700 r278763 430597 2021-06-04 12:08:52 -0700 2021-06-04 15:56:47 -0700 Patch bug-226635-20210604120851.patch text/plain 1284 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3ODQ4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIxLTA2LTA0ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRXZlbnRTb3Vy Y2UuY29uc3RydWN0b3IgdGhyb3dzIGFuIGV4Y2VwdGlvbiB3aGVuIHRoZSB1cmwgcGFyYW0gaXMg YW4gZW1wdHkgc3RyaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMjY2MzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHBhZ2UvRXZlbnRTb3VyY2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRT b3VyY2U6OmNyZWF0ZSk6CisKIDIwMjEtMDYtMDQgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxl LmNvbT4KIAogICAgICAgICBET01GaWxlU3lzdGVtOjpsaXN0RGlyZWN0b3J5KCkgZmFpbHMgdG8g cHJvdGVjdCB8dGhpc3wgd2hlbiBnb2luZyB0byB0aGUgYmFja2dyb3VuZCB0aHJlYWQKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRTb3VyY2UuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3BhZ2UvRXZlbnRTb3VyY2UuY3BwCShyZXZpc2lvbiAyNzg0NzYpCisrKyBTb3Vy Y2UvV2ViQ29yZS9wYWdlL0V2ZW50U291cmNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjYsOSAr NjYsNiBAQCBpbmxpbmUgRXZlbnRTb3VyY2U6OkV2ZW50U291cmNlKFNjcmlwdEV4CiAKIEV4Y2Vw dGlvbk9yPFJlZjxFdmVudFNvdXJjZT4+IEV2ZW50U291cmNlOjpjcmVhdGUoU2NyaXB0RXhlY3V0 aW9uQ29udGV4dCYgY29udGV4dCwgY29uc3QgU3RyaW5nJiB1cmwsIGNvbnN0IEluaXQmIGV2ZW50 U291cmNlSW5pdCkKIHsKLSAgICBpZiAodXJsLmlzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJuIEV4 Y2VwdGlvbiB7IFN5bnRheEVycm9yIH07Ci0KICAgICBVUkwgZnVsbFVSTCA9IGNvbnRleHQuY29t cGxldGVVUkwodXJsKTsKICAgICBpZiAoIWZ1bGxVUkwuaXNWYWxpZCgpKQogICAgICAgICByZXR1 cm4gRXhjZXB0aW9uIHsgU3ludGF4RXJyb3IgfTsK 430626 2021-06-04 15:56:50 -0700 2021-06-06 23:55:21 -0700 Patch bug-226635-20210604155649.patch text/plain 3757 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3ODQ4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIxLTA2LTA0ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRXZlbnRTb3Vy Y2UuY29uc3RydWN0b3IgdGhyb3dzIGFuIGV4Y2VwdGlvbiB3aGVuIHRoZSB1cmwgcGFyYW0gaXMg YW4gZW1wdHkgc3RyaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMjY2MzUKKworICAgICAgICBSZXZpZXdlZCBieSBZdXN1a2UgU3V6dWtpLgorCisg ICAgICAgICogcGFnZS9FdmVudFNvdXJjZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFdmVudFNv dXJjZTo6Y3JlYXRlKToKKwogMjAyMS0wNi0wNCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUu Y29tPgogCiAgICAgICAgIERPTUZpbGVTeXN0ZW06Omxpc3REaXJlY3RvcnkoKSBmYWlscyB0byBw cm90ZWN0IHx0aGlzfCB3aGVuIGdvaW5nIHRvIHRoZSBiYWNrZ3JvdW5kIHRocmVhZApJbmRleDog U291cmNlL1dlYkNvcmUvcGFnZS9FdmVudFNvdXJjZS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcGFnZS9FdmVudFNvdXJjZS5jcHAJKHJldmlzaW9uIDI3ODQ3NikKKysrIFNvdXJj ZS9XZWJDb3JlL3BhZ2UvRXZlbnRTb3VyY2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02Niw5ICs2 Niw2IEBAIGlubGluZSBFdmVudFNvdXJjZTo6RXZlbnRTb3VyY2UoU2NyaXB0RXgKIAogRXhjZXB0 aW9uT3I8UmVmPEV2ZW50U291cmNlPj4gRXZlbnRTb3VyY2U6OmNyZWF0ZShTY3JpcHRFeGVjdXRp b25Db250ZXh0JiBjb250ZXh0LCBjb25zdCBTdHJpbmcmIHVybCwgY29uc3QgSW5pdCYgZXZlbnRT b3VyY2VJbml0KQogewotICAgIGlmICh1cmwuaXNFbXB0eSgpKQotICAgICAgICByZXR1cm4gRXhj ZXB0aW9uIHsgU3ludGF4RXJyb3IgfTsKLQogICAgIFVSTCBmdWxsVVJMID0gY29udGV4dC5jb21w bGV0ZVVSTCh1cmwpOwogICAgIGlmICghZnVsbFVSTC5pc1ZhbGlkKCkpCiAgICAgICAgIHJldHVy biBFeGNlcHRpb24geyBTeW50YXhFcnJvciB9OwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMjc4NTA5KQor KysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMjEtMDYtMDQgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4K KworICAgICAgICBFdmVudFNvdXJjZS5jb25zdHJ1Y3RvciB0aHJvd3MgYW4gZXhjZXB0aW9uIHdo ZW4gdGhlIHVybCBwYXJhbSBpcyBhbiBlbXB0eSBzdHJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjYzNQorCisgICAgICAgIFJldmlld2VkIGJ5 IFl1c3VrZSBTdXp1a2kuCisKKyAgICAgICAgKiBmYXN0L2V2ZW50c291cmNlL2V2ZW50c291cmNl LWNvbnN0cnVjdG9yLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2V2ZW50c291cmNlL2V2 ZW50c291cmNlLWNvbnN0cnVjdG9yLmh0bWw6CisKIDIwMjEtMDYtMDQgIEJyYWR5IEVpZHNvbiAg PGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIEVuZm9yY2UgYSBxdW90YSBpbiB3aW5kb3cu c2Vzc2lvblN0b3JhZ2UKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZXZlbnRzb3VyY2UvZXZlbnRz b3VyY2UtY29uc3RydWN0b3ItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2Zhc3QvZXZlbnRzb3VyY2UvZXZlbnRzb3VyY2UtY29uc3RydWN0b3ItZXhwZWN0ZWQudHh0CShy ZXZpc2lvbiAyNzg0NzYpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50c291cmNlL2V2ZW50c291 cmNlLWNvbnN0cnVjdG9yLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSw3ICsxLDcg QEAKIFRlc3QgRXZlbnRTb3VyY2UgY29uc3RydWN0b3IgZnVuY3Rpb25hbGl0eS4gU2hvdWxkIHBy aW50IGEgc2VyaWVzIG9mIFBBU1MgbWVzc2FnZXMgZm9sbG93ZWQgYnkgRE9ORS4KIAogUEFTUzog bWlzc2luZyBhcmd1bWVudCB0byBFdmVudFNvdXJjZSBjb25zdHJ1Y3RvciByZXN1bHRlZCBpbiBh biBleGNlcHRpb24gKFR5cGVFcnJvcjogTm90IGVub3VnaCBhcmd1bWVudHMpCi1QQVNTOiBwYXNz aW5nIGFuIGVtcHR5IHN0cmluZyB0byB0aGUgRXZlbnRTb3VyY2UgY29uc3RydWN0b3IgcmVzdWx0 ZWQgaW4gYW4gZXhjZXB0aW9uIChTeW50YXhFcnJvcjogVGhlIHN0cmluZyBkaWQgbm90IG1hdGNo IHRoZSBleHBlY3RlZCBwYXR0ZXJuLikKK1BBU1M6IG5vIGV4Y2VwdGlvbiB3aGVuIHBhc3Npbmcg YW4gZW1wdHkgc3RyaW5nIHRvIHRoZSBFdmVudFNvdXJjZSBjb25zdHJ1Y3RvcgogUEFTUzogcGFz c2luZyBhbiBpbnZhbGlkIFVSTCB0byB0aGUgRXZlbnRTb3VyY2UgY29uc3RydWN0b3IgcmVzdWx0 ZWQgaW4gYW4gZXhjZXB0aW9uIChTeW50YXhFcnJvcjogVGhlIHN0cmluZyBkaWQgbm90IG1hdGNo IHRoZSBleHBlY3RlZCBwYXR0ZXJuLikKIFBBU1M6IG5vIGV4Y2VwdGlvbiB3aGVuIHBhc3Npbmcg YSBzZWNvbmQgYXJndW1lbnQgdG8gdGhlIEV2ZW50U291cmNlIGNvbnN0cnVjdG9yCiBET05FCklu ZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50c291cmNlL2V2ZW50c291cmNlLWNvbnN0cnVjdG9y Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9ldmVudHNvdXJjZS9ldmVudHNv dXJjZS1jb25zdHJ1Y3Rvci5odG1sCShyZXZpc2lvbiAyNzg0NzYpCisrKyBMYXlvdXRUZXN0cy9m YXN0L2V2ZW50c291cmNlL2V2ZW50c291cmNlLWNvbnN0cnVjdG9yLmh0bWwJKHdvcmtpbmcgY29w eSkKQEAgLTIyLDEwICsyMiwxMCBAQCBjYXRjaCAoZXgpIHsKIAogdHJ5IHsKICAgICBuZXcgRXZl bnRTb3VyY2UoIiIpOwotICAgIGxvZygiRkFJTDogbm8gZXhjZXB0aW9uIHdoZW4gcGFzc2luZyBh biBlbXB0eSBzdHJpbmcgdG8gdGhlIEV2ZW50U291cmNlIGNvbnN0cnVjdG9yIik7CisgICAgbG9n KCJQQVNTOiBubyBleGNlcHRpb24gd2hlbiBwYXNzaW5nIGFuIGVtcHR5IHN0cmluZyB0byB0aGUg RXZlbnRTb3VyY2UgY29uc3RydWN0b3IiKTsKIH0KIGNhdGNoIChleCkgewotICAgIGxvZygiUEFT UzogcGFzc2luZyBhbiBlbXB0eSBzdHJpbmcgdG8gdGhlIEV2ZW50U291cmNlIGNvbnN0cnVjdG9y IHJlc3VsdGVkIGluIGFuIGV4Y2VwdGlvbiAoIiArIGV4ICsgIikiKTsKKyAgICBsb2coIkZBSUw6 IHBhc3NpbmcgYW4gZW1wdHkgc3RyaW5nIHRvIHRoZSBFdmVudFNvdXJjZSBjb25zdHJ1Y3RvciBy ZXN1bHRlZCBpbiBhbiBleGNlcHRpb24gKCIgKyBleCArICIpIik7CiB9CiAKIHRyeSB7Cg==