<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>226627</bug_id>
          
          <creation_ts>2021-06-03 23:20:13 -0700</creation_ts>
          <short_desc>[GTK] Support color-scheme</short_desc>
          <delta_ts>2021-07-09 05:01:20 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>208204</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Milan Crha">mcrha</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>alicem</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1766685</commentid>
    <comment_count>0</comment_count>
      <attachid>430550</attachid>
    <who name="Milan Crha">mcrha</who>
    <bug_when>2021-06-03 23:20:13 -0700</bug_when>
    <thetext>Created attachment 430550
a.html

Coming from a downstream bug report:
https://gitlab.gnome.org/GNOME/evolution/-/issues/1522

There are cases where form elements should be better drawn with the theme color, rather than &quot;always light theme&quot;.

Michael also pointer to bug #197947 there.

Reproducer:

a) get the attached a.html
b) execute:

   GTK_THEME=Adwaita-dark /usr/libexec/webkit2gtk-4.0/MiniBrowser /tmp/a.html

the buttons (and the content) is in the light theme, even it would be better in the dark theme. At least the buttons.

I also tried to set content=&quot;dark&quot; in the &lt;meta&gt;, but it didn&apos;t change anything (I thought it&apos;ll force the dark theme).

This is with webkit2gtk3-2.32.1-1.fc34.x86_64.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1766746</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-06-04 06:38:59 -0700</bug_when>
    <thetext>Basically in bug #197947 we made normal web content that doesn&apos;t know about dark mode work properly, and we made web content that uses only prefers-color-scheme work properly. But we don&apos;t support color-scheme at all. I think that&apos;s HAVE(OS_DARK_MODE_SUPPORT) which was disabled in bug #197947. We probably want to bring that back.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1775954</commentid>
    <comment_count>2</comment_count>
    <who name="Alice Mikhaylenko">alicem</who>
    <bug_when>2021-07-09 04:16:33 -0700</bug_when>
    <thetext>Duplicate of https://bugs.webkit.org/show_bug.cgi?id=208204?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1775965</commentid>
    <comment_count>3</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-07-09 05:01:20 -0700</bug_when>
    <thetext>Yes.

*** This bug has been marked as a duplicate of bug 208204 ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>430550</attachid>
            <date>2021-06-03 23:20:13 -0700</date>
            <delta_ts>2021-06-03 23:20:13 -0700</delta_ts>
            <desc>a.html</desc>
            <filename>a.html</filename>
            <type>text/html</type>
            <size>152</size>
            <attacher name="Milan Crha">mcrha</attacher>
            
              <data encoding="base64">PGh0bWw+PGhlYWQ+CjxtZXRhIG5hbWU9ImNvbG9yLXNjaGVtZSIgY29udGVudD0iZGFyayBsaWdo
dCI+CjwvaGVhZD4KPGJvZHk+CjxkaXY+IHRleHQgPGJ1dHRvbiB0eXBlPSJidXR0b24iPmJ1dHRp
ZTwvYnV0dG9uPiB0ZXh0IDwvZGl2Pgo8L2JvZHk+PC9odG1sPgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>