22662 2008-12-04 14:54:20 -0800 RenderThemeWx reports incorrectly that it can style controls 2008-12-04 17:59:39 -0800 1 1 1 Unclassified WebKit WebKit wx 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 kevinwatters webkit-unassigned oldest_to_newest 101401 0 kevinwatters 2008-12-04 14:54:20 -0800 RenderThemeWx's isControlStyled method is delegating to RenderTheme -- but until we have fleshed out the implementation of CSS modified "native" controls this results in incorrect layout of buttons and other form controls. 101402 1 25755 kevinwatters 2008-12-04 14:54:57 -0800 Created attachment 25755 This patch disables styled RenderTheme controls until we can flesh out the implementation. 101428 2 kevino 2008-12-04 17:57:24 -0800 Landed in r39008, thanks! 101429 3 kevino 2008-12-04 17:59:39 -0800 (In reply to comment #2) > Landed in r39008, thanks! > Sorry, typo. Actual commit was r39011. 25755 2008-12-04 14:54:57 -0800 2008-12-04 16:05:04 -0800 This patch disables styled RenderTheme controls until we can flesh out the implementation. disablestyledcontrols.patch text/plain 1684 kevinwatters SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODk5OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDgtMTItMDQgIEtldmluIFdhdHRlcnMgIDxrZXZpbndhdHRlcnNA Z21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFR1cm4gb2ZmIHN0eWxlZCBjb250cm9scyB1bnRpbCB3ZSBjYW4gaW1wbGVtZW50IHRoZW0g cHJvcGVybHkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93eC9SZW5kZXJUaGVtZVd4LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lV3g6OmlzQ29udHJvbFN0eWxlZCk6CisKIDIwMDgt MTEtMTMgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBhIGJ1 ZyBpbiBTY3JvbGxWaWV3J3MgcmVmYWN0b3JpbmcuICBBbiBpc1Zpc2libGUgY2hlY2sgc2hvdWxk IGhhdmUgYmVlbiBpc1NlbGZWaXNpYmxlLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS93eC9SZW5k ZXJUaGVtZVd4LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL3d4L1JlbmRlclRo ZW1lV3guY3BwCShyZXZpc2lvbiAzODk5OCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vd3gvUmVuZGVy VGhlbWVXeC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzMCw3ICsxMzAsMTIgQEAKICAgICBpZiAo c3R5bGUtPmFwcGVhcmFuY2UoKSA9PSBUZXh0RmllbGRQYXJ0IHx8IHN0eWxlLT5hcHBlYXJhbmNl KCkgPT0gVGV4dEFyZWFQYXJ0KQogICAgICAgICByZXR1cm4gc3R5bGUtPmJvcmRlcigpICE9IGJv cmRlcjsKIAotICAgIHJldHVybiBSZW5kZXJUaGVtZTo6aXNDb250cm9sU3R5bGVkKHN0eWxlLCBi b3JkZXIsIGJhY2tncm91bmQsIGJhY2tncm91bmRDb2xvcik7CisgICAgLy8gTm9ybWFsbHkgQ1NT IGNhbiBiZSB1c2VkIHRvIHNldCBwcm9wZXJ0aWVzIG9mIGZvcm0gY29udHJvbHMgKHN1Y2ggYXMg YWRkaW5nIGEgYmFja2dyb3VuZCBiaXRtYXApLgorICAgIC8vIEhvd2V2ZXIsIGZvciB0aGlzIHRv IHdvcmsgUmVuZGVyVGhlbWVXeCBuZWVkcyB0byBhZGp1c3QgdW5jdXN0b21pemVkIGVsZW1lbnRz IChlLmcuIGJ1dHRvbnMpIHRvIHJlZmxlY3QgdGhlCisgICAgLy8gY2hhbmdlcyBtYWRlIGJ5IENT Uy4gU2luY2Ugd2UgZG9uJ3QgZG8gdGhhdCByaWdodCBub3csIHRoZSBuYXRpdmUgcGFydHMgb2Yg Zm9ybSBlbGVtZW50cyBhcHBlYXIgaW4gb2RkIHBsYWNlcy4gCisgICAgLy8gVW50aWwgd2UgaGF2 ZSB0aW1lIHRvIGltcGxlbWVudCB0aGF0IHN1cHBvcnQsIHdlIHJldHVybiBmYWxzZSBoZXJlLCBz byB0aGF0IHdlIGlnbm9yZSBjdXN0b21pemF0aW9ucyAKKyAgICAvLyBhbmQgYWx3YXlzIHVzZSB0 aGUgbmF0aXZlIHRoZW1lIGRyYXdpbmcgdG8gZHJhdyBmb3JtIGNvbnRyb2xzLgorICAgIHJldHVy biBmYWxzZTsKIH0KIAogdm9pZCBSZW5kZXJUaGVtZVd4OjphZGp1c3RSZXBhaW50UmVjdChjb25z dCBSZW5kZXJPYmplY3QqIG8sIEludFJlY3QmIHIpCg==