226613 2021-06-03 17:45:36 -0700 [Cairo] Fix Path::boundingRectSlowCase when the path is a single MoveTo 2021-06-10 13:58:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 crzwdjk webkit-unassigned cgarcia fujii webkit-bug-importer oldest_to_newest 1766608 0 crzwdjk 2021-06-03 17:45:36 -0700 [Cairo] Fix Path::boundingRectSlowCase when the path is a single MoveTo 1766610 1 430520 crzwdjk 2021-06-03 17:46:20 -0700 Created attachment 430520 Patch 1766621 2 fujii 2021-06-03 18:09:38 -0700 I have questions. Which benchmark are you using? How does it improve? Why is it using the single move paths? Why is cairo_path_extents slower for the case? 1766625 3 fujii 2021-06-03 18:35:18 -0700 Oops. I misread and misunderstood. This is not a speed-up, but a bug fix. Do you have a test case? 1766699 4 430520 cgarcia 2021-06-04 00:43:14 -0700 Comment on attachment 430520 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430520&action=review > Source/WebCore/ChangeLog:7 > + Could you explain here what's wrong exactly. Are we rendering anything incorrectly? does this fix any test? or can we add a new one? > Source/WebCore/platform/graphics/cairo/PathCairo.cpp:414 > + if (m_elements && m_elements.value().size() == 1 > + && m_elements.value()[0].type == PathElement::Type::MoveToPoint) { This could be a single line. 1767277 5 430520 fujii 2021-06-06 18:55:00 -0700 Comment on attachment 430520 Patch r- for comment#4. 1767446 6 crzwdjk 2021-06-07 08:21:32 -0700 Sorry, I should have been clearer. This fixes the new fast/svg/bounding-rect-for-path-with-only-move-command.html test which was added recently, I will add that to the changelog, and fix the formatting issue. Thanks for taking a look. 1768245 7 430981 crzwdjk 2021-06-09 11:16:18 -0700 Created attachment 430981 Patch 1768306 8 431000 crzwdjk 2021-06-09 13:08:10 -0700 Created attachment 431000 Patch 1768719 9 ews-feeder 2021-06-10 13:57:04 -0700 Committed r278730 (238693@main): <https://commits.webkit.org/238693@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431000. 1768720 10 webkit-bug-importer 2021-06-10 13:58:17 -0700 <rdar://problem/79158727> 430520 2021-06-03 17:46:20 -0700 2021-06-09 11:16:15 -0700 Patch bug-226613-20210603204619.patch text/plain 1517 crzwdjk U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MzY0CmRpZmYgLS1naXQgU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0ZWY2NGFkOGJhNzdiOTY1NmFk YWExMmI3OTYwY2MzMGYyYTQzNWZmLi5hOTBmODM0ZWNiMGI1MDBmMDUxNTU3Y2I1NDczNGY5M2E0 ZGFhMDk3IDEwMDY0NAotLS0gU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMS0wNi0wMyAgQXJjYWR5IEdvbGRt aW50cy1PcmxvdiAgPGFnb2xkbWludHNAaWdhbGlhLmNvbT4KKworICAgICAgICBbQ2Fpcm9dIEZp eCBQYXRoOjpib3VuZGluZ1JlY3RTbG93Q2FzZSB3aGVuIHRoZSBwYXRoIGlzIGEgc2luZ2xlIE1v dmVUbworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2 NjEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9jYWlyby9QYXRoQ2Fpcm8uY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UGF0aDo6Ym91bmRpbmdSZWN0U2xvd0Nhc2UgY29uc3QpOgorCiAyMDIxLTA2LTAyICBTYW0gV2Vp bmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3IgInJlbGF0 aXZlIGNvbG9yIHN5bnRheCIgZm9yIGNvbG9yKCkKZGlmZiAtLWdpdCBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jYWlyby9QYXRoQ2Fpcm8uY3BwIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NhaXJvL1BhdGhDYWlyby5jcHAKaW5kZXggNjNlYWJjYjQwODBmZjljYThi YWJhZjFjOGYxZTdlNWU2YTM2N2EwNS4uYWI2MDM3YjZlMTQxNzc2NjM3MmI0ODRiODY1ZDUxOWE5 ZmU2NTAxMiAxMDA2NDQKLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJv L1BhdGhDYWlyby5jcHAKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJv L1BhdGhDYWlyby5jcHAKQEAgLTQxMCw2ICs0MTAsMTEgQEAgdm9pZCBQYXRoOjpjbG9zZVN1YnBh dGgoKQogRmxvYXRSZWN0IFBhdGg6OmJvdW5kaW5nUmVjdFNsb3dDYXNlKCkgY29uc3QKIHsKICAg ICBkb3VibGUgeDAsIHgxLCB5MCwgeTE7CisgICAgaWYgKG1fZWxlbWVudHMgJiYgbV9lbGVtZW50 cy52YWx1ZSgpLnNpemUoKSA9PSAxCisgICAgICAgICYmIG1fZWxlbWVudHMudmFsdWUoKVswXS50 eXBlID09IFBhdGhFbGVtZW50OjpUeXBlOjpNb3ZlVG9Qb2ludCkgeworICAgICAgICBGbG9hdFBv aW50IHAgPSBtX2VsZW1lbnRzLnZhbHVlKClbMF0ucG9pbnRzWzBdOworICAgICAgICByZXR1cm4g RmxvYXRSZWN0KHAueCgpLCBwLnkoKSwgMCwgMCk7CisgICAgfQogICAgIGNhaXJvX3BhdGhfZXh0 ZW50cyhtX3BhdGguZ2V0KCksICZ4MCwgJnkwLCAmeDEsICZ5MSk7CiAgICAgcmV0dXJuIEZsb2F0 UmVjdCh4MCwgeTAsIHgxIC0geDAsIHkxIC0geTApOwogfQo= 430981 2021-06-09 11:16:18 -0700 2021-06-09 13:08:02 -0700 Patch bug-226613-20210609141618.patch text/plain 1791 crzwdjk U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MzY0CmRpZmYgLS1naXQgU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0ZWY2NGFkOGJhNzdiOTY1NmFk YWExMmI3OTYwY2MzMGYyYTQzNWZmLi4xMmU2NTI0MjRlM2U0MjRlNzc3MDRhN2Q1NTc5ZmI4MWUx ZTJjNGQyIDEwMDY0NAotLS0gU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAyMS0wNi0wOSAgQXJjYWR5IEdvbGRt aW50cy1PcmxvdiAgPGFnb2xkbWludHNAaWdhbGlhLmNvbT4KKworICAgICAgICBbQ2Fpcm9dIEZp eCBQYXRoOjpib3VuZGluZ1JlY3RTbG93Q2FzZSB3aGVuIHRoZSBwYXRoIGlzIGEgc2luZ2xlIE1v dmVUbworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2 NjEzCisKKyAgICAgICAgQ2Fpcm8gc2F5cyB0aGVyZSBpcyBubyBib3VuZGluZyByZWN0YW5nbGUg aW4gdGhpcyBjYXNlLCB3aGVyZWFzIHRoZSBTVkcKKyAgICAgICAgc3RhbmRhcmQgc2F5cyB0aGVy ZSBpdCBzaG91bGQgYmUgYSB6ZXJvLXNpemUgcmVjdGFuZ2xlIGF0IHRoZSBtb3ZlZC10bworICAg ICAgICBwb2ludC4gVGhpcyBmaXhlcyB0aGUgcmVjZW50bHkgYWRkZWQgdGVzdAorICAgICAgICBm YXN0L3N2Zy9ib3VuZGluZy1yZWN0LWZvci1wYXRoLXdpdGgtb25seS1tb3ZlLWNvbW1hbmQuaHRt bAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGF0aENhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBh dGg6OmJvdW5kaW5nUmVjdFNsb3dDYXNlIGNvbnN0KToKKwogMjAyMS0wNi0wMiAgU2FtIFdlaW5p ZyAgPHdlaW5pZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHN1cHBvcnQgZm9yICJyZWxhdGl2 ZSBjb2xvciBzeW50YXgiIGZvciBjb2xvcigpCmRpZmYgLS1naXQgU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGF0aENhaXJvLmNwcCBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jYWlyby9QYXRoQ2Fpcm8uY3BwCmluZGV4IDYzZWFiY2I0MDgwZmY5Y2E4YmFi YWYxYzhmMWU3ZTVlNmEzNjdhMDUuLmVjODhjMzViNTc1ZTA2MTVhODVkMTdiN2FmNWVlMTViZGQ5 MmVkYTkgMTAwNjQ0Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9Q YXRoQ2Fpcm8uY3BwCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9Q YXRoQ2Fpcm8uY3BwCkBAIC00MTAsNiArNDEwLDEwIEBAIHZvaWQgUGF0aDo6Y2xvc2VTdWJwYXRo KCkKIEZsb2F0UmVjdCBQYXRoOjpib3VuZGluZ1JlY3RTbG93Q2FzZSgpIGNvbnN0CiB7CiAgICAg ZG91YmxlIHgwLCB4MSwgeTAsIHkxOworICAgIGlmIChtX2VsZW1lbnRzICYmIG1fZWxlbWVudHMu dmFsdWUoKS5zaXplKCkgPT0gMSAmJiBtX2VsZW1lbnRzLnZhbHVlKClbMF0udHlwZSA9PSBQYXRo RWxlbWVudDo6VHlwZTo6TW92ZVRvUG9pbnQpIHsKKyAgICAgICAgRmxvYXRQb2ludCBwID0gbV9l bGVtZW50cy52YWx1ZSgpWzBdLnBvaW50c1swXTsKKyAgICAgICAgcmV0dXJuIEZsb2F0UmVjdChw LngoKSwgcC55KCksIDAsIDApOworICAgIH0KICAgICBjYWlyb19wYXRoX2V4dGVudHMobV9wYXRo LmdldCgpLCAmeDAsICZ5MCwgJngxLCAmeTEpOwogICAgIHJldHVybiBGbG9hdFJlY3QoeDAsIHkw LCB4MSAtIHgwLCB5MSAtIHkwKTsKIH0K 431000 2021-06-09 13:08:10 -0700 2021-06-10 13:57:04 -0700 Patch bug-226613-20210609160810.patch text/plain 1791 crzwdjk U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MzY0CmRpZmYgLS1naXQgU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0ZWY2NGFkOGJhNzdiOTY1NmFk YWExMmI3OTYwY2MzMGYyYTQzNWZmLi4xMmU2NTI0MjRlM2U0MjRlNzc3MDRhN2Q1NTc5ZmI4MWUx ZTJjNGQyIDEwMDY0NAotLS0gU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAyMS0wNi0wOSAgQXJjYWR5IEdvbGRt aW50cy1PcmxvdiAgPGFnb2xkbWludHNAaWdhbGlhLmNvbT4KKworICAgICAgICBbQ2Fpcm9dIEZp eCBQYXRoOjpib3VuZGluZ1JlY3RTbG93Q2FzZSB3aGVuIHRoZSBwYXRoIGlzIGEgc2luZ2xlIE1v dmVUbworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2 NjEzCisKKyAgICAgICAgQ2Fpcm8gc2F5cyB0aGVyZSBpcyBubyBib3VuZGluZyByZWN0YW5nbGUg aW4gdGhpcyBjYXNlLCB3aGVyZWFzIHRoZSBTVkcKKyAgICAgICAgc3RhbmRhcmQgc2F5cyB0aGVy ZSBpdCBzaG91bGQgYmUgYSB6ZXJvLXNpemUgcmVjdGFuZ2xlIGF0IHRoZSBtb3ZlZC10bworICAg ICAgICBwb2ludC4gVGhpcyBmaXhlcyB0aGUgcmVjZW50bHkgYWRkZWQgdGVzdAorICAgICAgICBm YXN0L3N2Zy9ib3VuZGluZy1yZWN0LWZvci1wYXRoLXdpdGgtb25seS1tb3ZlLWNvbW1hbmQuaHRt bAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGF0aENhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBh dGg6OmJvdW5kaW5nUmVjdFNsb3dDYXNlIGNvbnN0KToKKwogMjAyMS0wNi0wMiAgU2FtIFdlaW5p ZyAgPHdlaW5pZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHN1cHBvcnQgZm9yICJyZWxhdGl2 ZSBjb2xvciBzeW50YXgiIGZvciBjb2xvcigpCmRpZmYgLS1naXQgU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2Fpcm8vUGF0aENhaXJvLmNwcCBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jYWlyby9QYXRoQ2Fpcm8uY3BwCmluZGV4IDYzZWFiY2I0MDgwZmY5Y2E4YmFi YWYxYzhmMWU3ZTVlNmEzNjdhMDUuLmVjODhjMzViNTc1ZTA2MTVhODVkMTdiN2FmNWVlMTViZGQ5 MmVkYTkgMTAwNjQ0Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9Q YXRoQ2Fpcm8uY3BwCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9Q YXRoQ2Fpcm8uY3BwCkBAIC00MTAsNiArNDEwLDEwIEBAIHZvaWQgUGF0aDo6Y2xvc2VTdWJwYXRo KCkKIEZsb2F0UmVjdCBQYXRoOjpib3VuZGluZ1JlY3RTbG93Q2FzZSgpIGNvbnN0CiB7CiAgICAg ZG91YmxlIHgwLCB4MSwgeTAsIHkxOworICAgIGlmIChtX2VsZW1lbnRzICYmIG1fZWxlbWVudHMu dmFsdWUoKS5zaXplKCkgPT0gMSAmJiBtX2VsZW1lbnRzLnZhbHVlKClbMF0udHlwZSA9PSBQYXRo RWxlbWVudDo6VHlwZTo6TW92ZVRvUG9pbnQpIHsKKyAgICAgICAgRmxvYXRQb2ludCBwID0gbV9l bGVtZW50cy52YWx1ZSgpWzBdLnBvaW50c1swXTsKKyAgICAgICAgcmV0dXJuIEZsb2F0UmVjdChw LngoKSwgcC55KCksIDAsIDApOworICAgIH0KICAgICBjYWlyb19wYXRoX2V4dGVudHMobV9wYXRo LmdldCgpLCAmeDAsICZ5MCwgJngxLCAmeTEpOwogICAgIHJldHVybiBGbG9hdFJlY3QoeDAsIHkw LCB4MSAtIHgwLCB5MSAtIHkwKTsKIH0K