226604 2021-06-03 15:01:03 -0700 DFG should eliminate obvious store barriers 2021-06-03 15:29:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo fpizlo ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1766547 0 fpizlo 2021-06-03 15:01:03 -0700 We have a store barrier elimination strategy mostly based on "clustering" -- moving the barriers to the point where they will actually be meaningful. Unfortunately, we have PutByOffset listed as DoesGC, so we will not eliminate any store barriers around sequences of PutByOffsets. This appears to be the case because PutByOffset was accidentally added to the DoesGC list in r240991. 1766549 1 430504 fpizlo 2021-06-03 15:04:18 -0700 Created attachment 430504 the patch 1766551 2 430504 mark.lam 2021-06-03 15:12:35 -0700 Comment on attachment 430504 the patch r=me 1766556 3 fpizlo 2021-06-03 15:28:03 -0700 Landed in https://trac.webkit.org/changeset/278424/webkit 1766557 4 webkit-bug-importer 2021-06-03 15:29:22 -0700 <rdar://problem/78839959> 430504 2021-06-03 15:04:18 -0700 2021-06-03 15:12:35 -0700 the patch fix-barriers.patch text/plain 3496 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc4NDIyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDIxLTA2LTAzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIHNob3VsZCBlbGltaW5hdGUgb2J2aW91cyBzdG9yZSBiYXJyaWVycworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2NjA0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBoYXMgYSBjb3VwbGUgY2hh bmdlczoKKyAgICAgICAgCisgICAgICAgIC0gUHV0QnlPZmZzZXQgZG9lc24ndCBHQyEgU28gbGV0 J3Mgbm90IHNheSB0aGF0IGl0IGRvZXMuCisKKyAgICAgICAgLSBUaGUgc3RvcmUgYmFycmllciBj bHVzdGVyaW5nIHBoYXNlIGlzIG5vIGxvbmdlciBjYWxsZWQgdGhlIHN0b3JlIGJhcnJpZXIgZmVu Y2luZyBwaGFzZSBpbgorICAgICAgICAgIGR1bXBzLgorCisgICAgICAgICogZGZnL0RGR0RvZXNH Qy5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6ZG9lc0dDKToKKyAgICAgICAgKiBkZmcvREZHU3Rv cmVCYXJyaWVyQ2x1c3RlcmluZ1BoYXNlLmNwcDoKKwogMjAyMS0wNi0wMyAgUGF0cmljayBBbmds ZSAgPHBhbmdsZUBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogW0NvY29hXSBg UmVtb3RlSW5zcGVjdG9yYCB3b24ndCBjb25uZWN0IHRvIGEgbmV3IHJlbGF5IGlmIGl0IGhhc24n dCB5ZXQgZmFpbGVkIHRvIGNvbW11bmljYXRlIHdpdGggYSBwcmV2aW91c2x5IGNvbm5lY3RlZCBy ZWxheQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdEb2VzR0MuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRG9lc0dDLmNwcAkocmV2aXNp b24gMjc4Mjg5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdEb2VzR0MuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAxNC0y MDIwIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAx NC0yMDIxIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1 dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQK ICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dp bmcgY29uZGl0aW9ucwpAQCAtMjU4LDYgKzI1OCw3IEBAIGJvb2wgZG9lc0dDKEdyYXBoJiBncmFw aCwgTm9kZSogbm9kZSkKICAgICBjYXNlIERhdGFWaWV3R2V0SW50OgogICAgIGNhc2UgRGF0YVZp ZXdHZXRGbG9hdDoKICAgICBjYXNlIERhdGFWaWV3U2V0OgorICAgIGNhc2UgUHV0QnlPZmZzZXQ6 CiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogI2lmIEFTU0VSVF9FTkFCTEVECkBAIC0zMjAsNyAr MzIxLDYgQEAgYm9vbCBkb2VzR0MoR3JhcGgmIGdyYXBoLCBOb2RlKiBub2RlKQogICAgIGNhc2Ug UHV0QnlJZERpcmVjdDoKICAgICBjYXNlIFB1dEJ5SWRGbHVzaDoKICAgICBjYXNlIFB1dEJ5SWRX aXRoVGhpczoKLSAgICBjYXNlIFB1dEJ5T2Zmc2V0OgogICAgIGNhc2UgUHV0QnlWYWxXaXRoVGhp czoKICAgICBjYXNlIFB1dER5bmFtaWNWYXI6CiAgICAgY2FzZSBQdXRHZXR0ZXJCeUlkOgpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTdG9yZUJhcnJpZXJDbHVzdGVyaW5nUGhh c2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3RvcmVC YXJyaWVyQ2x1c3RlcmluZ1BoYXNlLmNwcAkocmV2aXNpb24gMjc4Mjg5KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdTdG9yZUJhcnJpZXJDbHVzdGVyaW5nUGhhc2UuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAxNiBBcHBs ZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTYtMjAyMSBB cHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5k IHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2Rp ZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRp dGlvbnMKQEAgLTQwLDEwICs0MCwxMiBAQCBuYW1lc3BhY2UgSlNDIHsgbmFtZXNwYWNlIERGRyB7 CiAKIG5hbWVzcGFjZSB7CiAKK2NvbnN0ZXhwciBib29sIHZlcmJvc2UgPSBmYWxzZTsKKwogY2xh c3MgU3RvcmVCYXJyaWVyQ2x1c3RlcmluZ1BoYXNlIDogcHVibGljIFBoYXNlIHsKIHB1YmxpYzoK ICAgICBTdG9yZUJhcnJpZXJDbHVzdGVyaW5nUGhhc2UoR3JhcGgmIGdyYXBoKQotICAgICAgICA6 IFBoYXNlKGdyYXBoLCAic3RvcmUgYmFycmllciBmZW5jaW5nIikKKyAgICAgICAgOiBQaGFzZShn cmFwaCwgInN0b3JlIGJhcnJpZXIgY2x1c3RlcmluZyIpCiAgICAgICAgICwgbV9pbnNlcnRpb25T ZXQoZ3JhcGgpCiAgICAgewogICAgIH0KQEAgLTk4LDYgKzEwMCwxMSBAQCBwcml2YXRlOgogICAg ICAgICAgICAgLy8gd291bGQgYmUgd2VpcmQgYmVjYXVzZSBpdCB3b3VsZCBjcmVhdGUgYSBuZXcg cm9vdCBmb3IgT1NSIGF2YWlsYWJpbGl0eSBhbmFseXNpcy4gSQogICAgICAgICAgICAgLy8gZG9u J3QgaGF2ZSBldmlkZW5jZSB0aGF0IGl0IHdvdWxkIGJlIHdvcnRoIGl0LgogICAgICAgICAgICAg aWYgKGRvZXNHQyhtX2dyYXBoLCBub2RlKSB8fCBtYXlFeGl0KG1fZ3JhcGgsIG5vZGUpICE9IERv ZXNOb3RFeGl0KSB7CisgICAgICAgICAgICAgICAgaWYgKHZlcmJvc2UpIHsKKyAgICAgICAgICAg ICAgICAgICAgZGF0YUxvZygiUG9zc2libGUgR0MgcG9pbnQgYXQgIiwgbm9kZSwgIlxuIik7Cisg ICAgICAgICAgICAgICAgICAgIGRhdGFMb2coIiAgICBkb2VzR0MgPSAiLCBkb2VzR0MobV9ncmFw aCwgbm9kZSksICJcbiIpOworICAgICAgICAgICAgICAgICAgICBkYXRhTG9nKCIgICAgbWF5RXhp dCA9ICIsIG1heUV4aXQobV9ncmFwaCwgbm9kZSksICJcbiIpOworICAgICAgICAgICAgICAgIH0K ICAgICAgICAgICAgICAgICBmdXR1cmVHQyA9IHRydWU7CiAgICAgICAgICAgICAgICAgY29udGlu dWU7CiAgICAgICAgICAgICB9Cg==