226596 2021-06-03 13:38:41 -0700 Stop storing Ref<IPC::Connection> in RTCDataChannelRemoteManagerProxy::m_webProcessConnections 2021-06-03 14:35:21 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen eric.carlson ggaren webkit-bug-importer youennf oldest_to_newest 1766500 0 cdumez 2021-06-03 13:38:41 -0700 Stop storing Ref<IPC::Connection> in RTCDataChannelRemoteManagerProxy::m_webProcessConnections. Keeping the IPC::Connection alive always carries the chance of leaking if we fail to properly clear the HashMap. We can simply store an IPC::Connection::UniqueID and use that ID to send the IPC on the background thread. 1766501 1 430496 cdumez 2021-06-03 13:39:46 -0700 Created attachment 430496 Patch 1766523 2 ews-feeder 2021-06-03 14:34:14 -0700 Committed r278420 (238444@main): <https://commits.webkit.org/238444@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430496. 1766526 3 webkit-bug-importer 2021-06-03 14:35:21 -0700 <rdar://problem/78836798> 430496 2021-06-03 13:39:46 -0700 2021-06-03 14:34:15 -0700 Patch bug-226596-20210603133945.patch text/plain 7134 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NDE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVhZTFhZWY3NzNjMDcwMzA1 M2RjMmVmZjRmMGRhOGFmZmIxYzQyZDkuLjJjMDNlYjZmMWVlZWY1MTMyMDJiOGYzMWUwM2FjNDYz ZTQ3ODAyNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMjEtMDYtMDMgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBTdG9wIHN0b3JpbmcgUmVmPElQQzo6 Q29ubmVjdGlvbj4gaW4gUlRDRGF0YUNoYW5uZWxSZW1vdGVNYW5hZ2VyUHJveHk6Om1fd2ViUHJv Y2Vzc0Nvbm5lY3Rpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMjY1OTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBTdG9wIHN0b3JpbmcgUmVmPElQQzo6Q29ubmVjdGlvbj4gaW4gUlRDRGF0YUNoYW5u ZWxSZW1vdGVNYW5hZ2VyUHJveHk6Om1fd2ViUHJvY2Vzc0Nvbm5lY3Rpb25zLgorICAgICAgICBL ZWVwaW5nIHRoZSBJUEM6OkNvbm5lY3Rpb24gYWxpdmUgYWx3YXlzIGNhcnJpZXMgdGhlIGNoYW5j ZSBvZiBsZWFraW5nIGlmIHdlIGZhaWwgdG8gcHJvcGVybHkKKyAgICAgICAgY2xlYXIgdGhlIEhh c2hNYXAuIFdlIGNhbiBzaW1wbHkgc3RvcmUgYW4gSVBDOjpDb25uZWN0aW9uOjpVbmlxdWVJRCBh bmQgdXNlIHRoYXQgSUQgdG8gc2VuZCB0aGUKKyAgICAgICAgSVBDIG9uIHRoZSBiYWNrZ3JvdW5k IHRocmVhZC4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL3dlYnJ0Yy9SVENEYXRhQ2hhbm5l bFJlbW90ZU1hbmFnZXJQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OlJUQ0RhdGFDaGFubmVs UmVtb3RlTWFuYWdlclByb3h5OjpyZWdpc3RlckNvbm5lY3Rpb25Ub1dlYlByb2Nlc3MpOgorICAg ICAgICAoV2ViS2l0OjpSVENEYXRhQ2hhbm5lbFJlbW90ZU1hbmFnZXJQcm94eTo6c2VuZERhdGEp OgorICAgICAgICAoV2ViS2l0OjpSVENEYXRhQ2hhbm5lbFJlbW90ZU1hbmFnZXJQcm94eTo6Y2xv c2UpOgorICAgICAgICAoV2ViS2l0OjpSVENEYXRhQ2hhbm5lbFJlbW90ZU1hbmFnZXJQcm94eTo6 Y2hhbmdlUmVhZHlTdGF0ZSk6CisgICAgICAgIChXZWJLaXQ6OlJUQ0RhdGFDaGFubmVsUmVtb3Rl TWFuYWdlclByb3h5OjpyZWNlaXZlRGF0YSk6CisgICAgICAgIChXZWJLaXQ6OlJUQ0RhdGFDaGFu bmVsUmVtb3RlTWFuYWdlclByb3h5OjpkZXRlY3RFcnJvcik6CisgICAgICAgIChXZWJLaXQ6OlJU Q0RhdGFDaGFubmVsUmVtb3RlTWFuYWdlclByb3h5OjpidWZmZXJlZEFtb3VudElzRGVjcmVhc2lu Zyk6CisgICAgICAgICogTmV0d29ya1Byb2Nlc3Mvd2VicnRjL1JUQ0RhdGFDaGFubmVsUmVtb3Rl TWFuYWdlclByb3h5Lmg6CisKIDIwMjEtMDYtMDMgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2ll aEBhcHBsZS5jb20+CiAKICAgICAgICAgW21hY09TXSBJbWFnZSBleHRyYWN0aW9uIHByZXZpZXcg cGFuZWwgc2hvdWxkIGF1dG9tYXRpY2FsbHkgY2xvc2Ugd2hlbiB0aGUgd2ViIHZpZXcgaXMgdW5w YXJlbnRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy93ZWJydGMv UlRDRGF0YUNoYW5uZWxSZW1vdGVNYW5hZ2VyUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3 b3JrUHJvY2Vzcy93ZWJydGMvUlRDRGF0YUNoYW5uZWxSZW1vdGVNYW5hZ2VyUHJveHkuY3BwCmlu ZGV4IDNlZWJjYTM1YTFlZWMyODFlMjBiNzVhMGJiZDMyODk4Y2FmNDFlNTQuLmJhYTBiYTBjZTdl N2MzNDU0NjNhMzNmZDU1ODY4YTI0ZjAxNWU0NzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3Mvd2VicnRjL1JUQ0RhdGFDaGFubmVsUmVtb3RlTWFuYWdlclByb3h5LmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL3dlYnJ0Yy9SVENEYXRhQ2hhbm5l bFJlbW90ZU1hbmFnZXJQcm94eS5jcHAKQEAgLTQwLDkgKzQwLDkgQEAgUlRDRGF0YUNoYW5uZWxS ZW1vdGVNYW5hZ2VyUHJveHk6OlJUQ0RhdGFDaGFubmVsUmVtb3RlTWFuYWdlclByb3h5KCkKIAog dm9pZCBSVENEYXRhQ2hhbm5lbFJlbW90ZU1hbmFnZXJQcm94eTo6cmVnaXN0ZXJDb25uZWN0aW9u VG9XZWJQcm9jZXNzKE5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzJiBjb25uZWN0aW9uVG9X ZWJQcm9jZXNzKQogewotICAgIG1fcXVldWUtPmRpc3BhdGNoKFt0aGlzLCBwcm90ZWN0ZWRUaGlz ID0gbWFrZVJlZigqdGhpcyksIGlkZW50aWZpZXIgPSBjb25uZWN0aW9uVG9XZWJQcm9jZXNzLndl YlByb2Nlc3NJZGVudGlmaWVyKCksIGNvbm5lY3Rpb24gPSBtYWtlUmVmKGNvbm5lY3Rpb25Ub1dl YlByb2Nlc3MuY29ubmVjdGlvbigpKV0oKSBtdXRhYmxlIHsKKyAgICBtX3F1ZXVlLT5kaXNwYXRj aChbdGhpcywgcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMpLCBpZGVudGlmaWVyID0gY29u bmVjdGlvblRvV2ViUHJvY2Vzcy53ZWJQcm9jZXNzSWRlbnRpZmllcigpLCBjb25uZWN0aW9uSUQg PSBjb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNvbm5lY3Rpb24oKS51bmlxdWVJRCgpXSgpIG11dGFi bGUgewogICAgICAgICBBU1NFUlQoIW1fd2ViUHJvY2Vzc0Nvbm5lY3Rpb25zLmNvbnRhaW5zKGlk ZW50aWZpZXIpKTsKLSAgICAgICAgbV93ZWJQcm9jZXNzQ29ubmVjdGlvbnMuYWRkKGlkZW50aWZp ZXIsIFdURk1vdmUoY29ubmVjdGlvbikpOworICAgICAgICBtX3dlYlByb2Nlc3NDb25uZWN0aW9u cy5hZGQoaWRlbnRpZmllciwgY29ubmVjdGlvbklEKTsKICAgICB9KTsKICAgICBjb25uZWN0aW9u VG9XZWJQcm9jZXNzLmNvbm5lY3Rpb24oKS5hZGRXb3JrUXVldWVNZXNzYWdlUmVjZWl2ZXIoTWVz c2FnZXM6OlJUQ0RhdGFDaGFubmVsUmVtb3RlTWFuYWdlclByb3h5OjptZXNzYWdlUmVjZWl2ZXJO YW1lKCksIG1fcXVldWUsIHRoaXMpOwogfQpAQCAtNTgsMzggKzU4LDM4IEBAIHZvaWQgUlRDRGF0 YUNoYW5uZWxSZW1vdGVNYW5hZ2VyUHJveHk6OnVucmVnaXN0ZXJDb25uZWN0aW9uVG9XZWJQcm9j ZXNzKE5ldHdvcmtDCiAKIHZvaWQgUlRDRGF0YUNoYW5uZWxSZW1vdGVNYW5hZ2VyUHJveHk6OnNl bmREYXRhKFdlYkNvcmU6OlJUQ0RhdGFDaGFubmVsSWRlbnRpZmllciBpZGVudGlmaWVyLCBib29s IGlzUmF3LCBjb25zdCBJUEM6OkRhdGFSZWZlcmVuY2UmIGRhdGEpCiB7Ci0gICAgaWYgKGF1dG8q IGNvbm5lY3Rpb24gPSBtX3dlYlByb2Nlc3NDb25uZWN0aW9ucy5nZXQoaWRlbnRpZmllci5wcm9j ZXNzSWRlbnRpZmllcikpCi0gICAgICAgIGNvbm5lY3Rpb24tPnNlbmQoTWVzc2FnZXM6OlJUQ0Rh dGFDaGFubmVsUmVtb3RlTWFuYWdlcjo6U2VuZERhdGEgeyBpZGVudGlmaWVyLCBpc1JhdywgZGF0 YSB9LCAwKTsKKyAgICBpZiAoYXV0byBjb25uZWN0aW9uSUQgPSBtX3dlYlByb2Nlc3NDb25uZWN0 aW9ucy5nZXQoaWRlbnRpZmllci5wcm9jZXNzSWRlbnRpZmllcikpCisgICAgICAgIElQQzo6Q29u bmVjdGlvbjo6c2VuZChjb25uZWN0aW9uSUQsIE1lc3NhZ2VzOjpSVENEYXRhQ2hhbm5lbFJlbW90 ZU1hbmFnZXI6OlNlbmREYXRhIHsgaWRlbnRpZmllciwgaXNSYXcsIGRhdGEgfSwgMCk7CiB9CiAK IHZvaWQgUlRDRGF0YUNoYW5uZWxSZW1vdGVNYW5hZ2VyUHJveHk6OmNsb3NlKFdlYkNvcmU6OlJU Q0RhdGFDaGFubmVsSWRlbnRpZmllciBpZGVudGlmaWVyKQogewotICAgIGlmIChhdXRvKiBjb25u ZWN0aW9uID0gbV93ZWJQcm9jZXNzQ29ubmVjdGlvbnMuZ2V0KGlkZW50aWZpZXIucHJvY2Vzc0lk ZW50aWZpZXIpKQotICAgICAgICBjb25uZWN0aW9uLT5zZW5kKE1lc3NhZ2VzOjpSVENEYXRhQ2hh bm5lbFJlbW90ZU1hbmFnZXI6OkNsb3NlIHsgaWRlbnRpZmllciB9LCAwKTsKKyAgICBpZiAoYXV0 byBjb25uZWN0aW9uSUQgPSBtX3dlYlByb2Nlc3NDb25uZWN0aW9ucy5nZXQoaWRlbnRpZmllci5w cm9jZXNzSWRlbnRpZmllcikpCisgICAgICAgIElQQzo6Q29ubmVjdGlvbjo6c2VuZChjb25uZWN0 aW9uSUQsIE1lc3NhZ2VzOjpSVENEYXRhQ2hhbm5lbFJlbW90ZU1hbmFnZXI6OkNsb3NlIHsgaWRl bnRpZmllciB9LCAwKTsKIH0KIAogdm9pZCBSVENEYXRhQ2hhbm5lbFJlbW90ZU1hbmFnZXJQcm94 eTo6Y2hhbmdlUmVhZHlTdGF0ZShXZWJDb3JlOjpSVENEYXRhQ2hhbm5lbElkZW50aWZpZXIgaWRl bnRpZmllciwgV2ViQ29yZTo6UlRDRGF0YUNoYW5uZWxTdGF0ZSBzdGF0ZSkKIHsKLSAgICBpZiAo YXV0byogY29ubmVjdGlvbiA9IG1fd2ViUHJvY2Vzc0Nvbm5lY3Rpb25zLmdldChpZGVudGlmaWVy LnByb2Nlc3NJZGVudGlmaWVyKSkKLSAgICAgICAgY29ubmVjdGlvbi0+c2VuZChNZXNzYWdlczo6 UlRDRGF0YUNoYW5uZWxSZW1vdGVNYW5hZ2VyOjpDaGFuZ2VSZWFkeVN0YXRlIHsgaWRlbnRpZmll ciwgc3RhdGUgfSwgMCk7CisgICAgaWYgKGF1dG8gY29ubmVjdGlvbklEID0gbV93ZWJQcm9jZXNz Q29ubmVjdGlvbnMuZ2V0KGlkZW50aWZpZXIucHJvY2Vzc0lkZW50aWZpZXIpKQorICAgICAgICBJ UEM6OkNvbm5lY3Rpb246OnNlbmQoY29ubmVjdGlvbklELCBNZXNzYWdlczo6UlRDRGF0YUNoYW5u ZWxSZW1vdGVNYW5hZ2VyOjpDaGFuZ2VSZWFkeVN0YXRlIHsgaWRlbnRpZmllciwgc3RhdGUgfSwg MCk7CiB9CiAKIHZvaWQgUlRDRGF0YUNoYW5uZWxSZW1vdGVNYW5hZ2VyUHJveHk6OnJlY2VpdmVE YXRhKFdlYkNvcmU6OlJUQ0RhdGFDaGFubmVsSWRlbnRpZmllciBpZGVudGlmaWVyLCBib29sIGlz UmF3LCBjb25zdCBJUEM6OkRhdGFSZWZlcmVuY2UmIGRhdGEpCiB7Ci0gICAgaWYgKGF1dG8qIGNv bm5lY3Rpb24gPSBtX3dlYlByb2Nlc3NDb25uZWN0aW9ucy5nZXQoaWRlbnRpZmllci5wcm9jZXNz SWRlbnRpZmllcikpCi0gICAgICAgIGNvbm5lY3Rpb24tPnNlbmQoTWVzc2FnZXM6OlJUQ0RhdGFD aGFubmVsUmVtb3RlTWFuYWdlcjo6UmVjZWl2ZURhdGEgeyBpZGVudGlmaWVyLCBpc1JhdywgZGF0 YSB9LCAwKTsKKyAgICBpZiAoYXV0byBjb25uZWN0aW9uSUQgPSBtX3dlYlByb2Nlc3NDb25uZWN0 aW9ucy5nZXQoaWRlbnRpZmllci5wcm9jZXNzSWRlbnRpZmllcikpCisgICAgICAgIElQQzo6Q29u bmVjdGlvbjo6c2VuZChjb25uZWN0aW9uSUQsIE1lc3NhZ2VzOjpSVENEYXRhQ2hhbm5lbFJlbW90 ZU1hbmFnZXI6OlJlY2VpdmVEYXRhIHsgaWRlbnRpZmllciwgaXNSYXcsIGRhdGEgfSwgMCk7CiB9 CiAKIHZvaWQgUlRDRGF0YUNoYW5uZWxSZW1vdGVNYW5hZ2VyUHJveHk6OmRldGVjdEVycm9yKFdl YkNvcmU6OlJUQ0RhdGFDaGFubmVsSWRlbnRpZmllciBpZGVudGlmaWVyKQogewotICAgIGlmIChh dXRvKiBjb25uZWN0aW9uID0gbV93ZWJQcm9jZXNzQ29ubmVjdGlvbnMuZ2V0KGlkZW50aWZpZXIu cHJvY2Vzc0lkZW50aWZpZXIpKQotICAgICAgICBjb25uZWN0aW9uLT5zZW5kKE1lc3NhZ2VzOjpS VENEYXRhQ2hhbm5lbFJlbW90ZU1hbmFnZXI6OkRldGVjdEVycm9yIHsgaWRlbnRpZmllciB9LCAw KTsKKyAgICBpZiAoYXV0byBjb25uZWN0aW9uSUQgPSBtX3dlYlByb2Nlc3NDb25uZWN0aW9ucy5n ZXQoaWRlbnRpZmllci5wcm9jZXNzSWRlbnRpZmllcikpCisgICAgICAgIElQQzo6Q29ubmVjdGlv bjo6c2VuZChjb25uZWN0aW9uSUQsIE1lc3NhZ2VzOjpSVENEYXRhQ2hhbm5lbFJlbW90ZU1hbmFn ZXI6OkRldGVjdEVycm9yIHsgaWRlbnRpZmllciB9LCAwKTsKIH0KIAogdm9pZCBSVENEYXRhQ2hh bm5lbFJlbW90ZU1hbmFnZXJQcm94eTo6YnVmZmVyZWRBbW91bnRJc0RlY3JlYXNpbmcoV2ViQ29y ZTo6UlRDRGF0YUNoYW5uZWxJZGVudGlmaWVyIGlkZW50aWZpZXIsIHNpemVfdCBhbW91bnQpCiB7 Ci0gICAgaWYgKGF1dG8qIGNvbm5lY3Rpb24gPSBtX3dlYlByb2Nlc3NDb25uZWN0aW9ucy5nZXQo aWRlbnRpZmllci5wcm9jZXNzSWRlbnRpZmllcikpCi0gICAgICAgIGNvbm5lY3Rpb24tPnNlbmQo TWVzc2FnZXM6OlJUQ0RhdGFDaGFubmVsUmVtb3RlTWFuYWdlcjo6QnVmZmVyZWRBbW91bnRJc0Rl Y3JlYXNpbmcgeyBpZGVudGlmaWVyLCBhbW91bnQgfSwgMCk7CisgICAgaWYgKGF1dG8gY29ubmVj dGlvbklEID0gbV93ZWJQcm9jZXNzQ29ubmVjdGlvbnMuZ2V0KGlkZW50aWZpZXIucHJvY2Vzc0lk ZW50aWZpZXIpKQorICAgICAgICBJUEM6OkNvbm5lY3Rpb246OnNlbmQoY29ubmVjdGlvbklELCBN ZXNzYWdlczo6UlRDRGF0YUNoYW5uZWxSZW1vdGVNYW5hZ2VyOjpCdWZmZXJlZEFtb3VudElzRGVj cmVhc2luZyB7IGlkZW50aWZpZXIsIGFtb3VudCB9LCAwKTsKIH0KIAogfQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy93ZWJydGMvUlRDRGF0YUNoYW5uZWxSZW1vdGVN YW5hZ2VyUHJveHkuaCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mvd2VicnRjL1JUQ0Rh dGFDaGFubmVsUmVtb3RlTWFuYWdlclByb3h5LmgKaW5kZXggODVjNzZkMTgwYTI4ZTYzYWU5MzUy MjE4ZTc2ZTUyZjg1Y2VkMzUzMC4uNzIxNDIwMjNmODY5YzA5YmQyOTQwNTg3YjM0ODZhZmZiYWQ5 NmVhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy93ZWJydGMvUlRD RGF0YUNoYW5uZWxSZW1vdGVNYW5hZ2VyUHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdv cmtQcm9jZXNzL3dlYnJ0Yy9SVENEYXRhQ2hhbm5lbFJlbW90ZU1hbmFnZXJQcm94eS5oCkBAIC02 MCw3ICs2MCw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBidWZmZXJlZEFtb3VudElzRGVjcmVhc2lu ZyhXZWJDb3JlOjpSVENEYXRhQ2hhbm5lbElkZW50aWZpZXIsIHNpemVfdCBhbW91bnQpOwogCiAg ICAgUmVmPFdvcmtRdWV1ZT4gbV9xdWV1ZTsKLSAgICBIYXNoTWFwPFdlYkNvcmU6OlByb2Nlc3NJ ZGVudGlmaWVyLCBSZWY8SVBDOjpDb25uZWN0aW9uPj4gbV93ZWJQcm9jZXNzQ29ubmVjdGlvbnM7 CisgICAgSGFzaE1hcDxXZWJDb3JlOjpQcm9jZXNzSWRlbnRpZmllciwgSVBDOjpDb25uZWN0aW9u OjpVbmlxdWVJRD4gbV93ZWJQcm9jZXNzQ29ubmVjdGlvbnM7CiB9OwogCiB9IC8vIG5hbWVzcGFj ZSBXZWJLaXQK