226591 2021-06-03 11:04:41 -0700 [JSC] Make $vm's accessor test functions robust against primitive |this| 2021-06-03 17:19:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1766447 0 ysuzuki 2021-06-03 11:04:41 -0700 [JSC] Make $vm's accessor test functions robust against primitive |this| 1766448 1 430485 ysuzuki 2021-06-03 11:05:42 -0700 Created attachment 430485 Patch 1766449 2 ysuzuki 2021-06-03 11:06:07 -0700 rdar://78804155 1766597 3 ews-feeder 2021-06-03 17:19:19 -0700 Committed r278434 (238456@main): <https://commits.webkit.org/238456@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430485. 430485 2021-06-03 11:05:42 -0700 2021-06-03 17:19:20 -0700 Patch bug-226591-20210603110541.patch text/plain 6388 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NDEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh N2JiYzRkZDdmYmZkMjFiMGEyNjVhMTE4NjgzOWJkYzQzNGUyOTVmLi4yYmZkMzcyOGVmNWI1Yjg1 ZjUzOWMyZjljZDgxMzA1Y2UwZTE0MDJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMS0wNi0wMyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIE1ha2UgJHZtJ3MgYWNjZXNzb3IgdGVzdCBmdW5jdGlvbnMgcm9i dXN0IGFnYWluc3QgcHJpbWl0aXZlIHx0aGlzfAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2NTkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlc2UgZnVuY3Rpb25zIGFyZSB0ZXN0aW5nLXB1cnBvc2Us IGFuZCB0aGV5IGFyZSBub3Qgcm9idXN0IGFnYWluc3QgcGFzc2luZyBwcmltaXRpdmUgYXMgfHRo aXN8LgorICAgICAgICBUaGlzIHBhdGNoIG1ha2VzIHRoZW0gcm9idXN0IHNvIHRoYXQgd2UgdGhy b3cgYW4gZXJyb3IgaW5zdGVhZCBvZiBjcmFzaC4KKworICAgICAgICAqIHRvb2xzL0pTRG9sbGFy Vk0uY3BwOgorCiAyMDIxLTA2LTAyICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBhcHBsZS5j b20+CiAKICAgICAgICAgQjNNb3ZlQ29uc3RhbnRzIHNob3VsZCBmaWx0ZXIgZGlyZWN0bHkgb24g VmFsdWVzLCBhbmQgb25seSBjcmVhdGUgVmFsdWVLZXlzIHdoZW4gdXNlZnVsCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdG9vbHMvSlNEb2xsYXJWTS5jcHAgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvdG9vbHMvSlNEb2xsYXJWTS5jcHAKaW5kZXggZmYxMzY1Yjg3NDkyMjU2OTJi N2FkNTRkZDllZjI3ZTczNzZjNDJhMS4uODAyNTU0NTFkMWI0MDUxNzEwMzc5OWU1ODFlYmM0YWUy ZmI2NjQ3OSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xzL0pTRG9sbGFy Vk0uY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90b29scy9KU0RvbGxhclZNLmNwcApA QCAtNzAyLDkgKzcwMiwxMSBAQCBKU0NfREVGSU5FX0NVU1RPTV9HRVRURVIodGVzdFN0YXRpY0Fj Y2Vzc29yR2V0dGVyLCAoSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdAogewogICAgIERvbGxh clZNQXNzZXJ0U2NvcGUgYXNzZXJ0U2NvcGU7CiAgICAgVk0mIHZtID0gZ2xvYmFsT2JqZWN0LT52 bSgpOworICAgIGF1dG8gc2NvcGUgPSBERUNMQVJFX1RIUk9XX1NDT1BFKHZtKTsKICAgICAKICAg ICBKU09iamVjdCogdGhpc09iamVjdCA9IGpzRHluYW1pY0Nhc3Q8SlNPYmplY3QqPih2bSwgSlNW YWx1ZTo6ZGVjb2RlKHRoaXNWYWx1ZSkpOwotICAgIFJFTEVBU0VfQVNTRVJUKHRoaXNPYmplY3Qp OworICAgIGlmICghdGhpc09iamVjdCkKKyAgICAgICAgcmV0dXJuIHRocm93Vk1UeXBlRXJyb3Io Z2xvYmFsT2JqZWN0LCBzY29wZSk7CiAKICAgICBpZiAoSlNWYWx1ZSByZXN1bHQgPSB0aGlzT2Jq ZWN0LT5nZXREaXJlY3Qodm0sIFByb3BlcnR5TmFtZShJZGVudGlmaWVyOjpmcm9tU3RyaW5nKHZt LCAidGVzdEZpZWxkIikpKSkKICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShyZXN1bHQp OwpAQCAtNzE1LDkgKzcxNywxMSBAQCBKU0NfREVGSU5FX0NVU1RPTV9TRVRURVIodGVzdFN0YXRp Y0FjY2Vzc29yUHV0dGVyLCAoSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdAogewogICAgIERv bGxhclZNQXNzZXJ0U2NvcGUgYXNzZXJ0U2NvcGU7CiAgICAgVk0mIHZtID0gZ2xvYmFsT2JqZWN0 LT52bSgpOworICAgIGF1dG8gc2NvcGUgPSBERUNMQVJFX1RIUk9XX1NDT1BFKHZtKTsKICAgICAK ICAgICBKU09iamVjdCogdGhpc09iamVjdCA9IGpzRHluYW1pY0Nhc3Q8SlNPYmplY3QqPih2bSwg SlNWYWx1ZTo6ZGVjb2RlKHRoaXNWYWx1ZSkpOwotICAgIFJFTEVBU0VfQVNTRVJUKHRoaXNPYmpl Y3QpOworICAgIGlmICghdGhpc09iamVjdCkKKyAgICAgICAgcmV0dXJuIHRocm93Vk1UeXBlRXJy b3IoZ2xvYmFsT2JqZWN0LCBzY29wZSk7CiAKICAgICByZXR1cm4gdGhpc09iamVjdC0+cHV0RGly ZWN0KHZtLCBQcm9wZXJ0eU5hbWUoSWRlbnRpZmllcjo6ZnJvbVN0cmluZyh2bSwgInRlc3RGaWVs ZCIpKSwgSlNWYWx1ZTo6ZGVjb2RlKHZhbHVlKSk7CiB9CkBAIC03ODUsOSArNzg5LDExIEBAIEpT Q19ERUZJTkVfQ1VTVE9NX1NFVFRFUih0ZXN0U3RhdGljVmFsdWVQdXR0ZXIsIChKU0dsb2JhbE9i amVjdCogZ2xvYmFsT2JqZWN0LCBFCiB7CiAgICAgRG9sbGFyVk1Bc3NlcnRTY29wZSBhc3NlcnRT Y29wZTsKICAgICBWTSYgdm0gPSBnbG9iYWxPYmplY3QtPnZtKCk7CisgICAgYXV0byBzY29wZSA9 IERFQ0xBUkVfVEhST1dfU0NPUEUodm0pOwogICAgIAogICAgIEpTT2JqZWN0KiB0aGlzT2JqZWN0 ID0ganNEeW5hbWljQ2FzdDxKU09iamVjdCo+KHZtLCBKU1ZhbHVlOjpkZWNvZGUodGhpc1ZhbHVl KSk7Ci0gICAgUkVMRUFTRV9BU1NFUlQodGhpc09iamVjdCk7CisgICAgaWYgKCF0aGlzT2JqZWN0 KQorICAgICAgICByZXR1cm4gdGhyb3dWTVR5cGVFcnJvcihnbG9iYWxPYmplY3QsIHNjb3BlKTsK IAogICAgIHJldHVybiB0aGlzT2JqZWN0LT5wdXREaXJlY3Qodm0sIFByb3BlcnR5TmFtZShJZGVu dGlmaWVyOjpmcm9tU3RyaW5nKHZtLCAidGVzdFN0YXRpY1ZhbHVlIikpLCBKU1ZhbHVlOjpkZWNv ZGUodmFsdWUpKTsKIH0KQEAgLTEwMjcsOCArMTAzMywxMCBAQCBKU0NfREVGSU5FX0NVU1RPTV9H RVRURVIoZG9tSklUR2V0dGVyQ3VzdG9tR2V0dGVyLCAoSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9i amVjdAogewogICAgIERvbGxhclZNQXNzZXJ0U2NvcGUgYXNzZXJ0U2NvcGU7CiAgICAgVk0mIHZt ID0gZ2xvYmFsT2JqZWN0LT52bSgpOworICAgIGF1dG8gc2NvcGUgPSBERUNMQVJFX1RIUk9XX1ND T1BFKHZtKTsKICAgICBET01KSVROb2RlKiB0aGlzT2JqZWN0ID0ganNEeW5hbWljQ2FzdDxET01K SVROb2RlKj4odm0sIEpTVmFsdWU6OmRlY29kZSh0aGlzVmFsdWUpKTsKLSAgICBBU1NFUlQodGhp c09iamVjdCk7CisgICAgaWYgKCF0aGlzT2JqZWN0KQorICAgICAgICByZXR1cm4gdGhyb3dWTVR5 cGVFcnJvcihnbG9iYWxPYmplY3QsIHNjb3BlKTsKICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2Rl KGpzTnVtYmVyKHRoaXNPYmplY3QtPnZhbHVlKCkpKTsKIH0KIApAQCAtMTEyNSw4ICsxMTMzLDEw IEBAIEpTQ19ERUZJTkVfQ1VTVE9NX0dFVFRFUihkb21KSVRHZXR0ZXJOb0VmZmVjdEN1c3RvbUdl dHRlciwgKEpTR2xvYmFsT2JqZWN0KiBnbG9iCiB7CiAgICAgRG9sbGFyVk1Bc3NlcnRTY29wZSBh c3NlcnRTY29wZTsKICAgICBWTSYgdm0gPSBnbG9iYWxPYmplY3QtPnZtKCk7CisgICAgYXV0byBz Y29wZSA9IERFQ0xBUkVfVEhST1dfU0NPUEUodm0pOwogICAgIERPTUpJVE5vZGUqIHRoaXNPYmpl Y3QgPSBqc0R5bmFtaWNDYXN0PERPTUpJVE5vZGUqPih2bSwgSlNWYWx1ZTo6ZGVjb2RlKHRoaXNW YWx1ZSkpOwotICAgIEFTU0VSVCh0aGlzT2JqZWN0KTsKKyAgICBpZiAoIXRoaXNPYmplY3QpCisg ICAgICAgIHJldHVybiB0aHJvd1ZNVHlwZUVycm9yKGdsb2JhbE9iamVjdCwgc2NvcGUpOwogICAg IHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNOdW1iZXIodGhpc09iamVjdC0+dmFsdWUoKSkpOwog fQogCkBAIC0xMjMwLDcgKzEyNDAsOCBAQCBKU0NfREVGSU5FX0NVU1RPTV9HRVRURVIoZG9tSklU R2V0dGVyQ29tcGxleEN1c3RvbUdldHRlciwgKEpTR2xvYmFsT2JqZWN0KiBnbG9iYQogICAgIGF1 dG8gc2NvcGUgPSBERUNMQVJFX1RIUk9XX1NDT1BFKHZtKTsKIAogICAgIGF1dG8qIHRoaXNPYmpl Y3QgPSBqc0R5bmFtaWNDYXN0PERPTUpJVEdldHRlckNvbXBsZXgqPih2bSwgSlNWYWx1ZTo6ZGVj b2RlKHRoaXNWYWx1ZSkpOwotICAgIEFTU0VSVCh0aGlzT2JqZWN0KTsKKyAgICBpZiAoIXRoaXNP YmplY3QpCisgICAgICAgIHJldHVybiB0aHJvd1ZNVHlwZUVycm9yKGdsb2JhbE9iamVjdCwgc2Nv cGUpOwogICAgIGlmICh0aGlzT2JqZWN0LT5tX2VuYWJsZUV4Y2VwdGlvbikKICAgICAgICAgcmV0 dXJuIEpTVmFsdWU6OmVuY29kZSh0aHJvd0V4Y2VwdGlvbihnbG9iYWxPYmplY3QsIHNjb3BlLCBj cmVhdGVFcnJvcihnbG9iYWxPYmplY3QsICJET01KSVRHZXR0ZXJDb21wbGV4IHNsb3cgY2FsbCBl eGNlcHRpb24iX3MpKSk7CiAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc051bWJlcih0aGlz T2JqZWN0LT52YWx1ZSgpKSk7CkBAIC0xNDg5LDggKzE1MDAsMTAgQEAgSlNDX0RFRklORV9DVVNU T01fR0VUVEVSKGRvbUpJVEdldHRlckJhc2VKU09iamVjdEN1c3RvbUdldHRlciwgKEpTR2xvYmFs T2JqZWN0KgogewogICAgIERvbGxhclZNQXNzZXJ0U2NvcGUgYXNzZXJ0U2NvcGU7CiAgICAgVk0m IHZtID0gZ2xvYmFsT2JqZWN0LT52bSgpOworICAgIGF1dG8gc2NvcGUgPSBERUNMQVJFX1RIUk9X X1NDT1BFKHZtKTsKICAgICBKU09iamVjdCogdGhpc09iamVjdCA9IGpzRHluYW1pY0Nhc3Q8SlNP YmplY3QqPih2bSwgSlNWYWx1ZTo6ZGVjb2RlKHRoaXNWYWx1ZSkpOwotICAgIFJFTEVBU0VfQVNT RVJUKHRoaXNPYmplY3QpOworICAgIGlmICghdGhpc09iamVjdCkKKyAgICAgICAgcmV0dXJuIHRo cm93Vk1UeXBlRXJyb3IoZ2xvYmFsT2JqZWN0LCBzY29wZSk7CiAgICAgcmV0dXJuIEpTVmFsdWU6 OmVuY29kZSh0aGlzT2JqZWN0LT5nZXRQcm90b3R5cGVEaXJlY3Qodm0pKTsKIH0KIApkaWZmIC0t Z2l0IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCAzNDlhODUy ZjMzNDE1MTMxNWI4NTE4MzE0MTBmYzNkMjdkMWU3Y2Y2Li5iNmM5OWZjZGY4NzI2MWM0NmM5MTA1 ZDI0MGExMjg5OTdkOWI3ZGIyIDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9K U1Rlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIxLTA2LTAzICBZdXN1a2UgU3V6 dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgW0pTQ10gTWFrZSAkdm0ncyBhY2Nl c3NvciB0ZXN0IGZ1bmN0aW9ucyByb2J1c3QgYWdhaW5zdCBwcmltaXRpdmUgfHRoaXN8CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjY1OTEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy90ZXN0 LXN0YXRpYy1hY2Nlc3Nvci1vbi1wcmltaXRpdmUuanM6IEFkZGVkLgorICAgICAgICAoc2hvdWxk VGhyb3cpOgorCiAyMDIxLTA1LTI4ICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBhcHBsZS5j b20+CiAKICAgICAgICAgRml4IExpa2VseURlbnNlVW5zaWduZWRJbnRlZ2VyU2V0OjpjbGVhcigp CmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy90ZXN0LXN0YXRpYy1hY2Nlc3Nvci1vbi1wcmlt aXRpdmUuanMgYi9KU1Rlc3RzL3N0cmVzcy90ZXN0LXN0YXRpYy1hY2Nlc3Nvci1vbi1wcmltaXRp dmUuanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uY2IyNjNlMDY1N2Q0NDk1NjM1OWY2MDhhYmI4M2Q0NzA2N2MxNGFj YwotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMvc3RyZXNzL3Rlc3Qtc3RhdGljLWFjY2Vzc29y LW9uLXByaW1pdGl2ZS5qcwpAQCAtMCwwICsxLDIwIEBACitmdW5jdGlvbiBzaG91bGRUaHJvdyhm dW5jLCBlcnJvck1lc3NhZ2UpIHsKKyAgICB2YXIgZXJyb3JUaHJvd24gPSBmYWxzZTsKKyAgICB2 YXIgZXJyb3IgPSBudWxsOworICAgIHRyeSB7CisgICAgICAgIGZ1bmMoKTsKKyAgICB9IGNhdGNo IChlKSB7CisgICAgICAgIGVycm9yVGhyb3duID0gdHJ1ZTsKKyAgICAgICAgZXJyb3IgPSBlOwor ICAgIH0KKyAgICBpZiAoIWVycm9yVGhyb3duKQorICAgICAgICB0aHJvdyBuZXcgRXJyb3IoJ25v dCB0aHJvd24nKTsKKyAgICBpZiAoU3RyaW5nKGVycm9yKSAhPT0gZXJyb3JNZXNzYWdlKQorICAg ICAgICB0aHJvdyBuZXcgRXJyb3IoYGJhZCBlcnJvcjogJHtTdHJpbmcoZXJyb3IpfWApOworfQor CitzaG91bGRUaHJvdygoKSA9PiB7CisgICAgT2JqZWN0LnNldFByb3RvdHlwZU9mKE51bWJlci5w cm90b3R5cGUsICR2bS5jcmVhdGVTdGF0aWNDdXN0b21BY2Nlc3NvcigpKTsKKyAgICBsZXQgeiA9 IDA7CisgICAgei50ZXN0U3RhdGljQWNjZXNzb3I7Cit9LCBgVHlwZUVycm9yOiBUeXBlIGVycm9y YCk7Cg==