226578 2021-06-03 06:25:44 -0700 Reintroduce logging useful for debugging in AudioSampleDataSource 2021-06-04 05:06:16 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf cdumez eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer youennf oldest_to_newest 1766368 0 youennf 2021-06-03 06:25:44 -0700 Reintroduce logging useful for debugging in AudioSampleDataSource 1766369 1 430465 youennf 2021-06-03 06:37:22 -0700 Created attachment 430465 Patch 1766452 2 430465 youennf 2021-06-03 11:08:33 -0700 Comment on attachment 430465 Patch I tried reducing the logging to the minimal case. I guess we could try further optimisations so that callOnMainThread would not always trigger an allocation but I think this is fine without it. 1766737 3 ews-feeder 2021-06-04 05:05:07 -0700 Committed r278453 (238473@main): <https://commits.webkit.org/238473@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430465. 1766738 4 webkit-bug-importer 2021-06-04 05:06:16 -0700 <rdar://problem/78864972> 430465 2021-06-03 06:37:22 -0700 2021-06-04 05:05:08 -0700 Patch bug-226578-20210603153721.patch text/plain 4299 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4NDAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjJiYzBlYmFiYWQ0Zjhj MWQwMjMyNDdmNDYwYzg2ZjYyNjdjN2Y1ZC4uYzA2ZTc1NjhhMDUzNDJkZGFlYzhiODRkZTdiYzQ3 ZGM0NzJjYTQ0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIxLTA2LTAzICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSZWludHJvZHVjZSBsb2dn aW5nIHVzZWZ1bCBmb3IgZGVidWdnaW5nIGluIEF1ZGlvU2FtcGxlRGF0YVNvdXJjZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2NTc4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlZCBsb2dnaW5n IHdhcyBhY3R1YWxseSB1c2VmdWwgZm9yIGRlYnVnZ2luZyBhdWRpbyBpc3N1ZXMuCisgICAgICAg IFJlaW50cm9kdWNlIGl0IGJ5IHJlc3RyaWN0IGxvZ2dpbmcgdG8gZW5zdXJlIHdlIGRvIG5vdCBp bnRyb2R1Y2UgdG9vIG11Y2ggYXVkaW8gZ2xpdGNoZXMgYnkgZG9pbmcgc286CisgICAgICAgIC0g SWYgd2UgcHVsbCBzYW1wbGVzIGFuZCBkbyBub3QgaGF2ZSBlbm91Z2ggZGF0YSwgZW50ZXIgbW9y ZS1kYXRhLW5lZWRlZCBtb2RlLCBhbmQgbG9nIG9uY2UgdGhhdCBkYXRhIGlzIG1pc3NpbmcuCisg ICAgICAgIC0gSWYgd2UgcHVsbCBzYW1wbGVzIGFuZCBkbyBub3QgaGF2ZSBlbm91Z2ggZGF0YSBh bmQgd2UgYXJlIGFscmVhZHkgaW4gbW9yZS1kYXRhLW5lZWRlZCBtb2RlLCBkbyBub3QgbG9nIGFu eXRoaW5nLgorICAgICAgICAtIElmIHdlIHB1c2ggc2FtcGxlcyBhbmQgYXJlIGluIG1vcmUtZGF0 YS1uZWVkZWQgbW9kZSwgcmVzZXQgbW9kZSB0byBub25lIGFuZCBsb2cgdGhpcyBpbmZvcm1hdGlv bi4KKyAgICAgICAgVGhlIG1vZGUgY2hlY2sgaGFwcGVucyBpbiB0d28gZGlmZmVyZW50IHRocmVh ZHMgc28gbWlnaHQgYmUgYSBiaXQgcmFjeSBidXQgYXQgd29yc3QsIHRoaXMgcmVkdWNlcyBhY2N1 cmFjeSBvZiB0aGUgbG9nZ2luZy4KKworICAgICAgICBObyBjaGFuZ2Ugb2YgYmVoYXZpb3IuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9hdWRpby9jb2NvYS9BdWRpb1NhbXBsZURhdGFTb3VyY2UuaDoK KyAgICAgICAgKiBwbGF0Zm9ybS9hdWRpby9jb2NvYS9BdWRpb1NhbXBsZURhdGFTb3VyY2UubW06 CisgICAgICAgIChXZWJDb3JlOjpBdWRpb1NhbXBsZURhdGFTb3VyY2U6OnB1c2hTYW1wbGVzSW50 ZXJuYWwpOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9TYW1wbGVEYXRhU291cmNlOjpwdWxsU2Ft cGxlc0ludGVybmFsKToKKwogMjAyMS0wNi0wMyAgSnVsaWFuIEdvbnphbGV6ICA8anVsaWFuX2Ff Z29uemFsZXpAYXBwbGUuY29tPgogCiAgICAgICAgIENyYXNoIGluIEhUTUxDb252ZXJ0ZXI6Ol9h ZGRMaW5rRm9yRWxlbWVudCgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9h dWRpby9jb2NvYS9BdWRpb1NhbXBsZURhdGFTb3VyY2UuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2F1ZGlvL2NvY29hL0F1ZGlvU2FtcGxlRGF0YVNvdXJjZS5oCmluZGV4IGRhMWZhY2U1N2Y1 NDYxODM4M2Q0MzU5NjIyYzA1YjY3ZmRjNDBkZGQuLmExZTcxYmQ1MjIzMjI0MjU3MTZjNmI5ZTVh Y2VkMDZlNTU4MjkzM2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlv L2NvY29hL0F1ZGlvU2FtcGxlRGF0YVNvdXJjZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2F1ZGlvL2NvY29hL0F1ZGlvU2FtcGxlRGF0YVNvdXJjZS5oCkBAIC0xMTYsNiArMTE2LDgg QEAgcHJpdmF0ZToKICAgICBib29sIG1fc2hvdWxkQ29tcHV0ZU91dHB1dFNhbXBsZU9mZnNldCB7 IHRydWUgfTsKICAgICB1aW50NjRfdCBtX2VuZEZyYW1lV2hlbk5vdEVub3VnaERhdGEgeyAwIH07 CiAKKyAgICBib29sIG1faXNJbk5lZWRPZk1vcmVEYXRhIHsgZmFsc2UgfTsKKwogI2lmICFSRUxF QVNFX0xPR19ESVNBQkxFRAogICAgIFJlZjxjb25zdCBMb2dnZXI+IG1fbG9nZ2VyOwogICAgIGNv bnN0IHZvaWQqIG1fbG9nSWRlbnRpZmllcjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2F1ZGlvL2NvY29hL0F1ZGlvU2FtcGxlRGF0YVNvdXJjZS5tbSBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2F1ZGlvL2NvY29hL0F1ZGlvU2FtcGxlRGF0YVNvdXJjZS5tbQppbmRleCA2 Y2E4ZWI2MmJmMDcxMjNhZjI0NDUxOWU3Y2ZlNDU3ZTlkOGZjYzkwLi5lNWVjNDc3Nzg1ODFhN2Fj ZjBlNzI1NTMzM2Y5ZTI2OTQxYzQ3MmQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9hdWRpby9jb2NvYS9BdWRpb1NhbXBsZURhdGFTb3VyY2UubW0KKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vYXVkaW8vY29jb2EvQXVkaW9TYW1wbGVEYXRhU291cmNlLm1tCkBAIC0x NzAsNiArMTcwLDEzIEBAIHZvaWQgQXVkaW9TYW1wbGVEYXRhU291cmNlOjpwdXNoU2FtcGxlc0lu dGVybmFsKGNvbnN0IEF1ZGlvQnVmZmVyTGlzdCYgYnVmZmVyTGlzCiAgICAgbV9yaW5nQnVmZmVy LT5nZXRDdXJyZW50RnJhbWVCb3VuZHMoc3RhcnRGcmFtZTEsIGVuZEZyYW1lMSk7CiAjZW5kaWYK IAorICAgIGlmIChtX2lzSW5OZWVkT2ZNb3JlRGF0YSkgeworICAgICAgICBtX2lzSW5OZWVkT2ZN b3JlRGF0YSA9IGZhbHNlOworICAgICAgICBEaXNhYmxlTWFsbG9jUmVzdHJpY3Rpb25zRm9yQ3Vy cmVudFRocmVhZFNjb3BlIGRpc2FibGVNYWxsb2NSZXN0cmljdGlvbnM7CisgICAgICAgIFJ1bkxv b3A6Om1haW4oKS5kaXNwYXRjaChbbG9nSWRlbnRpZmllciA9IExPR0lERU5USUZJRVIsIHNhbXBs ZUNvdW50LCB0aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZlB0cigqdGhpcyldIHsKKyAgICAg ICAgICAgIEFMV0FZU19MT0cobG9nSWRlbnRpZmllciwgIm5lZWRlZCBtb3JlIGRhdGEsIHB1c2hp bmcgIiwgc2FtcGxlQ291bnQsICIgc2FtcGxlcyIpOworICAgICAgICB9KTsKKyAgICB9CiAgICAg bV9yaW5nQnVmZmVyLT5zdG9yZShzYW1wbGVCdWZmZXJMaXN0LCBzYW1wbGVDb3VudCwgc2FtcGxl VGltZS50aW1lVmFsdWUoKSk7CiAgICAgbV9sYXN0UHVzaGVkU2FtcGxlQ291bnQgPSBzYW1wbGVD b3VudDsKIH0KQEAgLTI1NSw2ICsyNjIsMTMgQEAgYm9vbCBBdWRpb1NhbXBsZURhdGFTb3VyY2U6 OnB1bGxTYW1wbGVzSW50ZXJuYWwoQXVkaW9CdWZmZXJMaXN0JiBidWZmZXIsIHNpemVfdAogICAg IHRpbWVTdGFtcCArPSBtX291dHB1dFNhbXBsZU9mZnNldDsKIAogICAgIGlmICh0aW1lU3RhbXAg PCBzdGFydEZyYW1lIHx8IHRpbWVTdGFtcCArIHNhbXBsZUNvdW50ID4gZW5kRnJhbWUpIHsKKyAg ICAgICAgaWYgKCFtX2lzSW5OZWVkT2ZNb3JlRGF0YSkgeworICAgICAgICAgICAgbV9pc0luTmVl ZE9mTW9yZURhdGEgPSB0cnVlOworICAgICAgICAgICAgRGlzYWJsZU1hbGxvY1Jlc3RyaWN0aW9u c0ZvckN1cnJlbnRUaHJlYWRTY29wZSBkaXNhYmxlTWFsbG9jUmVzdHJpY3Rpb25zOworICAgICAg ICAgICAgUnVuTG9vcDo6bWFpbigpLmRpc3BhdGNoKFtsb2dJZGVudGlmaWVyID0gTE9HSURFTlRJ RklFUiwgdGltZVN0YW1wLCBzdGFydEZyYW1lLCBlbmRGcmFtZSwgc2FtcGxlQ291bnQsIG91dHB1 dFNhbXBsZU9mZnNldCA9IG1fb3V0cHV0U2FtcGxlT2Zmc2V0LCB0aGlzLCBwcm90ZWN0ZWRUaGlz ID0gbWFrZVJlZlB0cigqdGhpcyldIHsKKyAgICAgICAgICAgICAgICBFUlJPUl9MT0cobG9nSWRl bnRpZmllciwgIm5lZWQgbW9yZSBkYXRhLCBzYW1wbGUgIiwgdGltZVN0YW1wLCAiIHdpdGggb2Zm c2V0ICIsIG91dHB1dFNhbXBsZU9mZnNldCwgIiwgdHJ5aW5nIHRvIGdldCAiLCBzYW1wbGVDb3Vu dCwgIiBzYW1wbGVzLCBidXQgbm90IGNvbXBsZXRlbHkgaW4gcmFuZ2UgWyIsIHN0YXJ0RnJhbWUs ICIgLi4gIiwgZW5kRnJhbWUsICJdIik7CisgICAgICAgICAgICB9KTsKKyAgICAgICAgfQogICAg ICAgICBpZiAodGltZVN0YW1wIDwgc3RhcnRGcmFtZSB8fCB0aW1lU3RhbXAgPj0gZW5kRnJhbWUp IHsKICAgICAgICAgICAgIC8vIFdlIGFyZSBvdXQgb2YgdGhlIHdpbmRvdywgbGV0J3MgcmVzdGFy dCB0aGUgb2Zmc2V0IGNvbXB1dGF0aW9uLgogICAgICAgICAgICAgbV9zaG91bGRDb21wdXRlT3V0 cHV0U2FtcGxlT2Zmc2V0ID0gdHJ1ZTsK