226564 2021-06-02 18:34:50 -0700 [WebXR] Supply an IOSurface in SimulatedXRDevice 2021-06-05 16:32:23 -0700 1 1 1 Unclassified WebKit WebXR WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino sam webkit-bug-importer oldest_to_newest 1766254 0 dino 2021-06-02 18:34:50 -0700 Supply an IOSurface in SimulatedXRDevice 1766255 1 webkit-bug-importer 2021-06-02 18:35:02 -0700 <rdar://problem/78793086> 1766256 2 430431 dino 2021-06-02 18:36:57 -0700 Created attachment 430431 Patch 1766390 3 430431 sam 2021-06-03 08:10:41 -0700 Comment on attachment 430431 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430431&action=review > Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:119 > + ASSERT(data.surface); Maybe consider making surface a UniqueRef? > Source/WebCore/testing/WebFakeXRDevice.cpp:154 > + auto surface = IOSurface::create(recommendedResolution(PlatformXR::SessionMode::ImmersiveVr), DestinationColorSpace::SRGB()); > + data.layers.add(layer.key, FrameData::LayerData { .surface = WTFMove(surface) }); I would do this in one line. 1767162 4 dino 2021-06-05 16:32:23 -0700 Committed r278528 (238527@main): <https://commits.webkit.org/238527@main> 430431 2021-06-02 18:36:57 -0700 2021-06-03 08:10:41 -0700 Patch bug-226564-20210603113656.patch text/plain 2816 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTU4ZTYwMTA5YjliMGE2 ZTczYjZlNjBlYWQ0MTJkYTQyOTJjYmY0NS4uNzE3MmM4Mzc3ZTE4OGM4NTFkNjFhZDE0ODdiY2Qz N2QwMWZiZDY4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA2LTAyICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViWFJdIFN1cHBseSBhbiBJ T1N1cmZhY2UgaW4gU2ltdWxhdGVkWFJEZXZpY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjU2NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzg3 OTMwODY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmF0aGVyIHRoYW4gaGFuZGxlIHRoZSBjYXNlIHdoZXJlIHdlIGdldCBhIG51bGwgSU9TdXJmYWNl LAorICAgICAgICBoYXZlIHRoZSBTaW11bGF0ZWRYUkRldmljZSBjcmVhdGUgb25lIG9uIGVhY2gg ZnJhbWUuCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYnhyL1dlYlhST3BhcXVlRnJhbWVidWZmZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViWFJPcGFxdWVGcmFtZWJ1ZmZlcjo6c3RhcnRGcmFt ZSk6CisgICAgICAgICogdGVzdGluZy9XZWJGYWtlWFJEZXZpY2UuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6U2ltdWxhdGVkWFJEZXZpY2U6OmZyYW1lVGltZXJGaXJlZCk6CisKIDIwMjEtMDYtMDEg IFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW21hY09T XSBEYXRhIGRldGVjdG9yIGhpZ2hsaWdodHMgc2hvdWxkIGFwcGVhciB3aGVuIGhvdmVyaW5nIGlu c2lkZSBpbWFnZSBvdmVybGF5cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93 ZWJ4ci9XZWJYUk9wYXF1ZUZyYW1lYnVmZmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv d2VieHIvV2ViWFJPcGFxdWVGcmFtZWJ1ZmZlci5jcHAKaW5kZXggMjMyOTQzMDNkODdjNDNlNzcz YWU5NjhiYjM4YWVkNTc1NjlmMDI4Zi4uODA3NTQzYzFmYjY3NjI3OTA0NmJiZDA3NzJiN2VkYjlh ZjZlMDhmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJ4ci9XZWJYUk9w YXF1ZUZyYW1lYnVmZmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnhyL1dl YlhST3BhcXVlRnJhbWVidWZmZXIuY3BwCkBAIC0xMTYsOCArMTE2LDcgQEAgdm9pZCBXZWJYUk9w YXF1ZUZyYW1lYnVmZmVyOjpzdGFydEZyYW1lKGNvbnN0IFBsYXRmb3JtWFI6OkRldmljZTo6RnJh bWVEYXRhOjpMYXkKICAgICAvLyB0aGUgdGV4dHVyZXMvcmVuZGVyYnVmZmVycy4KIAogI2lmIFVT RShJT1NVUkZBQ0VfRk9SX1hSX0xBWUVSX0RBVEEpCi0gICAgaWYgKCFkYXRhLnN1cmZhY2UpCi0g ICAgICAgIHJldHVybjsKKyAgICBBU1NFUlQoZGF0YS5zdXJmYWNlKTsKIAogICAgIGF1dG8gZ0NH TCA9IHN0YXRpY19jYXN0PEdyYXBoaWNzQ29udGV4dEdMT3BlbkdMKj4obV9jb250ZXh0LmdyYXBo aWNzQ29udGV4dEdMKCkpOwogICAgIEdDR0xlbnVtIHRleHR1cmVUYXJnZXQgPSBHcmFwaGljc0Nv bnRleHRHTE9wZW5HTDo6ZHJhd2luZ0J1ZmZlclRleHR1cmVUYXJnZXQoKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvV2ViRmFrZVhSRGV2aWNlLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3Rlc3RpbmcvV2ViRmFrZVhSRGV2aWNlLmNwcAppbmRleCA0OGNhOWY1ZTRlZDcyNTk5NGI5 YWNjNjg5NjU1NWE5YjE3YmRjNThkLi4xZGU4MWE2YTM5ODk3ODAwZDI0ODhjZGJiMDhjYWE3OTNh ZWE2ODFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL1dlYkZha2VYUkRldmlj ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9XZWJGYWtlWFJEZXZpY2UuY3BwCkBA IC0zNSw2ICszNSwxMCBAQAogI2luY2x1ZGUgPHd0Zi9Db21wbGV0aW9uSGFuZGxlci5oPgogI2lu Y2x1ZGUgPHd0Zi9NYXRoRXh0cmFzLmg+CiAKKyNpZiBVU0UoSU9TVVJGQUNFX0ZPUl9YUl9MQVlF Ul9EQVRBKQorI2luY2x1ZGUgIklPU3VyZmFjZS5oIgorI2VuZGlmCisKIG5hbWVzcGFjZSBXZWJD b3JlIHsKIAogc3RhdGljIGNvbnN0ZXhwciBTZWNvbmRzIEZha2VYUkZyYW1lVGltZSA9IDE1X21z OwpAQCAtMTQ2LDcgKzE1MCw4IEBAIHZvaWQgU2ltdWxhdGVkWFJEZXZpY2U6OmZyYW1lVGltZXJG aXJlZCgpCiAKICAgICBmb3IgKGF1dG8mIGxheWVyIDogbV9sYXllcnMpIHsKICNpZiBVU0UoSU9T VVJGQUNFX0ZPUl9YUl9MQVlFUl9EQVRBKQotICAgICAgICBkYXRhLmxheWVycy5hZGQobGF5ZXIu a2V5LCBGcmFtZURhdGE6OkxheWVyRGF0YSB7IH0pOworICAgICAgICBhdXRvIHN1cmZhY2UgPSBJ T1N1cmZhY2U6OmNyZWF0ZShyZWNvbW1lbmRlZFJlc29sdXRpb24oUGxhdGZvcm1YUjo6U2Vzc2lv bk1vZGU6OkltbWVyc2l2ZVZyKSwgRGVzdGluYXRpb25Db2xvclNwYWNlOjpTUkdCKCkpOworICAg ICAgICBkYXRhLmxheWVycy5hZGQobGF5ZXIua2V5LCBGcmFtZURhdGE6OkxheWVyRGF0YSB7IC5z dXJmYWNlID0gV1RGTW92ZShzdXJmYWNlKSB9KTsKICNlbHNlCiAgICAgICAgIGRhdGEubGF5ZXJz LmFkZChsYXllci5rZXksIEZyYW1lRGF0YTo6TGF5ZXJEYXRhIHsgLm9wYXF1ZVRleHR1cmUgPSBs YXllci52YWx1ZSB9KTsKICNlbmRpZgo=