226562 2021-06-02 17:26:37 -0700 Weak external symbols found when building with Release+Coverage configuration 2021-07-18 13:04:53 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 206686 226668 226684 228063 1 ddkilzer ddkilzer ews-watchlist jbedard tuomas.webkit webkit-bug-importer oldest_to_newest 1766232 0 ddkilzer 2021-06-02 17:26:37 -0700 Weak external symbols found when building with Release+Coverage configuration: PhaseScriptExecution Check\ For\ Weak\ VTables\ and\ Externals JavaScriptCore.build/Release/JavaScriptCore.build/Script-5D29D8BE0E9860B400C3D2D0.sh cd OpenSource/Source/JavaScriptCore /bin/sh -c JavaScriptCore.build/Release/JavaScriptCore.build/Script-5D29D8BE0E9860B400C3D2D0.sh ERROR: JavaScriptCore has a weak external symbol in it (Release/JavaScriptCore.framework/Versions/A/JavaScriptCore) ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library. ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file. ERROR: symbol ___llvm_profile_filename ERROR: symbol ___llvm_profile_raw_version ERROR: symbol _lprofDirMode Command /bin/sh failed with exit code 1 <rdar://problem/78765608> 1766233 1 430423 ddkilzer 2021-06-02 17:30:27 -0700 Created attachment 430423 Patch v1 1766644 2 ews-feeder 2021-06-03 19:21:05 -0700 Committed r278444 (238464@main): <https://commits.webkit.org/238464@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430423. 1766785 3 ddkilzer 2021-06-04 08:56:49 -0700 Follow-up build fix for coverage+release builds due to weak external symbol: REGRESSION (r278121): Fix build failure due to weak external symbol Committed r278461 (278461@main): <https://commits.webkit.org/278461@main> 430423 2021-06-02 17:30:27 -0700 2021-06-03 19:21:06 -0700 Patch v1 bug-226562-20210602173026.patch text/plain 4103 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MjI3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGYzMTQzNzhlZmVkODMyOTk2NGI2MzU2NDcxZjgzOTI3 MzdhYmNlOS4uZjg4NmM0YjE1ZTExYjk3YTliOTZiMWRmNGNmNGRhZjgyNzNmYmM0YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4 IEBACisyMDIxLTA2LTAyICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgV2VhayBleHRlcm5hbCBzeW1ib2xzIGZvdW5kIHdoZW4gYnVpbGRpbmcgd2l0aCBSZWxl YXNlK0NvdmVyYWdlIGNvbmZpZ3VyYXRpb24KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9i LzIyNjU2Mj4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc4NzY1NjA4PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9jaGVjay1mb3It d2Vhay12dGFibGVzLWFuZC1leHRlcm5hbHM6CisgICAgICAgIC0gSWdub3JlIHdlYWsgc3ltYm9s cyBmcm9tIGxsdm0gd2hlbiBidWlsZGluZyB3aXRoCisgICAgICAgICAgY292ZXJhZ2UgZW5hYmxl ZC4gIFRoaXMgZml4ZXMgdGhlIGJ1aWxkLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5w bToKKyAgICAgICAgKFhjb2RlT3B0aW9ucyk6CisgICAgICAgIC0gU3dpdGNoIHRvIHVzaW5nIFhj b2RlQ292ZXJhZ2VTdXBwb3J0T3B0aW9ucygpIHNvCisgICAgICAgICAgYG1ha2VgIGFuZCBgYnVp bGQtd2Via2l0YCBib3RoIHVzZSB0aGUgc2FtZQorICAgICAgICAgIGNvbmZpZ3VyYXRpb24uCisg ICAgICAgIChYY29kZUNvdmVyYWdlU3VwcG9ydE9wdGlvbnMpOgorICAgICAgICAtIFJlbW92ZSBv bGQgWGNvZGUgdmFyaWFibGVzIGZyb20gMjAwOCBpbiBmYXZvciBvZgorICAgICAgICAgIHBhc3Np bmcgYC14Y2NvbmZpZyBUb29scy9jb3ZlcmFnZS9jb3ZlcmFnZS54Y2NvbmZpZ2AuCisgICAgICAg ICogY292ZXJhZ2UvY292ZXJhZ2UueGNjb25maWc6CisgICAgICAgIChPVEhFUl9DUExVU1BMVVNG TEFHUyk6CisgICAgICAgIC0gUmVtb3ZlIE9USEVSX0NQTFVTUExVU0ZMQUdTIHNpbmNlIHRoaXMg anVzdCBjYXVzZWQKKyAgICAgICAgICBkdXBsaWNhdGUgY29tbWFuZC1saW5lIHN3aXRjaGVzIHRv IGJlIHVzZWQgd2hlbgorICAgICAgICAgIGNvbXBpbGluZyBDKysgc291cmNlcy4KKwogMjAyMS0w NS0yOCAgTWF0dCBHaWxsaWdhbiAgPG1hdHRoZXdfZ2lsbGlnYW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFByZXZlbnQgcmVzZXR0aW5nIHNjcm9sbCBwb3NpdGlvbiBpbiB1bm5lY2Vzc2FyeSBjYXNl cyBkdXJpbmcgcGFnZSBsb2FkCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2NoZWNrLWZvci13 ZWFrLXZ0YWJsZXMtYW5kLWV4dGVybmFscyBiL1Rvb2xzL1NjcmlwdHMvY2hlY2stZm9yLXdlYWst dnRhYmxlcy1hbmQtZXh0ZXJuYWxzCmluZGV4IDhiY2RlZTI4NzgyZTlmZjJkNjY5Nzg1NmFjYTYw MTYwNGY2Njg1OTguLjQ4ZDY1ZjEwM2RiZDgzMDFkMTllZDViNWEyNGJlMWU0ZjEwNjZhMGMgMTAw NzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvY2hlY2stZm9yLXdlYWstdnRhYmxlcy1hbmQtZXh0ZXJu YWxzCisrKyBiL1Rvb2xzL1NjcmlwdHMvY2hlY2stZm9yLXdlYWstdnRhYmxlcy1hbmQtZXh0ZXJu YWxzCkBAIC02OCw2ICs2OCw5IEBAIGlmICghZGVmaW5lZCAkZXhlY3V0YWJsZVBhdGhBZ2UgfHwg IWRlZmluZWQgJGJ1aWxkVGltZXN0YW1wQWdlIHx8ICRleGVjdXRhYmxlUGF0CiAgICAgICAgICAg ICAjIEFTYW4gY29tcGlsZXItcnQgY2FsbHMgaW50byBfX2FzYW5fbWFwcGluZ19vZmZzZXQgYW5k IF9fYXNhbl9tYXBwaW5nX3NjYWxlCiAgICAgICAgICAgICBuZXh0IGlmIC9cYl9fX2FzYW4vOwog CisgICAgICAgICAgICAjIElnbm9yZSB3ZWFrIHN5bWJvbHMgcHJlc2VudCB3aGVuIGNvbXBpbGlu ZyB3aXRoIGNvdmVyYWdlIGVuYWJsZWQuCisgICAgICAgICAgICBuZXh0IGlmIC9cYihfX19sbHZt X3Byb2ZpbGVfZmlsZW5hbWV8X19fbGx2bV9wcm9maWxlX3Jhd192ZXJzaW9ufF9scHJvZkRpck1v ZGUpLyAmJiBjb3ZlcmFnZUlzRW5hYmxlZCgpOworCiAgICAgICAgICAgICBpZiAoL3dlYWsgZXh0 ZXJuYWwgdnRhYmxlIGZvciAoLiopJC8pIHsKICAgICAgICAgICAgICAgICBwdXNoIEB3ZWFrVlRh YmxlQ2xhc3NlcywgJDE7CiAgICAgICAgICAgICB9IGVsc2lmICgvd2VhayBleHRlcm5hbCAoLiop JC8pIHsKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCAwN2IwMzhiMDRhY2RjY2IxNDI0YTE5OTEwNjJhZmE1 YzEyYjRhNDVhLi5lYWQwMDEwODI4NGYwOTY0OWMwZjA5NTExZDM4OGVlZjBkN2VhMTQ2IDEwMDc1 NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRkaXJzLnBtCkBAIC0xMDIyLDcgKzEwMjIsNyBAQCBzdWIgWGNvZGVPcHRpb25zCiAgICAg ICAgIHB1c2ggQG9wdGlvbnMsICgiLXhjY29uZmlnIiwgRmlsZTo6U3BlYy0+Y2F0ZmlsZShzb3Vy Y2VEaXIoKSwgIlRvb2xzIiwgInNhbml0aXplciIsICJ0c2FuLnhjY29uZmlnIikpOwogICAgIH0K ICAgICBwdXNoIEBvcHRpb25zLCAoIi14Y2NvbmZpZyIsIEZpbGU6OlNwZWMtPmNhdGZpbGUoc291 cmNlRGlyKCksICJUb29scyIsICJzYW5pdGl6ZXIiLCAidWJzYW4ueGNjb25maWciKSkgaWYgJHVi c2FuSXNFbmFibGVkOwotICAgIHB1c2ggQG9wdGlvbnMsICgiLXhjY29uZmlnIiwgc291cmNlRGly KCkgLiAiL1Rvb2xzL2NvdmVyYWdlL2NvdmVyYWdlLnhjY29uZmlnIikgaWYgJGNvdmVyYWdlSXNF bmFibGVkOworICAgIHB1c2ggQG9wdGlvbnMsIFhjb2RlQ292ZXJhZ2VTdXBwb3J0T3B0aW9ucygp IGlmICRjb3ZlcmFnZUlzRW5hYmxlZDsKICAgICBwdXNoIEBvcHRpb25zLCAoIkdDQ19PUFRJTUla QVRJT05fTEVWRUw9JGZvcmNlT3B0aW1pemF0aW9uTGV2ZWwiKSBpZiAkZm9yY2VPcHRpbWl6YXRp b25MZXZlbDsKICAgICBwdXNoIEBvcHRpb25zLCAiV0tfTFRPX01PREU9JGx0b01vZGUiIGlmICRs dG9Nb2RlOwogICAgIHB1c2ggQG9wdGlvbnMsIEBiYXNlUHJvZHVjdERpck9wdGlvbjsKQEAgLTEw NjIsMTAgKzEwNjIsNyBAQCBzdWIgWGNvZGVPcHRpb25TdHJpbmdOb0NvbmZpZwogCiBzdWIgWGNv ZGVDb3ZlcmFnZVN1cHBvcnRPcHRpb25zKCkKIHsKLSAgICBteSBAY292ZXJhZ2VTdXBwb3J0T3B0 aW9ucyA9ICgpOwotICAgIHB1c2ggQGNvdmVyYWdlU3VwcG9ydE9wdGlvbnMsICJHQ0NfR0VORVJB VEVfVEVTVF9DT1ZFUkFHRV9GSUxFUz1ZRVMiOwotICAgIHB1c2ggQGNvdmVyYWdlU3VwcG9ydE9w dGlvbnMsICJHQ0NfSU5TVFJVTUVOVF9QUk9HUkFNX0ZMT1dfQVJDUz1ZRVMiOwotICAgIHJldHVy biBAY292ZXJhZ2VTdXBwb3J0T3B0aW9uczsKKyAgICByZXR1cm4gKCIteGNjb25maWciLCBzb3Vy Y2VEaXIoKSAuICIvVG9vbHMvY292ZXJhZ2UvY292ZXJhZ2UueGNjb25maWciKTsKIH0KIAogc3Vi IFhjb2RlU3RhdGljQW5hbHl6ZXJPcHRpb24oKQpkaWZmIC0tZ2l0IGEvVG9vbHMvY292ZXJhZ2Uv Y292ZXJhZ2UueGNjb25maWcgYi9Ub29scy9jb3ZlcmFnZS9jb3ZlcmFnZS54Y2NvbmZpZwppbmRl eCBhMmNlOTE0ZjIyZGE0MDUyNjQxYzViNmIzODU4NjVlM2M4Y2ZlZmQ3Li4wZWYyMmMxN2Y3MmY2 MTg2NGY5YzJmMzg5ZWRiNDE4MGFiODFjN2E3IDEwMDY0NAotLS0gYS9Ub29scy9jb3ZlcmFnZS9j b3ZlcmFnZS54Y2NvbmZpZworKysgYi9Ub29scy9jb3ZlcmFnZS9jb3ZlcmFnZS54Y2NvbmZpZwpA QCAtMSwzICsxLDIgQEAKIE9USEVSX0NGTEFHUyA9ICQoaW5oZXJpdGVkKSAtZnByb2ZpbGUtaW5z dHItZ2VuZXJhdGUgLWZjb3ZlcmFnZS1tYXBwaW5nOwotT1RIRVJfQ1BMVVNQTFVTRkxBR1MgPSAk KGluaGVyaXRlZCkgLWZwcm9maWxlLWluc3RyLWdlbmVyYXRlIC1mY292ZXJhZ2UtbWFwcGluZzsK IE9USEVSX0xERkxBR1MgPSAkKGluaGVyaXRlZCkgLWZwcm9maWxlLWluc3RyLWdlbmVyYXRlOwo=