22656 2008-12-04 12:10:17 -0800 tests document.write() 2010-04-26 19:10:56 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Mac OS X 10.5 RESOLVED DUPLICATE 32755 P4 Minor --- 0 krackguy webkit-unassigned joepeck pam oldest_to_newest 101362 0 krackguy 2008-12-04 12:10:17 -0800 This patch tests that document.write() with no parameters does not output any text. 101363 1 25746 krackguy 2008-12-04 12:11:01 -0800 Created attachment 25746 patch for testing document.write 101405 2 25746 darin 2008-12-04 16:01:35 -0800 Comment on attachment 25746 patch for testing document.write This test looks fine, but the patch needs to also include a ChangeLog entry. Also, we prefer to have the "newline at end of file" unless there's a reason not to have it. Also, we prefer tests that cover a bit more per test. It's OK to have a test that tests only this one targeted thing, but it's better to cover more per test so our tests cover a lot of different cases and run quickly. 217324 3 joepeck 2010-04-26 15:34:43 -0700 It looks like testing an empty document.write is now covered by: LayoutTests/fast/forms/document-write-empty.html The Git/SVN/Trac History of this file seems to be confused: http://trac.webkit.org/browser/trunk/LayoutTests/fast/forms/document-write-empty.html?rev=58265 The content is essentially identical, and the test's description is verbatim! I don't really know what is best, so I'm closing this as "Works For Me" because there is now a test. I'd mark it a duplicate, but I can't accurately find the original bug. 217437 4 ap 2010-04-26 19:10:56 -0700 *** This bug has been marked as a duplicate of bug 32755 *** 25746 2008-12-04 12:11:01 -0800 2008-12-04 16:01:35 -0800 patch for testing document.write document-write-empty-patch.txt text/plain 906 krackguy SW5kZXg6IGRvY3VtZW50LXdyaXRlLWVtcHR5LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBk b2N1bWVudC13cml0ZS1lbXB0eS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBkb2N1bWVu dC13cml0ZS1lbXB0eS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMyBAQAor VGhpcyB0ZXN0cyB0aGF0IGRvY3VtZW50LndyaXRlKCkgd2l0aCBubyBwYXJhbWV0ZXJzIGRvZXMg bm90IG91dHB1dCBhbnkgdGV4dC4KKworVGhlcmUgc2hvdWxkIG5vdCBiZSBhbnkgdGV4dCBiZWxv dyB0aGlzIHNlbnRlbmNlLgpJbmRleDogZG9jdW1lbnQtd3JpdGUtZW1wdHkuaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBkb2N1bWVudC13cml0ZS1lbXB0eS5odG1sCShyZXZpc2lvbiAwKQorKysgZG9jdW1l bnQtd3JpdGUtZW1wdHkuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxNCBAQAorPGh0bWw+ Cis8Ym9keT4KKzxwPlRoaXMgdGVzdHMgdGhhdCBkb2N1bWVudC53cml0ZSgpIHdpdGggbm8gcGFy YW1ldGVycyBkb2VzIG5vdCBvdXRwdXQgYW55IHRleHQuPC9wPgorCis8cD5UaGVyZSBzaG91bGQg bm90IGJlIGFueSB0ZXh0IGJlbG93IHRoaXMgc2VudGVuY2UuPC9wPgorPHNjcmlwdD4KKyAgICBp ZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICBsYXlvdXRUZXN0Q29udHJv bGxlci5kdW1wQXNUZXh0KCk7CisgIAorICAgIGRvY3VtZW50LndyaXRlKCk7ICAKKzwvc2NyaXB0 PgorIAorPC9ib2R5PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK