226540 2021-06-02 09:49:36 -0700 [test-webkit-lldb] 3 dump_class_layout_unittest.TestDumpClassLayout tests failing with Xcode 12.5 2021-06-09 14:31:29 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=226603 InRadar P2 Normal --- 1 ryanhaddad webkit-unassigned ap jbedard simon.fraser webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1766041 0 ryanhaddad 2021-06-02 09:49:36 -0700 3 dump_class_layout_unittest.TestDumpClassLayout tests are failing on bots with Xcode 12.5 install [14/42] dump_class_layout_unittest.TestDumpClassLayout.serial_test_MemberHasBitfieldPadding failed: Traceback (most recent call last): File "/Volumes/Data/worker/bigsur-release-tests-wk2/build/Tools/lldb/dump_class_layout_unittest.py", line 358, in serial_test_MemberHasBitfieldPadding self.assertEqual(EXPECTED_RESULT, actual_layout.as_string()) AssertionError: ' +0[383 chars]2 < 2> <PADDING: 2 bytes>\n +4 < 4> [387 chars]50 %' != ' +0[383 chars]2 < 1> <PADDING: 1 bytes>\n +4 < 4> [387 chars]98 %' +0 < 24> MemberHasBitfieldPadding +0 < 16> ClassWithPaddedBitfields bitfieldMember +0 < 1> bool boolMember +1 < :1> unsigned int bitfield1 : 1 +1 < :1> bool bitfield2 : 1 +1 < :2> unsigned int bitfield3 : 2 +1 < :1> unsigned int bitfield4 : 1 +1 < :2> unsigned long bitfield5 : 2 +1 < :1> <UNUSED BITS: 1 bit> - +2 < 2> <PADDING: 2 bytes> ? ^ ^ + +2 < 1> <PADDING: 1 bytes> ? ^ ^ +4 < 4> int intMember +8 < :1> unsigned int bitfield7 : 1 +8 < :9> unsigned int bitfield8 : 9 +9 < :1> bool bitfield9 : 1 +9 < :5> <UNUSED BITS: 5 bits> +10 < 6> <PADDING: 6 bytes> +16 < :1> bool bitfield1 : 1 +16 < :7> <UNUSED BITS: 7 bits> +17 < 7> <PADDING: 7 bytes> Total byte size: 24 - Total pad bytes: 15 ? ^ + Total pad bytes: 14 ? ^ - Padding percentage: 62.50 %? ^ ^^ + Padding percentage: 61.98 %? ^ ^^ [35/42] dump_class_layout_unittest.TestDumpClassLayout.serial_test_InheritsFromClassWithPaddedBitfields failed: Traceback (most recent call last): File "/Volumes/Data/worker/bigsur-release-tests-wk2/build/Tools/lldb/dump_class_layout_unittest.py", line 383, in serial_test_InheritsFromClassWithPaddedBitfields self.assertEqual(EXPECTED_RESULT, actual_layout.as_string()) AssertionError: ' +0[405 chars]2 < 2> <PADDING: 2 bytes>\n +4 < 4> [359 chars]75 %' != ' +0[405 chars]2 < 1> <PADDING: 1 bytes>\n +4 < 4> [359 chars]97 %' +0 < 16> InheritsFromClassWithPaddedBitfields +0 < 16> ClassWithPaddedBitfields ClassWithPaddedBitfields +0 < 1> bool boolMember +1 < :1> unsigned int bitfield1 : 1 +1 < :1> bool bitfield2 : 1 +1 < :2> unsigned int bitfield3 : 2 +1 < :1> unsigned int bitfield4 : 1 +1 < :2> unsigned long bitfield5 : 2 +1 < :1> <UNUSED BITS: 1 bit> - +2 < 2> <PADDING: 2 bytes> ? ^ ^ + +2 < 1> <PADDING: 1 bytes> ? ^ ^ +4 < 4> int intMember +8 < :1> unsigned int bitfield7 : 1 +8 < :9> unsigned int bitfield8 : 9 +9 < :1> bool bitfield9 : 1 +9 < :5> <UNUSED BITS: 5 bits> +10 < :1> bool derivedBitfield : 1 +10 < :7> <UNUSED BITS: 7 bits> +11 < 5> <PADDING: 5 bytes> Total byte size: 16 - Total pad bytes: 7 ? ^ + Total pad bytes: 6 ? ^ - Padding percentage: 43.75 %? ^ - + Padding percentage: 42.97 %? ^ + [38/42] dump_class_layout_unittest.TestDumpClassLayout.serial_test_ClassWithPaddedBitfields failed: Traceback (most recent call last): File "/Volumes/Data/worker/bigsur-release-tests-wk2/build/Tools/lldb/dump_class_layout_unittest.py", line 332, in serial_test_ClassWithPaddedBitfields self.assertEqual(EXPECTED_RESULT, actual_layout.as_string()) AssertionError: ' +0[299 chars]2 < 2> <PADDING: 2 bytes>\n +4 < 4> int[260 chars]00 %' != ' +0[299 chars]2 < 1> <PADDING: 1 bytes>\n +4 < 4> int[260 chars]22 %' +0 < 16> ClassWithPaddedBitfields +0 < 1> bool boolMember +1 < :1> unsigned int bitfield1 : 1 +1 < :1> bool bitfield2 : 1 +1 < :2> unsigned int bitfield3 : 2 +1 < :1> unsigned int bitfield4 : 1 +1 < :2> unsigned long bitfield5 : 2 +1 < :1> <UNUSED BITS: 1 bit> - +2 < 2> <PADDING: 2 bytes> ? ^ ^ + +2 < 1> <PADDING: 1 bytes> ? ^ ^ +4 < 4> int intMember +8 < :1> unsigned int bitfield7 : 1 +8 < :9> unsigned int bitfield8 : 9 +9 < :1> bool bitfield9 : 1 +9 < :5> <UNUSED BITS: 5 bits> +10 < 6> <PADDING: 6 bytes> Total byte size: 16 - Total pad bytes: 8 ? ^ + Total pad bytes: 7 ? ^ - Padding percentage: 50.00 %? ^^ ^^ + Padding percentage: 49.22 %? ^^ ^^ https://build.webkit.org/#/builders/70/builds/3047/steps/12/logs/stdio 1766043 1 webkit-bug-importer 2021-06-02 09:50:09 -0700 <rdar://problem/78768841> 1766050 2 ryanhaddad 2021-06-02 09:56:26 -0700 Simon, does this look like something we need to rebaseline? 1766065 3 simon.fraser 2021-06-02 10:42:35 -0700 Looks like a progression, yeah, but will depend on the tools version. 1768352 4 ryanhaddad 2021-06-09 14:31:29 -0700 Rebaselined in https://trac.webkit.org/changeset/278674/webkit