<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>226539</bug_id>
          
          <creation_ts>2021-06-02 09:46:20 -0700</creation_ts>
          <short_desc>Web Inspector: [Cocoa] `RemoteInspector` won&apos;t connect to a new relay if it hasn&apos;t yet failed to communicate with a previously connected relay</short_desc>
          <delta_ts>2021-07-26 15:00:45 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>228303</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Patrick Angle">pangle</reporter>
          <assigned_to name="Patrick Angle">pangle</assigned_to>
          <cc>ews-watchlist</cc>
    
    <cc>hi</cc>
    
    <cc>inspector-bugzilla-changes</cc>
    
    <cc>joepeck</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>pangle</cc>
    
    <cc>saam</cc>
    
    <cc>tzagallo</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1766038</commentid>
    <comment_count>0</comment_count>
    <who name="Patrick Angle">pangle</who>
    <bug_when>2021-06-02 09:46:20 -0700</bug_when>
    <thetext>&lt;rdar://78237764&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1766040</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-06-02 09:46:39 -0700</bug_when>
    <thetext>&lt;rdar://problem/78768633&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1766108</commentid>
    <comment_count>2</comment_count>
      <attachid>430392</attachid>
    <who name="Patrick Angle">pangle</who>
    <bug_when>2021-06-02 12:34:53 -0700</bug_when>
    <thetext>Created attachment 430392
Patch v1.0</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1766112</commentid>
    <comment_count>3</comment_count>
    <who name="Patrick Angle">pangle</who>
    <bug_when>2021-06-02 12:43:33 -0700</bug_when>
    <thetext>Correct radar is &lt;rdar://78237764&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1766114</commentid>
    <comment_count>4</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2021-06-02 12:49:54 -0700</bug_when>
    <thetext>&lt;rdar://78237764&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1766210</commentid>
    <comment_count>5</comment_count>
      <attachid>430392</attachid>
    <who name="Devin Rousso">hi</who>
    <bug_when>2021-06-02 16:34:14 -0700</bug_when>
    <thetext>Comment on attachment 430392
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=430392&amp;action=review

r=me, nice fix with a great explanation :)

&gt; Source/JavaScriptCore/inspector/remote/RemoteInspector.h:263
&gt; +    bool m_allowRetryRelayConnection { false };

NIT: How about something a bit more specific/explanatory like `m_shouldReconnectToRelayOnFailure`?

&gt; Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm:281
&gt; +        m_relayConnection-&gt;sendMessage(@&quot;syn&quot;, nil);

NIT: I wonder if maybe we should give this a different name so it shows up differently in logging.  If we do keep the same name, perhaps we should create a static constant instead of hardcoding in both spots?

&gt; Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm:376
&gt; +    if (m_allowRetryRelayConnection) {

Style: I&apos;d make this into an early return

&gt; Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm:377
&gt; +        WTFLogAlways(&quot;RemoteInspector XPC connection to relay failed, reattempting connection...&quot;);

NIT: s/reattempting connection/reconnecting/

&gt; Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm:380
&gt; +        dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{

Should we maybe wait a second or two before attempting to reconnect?

&gt; Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm:384
&gt; +        m_allowRetryRelayConnection = false;

NIT: I&apos;d put this as the first thing in the `if` so that if someone adds an early return in the future it&apos;s less likely to be missed/forgotten</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1766445</commentid>
    <comment_count>6</comment_count>
      <attachid>430484</attachid>
    <who name="Patrick Angle">pangle</who>
    <bug_when>2021-06-03 11:03:23 -0700</bug_when>
    <thetext>Created attachment 430484
Patch v1.1 - Review nits</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1766467</commentid>
    <comment_count>7</comment_count>
      <attachid>430491</attachid>
    <who name="Patrick Angle">pangle</who>
    <bug_when>2021-06-03 11:35:41 -0700</bug_when>
    <thetext>Created attachment 430491
Patch v1.1.1 - Add reviewer to changelog</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1766478</commentid>
    <comment_count>8</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-06-03 12:32:29 -0700</bug_when>
    <thetext>Committed r278413 (238438@main): &lt;https://commits.webkit.org/238438@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430491.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>430392</attachid>
            <date>2021-06-02 12:34:53 -0700</date>
            <delta_ts>2021-06-03 11:03:21 -0700</delta_ts>
            <desc>Patch v1.0</desc>
            <filename>bug-226539-20210602123452.patch</filename>
            <type>text/plain</type>
            <size>6051</size>
            <attacher name="Patrick Angle">pangle</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MzI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl
MGI1NDVlOGM2ZTIwNWFhOThjMTc4NDUyNDkwOTQ4OWQzNTI4OTZmLi42YTQwZTQ5YzY0OWEwMGFl
MGM3MzZlMzEzYWY0MDIwZTA5ZDhiYTIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSw0MCBAQAorMjAyMS0wNi0wMiAgUGF0cmljayBBbmdsZSAgPHBhbmdsZUBhcHBsZS5jb20+
CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogW0NvY29hXSBgUmVtb3RlSW5zcGVjdG9yYCB3b24n
dCBjb25uZWN0IHRvIGEgbmV3IHJlbGF5IGlmIGl0IGhhc24ndCB5ZXQgZmFpbGVkIHRvIGNvbW11
bmljYXRlIHdpdGggYSBwcmV2aW91c2x5IGNvbm5lY3RlZCByZWxheQorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2NTM5CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgYFJlbW90ZUluc3BlY3RvcmAgY29tbXVu
aWNhdGVzIHdpdGggYSByZWxheSBkYWVtb24gcnVubmluZyBvbiB0aGUgc2FtZSBkZXZpY2UgaW4g
b3JkZXIgdG8gc2VuZCB1cGRhdGVzIGxpa2UgbmV3CisgICAgICAgIG9yIHJlbW92ZWQgaW5zcGVj
dGFibGUgdGFyZ2V0cyBhbmQgcmVjZWl2ZSBjaGFuZ2VzIHRvIHNldHRpbmdzIGxpa2UgYXV0b21h
dGljIGRlYnVnZ2luZy4gVGhlIHJlbGF5IGRhZW1vbiB0aGVuCisgICAgICAgIGNvbW11bmljYXRl
cyB3aXRoIGEgY2xpZW50IHRoYXQgY29ubmVjdHMgZm9yIGRlYnVnZ2luZy4gT25seSBvbmUgcmVs
YXkgZGFlbW9uIHNob3VsZCBldmVyIGJlIHJ1bm5pbmcgYXQgYSB0aW1lLAorICAgICAgICBhbmQg
aXRzIGxpZmVjeWNsZSBpcyBtYW5hZ2VkIHNlcGVyYXRlbHkgZnJvbSBKYXZhU2NyaXB0Q29yZS4K
KworICAgICAgICBSZW1vdGVJbnNwZWN0b3IgaG9sZHMgYSBSZWZQdHIgdG8gaXRzIGNvbm5lY3Rp
b24gdG8gdGhpcyByZWxheSwgYW5kIG9ubHkgY2xlYXJzIHRoaXMgcG9pbnRlciB1cG9uIGEgZmFp
bHVyZSB0bworICAgICAgICBjb21tdW5pY2F0ZSBvdmVyIHRoZSBYUEMgY29ubmVjdGlvbiBvciBh
IGtub3duIGRpc2Nvbm5lY3Rpb24uIEhvd2V2ZXIsIGl0IGlzIHBvc3NpYmxlLCBhbmQgaW4gc29t
ZSBjYXNlcyBsaWtlbHkKKyAgICAgICAgKGZvciBleGFtcGxlIHRoZSByZWxheSByZXN0YXJ0aW5n
IGZyb20gYSBicmllZiBjbGllbnQgZGlzY29ubmVjdGlvbiBhbmQgcmVjb25uZWN0aW9uKSwgdGhh
dCB3ZSBjYW4gYmUgaW5mb3JtZWQKKyAgICAgICAgb2YgYSBuZXdseSBsYXVuY2hlZCByZWxheSBi
ZWluZyBhdmFpbGFibGUgd2hpbGUgc3RpbGwgdGhpbmtpbmcgd2UgYXJlIGNvbm5lY3RlZCB0byB0
aGUgb2xkIHJlbGF5LCBhcyB3ZSBoYXZlIG5vdCAKKyAgICAgICAgeWV0IHNlbnQgYSBtZXNzYWdl
IGFuZCB0cmlnZ2VyZWQgYSBmYWlsdXJlIGluIHRoZSBpbnRlcmltIHBlcmlvZCBvZiB0aW1lLgor
CisgICAgICAgIFRvIGNvcnJlY3QgdGhpcyB3ZSBub3cgc2VuZCBhIHNpbXBsZSBtZXNzYWdlIGFu
eSB0aW1lIGBzZXR1cFhQQ0Nvbm5lY3Rpb25JZk5lZWRlZGAgaXMgY2FsbGVkIGlmIHdlIGhhdmUg
YW4KKyAgICAgICAgZXhpc3RpbmcgUmVmUHRyIHRvIGEgcmVsYXkgY29ubmVjdGlvbiBpbiBvcmRl
ciB0byB2ZXJpZnkgdGhlIGNvbm5lY3Rpb24gaXMgc3RpbGwgZnVuY3Rpb25hbC4gV2Ugbm93IGFs
c28gcmV0cnkKKyAgICAgICAgdG8gY29ubmVjdCB0byBhIHJlbGF5IHVwb24gZmFpbHVyZSBpbiBv
cmRlciB0byBjcmVhdGUgYSBuZXcgY29ubmVjdGlvbiB0byB0aGUgY3VycmVudCByZWxheS4KKwor
ICAgICAgICBJbiBvcmRlciB0byBwcmV2ZW50IGVudGVyaW5nIGEgcmV0cnkgbG9vcCB3aGVyZSBl
dmVyeSBzdWJzZXF1ZW50IHJldHJ5J3MgZmFpbHVyZSByZXN1bHRzIGluIGFub3RoZXIgcmV0cnkK
KyAgICAgICAgZm9yZXZlciwgYSBmbGFnIHRvIHJldHJ5IGNvbm5lY3RpbmcgaXMgc2V0IHdoZW4g
YSBjYWxsIHRvIHNldHVwWFBDQ29ubmVjdGlvbklmTmVlZGVkIGlzIG1hZGUgd2hpbGUgd2UgYWxy
ZWFkeQorICAgICAgICBoYXZlIGEgUmVmUHRyIHRvIGEgcmVsYXkgY29ubmVjdGlvbi4gT24gZmFp
bHVyZSBpZiB3ZSBhcmUgaW4gdGhpcyBzcGVjaWFsIHN0YXRlIHdlIHdpbGwgcmV0cnkgb25jZSB0
byBjb25uZWN0CisgICAgICAgIGJ1dCBzdWJzZXF1ZW50IGZhaWx1cmVzIHdpbGwgbm90IGF1dG9t
YXRpY2FsbHkgcmVhdHRlbXB0IGEgY29ubmVjdGlvbi4KKworICAgICAgICAqIGluc3BlY3Rvci9y
ZW1vdGUvUmVtb3RlSW5zcGVjdG9yLmg6CisgICAgICAgICogaW5zcGVjdG9yL3JlbW90ZS9jb2Nv
YS9SZW1vdGVJbnNwZWN0b3JDb2NvYS5tbToKKyAgICAgICAgKEluc3BlY3Rvcjo6UmVtb3RlSW5z
cGVjdG9yOjpzdG9wSW50ZXJuYWwpOgorICAgICAgICAtIENsZWFyIHRoZSByZXRyeSBjb25uZWN0
aW9uIGZsYWcgd2hlbiBzdG9wcGluZyBpbiBhbiBvcmRlcmx5IGZhc2hpb24uCisgICAgICAgIChJ
bnNwZWN0b3I6OlJlbW90ZUluc3BlY3Rvcjo6c2V0dXBYUENDb25uZWN0aW9uSWZOZWVkZWQpOgor
ICAgICAgICAtIFNldCB0aGUgcmV0cnkgY29ubmVjdGlvbiBmbGFnIGFuZCBzZW5kIGEgc2ltcGxl
IG1lc3NhZ2UgaWYgd2UgYWxyZWFkeSBoYXZlIGEgcmVsYXkgY29ubmVjdGlvbiBpbiBvcmRlciB0
byBtYWtlIHN1cmUgdGhlIGNvbm5lY3Rpb24gaXMgZWl0aGVyCisgICAgICAgIHN0aWxsIHZhbGlk
IG9yIGlzIHRvcm4gZG93biBwcm9wZXJseSBvbiBmYWlsdXJlLgorICAgICAgICAoSW5zcGVjdG9y
OjpSZW1vdGVJbnNwZWN0b3I6OnhwY0Nvbm5lY3Rpb25GYWlsZWQpOgorICAgICAgICAtIElmIHRo
ZSByZXRyeSBmbGFnIGlzIHNldCwgc2NoZWR1bGUgYSByZXRyeSBhbmQgY2xlYXIgdGhlIHJldHJ5
IGZsYWcuCisKIDIwMjEtMDYtMDEgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdh
bGlhLmNvbT4KIAogICAgICAgICBbV1BFXVtHVEtdIFN1cHBvcnQgYnVpbGRpbmcgYWdhaW5zdCB1
Q2xpYmMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3Rl
L1JlbW90ZUluc3BlY3Rvci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1v
dGUvUmVtb3RlSW5zcGVjdG9yLmgKaW5kZXggMGU1YzY4MjZkNmQzZjg4ODU2YjI0YzcxODM2NWQ4
NzkzZTJjOWY4MC4uM2IxYzk5MDQwMTIxMWZlZjRmMmMzYzEyNjk4ODBhMWFhNjFhZmNkMiAxMDA2
NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5z
cGVjdG9yLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVt
b3RlSW5zcGVjdG9yLmgKQEAgLTI2MCw2ICsyNjAsNyBAQCBwcml2YXRlOgogCiAjaWYgUExBVEZP
Uk0oQ09DT0EpCiAgICAgUmVmUHRyPFJlbW90ZUluc3BlY3RvclhQQ0Nvbm5lY3Rpb24+IG1fcmVs
YXlDb25uZWN0aW9uOworICAgIGJvb2wgbV9hbGxvd1JldHJ5UmVsYXlDb25uZWN0aW9uIHsgZmFs
c2UgfTsKICNlbmRpZgogI2lmIFVTRShHTElCKQogICAgIFJlZlB0cjxTb2NrZXRDb25uZWN0aW9u
PiBtX3NvY2tldENvbm5lY3Rpb247CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv
aW5zcGVjdG9yL3JlbW90ZS9jb2NvYS9SZW1vdGVJbnNwZWN0b3JDb2NvYS5tbSBiL1NvdXJjZS9K
YXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL2NvY29hL1JlbW90ZUluc3BlY3RvckNvY29h
Lm1tCmluZGV4IDc1ZjM5NDM3YmU1YjlmYzkwNWIwZDJhYzZmMDZkNDMwZjhiYjY1OTEuLjkyMjYz
MzMzYWNjNzJlNzM0Yzg4NTRjNzQ0YzI4ZDhlYTY2NWVhZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K
YXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL2NvY29hL1JlbW90ZUluc3BlY3RvckNvY29h
Lm1tCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL2NvY29hL1Jl
bW90ZUluc3BlY3RvckNvY29hLm1tCkBAIC0yNjUsNiArMjY1LDggQEAgdm9pZCBSZW1vdGVJbnNw
ZWN0b3I6OnN0b3BJbnRlcm5hbChTdG9wU291cmNlIHNvdXJjZSkKICAgICAgICAgbV9yZWxheUNv
bm5lY3Rpb24gPSBudWxscHRyOwogICAgIH0KIAorICAgIG1fYWxsb3dSZXRyeVJlbGF5Q29ubmVj
dGlvbiA9IGZhbHNlOworCiAgICAgbm90aWZ5X2NhbmNlbChtX25vdGlmeVRva2VuKTsKIH0KIApA
QCAtMjcyLDEyICsyNzQsMTkgQEAgdm9pZCBSZW1vdGVJbnNwZWN0b3I6OnNldHVwWFBDQ29ubmVj
dGlvbklmTmVlZGVkKCkKIHsKICAgICBMb2NrZXIgbG9ja2VyIHsgbV9tdXRleCB9OwogCi0gICAg
aWYgKG1fcmVsYXlDb25uZWN0aW9uKQorICAgIGlmIChtX3JlbGF5Q29ubmVjdGlvbikgeworICAg
ICAgICBtX2FsbG93UmV0cnlSZWxheUNvbm5lY3Rpb24gPSB0cnVlOworCisgICAgICAgIC8vIFNl
bmQgYSBzaW1wbGUgbWVzc2FnZSB0byBtYWtlIHN1cmUgdGhlIGNvbm5lY3Rpb24gaXMgc3RpbGwg
b3Blbi4KKyAgICAgICAgbV9yZWxheUNvbm5lY3Rpb24tPnNlbmRNZXNzYWdlKEAic3luIiwgbmls
KTsKICAgICAgICAgcmV0dXJuOworICAgIH0KIAogICAgIGF1dG8gY29ubmVjdGlvbiA9IGFkb3B0
T1NPYmplY3QoeHBjX2Nvbm5lY3Rpb25fY3JlYXRlX21hY2hfc2VydmljZShXSVJYUENNYWNoUG9y
dE5hbWUsIG1feHBjUXVldWUsIDApKTsKLSAgICBpZiAoIWNvbm5lY3Rpb24pCisgICAgaWYgKCFj
b25uZWN0aW9uKSB7CisgICAgICAgIFdURkxvZ0Fsd2F5cygiUmVtb3RlSW5zcGVjdG9yIGZhaWxl
ZCB0byBjcmVhdGUgWFBDIGNvbm5lY3Rpb24uIik7CiAgICAgICAgIHJldHVybjsKKyAgICB9CiAK
ICAgICBtX3JlbGF5Q29ubmVjdGlvbiA9IGFkb3B0UmVmKG5ldyBSZW1vdGVJbnNwZWN0b3JYUEND
b25uZWN0aW9uKGNvbm5lY3Rpb24uZ2V0KCksIG1feHBjUXVldWUsIHRoaXMpKTsKICAgICBtX3Jl
bGF5Q29ubmVjdGlvbi0+c2VuZE1lc3NhZ2UoQCJzeW4iLCBuaWwpOyAvLyBTZW5kIGEgc2ltcGxl
IG1lc3NhZ2UgdG8gaW5pdGlhbGl6ZSB0aGUgWFBDIGNvbm5lY3Rpb24uCkBAIC0zNjMsNiArMzcy
LDE4IEBAIHZvaWQgUmVtb3RlSW5zcGVjdG9yOjp4cGNDb25uZWN0aW9uRmFpbGVkKFJlbW90ZUlu
c3BlY3RvclhQQ0Nvbm5lY3Rpb24qIHJlbGF5Q29uCiAKICAgICAvLyBUaGUgWFBDIGNvbm5lY3Rp
b24gd2lsbCBjbG9zZSBpdHNlbGYuCiAgICAgbV9yZWxheUNvbm5lY3Rpb24gPSBudWxscHRyOwor
CisgICAgaWYgKG1fYWxsb3dSZXRyeVJlbGF5Q29ubmVjdGlvbikgeworICAgICAgICBXVEZMb2dB
bHdheXMoIlJlbW90ZUluc3BlY3RvciBYUEMgY29ubmVjdGlvbiB0byByZWxheSBmYWlsZWQsIHJl
YXR0ZW1wdGluZyBjb25uZWN0aW9uLi4uIik7CisKKyAgICAgICAgLy8gQXN5bmNyb25vdXNseSBk
aXNwYXRjaCBzZXR0aW5nIHVwIGEgbmV3IGNvbm5lY3Rpb24sIHNpbmNlIHdlIGN1cnJlbnRseSBh
cmUgaG9sZGluZyBhIGxvY2sgbmVlZGVkIHRvIGNyZWF0ZSBhIG5ldyBjb25uZWN0aW9uLgorICAg
ICAgICBkaXNwYXRjaF9hc3luYyhkaXNwYXRjaF9nZXRfZ2xvYmFsX3F1ZXVlKERJU1BBVENIX1FV
RVVFX1BSSU9SSVRZX0RFRkFVTFQsIDApLCBeeworICAgICAgICAgICAgUmVtb3RlSW5zcGVjdG9y
OjpzaW5nbGV0b24oKS5zZXR1cFhQQ0Nvbm5lY3Rpb25JZk5lZWRlZCgpOworICAgICAgICB9KTsK
KworICAgICAgICBtX2FsbG93UmV0cnlSZWxheUNvbm5lY3Rpb24gPSBmYWxzZTsKKyAgICB9IGVs
c2UKKyAgICAgICAgV1RGTG9nQWx3YXlzKCJSZW1vdGVJbnNwZWN0b3IgWFBDIGNvbm5lY3Rpb24g
dG8gcmVsYXkgZmFpbGVkLiIpOwogfQogCiB2b2lkIFJlbW90ZUluc3BlY3Rvcjo6eHBjQ29ubmVj
dGlvblVuaGFuZGxlZE1lc3NhZ2UoUmVtb3RlSW5zcGVjdG9yWFBDQ29ubmVjdGlvbiosIHhwY19v
YmplY3RfdCkK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>430484</attachid>
            <date>2021-06-03 11:03:23 -0700</date>
            <delta_ts>2021-06-03 11:35:39 -0700</delta_ts>
            <desc>Patch v1.1 - Review nits</desc>
            <filename>bug-226539-20210603110322.patch</filename>
            <type>text/plain</type>
            <size>6111</size>
            <attacher name="Patrick Angle">pangle</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MzI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl
MGI1NDVlOGM2ZTIwNWFhOThjMTc4NDUyNDkwOTQ4OWQzNTI4OTZmLi4wOTUxOWNhYmNkZDI1MGFh
MDM3ZDk3ODQxZGQ0MTA1Zjk2MjcwN2UxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSw0MCBAQAorMjAyMS0wNi0wMyAgUGF0cmljayBBbmdsZSAgPHBhbmdsZUBhcHBsZS5jb20+
CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogW0NvY29hXSBgUmVtb3RlSW5zcGVjdG9yYCB3b24n
dCBjb25uZWN0IHRvIGEgbmV3IHJlbGF5IGlmIGl0IGhhc24ndCB5ZXQgZmFpbGVkIHRvIGNvbW11
bmljYXRlIHdpdGggYSBwcmV2aW91c2x5IGNvbm5lY3RlZCByZWxheQorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2NTM5CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgYFJlbW90ZUluc3BlY3RvcmAgY29tbXVu
aWNhdGVzIHdpdGggYSByZWxheSBkYWVtb24gcnVubmluZyBvbiB0aGUgc2FtZSBkZXZpY2UgaW4g
b3JkZXIgdG8gc2VuZCB1cGRhdGVzIGxpa2UgbmV3CisgICAgICAgIG9yIHJlbW92ZWQgaW5zcGVj
dGFibGUgdGFyZ2V0cyBhbmQgcmVjZWl2ZSBjaGFuZ2VzIHRvIHNldHRpbmdzIGxpa2UgYXV0b21h
dGljIGRlYnVnZ2luZy4gVGhlIHJlbGF5IGRhZW1vbiB0aGVuCisgICAgICAgIGNvbW11bmljYXRl
cyB3aXRoIGEgY2xpZW50IHRoYXQgY29ubmVjdHMgZm9yIGRlYnVnZ2luZy4gT25seSBvbmUgcmVs
YXkgZGFlbW9uIHNob3VsZCBldmVyIGJlIHJ1bm5pbmcgYXQgYSB0aW1lLAorICAgICAgICBhbmQg
aXRzIGxpZmVjeWNsZSBpcyBtYW5hZ2VkIHNlcGFyYXRlbHkgZnJvbSBKYXZhU2NyaXB0Q29yZS4K
KworICAgICAgICBSZW1vdGVJbnNwZWN0b3IgaG9sZHMgYSBSZWZQdHIgdG8gaXRzIGNvbm5lY3Rp
b24gdG8gdGhpcyByZWxheSwgYW5kIG9ubHkgY2xlYXJzIHRoaXMgcG9pbnRlciB1cG9uIGEgZmFp
bHVyZSB0bworICAgICAgICBjb21tdW5pY2F0ZSBvdmVyIHRoZSBYUEMgY29ubmVjdGlvbiBvciBh
IGtub3duIGRpc2Nvbm5lY3Rpb24uIEhvd2V2ZXIsIGl0IGlzIHBvc3NpYmxlLCBhbmQgaW4gc29t
ZSBjYXNlcyBsaWtlbHkKKyAgICAgICAgKGZvciBleGFtcGxlIHRoZSByZWxheSByZXN0YXJ0aW5n
IGZyb20gYSBicmllZiBjbGllbnQgZGlzY29ubmVjdGlvbiBhbmQgcmVjb25uZWN0aW9uKSwgdGhh
dCB3ZSBjYW4gYmUgaW5mb3JtZWQKKyAgICAgICAgb2YgYSBuZXdseSBsYXVuY2hlZCByZWxheSBi
ZWluZyBhdmFpbGFibGUgd2hpbGUgc3RpbGwgdGhpbmtpbmcgd2UgYXJlIGNvbm5lY3RlZCB0byB0
aGUgb2xkIHJlbGF5LCBhcyB3ZSBoYXZlIG5vdCAKKyAgICAgICAgeWV0IHNlbnQgYSBtZXNzYWdl
IGFuZCB0cmlnZ2VyZWQgYSBmYWlsdXJlIGluIHRoZSBpbnRlcmltIHBlcmlvZCBvZiB0aW1lLgor
CisgICAgICAgIFRvIGNvcnJlY3QgdGhpcyB3ZSBub3cgc2VuZCBhIHNpbXBsZSBtZXNzYWdlIGFu
eSB0aW1lIGBzZXR1cFhQQ0Nvbm5lY3Rpb25JZk5lZWRlZGAgaXMgY2FsbGVkIGlmIHdlIGhhdmUg
YW4KKyAgICAgICAgZXhpc3RpbmcgUmVmUHRyIHRvIGEgcmVsYXkgY29ubmVjdGlvbiBpbiBvcmRl
ciB0byB2ZXJpZnkgdGhlIGNvbm5lY3Rpb24gaXMgc3RpbGwgZnVuY3Rpb25hbC4gV2Ugbm93IGFs
c28gcmV0cnkKKyAgICAgICAgdG8gY29ubmVjdCB0byBhIHJlbGF5IHVwb24gZmFpbHVyZSBpbiBv
cmRlciB0byBjcmVhdGUgYSBuZXcgY29ubmVjdGlvbiB0byB0aGUgY3VycmVudCByZWxheS4KKwor
ICAgICAgICBJbiBvcmRlciB0byBwcmV2ZW50IGVudGVyaW5nIGEgcmV0cnkgbG9vcCB3aGVyZSBl
dmVyeSBzdWJzZXF1ZW50IHJldHJ5J3MgZmFpbHVyZSByZXN1bHRzIGluIGFub3RoZXIgcmV0cnkK
KyAgICAgICAgZm9yZXZlciwgYSBmbGFnIHRvIHJldHJ5IGNvbm5lY3RpbmcgaXMgc2V0IHdoZW4g
YSBjYWxsIHRvIHNldHVwWFBDQ29ubmVjdGlvbklmTmVlZGVkIGlzIG1hZGUgd2hpbGUgd2UgYWxy
ZWFkeQorICAgICAgICBoYXZlIGEgUmVmUHRyIHRvIGEgcmVsYXkgY29ubmVjdGlvbi4gT24gZmFp
bHVyZSBpZiB3ZSBhcmUgaW4gdGhpcyBzcGVjaWFsIHN0YXRlIHdlIHdpbGwgcmV0cnkgb25jZSB0
byBjb25uZWN0CisgICAgICAgIGJ1dCBzdWJzZXF1ZW50IGZhaWx1cmVzIHdpbGwgbm90IGF1dG9t
YXRpY2FsbHkgcmVhdHRlbXB0IGEgY29ubmVjdGlvbi4KKworICAgICAgICAqIGluc3BlY3Rvci9y
ZW1vdGUvUmVtb3RlSW5zcGVjdG9yLmg6CisgICAgICAgICogaW5zcGVjdG9yL3JlbW90ZS9jb2Nv
YS9SZW1vdGVJbnNwZWN0b3JDb2NvYS5tbToKKyAgICAgICAgKEluc3BlY3Rvcjo6UmVtb3RlSW5z
cGVjdG9yOjpzdG9wSW50ZXJuYWwpOgorICAgICAgICAtIENsZWFyIHRoZSByZXRyeSBjb25uZWN0
aW9uIGZsYWcgd2hlbiBzdG9wcGluZyBpbiBhbiBvcmRlcmx5IGZhc2hpb24uCisgICAgICAgIChJ
bnNwZWN0b3I6OlJlbW90ZUluc3BlY3Rvcjo6c2V0dXBYUENDb25uZWN0aW9uSWZOZWVkZWQpOgor
ICAgICAgICAtIFNldCB0aGUgcmV0cnkgY29ubmVjdGlvbiBmbGFnIGFuZCBzZW5kIGEgc2ltcGxl
IG1lc3NhZ2UgaWYgd2UgYWxyZWFkeSBoYXZlIGEgcmVsYXkgY29ubmVjdGlvbiBpbiBvcmRlciB0
byBtYWtlCisgICAgICAgIHN1cmUgdGhlIGNvbm5lY3Rpb24gaXMgZWl0aGVyIHN0aWxsIHZhbGlk
IG9yIGlzIHRvcm4gZG93biBwcm9wZXJseSBvbiBmYWlsdXJlLgorICAgICAgICAoSW5zcGVjdG9y
OjpSZW1vdGVJbnNwZWN0b3I6OnhwY0Nvbm5lY3Rpb25GYWlsZWQpOgorICAgICAgICAtIElmIHRo
ZSByZXRyeSBmbGFnIGlzIHNldCwgc2NoZWR1bGUgYSByZXRyeSBhbmQgY2xlYXIgdGhlIHJldHJ5
IGZsYWcuCisKIDIwMjEtMDYtMDEgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdh
bGlhLmNvbT4KIAogICAgICAgICBbV1BFXVtHVEtdIFN1cHBvcnQgYnVpbGRpbmcgYWdhaW5zdCB1
Q2xpYmMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3Rl
L1JlbW90ZUluc3BlY3Rvci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1v
dGUvUmVtb3RlSW5zcGVjdG9yLmgKaW5kZXggMGU1YzY4MjZkNmQzZjg4ODU2YjI0YzcxODM2NWQ4
NzkzZTJjOWY4MC4uNjgyYzlmYjkzOGVjNjVhYjQzMjU5M2QzMzM1YmM2YjM3ZTJlZGVjZCAxMDA2
NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5z
cGVjdG9yLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvUmVt
b3RlSW5zcGVjdG9yLmgKQEAgLTI2MCw2ICsyNjAsNyBAQCBwcml2YXRlOgogCiAjaWYgUExBVEZP
Uk0oQ09DT0EpCiAgICAgUmVmUHRyPFJlbW90ZUluc3BlY3RvclhQQ0Nvbm5lY3Rpb24+IG1fcmVs
YXlDb25uZWN0aW9uOworICAgIGJvb2wgbV9zaG91bGRSZWNvbm5lY3RUb1JlbGF5T25GYWlsdXJl
IHsgZmFsc2UgfTsKICNlbmRpZgogI2lmIFVTRShHTElCKQogICAgIFJlZlB0cjxTb2NrZXRDb25u
ZWN0aW9uPiBtX3NvY2tldENvbm5lY3Rpb247CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvaW5zcGVjdG9yL3JlbW90ZS9jb2NvYS9SZW1vdGVJbnNwZWN0b3JDb2NvYS5tbSBiL1Nv
dXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL2NvY29hL1JlbW90ZUluc3BlY3Rv
ckNvY29hLm1tCmluZGV4IDc1ZjM5NDM3YmU1YjlmYzkwNWIwZDJhYzZmMDZkNDMwZjhiYjY1OTEu
LmEzNjE0ZTE1M2FkNTFlNTE3ZWIzNTA4OWI0ZjRkMzA3MzEzODNmMDQgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL2NvY29hL1JlbW90ZUluc3BlY3Rv
ckNvY29hLm1tCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL2Nv
Y29hL1JlbW90ZUluc3BlY3RvckNvY29hLm1tCkBAIC0yNjUsNiArMjY1LDggQEAgdm9pZCBSZW1v
dGVJbnNwZWN0b3I6OnN0b3BJbnRlcm5hbChTdG9wU291cmNlIHNvdXJjZSkKICAgICAgICAgbV9y
ZWxheUNvbm5lY3Rpb24gPSBudWxscHRyOwogICAgIH0KIAorICAgIG1fc2hvdWxkUmVjb25uZWN0
VG9SZWxheU9uRmFpbHVyZSA9IGZhbHNlOworCiAgICAgbm90aWZ5X2NhbmNlbChtX25vdGlmeVRv
a2VuKTsKIH0KIApAQCAtMjcyLDEyICsyNzQsMTkgQEAgdm9pZCBSZW1vdGVJbnNwZWN0b3I6OnNl
dHVwWFBDQ29ubmVjdGlvbklmTmVlZGVkKCkKIHsKICAgICBMb2NrZXIgbG9ja2VyIHsgbV9tdXRl
eCB9OwogCi0gICAgaWYgKG1fcmVsYXlDb25uZWN0aW9uKQorICAgIGlmIChtX3JlbGF5Q29ubmVj
dGlvbikgeworICAgICAgICBtX3Nob3VsZFJlY29ubmVjdFRvUmVsYXlPbkZhaWx1cmUgPSB0cnVl
OworCisgICAgICAgIC8vIFNlbmQgYSBzaW1wbGUgbWVzc2FnZSB0byBtYWtlIHN1cmUgdGhlIGNv
bm5lY3Rpb24gaXMgc3RpbGwgb3Blbi4KKyAgICAgICAgbV9yZWxheUNvbm5lY3Rpb24tPnNlbmRN
ZXNzYWdlKEAiY2hlY2siLCBuaWwpOwogICAgICAgICByZXR1cm47CisgICAgfQogCiAgICAgYXV0
byBjb25uZWN0aW9uID0gYWRvcHRPU09iamVjdCh4cGNfY29ubmVjdGlvbl9jcmVhdGVfbWFjaF9z
ZXJ2aWNlKFdJUlhQQ01hY2hQb3J0TmFtZSwgbV94cGNRdWV1ZSwgMCkpOwotICAgIGlmICghY29u
bmVjdGlvbikKKyAgICBpZiAoIWNvbm5lY3Rpb24pIHsKKyAgICAgICAgV1RGTG9nQWx3YXlzKCJS
ZW1vdGVJbnNwZWN0b3IgZmFpbGVkIHRvIGNyZWF0ZSBYUEMgY29ubmVjdGlvbi4iKTsKICAgICAg
ICAgcmV0dXJuOworICAgIH0KIAogICAgIG1fcmVsYXlDb25uZWN0aW9uID0gYWRvcHRSZWYobmV3
IFJlbW90ZUluc3BlY3RvclhQQ0Nvbm5lY3Rpb24oY29ubmVjdGlvbi5nZXQoKSwgbV94cGNRdWV1
ZSwgdGhpcykpOwogICAgIG1fcmVsYXlDb25uZWN0aW9uLT5zZW5kTWVzc2FnZShAInN5biIsIG5p
bCk7IC8vIFNlbmQgYSBzaW1wbGUgbWVzc2FnZSB0byBpbml0aWFsaXplIHRoZSBYUEMgY29ubmVj
dGlvbi4KQEAgLTM2Myw2ICszNzIsMTkgQEAgdm9pZCBSZW1vdGVJbnNwZWN0b3I6OnhwY0Nvbm5l
Y3Rpb25GYWlsZWQoUmVtb3RlSW5zcGVjdG9yWFBDQ29ubmVjdGlvbiogcmVsYXlDb24KIAogICAg
IC8vIFRoZSBYUEMgY29ubmVjdGlvbiB3aWxsIGNsb3NlIGl0c2VsZi4KICAgICBtX3JlbGF5Q29u
bmVjdGlvbiA9IG51bGxwdHI7CisKKyAgICBpZiAoIW1fc2hvdWxkUmVjb25uZWN0VG9SZWxheU9u
RmFpbHVyZSkgeworICAgICAgICBXVEZMb2dBbHdheXMoIlJlbW90ZUluc3BlY3RvciBYUEMgY29u
bmVjdGlvbiB0byByZWxheSBmYWlsZWQuIik7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAg
ICBtX3Nob3VsZFJlY29ubmVjdFRvUmVsYXlPbkZhaWx1cmUgPSBmYWxzZTsKKyAgICBXVEZMb2dB
bHdheXMoIlJlbW90ZUluc3BlY3RvciBYUEMgY29ubmVjdGlvbiB0byByZWxheSBmYWlsZWQsIHJl
Y29ubmVjdGluZyBpbiAxIHNlY29uZC4uLiIpOworCisgICAgLy8gU2NoZWR1bGUgc2V0dGluZyB1
cCBhIG5ldyBjb25uZWN0aW9uLCBzaW5jZSB3ZSBjdXJyZW50bHkgYXJlIGhvbGRpbmcgYSBsb2Nr
IG5lZWRlZCB0byBjcmVhdGUgYSBuZXcgY29ubmVjdGlvbi4KKyAgICBkaXNwYXRjaF9hZnRlcihk
aXNwYXRjaF90aW1lKERJU1BBVENIX1RJTUVfTk9XLCAxICogTlNFQ19QRVJfU0VDKSwgZGlzcGF0
Y2hfZ2V0X2dsb2JhbF9xdWV1ZShESVNQQVRDSF9RVUVVRV9QUklPUklUWV9ERUZBVUxULCAwKSwg
XnsKKyAgICAgICAgUmVtb3RlSW5zcGVjdG9yOjpzaW5nbGV0b24oKS5zZXR1cFhQQ0Nvbm5lY3Rp
b25JZk5lZWRlZCgpOworICAgIH0pOwogfQogCiB2b2lkIFJlbW90ZUluc3BlY3Rvcjo6eHBjQ29u
bmVjdGlvblVuaGFuZGxlZE1lc3NhZ2UoUmVtb3RlSW5zcGVjdG9yWFBDQ29ubmVjdGlvbiosIHhw
Y19vYmplY3RfdCkK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>430491</attachid>
            <date>2021-06-03 11:35:41 -0700</date>
            <delta_ts>2021-06-03 12:32:30 -0700</delta_ts>
            <desc>Patch v1.1.1 - Add reviewer to changelog</desc>
            <filename>bug-226539-20210603113540.patch</filename>
            <type>text/plain</type>
            <size>6109</size>
            <attacher name="Patrick Angle">pangle</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MzI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl
MGI1NDVlOGM2ZTIwNWFhOThjMTc4NDUyNDkwOTQ4OWQzNTI4OTZmLi44NzZiMjczMDYxMDRlODkw
M2U5ZWI5ODNmNGRhMGQyYzYwNzQ3ODM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSw0MCBAQAorMjAyMS0wNi0wMyAgUGF0cmljayBBbmdsZSAgPHBhbmdsZUBhcHBsZS5jb20+
CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogW0NvY29hXSBgUmVtb3RlSW5zcGVjdG9yYCB3b24n
dCBjb25uZWN0IHRvIGEgbmV3IHJlbGF5IGlmIGl0IGhhc24ndCB5ZXQgZmFpbGVkIHRvIGNvbW11
bmljYXRlIHdpdGggYSBwcmV2aW91c2x5IGNvbm5lY3RlZCByZWxheQorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2NTM5CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgRGV2aW4gUm91c3NvLgorCisgICAgICAgIGBSZW1vdGVJbnNwZWN0b3JgIGNvbW11bmlj
YXRlcyB3aXRoIGEgcmVsYXkgZGFlbW9uIHJ1bm5pbmcgb24gdGhlIHNhbWUgZGV2aWNlIGluIG9y
ZGVyIHRvIHNlbmQgdXBkYXRlcyBsaWtlIG5ldworICAgICAgICBvciByZW1vdmVkIGluc3BlY3Rh
YmxlIHRhcmdldHMgYW5kIHJlY2VpdmUgY2hhbmdlcyB0byBzZXR0aW5ncyBsaWtlIGF1dG9tYXRp
YyBkZWJ1Z2dpbmcuIFRoZSByZWxheSBkYWVtb24gdGhlbgorICAgICAgICBjb21tdW5pY2F0ZXMg
d2l0aCBhIGNsaWVudCB0aGF0IGNvbm5lY3RzIGZvciBkZWJ1Z2dpbmcuIE9ubHkgb25lIHJlbGF5
IGRhZW1vbiBzaG91bGQgZXZlciBiZSBydW5uaW5nIGF0IGEgdGltZSwKKyAgICAgICAgYW5kIGl0
cyBsaWZlY3ljbGUgaXMgbWFuYWdlZCBzZXBhcmF0ZWx5IGZyb20gSmF2YVNjcmlwdENvcmUuCisK
KyAgICAgICAgUmVtb3RlSW5zcGVjdG9yIGhvbGRzIGEgUmVmUHRyIHRvIGl0cyBjb25uZWN0aW9u
IHRvIHRoaXMgcmVsYXksIGFuZCBvbmx5IGNsZWFycyB0aGlzIHBvaW50ZXIgdXBvbiBhIGZhaWx1
cmUgdG8KKyAgICAgICAgY29tbXVuaWNhdGUgb3ZlciB0aGUgWFBDIGNvbm5lY3Rpb24gb3IgYSBr
bm93biBkaXNjb25uZWN0aW9uLiBIb3dldmVyLCBpdCBpcyBwb3NzaWJsZSwgYW5kIGluIHNvbWUg
Y2FzZXMgbGlrZWx5CisgICAgICAgIChmb3IgZXhhbXBsZSB0aGUgcmVsYXkgcmVzdGFydGluZyBm
cm9tIGEgYnJpZWYgY2xpZW50IGRpc2Nvbm5lY3Rpb24gYW5kIHJlY29ubmVjdGlvbiksIHRoYXQg
d2UgY2FuIGJlIGluZm9ybWVkCisgICAgICAgIG9mIGEgbmV3bHkgbGF1bmNoZWQgcmVsYXkgYmVp
bmcgYXZhaWxhYmxlIHdoaWxlIHN0aWxsIHRoaW5raW5nIHdlIGFyZSBjb25uZWN0ZWQgdG8gdGhl
IG9sZCByZWxheSwgYXMgd2UgaGF2ZSBub3QgCisgICAgICAgIHlldCBzZW50IGEgbWVzc2FnZSBh
bmQgdHJpZ2dlcmVkIGEgZmFpbHVyZSBpbiB0aGUgaW50ZXJpbSBwZXJpb2Qgb2YgdGltZS4KKwor
ICAgICAgICBUbyBjb3JyZWN0IHRoaXMgd2Ugbm93IHNlbmQgYSBzaW1wbGUgbWVzc2FnZSBhbnkg
dGltZSBgc2V0dXBYUENDb25uZWN0aW9uSWZOZWVkZWRgIGlzIGNhbGxlZCBpZiB3ZSBoYXZlIGFu
CisgICAgICAgIGV4aXN0aW5nIFJlZlB0ciB0byBhIHJlbGF5IGNvbm5lY3Rpb24gaW4gb3JkZXIg
dG8gdmVyaWZ5IHRoZSBjb25uZWN0aW9uIGlzIHN0aWxsIGZ1bmN0aW9uYWwuIFdlIG5vdyBhbHNv
IHJldHJ5CisgICAgICAgIHRvIGNvbm5lY3QgdG8gYSByZWxheSB1cG9uIGZhaWx1cmUgaW4gb3Jk
ZXIgdG8gY3JlYXRlIGEgbmV3IGNvbm5lY3Rpb24gdG8gdGhlIGN1cnJlbnQgcmVsYXkuCisKKyAg
ICAgICAgSW4gb3JkZXIgdG8gcHJldmVudCBlbnRlcmluZyBhIHJldHJ5IGxvb3Agd2hlcmUgZXZl
cnkgc3Vic2VxdWVudCByZXRyeSdzIGZhaWx1cmUgcmVzdWx0cyBpbiBhbm90aGVyIHJldHJ5Cisg
ICAgICAgIGZvcmV2ZXIsIGEgZmxhZyB0byByZXRyeSBjb25uZWN0aW5nIGlzIHNldCB3aGVuIGEg
Y2FsbCB0byBzZXR1cFhQQ0Nvbm5lY3Rpb25JZk5lZWRlZCBpcyBtYWRlIHdoaWxlIHdlIGFscmVh
ZHkKKyAgICAgICAgaGF2ZSBhIFJlZlB0ciB0byBhIHJlbGF5IGNvbm5lY3Rpb24uIE9uIGZhaWx1
cmUgaWYgd2UgYXJlIGluIHRoaXMgc3BlY2lhbCBzdGF0ZSB3ZSB3aWxsIHJldHJ5IG9uY2UgdG8g
Y29ubmVjdAorICAgICAgICBidXQgc3Vic2VxdWVudCBmYWlsdXJlcyB3aWxsIG5vdCBhdXRvbWF0
aWNhbGx5IHJlYXR0ZW1wdCBhIGNvbm5lY3Rpb24uCisKKyAgICAgICAgKiBpbnNwZWN0b3IvcmVt
b3RlL1JlbW90ZUluc3BlY3Rvci5oOgorICAgICAgICAqIGluc3BlY3Rvci9yZW1vdGUvY29jb2Ev
UmVtb3RlSW5zcGVjdG9yQ29jb2EubW06CisgICAgICAgIChJbnNwZWN0b3I6OlJlbW90ZUluc3Bl
Y3Rvcjo6c3RvcEludGVybmFsKToKKyAgICAgICAgLSBDbGVhciB0aGUgcmV0cnkgY29ubmVjdGlv
biBmbGFnIHdoZW4gc3RvcHBpbmcgaW4gYW4gb3JkZXJseSBmYXNoaW9uLgorICAgICAgICAoSW5z
cGVjdG9yOjpSZW1vdGVJbnNwZWN0b3I6OnNldHVwWFBDQ29ubmVjdGlvbklmTmVlZGVkKToKKyAg
ICAgICAgLSBTZXQgdGhlIHJldHJ5IGNvbm5lY3Rpb24gZmxhZyBhbmQgc2VuZCBhIHNpbXBsZSBt
ZXNzYWdlIGlmIHdlIGFscmVhZHkgaGF2ZSBhIHJlbGF5IGNvbm5lY3Rpb24gaW4gb3JkZXIgdG8g
bWFrZQorICAgICAgICBzdXJlIHRoZSBjb25uZWN0aW9uIGlzIGVpdGhlciBzdGlsbCB2YWxpZCBv
ciBpcyB0b3JuIGRvd24gcHJvcGVybHkgb24gZmFpbHVyZS4KKyAgICAgICAgKEluc3BlY3Rvcjo6
UmVtb3RlSW5zcGVjdG9yOjp4cGNDb25uZWN0aW9uRmFpbGVkKToKKyAgICAgICAgLSBJZiB0aGUg
cmV0cnkgZmxhZyBpcyBzZXQsIHNjaGVkdWxlIGEgcmV0cnkgYW5kIGNsZWFyIHRoZSByZXRyeSBm
bGFnLgorCiAyMDIxLTA2LTAxICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxp
YS5jb20+CiAKICAgICAgICAgW1dQRV1bR1RLXSBTdXBwb3J0IGJ1aWxkaW5nIGFnYWluc3QgdUNs
aWJjCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9S
ZW1vdGVJbnNwZWN0b3IuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3Rl
L1JlbW90ZUluc3BlY3Rvci5oCmluZGV4IDBlNWM2ODI2ZDZkM2Y4ODg1NmIyNGM3MTgzNjVkODc5
M2UyYzlmODAuLjY4MmM5ZmI5MzhlYzY1YWI0MzI1OTNkMzMzNWJjNmIzN2UyZWRlY2QgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3Bl
Y3Rvci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90
ZUluc3BlY3Rvci5oCkBAIC0yNjAsNiArMjYwLDcgQEAgcHJpdmF0ZToKIAogI2lmIFBMQVRGT1JN
KENPQ09BKQogICAgIFJlZlB0cjxSZW1vdGVJbnNwZWN0b3JYUENDb25uZWN0aW9uPiBtX3JlbGF5
Q29ubmVjdGlvbjsKKyAgICBib29sIG1fc2hvdWxkUmVjb25uZWN0VG9SZWxheU9uRmFpbHVyZSB7
IGZhbHNlIH07CiAjZW5kaWYKICNpZiBVU0UoR0xJQikKICAgICBSZWZQdHI8U29ja2V0Q29ubmVj
dGlvbj4gbV9zb2NrZXRDb25uZWN0aW9uOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD
b3JlL2luc3BlY3Rvci9yZW1vdGUvY29jb2EvUmVtb3RlSW5zcGVjdG9yQ29jb2EubW0gYi9Tb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9jb2NvYS9SZW1vdGVJbnNwZWN0b3JD
b2NvYS5tbQppbmRleCA3NWYzOTQzN2JlNWI5ZmM5MDViMGQyYWM2ZjA2ZDQzMGY4YmI2NTkxLi5h
MzYxNGUxNTNhZDUxZTUxN2ViMzUwODliNGY0ZDMwNzMxMzgzZjA0IDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9jb2NvYS9SZW1vdGVJbnNwZWN0b3JD
b2NvYS5tbQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9jb2Nv
YS9SZW1vdGVJbnNwZWN0b3JDb2NvYS5tbQpAQCAtMjY1LDYgKzI2NSw4IEBAIHZvaWQgUmVtb3Rl
SW5zcGVjdG9yOjpzdG9wSW50ZXJuYWwoU3RvcFNvdXJjZSBzb3VyY2UpCiAgICAgICAgIG1fcmVs
YXlDb25uZWN0aW9uID0gbnVsbHB0cjsKICAgICB9CiAKKyAgICBtX3Nob3VsZFJlY29ubmVjdFRv
UmVsYXlPbkZhaWx1cmUgPSBmYWxzZTsKKwogICAgIG5vdGlmeV9jYW5jZWwobV9ub3RpZnlUb2tl
bik7CiB9CiAKQEAgLTI3MiwxMiArMjc0LDE5IEBAIHZvaWQgUmVtb3RlSW5zcGVjdG9yOjpzZXR1
cFhQQ0Nvbm5lY3Rpb25JZk5lZWRlZCgpCiB7CiAgICAgTG9ja2VyIGxvY2tlciB7IG1fbXV0ZXgg
fTsKIAotICAgIGlmIChtX3JlbGF5Q29ubmVjdGlvbikKKyAgICBpZiAobV9yZWxheUNvbm5lY3Rp
b24pIHsKKyAgICAgICAgbV9zaG91bGRSZWNvbm5lY3RUb1JlbGF5T25GYWlsdXJlID0gdHJ1ZTsK
KworICAgICAgICAvLyBTZW5kIGEgc2ltcGxlIG1lc3NhZ2UgdG8gbWFrZSBzdXJlIHRoZSBjb25u
ZWN0aW9uIGlzIHN0aWxsIG9wZW4uCisgICAgICAgIG1fcmVsYXlDb25uZWN0aW9uLT5zZW5kTWVz
c2FnZShAImNoZWNrIiwgbmlsKTsKICAgICAgICAgcmV0dXJuOworICAgIH0KIAogICAgIGF1dG8g
Y29ubmVjdGlvbiA9IGFkb3B0T1NPYmplY3QoeHBjX2Nvbm5lY3Rpb25fY3JlYXRlX21hY2hfc2Vy
dmljZShXSVJYUENNYWNoUG9ydE5hbWUsIG1feHBjUXVldWUsIDApKTsKLSAgICBpZiAoIWNvbm5l
Y3Rpb24pCisgICAgaWYgKCFjb25uZWN0aW9uKSB7CisgICAgICAgIFdURkxvZ0Fsd2F5cygiUmVt
b3RlSW5zcGVjdG9yIGZhaWxlZCB0byBjcmVhdGUgWFBDIGNvbm5lY3Rpb24uIik7CiAgICAgICAg
IHJldHVybjsKKyAgICB9CiAKICAgICBtX3JlbGF5Q29ubmVjdGlvbiA9IGFkb3B0UmVmKG5ldyBS
ZW1vdGVJbnNwZWN0b3JYUENDb25uZWN0aW9uKGNvbm5lY3Rpb24uZ2V0KCksIG1feHBjUXVldWUs
IHRoaXMpKTsKICAgICBtX3JlbGF5Q29ubmVjdGlvbi0+c2VuZE1lc3NhZ2UoQCJzeW4iLCBuaWwp
OyAvLyBTZW5kIGEgc2ltcGxlIG1lc3NhZ2UgdG8gaW5pdGlhbGl6ZSB0aGUgWFBDIGNvbm5lY3Rp
b24uCkBAIC0zNjMsNiArMzcyLDE5IEBAIHZvaWQgUmVtb3RlSW5zcGVjdG9yOjp4cGNDb25uZWN0
aW9uRmFpbGVkKFJlbW90ZUluc3BlY3RvclhQQ0Nvbm5lY3Rpb24qIHJlbGF5Q29uCiAKICAgICAv
LyBUaGUgWFBDIGNvbm5lY3Rpb24gd2lsbCBjbG9zZSBpdHNlbGYuCiAgICAgbV9yZWxheUNvbm5l
Y3Rpb24gPSBudWxscHRyOworCisgICAgaWYgKCFtX3Nob3VsZFJlY29ubmVjdFRvUmVsYXlPbkZh
aWx1cmUpIHsKKyAgICAgICAgV1RGTG9nQWx3YXlzKCJSZW1vdGVJbnNwZWN0b3IgWFBDIGNvbm5l
Y3Rpb24gdG8gcmVsYXkgZmFpbGVkLiIpOworICAgICAgICByZXR1cm47CisgICAgfQorCisgICAg
bV9zaG91bGRSZWNvbm5lY3RUb1JlbGF5T25GYWlsdXJlID0gZmFsc2U7CisgICAgV1RGTG9nQWx3
YXlzKCJSZW1vdGVJbnNwZWN0b3IgWFBDIGNvbm5lY3Rpb24gdG8gcmVsYXkgZmFpbGVkLCByZWNv
bm5lY3RpbmcgaW4gMSBzZWNvbmQuLi4iKTsKKworICAgIC8vIFNjaGVkdWxlIHNldHRpbmcgdXAg
YSBuZXcgY29ubmVjdGlvbiwgc2luY2Ugd2UgY3VycmVudGx5IGFyZSBob2xkaW5nIGEgbG9jayBu
ZWVkZWQgdG8gY3JlYXRlIGEgbmV3IGNvbm5lY3Rpb24uCisgICAgZGlzcGF0Y2hfYWZ0ZXIoZGlz
cGF0Y2hfdGltZShESVNQQVRDSF9USU1FX05PVywgMSAqIE5TRUNfUEVSX1NFQyksIGRpc3BhdGNo
X2dldF9nbG9iYWxfcXVldWUoRElTUEFUQ0hfUVVFVUVfUFJJT1JJVFlfREVGQVVMVCwgMCksIF57
CisgICAgICAgIFJlbW90ZUluc3BlY3Rvcjo6c2luZ2xldG9uKCkuc2V0dXBYUENDb25uZWN0aW9u
SWZOZWVkZWQoKTsKKyAgICB9KTsKIH0KIAogdm9pZCBSZW1vdGVJbnNwZWN0b3I6OnhwY0Nvbm5l
Y3Rpb25VbmhhbmRsZWRNZXNzYWdlKFJlbW90ZUluc3BlY3RvclhQQ0Nvbm5lY3Rpb24qLCB4cGNf
b2JqZWN0X3QpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>