226498 2021-06-01 07:53:14 -0700 [EME][Thunder] Build broken since r278244 2021-06-01 13:23:07 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand achristensen calvaris cgarcia darin ews-watchlist gustavo menard vjaquez webkit-bug-importer oldest_to_newest 1765609 0 pnormand 2021-06-01 07:53:14 -0700 ../../Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp:678:12: error: cannot cast from type 'const WeakPtr<WebCore::CDMInstanceProxy>' to pointer type 'WebCore::CDMInstanceThunder *' return static_cast<CDMInstanceThunder*>(cdmInstanceProxy()); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. 1765610 1 430262 pnormand 2021-06-01 07:55:41 -0700 Created attachment 430262 Patch 1765695 2 ews-feeder 2021-06-01 11:50:23 -0700 Committed r278316 (238352@main): <https://commits.webkit.org/238352@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430262. 1765696 3 webkit-bug-importer 2021-06-01 11:51:21 -0700 <rdar://problem/78725269> 1765727 4 430262 darin 2021-06-01 13:23:07 -0700 Comment on attachment 430262 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430262&action=review > Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp:679 > - return static_cast<CDMInstanceThunder*>(cdmInstanceProxy()); > + auto proxy = cdmInstanceProxy(); > + return static_cast<CDMInstanceThunder*>(proxy.get()); Adding the ".get()" was good. But adding the local variable was unnecessary. 430262 2021-06-01 07:55:41 -0700 2021-06-01 11:50:25 -0700 Patch bug-226498-20210601075540.patch text/plain 1506 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MzA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODliYjg1MGY5ZDZlYzg0 YTNlYmUyMWY2ZGUwOTA5NDQ2YzQyOWE5Mi4uOWE5ZWJjNWUwOTM1N2FlZmNlNGQwMjMxNzJhMzYz MWZiNjA5NmU3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA2LTAxICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbRU1FXVtUaHVu ZGVyXSBCdWlsZCBicm9rZW4gc2luY2UgcjI3ODI0NAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2NDk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvZW1l L0NETVRodW5kZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q0RNSW5zdGFuY2VTZXNzaW9uVGh1 bmRlcjo6Y2RtSW5zdGFuY2VUaHVuZGVyIGNvbnN0KTogQ2FzdCByYXcgcG9pbnRlciBpbnN0ZWFk IG9mCisgICAgICAgIGl0cyBzbWFydCBwb2ludGVyIGNvbnRhaW5lci4KKwogMjAyMS0wNi0wMSAg QW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIENvbXBs ZXhMaW5lTGF5b3V0IHRvIExlZ2FjeUxpbmVMYXlvdXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9lbWUvQ0RNVGh1bmRlci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvZW1lL0NETVRodW5kZXIuY3Bw CmluZGV4IDg3MGUwY2QxNzYwMDY3ZDliY2UyNWZiZjcyYTVhYjlhNjFiNDZjYzguLjQ0OTgzNzM2 NjFhN2ViMDk5ZmI5ODQ1NmU5NGE0MWQ4NGFkYjFjMTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9lbWUvQ0RNVGh1bmRlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL2VtZS9DRE1UaHVuZGVy LmNwcApAQCAtNjc1LDcgKzY3NSw4IEBAIHZvaWQgQ0RNSW5zdGFuY2VTZXNzaW9uVGh1bmRlcjo6 c3RvcmVSZWNvcmRPZktleVVzYWdlKGNvbnN0IFN0cmluZyYpCiAKIENETUluc3RhbmNlVGh1bmRl ciogQ0RNSW5zdGFuY2VTZXNzaW9uVGh1bmRlcjo6Y2RtSW5zdGFuY2VUaHVuZGVyKCkgY29uc3QK IHsKLSAgICByZXR1cm4gc3RhdGljX2Nhc3Q8Q0RNSW5zdGFuY2VUaHVuZGVyKj4oY2RtSW5zdGFu Y2VQcm94eSgpKTsKKyAgICBhdXRvIHByb3h5ID0gY2RtSW5zdGFuY2VQcm94eSgpOworICAgIHJl dHVybiBzdGF0aWNfY2FzdDxDRE1JbnN0YW5jZVRodW5kZXIqPihwcm94eS5nZXQoKSk7CiB9CiAK IH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK