22648 2008-12-04 08:12:54 -0800 Fix threading on Qt-port for Sampling tool 2008-12-11 03:19:40 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 loki webkit-unassigned oldest_to_newest 101319 0 loki 2008-12-04 08:12:54 -0800 The Sampling tool fails on Qt-port. The problem is in the implementation of 'waitForThreadCompletion' function (wtf/ThreadingQt.cpp). I am going to attach a patch which could fix this problem on Qt-port. 101320 1 25739 loki 2008-12-04 08:16:39 -0800 Created attachment 25739 fix waitForThreadCompletion for sampling tool This patch fixes the threading for sampling tool on Qt-port. I've did the same for Gtk, but I didn't test it. 101325 2 25739 darin 2008-12-04 09:13:11 -0800 Comment on attachment 25739 fix waitForThreadCompletion for sampling tool > + if (result) > + *result = g_thread_join(thread); I believe this is wrong. Even if we don't want to store the result, we do want to call g_thread_join so we wait for the thread to complete. 101452 3 25767 loki 2008-12-05 02:06:14 -0800 Created attachment 25767 fix waitForThreadCompletion for sampling tool (v2) You are right. I missed that one. Here is the proposed patch. 101478 4 25767 darin 2008-12-05 05:53:18 -0800 Comment on attachment 25767 fix waitForThreadCompletion for sampling tool (v2) r=me 102225 5 zecke 2008-12-11 03:19:40 -0800 Landed in r39204. 25739 2008-12-04 08:16:39 -0800 2008-12-05 02:06:14 -0800 fix waitForThreadCompletion for sampling tool sampling.patch text/plain 2199 loki RnJvbSA5MGIyMjQ0ODQ2Y2E4MWU1NTAyYzJmNzNkZDMwMzcyZjMwODE4NTQwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHYWJvciBMb2tpIDxsb2tpQGluZi51LXN6ZWdlZC5odT4KRGF0 ZTogVGh1LCA0IERlYyAyMDA4IDE3OjA1OjU3ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gRml4IHRo cmVhZGluZyBvbiBRdC1wb3J0IGFuZCBHdGstcG9ydCBmb3IgU2FtcGxpbmcgdG9vbC4KClNpZ25l ZC1vZmYtYnk6IEdhYm9yIExva2kgPGxva2lAaW5mLnUtc3plZ2VkLmh1PgotLS0KIEphdmFTY3Jp cHRDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysKIEphdmFTY3Jp cHRDb3JlL3d0Zi9UaHJlYWRpbmdHdGsuY3BwIHwgICAgMyArKy0KIEphdmFTY3JpcHRDb3JlL3d0 Zi9UaHJlYWRpbmdRdC5jcHAgIHwgICAgMyArKy0KIDMgZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0 aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggZTQ0Nzg3ZS4uYjlkYWY2NCAx MDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDA4LTEyLTA0ICBHYWJvciBMb2tpICA8bG9r aUBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjY0 OD4KKyAgICAgICAgRml4IHRocmVhZGluZyBvbiBRdC1wb3J0IGFuZCBHdGstcG9ydCBmb3IgU2Ft cGxpbmcgdG9vbC4KKworICAgICAgICAqIHd0Zi9UaHJlYWRpbmdHdGsuY3BwOgorICAgICAgICAo V1RGOjp3YWl0Rm9yVGhyZWFkQ29tcGxldGlvbik6CisgICAgICAgICogd3RmL1RocmVhZGluZ1F0 LmNwcDoKKyAgICAgICAgKFdURjo6d2FpdEZvclRocmVhZENvbXBsZXRpb24pOgorCiAyMDA4LTEy LTAzICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgT2xpdmVyIEh1bnQsIHdpdGggaGVscCBmcm9tIEdhdmluIEJhcnJhY2xvdWdoLgpkaWZm IC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZ0d0ay5jcHAgYi9KYXZhU2NyaXB0 Q29yZS93dGYvVGhyZWFkaW5nR3RrLmNwcAppbmRleCBkYTc0YjcxLi42NDQ4OWNhIDEwMDY0NAot LS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nR3RrLmNwcAorKysgYi9KYXZhU2NyaXB0 Q29yZS93dGYvVGhyZWFkaW5nR3RrLmNwcApAQCAtMTQwLDcgKzE0MCw4IEBAIGludCB3YWl0Rm9y VGhyZWFkQ29tcGxldGlvbihUaHJlYWRJZGVudGlmaWVyIHRocmVhZElELCB2b2lkKiogcmVzdWx0 KQogCiAgICAgR1RocmVhZCogdGhyZWFkID0gdGhyZWFkRm9ySWRlbnRpZmllcih0aHJlYWRJRCk7 CiAKLSAgICAqcmVzdWx0ID0gZ190aHJlYWRfam9pbih0aHJlYWQpOworICAgIGlmIChyZXN1bHQp CisgICAgICAgICpyZXN1bHQgPSBnX3RocmVhZF9qb2luKHRocmVhZCk7CiAKICAgICBjbGVhclRo cmVhZEZvcklkZW50aWZpZXIodGhyZWFkSUQpOwogICAgIHJldHVybiAwOwpkaWZmIC0tZ2l0IGEv SmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZ1F0LmNwcCBiL0phdmFTY3JpcHRDb3JlL3d0Zi9U aHJlYWRpbmdRdC5jcHAKaW5kZXggZjZlYmRmMy4uMmFjYmMwNSAxMDA2NDQKLS0tIGEvSmF2YVNj cmlwdENvcmUvd3RmL1RocmVhZGluZ1F0LmNwcAorKysgYi9KYXZhU2NyaXB0Q29yZS93dGYvVGhy ZWFkaW5nUXQuY3BwCkBAIC0xNjgsNyArMTY4LDggQEAgaW50IHdhaXRGb3JUaHJlYWRDb21wbGV0 aW9uKFRocmVhZElkZW50aWZpZXIgdGhyZWFkSUQsIHZvaWQqKiByZXN1bHQpCiAgICAgYm9vbCBy ZXMgPSB0aHJlYWQtPndhaXQoKTsKIAogICAgIGNsZWFyVGhyZWFkRm9ySWRlbnRpZmllcih0aHJl YWRJRCk7Ci0gICAgKnJlc3VsdCA9IHN0YXRpY19jYXN0PFRocmVhZFByaXZhdGUqPih0aHJlYWQp LT5nZXRSZXR1cm5WYWx1ZSgpOworICAgIGlmIChyZXN1bHQpCisgICAgICAgICpyZXN1bHQgPSBz dGF0aWNfY2FzdDxUaHJlYWRQcml2YXRlKj4odGhyZWFkKS0+Z2V0UmV0dXJuVmFsdWUoKTsKIAog ICAgIHJldHVybiAhcmVzOwogfQotLSAKMS41LjQuMwoK 25767 2008-12-05 02:06:14 -0800 2008-12-05 05:53:18 -0800 fix waitForThreadCompletion for sampling tool (v2) sampling.patch text/plain 2236 loki RnJvbSA2NmRmOTEwZGY5MjJkZjhmNTEyMjU4NmZhZWViNmVlYWQyYzljYzczIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHYWJvciBMb2tpIDxsb2tpQGluZi51LXN6ZWdlZC5odT4KRGF0 ZTogRnJpLCA1IERlYyAyMDA4IDA5OjU3OjA3ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gRml4IHRo cmVhZGluZyBvbiBRdC1wb3J0IGFuZCBHdGstcG9ydCBmb3IgU2FtcGxpbmcgdG9vbC4KClNpZ25l ZC1vZmYtYnk6IEdhYm9yIExva2kgPGxva2lAaW5mLnUtc3plZ2VkLmh1PgotLS0KIEphdmFTY3Jp cHRDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysKIEphdmFTY3Jp cHRDb3JlL3d0Zi9UaHJlYWRpbmdHdGsuY3BwIHwgICAgNCArKystCiBKYXZhU2NyaXB0Q29yZS93 dGYvVGhyZWFkaW5nUXQuY3BwICB8ICAgIDMgKystCiAzIGZpbGVzIGNoYW5nZWQsIDE3IGluc2Vy dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGU0NDc4N2UuLjg2MWIzYzYg MTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOC0xMi0wNCAgR2Fib3IgTG9raSAgPGxv a2lAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2 NDg+CisgICAgICAgIEZpeCB0aHJlYWRpbmcgb24gUXQtcG9ydCBhbmQgR3RrLXBvcnQgZm9yIFNh bXBsaW5nIHRvb2wuCisKKyAgICAgICAgKiB3dGYvVGhyZWFkaW5nR3RrLmNwcDoKKyAgICAgICAg KFdURjo6d2FpdEZvclRocmVhZENvbXBsZXRpb24pOgorICAgICAgICAqIHd0Zi9UaHJlYWRpbmdR dC5jcHA6CisgICAgICAgIChXVEY6OndhaXRGb3JUaHJlYWRDb21wbGV0aW9uKToKKwogMjAwOC0x Mi0wMyAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IE9saXZlciBIdW50LCB3aXRoIGhlbHAgZnJvbSBHYXZpbiBCYXJyYWNsb3VnaC4KZGlm ZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmdHdGsuY3BwIGIvSmF2YVNjcmlw dENvcmUvd3RmL1RocmVhZGluZ0d0ay5jcHAKaW5kZXggZGE3NGI3MS4uMjQ1MTA0OCAxMDA2NDQK LS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZ0d0ay5jcHAKKysrIGIvSmF2YVNjcmlw dENvcmUvd3RmL1RocmVhZGluZ0d0ay5jcHAKQEAgLTE0MCw3ICsxNDAsOSBAQCBpbnQgd2FpdEZv clRocmVhZENvbXBsZXRpb24oVGhyZWFkSWRlbnRpZmllciB0aHJlYWRJRCwgdm9pZCoqIHJlc3Vs dCkKIAogICAgIEdUaHJlYWQqIHRocmVhZCA9IHRocmVhZEZvcklkZW50aWZpZXIodGhyZWFkSUQp OwogCi0gICAgKnJlc3VsdCA9IGdfdGhyZWFkX2pvaW4odGhyZWFkKTsKKyAgICB2b2lkKiBqb2lu UmVzdWx0ID0gZ190aHJlYWRfam9pbih0aHJlYWQpOworICAgIGlmIChyZXN1bHQpCisgICAgICAg ICpyZXN1bHQgPSBqb2luUmVzdWx0OwogCiAgICAgY2xlYXJUaHJlYWRGb3JJZGVudGlmaWVyKHRo cmVhZElEKTsKICAgICByZXR1cm4gMDsKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3d0Zi9U aHJlYWRpbmdRdC5jcHAgYi9KYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nUXQuY3BwCmluZGV4 IGY2ZWJkZjMuLjJhY2JjMDUgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRp bmdRdC5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZ1F0LmNwcApAQCAtMTY4 LDcgKzE2OCw4IEBAIGludCB3YWl0Rm9yVGhyZWFkQ29tcGxldGlvbihUaHJlYWRJZGVudGlmaWVy IHRocmVhZElELCB2b2lkKiogcmVzdWx0KQogICAgIGJvb2wgcmVzID0gdGhyZWFkLT53YWl0KCk7 CiAKICAgICBjbGVhclRocmVhZEZvcklkZW50aWZpZXIodGhyZWFkSUQpOwotICAgICpyZXN1bHQg PSBzdGF0aWNfY2FzdDxUaHJlYWRQcml2YXRlKj4odGhyZWFkKS0+Z2V0UmV0dXJuVmFsdWUoKTsK KyAgICBpZiAocmVzdWx0KQorICAgICAgICAqcmVzdWx0ID0gc3RhdGljX2Nhc3Q8VGhyZWFkUHJp dmF0ZSo+KHRocmVhZCktPmdldFJldHVyblZhbHVlKCk7CiAKICAgICByZXR1cm4gIXJlczsKIH0K LS0gCjEuNS40LjMKCg==