226475 2021-05-31 17:21:25 -0700 Fix thread safety issues in MediaElementAudioSourceNode 2021-06-01 07:57:15 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez cdumez darin eric.carlson ews-watchlist ggaren glenn jer.noble peng.liu6 philipj sam sergio webkit-bug-importer youennf oldest_to_newest 1765473 0 cdumez 2021-05-31 17:21:25 -0700 Adopt thread safety analysis annotations in MediaElementAudioSourceNode and fix bugs found by clang. 1765474 1 430218 cdumez 2021-05-31 17:24:45 -0700 Created attachment 430218 Patch 1765611 2 ews-feeder 2021-06-01 07:56:12 -0700 Committed r278306 (238343@main): <https://commits.webkit.org/238343@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430218. 1765612 3 webkit-bug-importer 2021-06-01 07:57:15 -0700 <rdar://problem/78714387> 430218 2021-05-31 17:24:45 -0700 2021-06-01 07:56:14 -0700 Patch bug-226475-20210531172444.patch text/plain 4722 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4Mjg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGIzNmYwODIwZTI0NmZh YmVkZDFhM2Y5NjAwYjg4MDlhODZlOWE0Zi4uYzU3YmYwNTVmYzkxMjdmNDA5MTZiMDJjMjY5Yzhh ODBkODAyZWQwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTA1LTMxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IHRocmVhZCBzYWZldHkg aXNzdWVzIGluIE1lZGlhRWxlbWVudEF1ZGlvU291cmNlTm9kZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2NDc1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRvcHQgdGhyZWFkIHNhZmV0eSBhbmFseXNp cyBhbm5vdGF0aW9ucyBpbiBNZWRpYUVsZW1lbnRBdWRpb1NvdXJjZU5vZGUgYW5kIGZpeAorICAg ICAgICBidWdzIGZvdW5kIGJ5IGNsYW5nLiBJbiBwYXJ0aWN1bGFyLCB0aGUgZm9sbG93aW5nIGlz c3VlcyB3ZXJlIGZpeGVkOgorICAgICAgICAtIHNldEZvcm1hdCgpIHdhcyBtb2RpZnlpbmcgbV9t dXRlZCAvIG1fc291cmNlTnVtYmVyT2ZDaGFubmVscyAvIG1fc291cmNlU2FtcGxlUmF0ZQorICAg ICAgICAgIG9uIHRoZSBtYWluIHRocmVhZCB3aXRob3V0IGxvY2tpbmcsIGV2ZW4gdGhvdWdoIHRo b3NlIGRhdGEgbWVtYmVycyBhcmUgYWNjZXNzZWQKKyAgICAgICAgICBmcm9tIHRoZSByZW5kZXJp bmcgdGhyZWFkLgorICAgICAgICAtIHByb2Nlc3MoKSB3YXMgYWNjZXNzaW5nICBtX211dGVkIC8g bV9zb3VyY2VOdW1iZXJPZkNoYW5uZWxzIC8gbV9zb3VyY2VTYW1wbGVSYXRlCisgICAgICAgICAg b24gdGhlIHJlbmRlcmluZyB0aHJlYWQgKmJlZm9yZSogbG9ja2luZy4KKworICAgICAgICAqIE1v ZHVsZXMvd2ViYXVkaW8vTWVkaWFFbGVtZW50QXVkaW9Tb3VyY2VOb2RlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Ok1lZGlhRWxlbWVudEF1ZGlvU291cmNlTm9kZTo6c2V0Rm9ybWF0KToKKyAgICAg ICAgKFdlYkNvcmU6Ok1lZGlhRWxlbWVudEF1ZGlvU291cmNlTm9kZTo6cHJvY2Vzcyk6CisgICAg ICAgICogTW9kdWxlcy93ZWJhdWRpby9NZWRpYUVsZW1lbnRBdWRpb1NvdXJjZU5vZGUuaDoKKwog MjAyMS0wNS0zMSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEZp eCB0aHJlYWQgc2FmZXR5IGlzc3VlcyBpbiBDb252b2x2ZXJOb2RlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL01lZGlhRWxlbWVudEF1ZGlvU291cmNlTm9kZS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL01lZGlhRWxlbWVudEF1ZGlvU291 cmNlTm9kZS5jcHAKaW5kZXggMGMxZTQ0NjU0MjY1MThkOThiMzQwMWZiNWJlZTc1ZTllMGNlMzli NC4uMDVlOTNlYzI2ZDU2NzA4MGNlNGE1MDNlN2UxYzc5YjliNWE0MzMzNSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9NZWRpYUVsZW1lbnRBdWRpb1NvdXJjZU5v ZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vTWVkaWFFbGVtZW50 QXVkaW9Tb3VyY2VOb2RlLmNwcApAQCAtODMsNiArODMsMTAgQEAgTWVkaWFFbGVtZW50QXVkaW9T b3VyY2VOb2RlOjp+TWVkaWFFbGVtZW50QXVkaW9Tb3VyY2VOb2RlKCkKIHZvaWQgTWVkaWFFbGVt ZW50QXVkaW9Tb3VyY2VOb2RlOjpzZXRGb3JtYXQoc2l6ZV90IG51bWJlck9mQ2hhbm5lbHMsIGZs b2F0IHNvdXJjZVNhbXBsZVJhdGUpCiB7CiAgICAgYXV0byBwcm90ZWN0ZWRUaGlzID0gbWFrZVJl ZigqdGhpcyk7CisKKyAgICAvLyBTeW5jaHJvbml6ZSB3aXRoIHByb2Nlc3MoKS4KKyAgICBMb2Nr ZXIgbG9ja2VyIHsgbV9wcm9jZXNzTG9jayB9OworCiAgICAgbV9tdXRlZCA9IHdvdWxkVGFpbnRP cmlnaW4oKTsKIAogICAgIGlmIChudW1iZXJPZkNoYW5uZWxzICE9IG1fc291cmNlTnVtYmVyT2ZD aGFubmVscyB8fCBzb3VyY2VTYW1wbGVSYXRlICE9IG1fc291cmNlU2FtcGxlUmF0ZSkgewpAQCAt OTcsOSArMTAxLDYgQEAgdm9pZCBNZWRpYUVsZW1lbnRBdWRpb1NvdXJjZU5vZGU6OnNldEZvcm1h dChzaXplX3QgbnVtYmVyT2ZDaGFubmVscywgZmxvYXQgc291cmMKICAgICAgICAgbV9zb3VyY2VO dW1iZXJPZkNoYW5uZWxzID0gbnVtYmVyT2ZDaGFubmVsczsKICAgICAgICAgbV9zb3VyY2VTYW1w bGVSYXRlID0gc291cmNlU2FtcGxlUmF0ZTsKIAotICAgICAgICAvLyBTeW5jaHJvbml6ZSB3aXRo IHByb2Nlc3MoKS4KLSAgICAgICAgTG9ja2VyIGxvY2tlciB7IG1fcHJvY2Vzc0xvY2sgfTsKLQog ICAgICAgICBpZiAoc291cmNlU2FtcGxlUmF0ZSAhPSBzYW1wbGVSYXRlKCkpIHsKICAgICAgICAg ICAgIGRvdWJsZSBzY2FsZUZhY3RvciA9IHNvdXJjZVNhbXBsZVJhdGUgLyBzYW1wbGVSYXRlKCk7 CiAgICAgICAgICAgICBtX211bHRpQ2hhbm5lbFJlc2FtcGxlciA9IG1ha2VVbmlxdWU8TXVsdGlD aGFubmVsUmVzYW1wbGVyPihzY2FsZUZhY3RvciwgbnVtYmVyT2ZDaGFubmVscywgQXVkaW9VdGls aXRpZXM6OnJlbmRlclF1YW50dW1TaXplLCBzdGQ6OmJpbmQoJk1lZGlhRWxlbWVudEF1ZGlvU291 cmNlTm9kZTo6cHJvdmlkZUlucHV0LCB0aGlzLCBzdGQ6OnBsYWNlaG9sZGVyczo6XzEsIHN0ZDo6 cGxhY2Vob2xkZXJzOjpfMikpOwpAQCAtMTUwLDExICsxNTEsNiBAQCB2b2lkIE1lZGlhRWxlbWVu dEF1ZGlvU291cmNlTm9kZTo6cHJvY2VzcyhzaXplX3QgbnVtYmVyT2ZGcmFtZXMpCiB7CiAgICAg QXVkaW9CdXMqIG91dHB1dEJ1cyA9IG91dHB1dCgwKS0+YnVzKCk7CiAKLSAgICBpZiAobV9tdXRl ZCB8fCAhbV9zb3VyY2VOdW1iZXJPZkNoYW5uZWxzIHx8ICFtX3NvdXJjZVNhbXBsZVJhdGUpIHsK LSAgICAgICAgb3V0cHV0QnVzLT56ZXJvKCk7Ci0gICAgICAgIHJldHVybjsKLSAgICB9Ci0KICAg ICAvLyBVc2UgdHJ5TG9jaygpIHRvIGF2b2lkIGNvbnRlbnRpb24gaW4gdGhlIHJlYWwtdGltZSBh dWRpbyB0aHJlYWQuCiAgICAgLy8gSWYgd2UgZmFpbCB0byBhY3F1aXJlIHRoZSBsb2NrIHRoZW4g dGhlIEhUTUxNZWRpYUVsZW1lbnQgbXVzdCBiZSBpbiB0aGUgbWlkZGxlIG9mCiAgICAgLy8gcmVj b25maWd1cmluZyBpdHMgcGxheWJhY2sgZW5naW5lLCBzbyB3ZSBvdXRwdXQgc2lsZW5jZSBpbiB0 aGlzIGNhc2UuCkBAIC0xNjUsNyArMTYxLDggQEAgdm9pZCBNZWRpYUVsZW1lbnRBdWRpb1NvdXJj ZU5vZGU6OnByb2Nlc3Moc2l6ZV90IG51bWJlck9mRnJhbWVzKQogICAgIH0KIAogICAgIExvY2tl ciBsb2NrZXIgeyBBZG9wdExvY2ssIG1fcHJvY2Vzc0xvY2sgfTsKLSAgICBpZiAobV9zb3VyY2VO dW1iZXJPZkNoYW5uZWxzICE9IG91dHB1dEJ1cy0+bnVtYmVyT2ZDaGFubmVscygpKSB7CisKKyAg ICBpZiAobV9tdXRlZCB8fCAhbV9zb3VyY2VOdW1iZXJPZkNoYW5uZWxzIHx8ICFtX3NvdXJjZVNh bXBsZVJhdGUgfHwgbV9zb3VyY2VOdW1iZXJPZkNoYW5uZWxzICE9IG91dHB1dEJ1cy0+bnVtYmVy T2ZDaGFubmVscygpKSB7CiAgICAgICAgIG91dHB1dEJ1cy0+emVybygpOwogICAgICAgICByZXR1 cm47CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9N ZWRpYUVsZW1lbnRBdWRpb1NvdXJjZU5vZGUuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vi YXVkaW8vTWVkaWFFbGVtZW50QXVkaW9Tb3VyY2VOb2RlLmgKaW5kZXggNGIyOGQ3N2E0ZWZmYTYw N2RhMDMzYjJiYTA4MGZkMThmNGM4NzljMy4uNzdiYzM5NjA0MGI1ZjA3MjI3YWQ1ZjY5ZjU2NDQw YzdkNmZkMmRjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9N ZWRpYUVsZW1lbnRBdWRpb1NvdXJjZU5vZGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L3dlYmF1ZGlvL01lZGlhRWxlbWVudEF1ZGlvU291cmNlTm9kZS5oCkBAIC03MiwxMSArNzIsMTEg QEAgcHJpdmF0ZToKICAgICBSZWY8SFRNTE1lZGlhRWxlbWVudD4gbV9tZWRpYUVsZW1lbnQ7CiAg ICAgTG9jayBtX3Byb2Nlc3NMb2NrOwogCi0gICAgdW5zaWduZWQgbV9zb3VyY2VOdW1iZXJPZkNo YW5uZWxzIHsgMCB9OwotICAgIGRvdWJsZSBtX3NvdXJjZVNhbXBsZVJhdGUgeyAwIH07Ci0gICAg Ym9vbCBtX211dGVkIHsgZmFsc2UgfTsKKyAgICB1bnNpZ25lZCBtX3NvdXJjZU51bWJlck9mQ2hh bm5lbHMgV1RGX0dVQVJERURfQllfTE9DSyhtX3Byb2Nlc3NMb2NrKSB7IDAgfTsKKyAgICBkb3Vi bGUgbV9zb3VyY2VTYW1wbGVSYXRlIFdURl9HVUFSREVEX0JZX0xPQ0sobV9wcm9jZXNzTG9jaykg eyAwIH07CisgICAgYm9vbCBtX211dGVkIFdURl9HVUFSREVEX0JZX0xPQ0sobV9wcm9jZXNzTG9j aykgeyBmYWxzZSB9OwogCi0gICAgc3RkOjp1bmlxdWVfcHRyPE11bHRpQ2hhbm5lbFJlc2FtcGxl cj4gbV9tdWx0aUNoYW5uZWxSZXNhbXBsZXI7CisgICAgc3RkOjp1bmlxdWVfcHRyPE11bHRpQ2hh bm5lbFJlc2FtcGxlcj4gbV9tdWx0aUNoYW5uZWxSZXNhbXBsZXIgV1RGX0dVQVJERURfQllfTE9D SyhtX3Byb2Nlc3NMb2NrKTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK