226468 2021-05-31 06:07:12 -0700 ANGLE Metal translator should clamp array access in MSL 2024-01-22 23:52:01 -0800 1 1 1 Unclassified WebKit ANGLE Other Unspecified Unspecified RESOLVED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=226397 InRadar P2 Normal --- 1 kkinnunen kkinnunen ahmad.saleem792 dino ews-watchlist graouts johncunningham kirtiar15502 kkinnunen kondapallykalyan kpiddington webkit-bug-importer oldest_to_newest 1765396 0 kkinnunen 2021-05-31 06:07:12 -0700 ANGLE Metal translator should clamp array access in MSL 1765397 1 kirtiar15502 2021-05-31 06:09:56 -0700 Looks like this issue was created after that, yes? 1765398 2 430200 kkinnunen 2021-05-31 06:10:17 -0700 Created attachment 430200 Patch 1765399 3 ews-watchlist 2021-05-31 06:11:25 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1765403 4 kkinnunen 2021-05-31 06:24:59 -0700 (In reply to Kirtikumar Anandrao Ramchandani from comment #1) > Looks like this issue was created after that, yes? This bug report was created based on bug 226397 and after that, yes. 1765426 5 dino 2021-05-31 11:02:10 -0700 Can we write a test for this? 1765428 6 kirtiar15502 2021-05-31 11:03:22 -0700 We can write a test case to reach that particular piece of code, yes. 1765521 7 kkinnunen 2021-05-31 23:49:48 -0700 (In reply to Dean Jackson from comment #5) > Can we write a test for this? At the moment it's a bit cumbersome. For manual inspection of shader text output we'd either need to: a) add a text-dumping translator tester to ANGLE b) implement (the long overdue) per-gpu filtering possibility to RWT and use the layout test to dump the GL/MTL shader output to expected files For draw inspection-based test it's hard to do since we don't know what to expect in the failure case. In practice we can't know that a success would indicate lack of bug. This is tested by conformance/uniforms/out-of-bounds-uniform-array-access.html but it's unclear to what extent we can observe the bug. Obviously we cannot, as the test did not trigger. I'll check if we can later turn on validating layer for Metal on Debug builds, but I doubt it will detect this either. I'll put testing this in the "back burner" and take the liberty to merge without, as we have bigger issues in testing than this. 1765522 8 kkinnunen 2021-05-31 23:56:12 -0700 > b) implement (the long overdue) per-gpu filtering possibility to RWT and use the layout test to dump the GL/MTL shader output to expected files Except, maybe it's doable since this the "MSL or GLSL or HLSL" decision is per platform in WebKit at the moment. I'll try to write the test. 1767422 9 webkit-bug-importer 2021-06-07 06:08:18 -0700 <rdar://problem/78944685> 1901038 10 ahmad.saleem792 2022-09-25 12:42:37 -0700 It seems this r+ patch didn't landed. Is it something still needed or being worked on? Thanks! 1903086 11 kkinnunen 2022-10-04 03:47:55 -0700 Thanks for the heads. I think I need to upstream this. 2006837 12 kkinnunen 2024-01-22 23:51:52 -0800 Already fixed in GenMetalTraverser::visitBinary(Visit, TIntermBinary *binaryNode) 430200 2021-05-31 06:10:17 -0700 2021-05-31 23:55:06 -0700 Patch bug-226468-20210531161015.patch text/plain 2057 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMGRjMGEzMzdmMDgxMzRlZmU2NjVmMzhmNWE5NmZhYmJkM2JmNWExYy4uOTQ3ZmEyOWM0OTU5 NjIxOTE1Nzc4ZDgyZjczNzcwODBmNjFiNjUxOCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTA1LTMxICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5l bkBhcHBsZS5jb20+CisKKyAgICAgICAgQU5HTEUgTWV0YWwgdHJhbnNsYXRvciBzaG91bGQgY2xh bXAgYXJyYXkgYWNjZXNzIGluIE1TTAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjI2NDY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBzcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvU2hhZGVyTXRsLm1t OgorICAgICAgICAocng6OlNoYWRlck10bDo6Y29tcGlsZSk6CisgICAgICAgIEFkZCBvcHRpb24g dG8gZW1pdCBjbGFtcGluZyBmb3IgYXJyYXkgYWNjZXNzZXMuCisgICAgICAgIENvbnNpc3RlbnQg d2l0aCBHTCBhbmQgVmsuCisKIDIwMjEtMDUtMjcgIEtpbW1vIEtpbm51bmVuICA8a2tpbm51bmVu QGFwcGxlLmNvbT4KIAogICAgICAgICBBTkdMRSBjb3VsZCBiZSBjb21waWxlZCB3aXRoICJhZ2dy ZXNzaXZlIHVuaW5pdGlhbGlzZWQgdmFyaWFibGUiIHNldHRpbmcKZGlmZiAtLWdpdCBhL1NvdXJj ZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9TaGFkZXJNdGwu bW0gYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwv U2hhZGVyTXRsLm1tCmluZGV4IGNlNThmOWQyYTU2ODExNTQyMDY3ODE5OTlmODM0NTgxYTFiM2Nk ZmQuLmU4NjBiYTYyMzI4YjVlMDNiOWNmZTU0ZGYyZmZmZjFmYWI4MWRiMTQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9TaGFk ZXJNdGwubW0KKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRl cmVyL21ldGFsL1NoYWRlck10bC5tbQpAQCAtMTI0LDkgKzEyNCwxNSBAQCBzdGQ6OnNoYXJlZF9w dHI8V2FpdGFibGVDb21waWxlRXZlbnQ+IFNoYWRlck10bDo6Y29tcGlsZShjb25zdCBnbDo6Q29u dGV4dCAqY29udAogICAgIFNoQ29tcGlsZU9wdGlvbnMgY29tcGlsZU9wdGlvbnMgPSBTSF9JTklU SUFMSVpFX1VOSU5JVElBTElaRURfTE9DQUxTOwogCiAgICAgYm9vbCBpc1dlYkdMID0gY29udGV4 dC0+Z2V0RXh0ZW5zaW9ucygpLndlYmdsQ29tcGF0aWJpbGl0eTsKLSAgICBpZiAoaXNXZWJHTCAm JiBtU3RhdGUuZ2V0U2hhZGVyVHlwZSgpICE9IGdsOjpTaGFkZXJUeXBlOjpDb21wdXRlKQorICAg IGlmIChpc1dlYkdMKQogICAgIHsKLSAgICAgICAgY29tcGlsZU9wdGlvbnMgfD0gU0hfSU5JVF9P VVRQVVRfVkFSSUFCTEVTOworICAgICAgICBpZiAobVN0YXRlLmdldFNoYWRlclR5cGUoKSAhPSBn bDo6U2hhZGVyVHlwZTo6Q29tcHV0ZSkKKyAgICAgICAgeworICAgICAgICAgICAgY29tcGlsZU9w dGlvbnMgfD0gU0hfSU5JVF9PVVRQVVRfVkFSSUFCTEVTOworICAgICAgICB9CisgICAgICAgIC8v IE1ldGFsIFNoYWRpbmcgTGFuZ3VhZ2UgU3BlY2lmaWNhdGlvbiBWZXJzaW9uIDIuMzoKKyAgICAg ICAgLy8gQWNjZXNzaW5nIGEgY29tcG9uZW50IG91dHNpZGUgdGhlIGJvdW5kcyBvZiBhIG1hdHJp eCB3aXRoIGEgbm9uLWNvbnN0YW50IGV4cHJlc3Npb24gcmVzdWx0cyBpbiB1bmRlZmluZWQgYmVo YXZpb3IuCisgICAgICAgIGNvbXBpbGVPcHRpb25zIHw9IFNIX0NMQU1QX0lORElSRUNUX0FSUkFZ X0JPVU5EUzsKICAgICB9CiAKICAgICBjb21waWxlT3B0aW9ucyB8PSBTSF9DTEFNUF9QT0lOVF9T SVpFOwo=