226453 2021-05-30 22:17:58 -0700 add Internals method to expose synchronous scrolling reasons for individual scrolling tree scrolling nodes 2021-06-01 15:22:19 -0700 1 1 1 Unclassified WebKit Scrolling WebKit Local Build Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 226399 1 heycam heycam changseok cmarcelo darin esprehn+autocc ews-watchlist fred.wang glenn jamesr kondapallykalyan luiz pdr simon.fraser tonikitoo oldest_to_newest 1765324 0 heycam 2021-05-30 22:17:58 -0700 So we can test the synchronous scrolling reasons are set correctly on scrolling tree nodes for overflow:scroll elements. 1765325 1 430174 heycam 2021-05-30 22:20:45 -0700 Created attachment 430174 Patch 1765593 2 430174 fred.wang 2021-06-01 06:26:15 -0700 Comment on attachment 430174 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430174&action=review > Source/WebCore/testing/Internals.h:441 > + ExceptionOr<String> synchronousScrollingReasonsForScrollableElement(Element&) const; Is it possible to make this a const Element&? 1765665 3 simon.fraser 2021-06-01 10:20:38 -0700 Doesn't dumping the scrolling state tree suffice? 1765743 4 heycam 2021-06-01 13:59:07 -0700 (In reply to Simon Fraser (smfr) from comment #3) > Doesn't dumping the scrolling state tree suffice? As I discovered from looking at other tests, yes it does. But it includes a lot of other irrelevant information for my tests. Seems like it's better to avoid having to update test expectations for changes in other parts of the scrolling state tree, but if you think it's better to just use the existing thing and avoid adding something new, I can do that. 1765761 5 430174 darin 2021-06-01 14:31:09 -0700 Comment on attachment 430174 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430174&action=review >> Source/WebCore/testing/Internals.h:441 >> + ExceptionOr<String> synchronousScrollingReasonsForScrollableElement(Element&) const; > > Is it possible to make this a const Element&? Why does that matter? This is designed to be called from JavaScript. 1765794 6 heycam 2021-06-01 15:22:19 -0700 (In reply to Simon Fraser (smfr) from comment #3) > Doesn't dumping the scrolling state tree suffice? I've updated my tests in bug 226399 to use the scrolling state tree dump so I'm not going to use this patch. 430174 2021-05-30 22:20:45 -0700 2021-06-01 06:26:15 -0700 Patch bug-226453-20210531152043.patch text/plain 12066 heycam U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjUwMzJmZDk1NWM2YTNm NjVkYjVkMmM0NzBiOWNlODNjZDAzZWZlNi4uYWMyNTJlNzhkNDI0MGFiODQ5NzNjM2JiOGI2OTc4 ODhjMWQxNDRhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDIxLTA1LTMwICBDYW1l cm9uIE1jQ29ybWFjayAgPGhleWNhbUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIEludGVybmFs cyBtZXRob2QgdG8gZXhwb3NlIHN5bmNocm9ub3VzIHNjcm9sbGluZyByZWFzb25zIGZvciBpbmRp dmlkdWFsIHNjcm9sbGluZyB0cmVlIG5vZGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjY0NTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBTbyB3ZSBjYW4gdGVzdCB0aGUgc3luY2hyb25vdXMgc2Nyb2xs aW5nIHJlYXNvbnMgYXJlIHNldCBjb3JyZWN0bHkgb24KKyAgICAgICAgc2Nyb2xsaW5nIHRyZWUg bm9kZXMgZm9yIG92ZXJmbG93OnNjcm9sbCBlbGVtZW50cy4KKworICAgICAgICAqIHBhZ2Uvc2Ny b2xsaW5nL0FzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 QXN5bmNTY3JvbGxpbmdDb29yZGluYXRvcjo6c3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb25zIGNv bnN0KToKKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9Bc3luY1Njcm9sbGluZ0Nvb3JkaW5hdG9y Lmg6CisgICAgICAgICogcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnNob3VsZFVwZGF0ZVNjcm9s bExheWVyUG9zaXRpb25TeW5jaHJvbm91c2x5IGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OlNj cm9sbGluZ0Nvb3JkaW5hdG9yOjpzeW5jaHJvbm91c1Njcm9sbGluZ1JlYXNvbnNBc1RleHQgY29u c3QpOgorICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmg6Cisg ICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdDb29yZGluYXRvcjo6c3luY2hyb25vdXNTY3JvbGxp bmdSZWFzb25zIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGluZ0Nvb3JkaW5hdG9y OjpoYXNTeW5jaHJvbm91c1Njcm9sbGluZ1JlYXNvbnMgY29uc3QpOgorICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy TGF5ZXJDb21wb3NpdG9yOjphc3luY1Njcm9sbGFibGVOb2RlSUQpOgorICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuaDoKKyAgICAgICAgKiB0ZXN0aW5nL0ludGVybmFs cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnRlcm5hbHM6OnN5bmNocm9ub3VzU2Nyb2xsaW5n UmVhc29uc0ZvclNjcm9sbGFibGVFbGVtZW50IGNvbnN0KToKKyAgICAgICAgKiB0ZXN0aW5nL0lu dGVybmFscy5oOgorICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxzLmlkbDoKKwogMjAyMS0wNS0y OCAgQ2FtZXJvbiBNY0Nvcm1hY2sgIDxoZXljYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbmFt ZSBJbnRlcm5hbHMubWFpblRocmVhZFNjcm9sbGluZ1JlYXNvbnMgdG8gc3luY2hyb25vdXNTY3Jv bGxpbmdSZWFzb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9B c3luY1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xs aW5nL0FzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwCmluZGV4IGU4MDU3ZjM4ZDcwM2Q2NjZm ZjA0YjA4OTJkZjA1OWMwNWRlYjBkYTcuLjMzNmRjOWU4NzAzMWZmOWU2MzhmYTNlMjkxNTE2ZTI4 ZjM5M2M1MDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL0FzeW5j U2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xs aW5nL0FzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwCkBAIC03ODQsMTYgKzc4NCwxNiBAQCB2 b2lkIEFzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnNldFN5bmNocm9ub3VzU2Nyb2xsaW5nUmVh c29ucyhTY3JvbGxpbmdOb2RlSUQgbgogI2VuZGlmCiB9CiAKLWJvb2wgQXN5bmNTY3JvbGxpbmdD b29yZGluYXRvcjo6aGFzU3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb25zKFNjcm9sbGluZ05vZGVJ RCBub2RlSUQpIGNvbnN0CitPcHRpb25TZXQ8U3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb24+IEFz eW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnN5bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29ucyhTY3Jv bGxpbmdOb2RlSUQgbm9kZUlEKSBjb25zdAogewogICAgIGF1dG8qIG5vZGUgPSBtX3Njcm9sbGlu Z1N0YXRlVHJlZS0+c3RhdGVOb2RlRm9ySUQobm9kZUlEKTsKICAgICBpZiAoIWlzPFNjcm9sbGlu Z1N0YXRlU2Nyb2xsaW5nTm9kZT4obm9kZSkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAg ICAgcmV0dXJuIHsgfTsKIAogI2lmIEVOQUJMRShTQ1JPTExJTkdfVEhSRUFEKQotICAgIHJldHVy biBkb3duY2FzdDxTY3JvbGxpbmdTdGF0ZVNjcm9sbGluZ05vZGU+KCpub2RlKS5oYXNTeW5jaHJv bm91c1Njcm9sbGluZ1JlYXNvbnMoKTsKKyAgICByZXR1cm4gZG93bmNhc3Q8U2Nyb2xsaW5nU3Rh dGVTY3JvbGxpbmdOb2RlPigqbm9kZSkuc3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb25zKCk7CiAj ZWxzZQotICAgIHJldHVybiBmYWxzZTsKKyAgICByZXR1cm4geyB9OwogI2VuZGlmCiB9CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL0FzeW5jU2Nyb2xsaW5nQ29v cmRpbmF0b3IuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL0FzeW5jU2Nyb2xsaW5n Q29vcmRpbmF0b3IuaAppbmRleCAyYzgwZGUyMmU2MjBiYWI0ZGYzOGViMTJmMjM1NTNjYjM1Y2Iy NDM4Li41MWQ2ZDg3NjIyZmZhODViYWJkMTk3OWExZGM1Y2ExZjFmYTA2YmUzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9Bc3luY1Njcm9sbGluZ0Nvb3JkaW5hdG9y LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvQXN5bmNTY3JvbGxpbmdDb29y ZGluYXRvci5oCkBAIC0xNDQsNyArMTQ0LDcgQEAgcHJpdmF0ZToKICAgICBXRUJDT1JFX0VYUE9S VCB2b2lkIHNjcm9sbGFibGVBcmVhU2Nyb2xsYmFyTGF5ZXJEaWRDaGFuZ2UoU2Nyb2xsYWJsZUFy ZWEmLCBTY3JvbGxiYXJPcmllbnRhdGlvbikgb3ZlcnJpZGU7CiAKICAgICBXRUJDT1JFX0VYUE9S VCB2b2lkIHNldFN5bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29ucyhTY3JvbGxpbmdOb2RlSUQsIE9w dGlvblNldDxTeW5jaHJvbm91c1Njcm9sbGluZ1JlYXNvbj4pIGZpbmFsOwotICAgIFdFQkNPUkVf RVhQT1JUIGJvb2wgaGFzU3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb25zKFNjcm9sbGluZ05vZGVJ RCkgY29uc3QgZmluYWw7CisgICAgV0VCQ09SRV9FWFBPUlQgT3B0aW9uU2V0PFN5bmNocm9ub3Vz U2Nyb2xsaW5nUmVhc29uPiBzeW5jaHJvbm91c1Njcm9sbGluZ1JlYXNvbnMoU2Nyb2xsaW5nTm9k ZUlEKSBjb25zdCBmaW5hbDsKIAogICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQgd2luZG93U2NyZWVu RGlkQ2hhbmdlKFBsYXRmb3JtRGlzcGxheUlELCBzdGQ6Om9wdGlvbmFsPEZyYW1lc1BlclNlY29u ZD4gbm9taW5hbEZyYW1lc1BlclNlY29uZCkgZmluYWw7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcAppbmRleCAxODcy ZTQyZWRmZWVlMTgwMzAwN2U5ZGVkZTc4MGJhODc4ZjFlM2I2Li5lZWRiYzg3Mjg2NzhmYjM4ZjNi ZWVhMGE1MDg1OGNmM2NiYTExNmZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Nj cm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwCkBAIC0zNTksNyArMzU5LDcgQEAg dm9pZCBTY3JvbGxpbmdDb29yZGluYXRvcjo6c2V0Rm9yY2VTeW5jaHJvbm91c1Njcm9sbExheWVy UG9zaXRpb25VcGRhdGVzKGJvb2wgZm8KIGJvb2wgU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnNob3Vs ZFVwZGF0ZVNjcm9sbExheWVyUG9zaXRpb25TeW5jaHJvbm91c2x5KGNvbnN0IEZyYW1lVmlldyYg ZnJhbWVWaWV3KSBjb25zdAogewogICAgIGlmICgmZnJhbWVWaWV3ID09IG1fcGFnZS0+bWFpbkZy YW1lKCkudmlldygpKQotICAgICAgICByZXR1cm4gIXN5bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29u c0ZvckZyYW1lVmlldyhmcmFtZVZpZXcpLmlzRW1wdHkoKTsKKyAgICAgICAgcmV0dXJuIGhhc1N5 bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29ucyhmcmFtZVZpZXcuc2Nyb2xsaW5nTm9kZUlEKCkpOwog ICAgIAogICAgIHJldHVybiB0cnVlOwogfQpAQCAtMzk0LDExICszOTQsMTYgQEAgU3RyaW5nIFNj cm9sbGluZ0Nvb3JkaW5hdG9yOjpzeW5jaHJvbm91c1Njcm9sbGluZ1JlYXNvbnNBc1RleHQoT3B0 aW9uU2V0PFN5bmNocm8KIFN0cmluZyBTY3JvbGxpbmdDb29yZGluYXRvcjo6c3luY2hyb25vdXNT Y3JvbGxpbmdSZWFzb25zQXNUZXh0KCkgY29uc3QKIHsKICAgICBpZiAoYXV0byogZnJhbWVWaWV3 ID0gbV9wYWdlLT5tYWluRnJhbWUoKS52aWV3KCkpCi0gICAgICAgIHJldHVybiBzeW5jaHJvbm91 c1Njcm9sbGluZ1JlYXNvbnNBc1RleHQoc3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb25zRm9yRnJh bWVWaWV3KCpmcmFtZVZpZXcpKTsKKyAgICAgICAgcmV0dXJuIHN5bmNocm9ub3VzU2Nyb2xsaW5n UmVhc29uc0FzVGV4dChzeW5jaHJvbm91c1Njcm9sbGluZ1JlYXNvbnMoZnJhbWVWaWV3LT5zY3Jv bGxpbmdOb2RlSUQoKSkpOwogCiAgICAgcmV0dXJuIFN0cmluZygpOwogfQogCitTdHJpbmcgU2Ny b2xsaW5nQ29vcmRpbmF0b3I6OnN5bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29uc0FzVGV4dChTY3Jv bGxpbmdOb2RlSUQgbm9kZUlEKSBjb25zdAoreworICAgIHJldHVybiBzeW5jaHJvbm91c1Njcm9s bGluZ1JlYXNvbnNBc1RleHQoc3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb25zKG5vZGVJRCkpOwor fQorCiBUZXh0U3RyZWFtJiBvcGVyYXRvcjw8KFRleHRTdHJlYW0mIHRzLCBTY3JvbGxhYmxlQXJl YVBhcmFtZXRlcnMgc2Nyb2xsYWJsZUFyZWFQYXJhbWV0ZXJzKQogewogICAgIHRzLmR1bXBQcm9w ZXJ0eSgiaG9yaXpvbnRhbCBzY3JvbGwgZWxhc3RpY2l0eSIsIHNjcm9sbGFibGVBcmVhUGFyYW1l dGVycy5ob3Jpem9udGFsU2Nyb2xsRWxhc3RpY2l0eSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5oIGIvU291cmNlL1dlYkNv cmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuaAppbmRleCA2Njc0NjYzYWFl NjQwYTdhY2IyNjVlODkwODYxZGEzODU3YTAzOWU2Li5kZTlhYzM2ZTM3ZDZhNzUzNDdhMzQ2NmVm YjZmZjM0ZjdmZTczOGVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGlu Zy9TY3JvbGxpbmdDb29yZGluYXRvci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xs aW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmgKQEAgLTE1NSw3ICsxNTUsNyBAQCBwdWJsaWM6CiAg ICAgdmlydHVhbCB2b2lkIHNldFBvc2l0aW9uZWROb2RlQ29uc3RyYWludHMoU2Nyb2xsaW5nTm9k ZUlELCBjb25zdCBBYnNvbHV0ZVBvc2l0aW9uQ29uc3RyYWludHMmKSB7IH0KICAgICB2aXJ0dWFs IHZvaWQgc2V0UmVsYXRlZE92ZXJmbG93U2Nyb2xsaW5nTm9kZXMoU2Nyb2xsaW5nTm9kZUlELCBW ZWN0b3I8U2Nyb2xsaW5nTm9kZUlEPiYmKSB7IH0KICAgICB2aXJ0dWFsIHZvaWQgc2V0U3luY2hy b25vdXNTY3JvbGxpbmdSZWFzb25zKFNjcm9sbGluZ05vZGVJRCwgT3B0aW9uU2V0PFN5bmNocm9u b3VzU2Nyb2xsaW5nUmVhc29uPikgeyB9Ci0gICAgdmlydHVhbCBib29sIGhhc1N5bmNocm9ub3Vz U2Nyb2xsaW5nUmVhc29ucyhTY3JvbGxpbmdOb2RlSUQpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9 CisgICAgdmlydHVhbCBPcHRpb25TZXQ8U3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb24+IHN5bmNo cm9ub3VzU2Nyb2xsaW5nUmVhc29ucyhTY3JvbGxpbmdOb2RlSUQpIGNvbnN0IHsgcmV0dXJuIHsg fTsgfQogCiAgICAgdmlydHVhbCB2b2lkIHJlY29uY2lsZVZpZXdwb3J0Q29uc3RyYWluZWRMYXll clBvc2l0aW9ucyhTY3JvbGxpbmdOb2RlSUQsIGNvbnN0IExheW91dFJlY3QmLCBTY3JvbGxpbmdM YXllclBvc2l0aW9uQWN0aW9uKSB7IH0KICAgICB2aXJ0dWFsIFN0cmluZyBzY3JvbGxpbmdTdGF0 ZVRyZWVBc1RleHQoU2Nyb2xsaW5nU3RhdGVUcmVlQXNUZXh0QmVoYXZpb3IgPSBTY3JvbGxpbmdT dGF0ZVRyZWVBc1RleHRCZWhhdmlvck5vcm1hbCkgY29uc3Q7CkBAIC0xNzEsNiArMTcxLDcgQEAg cHVibGljOgogICAgIFNjcm9sbGluZ05vZGVJRCB1bmlxdWVTY3JvbGxpbmdOb2RlSUQoKTsKIAog ICAgIGJvb2wgc2hvdWxkVXBkYXRlU2Nyb2xsTGF5ZXJQb3NpdGlvblN5bmNocm9ub3VzbHkoY29u c3QgRnJhbWVWaWV3JikgY29uc3Q7CisgICAgYm9vbCBoYXNTeW5jaHJvbm91c1Njcm9sbGluZ1Jl YXNvbnMoU2Nyb2xsaW5nTm9kZUlEIG5vZGVJRCkgY29uc3QgeyByZXR1cm4gISFzeW5jaHJvbm91 c1Njcm9sbGluZ1JlYXNvbnMobm9kZUlEKTsgfQogCiAgICAgdmlydHVhbCB2b2lkIHdpbGxEZXN0 cm95U2Nyb2xsYWJsZUFyZWEoU2Nyb2xsYWJsZUFyZWEmKSB7IH0KICAgICB2aXJ0dWFsIHZvaWQg c2Nyb2xsYWJsZUFyZWFTY3JvbGxiYXJMYXllckRpZENoYW5nZShTY3JvbGxhYmxlQXJlYSYsIFNj cm9sbGJhck9yaWVudGF0aW9uKSB7IH0KQEAgLTE3OSw2ICsxODAsNyBAQCBwdWJsaWM6CiAKICAg ICBzdGF0aWMgU3RyaW5nIHN5bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29uc0FzVGV4dChPcHRpb25T ZXQ8U3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb24+KTsKICAgICBTdHJpbmcgc3luY2hyb25vdXNT Y3JvbGxpbmdSZWFzb25zQXNUZXh0KCkgY29uc3Q7CisgICAgV0VCQ09SRV9FWFBPUlQgU3RyaW5n IHN5bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29uc0FzVGV4dChTY3JvbGxpbmdOb2RlSUQpIGNvbnN0 OwogCiAgICAgRXZlbnRUcmFja2luZ1JlZ2lvbnMgYWJzb2x1dGVFdmVudFRyYWNraW5nUmVnaW9u cygpIGNvbnN0OwogICAgIHZpcnR1YWwgdm9pZCB1cGRhdGVJc01vbml0b3JpbmdXaGVlbEV2ZW50 c0ZvckZyYW1lVmlldyhjb25zdCBGcmFtZVZpZXcmKSB7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKaW5kZXggYzAzNmQ4NTgzYjMz YmNkNzk1NjIwMjM1MWUzNGU5MWQ3ZjAxN2VmNy4uMTY2NTc1Y2QyY2JiMzZlOGE0OGIyMDY3NmU0 MTg5ZjM0MGVmYTUzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyQ29tcG9zaXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyQ29tcG9zaXRvci5jcHAKQEAgLTI5MTAsNiArMjkxMCwxNSBAQCBWZWN0b3I8Q29tcG9z aXRlZENsaXBEYXRhPiBSZW5kZXJMYXllckNvbXBvc2l0b3I6OmNvbXB1dGVBbmNlc3RvckNsaXBw aW5nU3RhY2soYwogICAgIHJldHVybiBuZXdTdGFjazsKIH0KIAorU2Nyb2xsaW5nTm9kZUlEIFJl bmRlckxheWVyQ29tcG9zaXRvcjo6YXN5bmNTY3JvbGxhYmxlTm9kZUlEKGNvbnN0IFJlbmRlckxh eWVyTW9kZWxPYmplY3QmIHJlbmRlcmVyKQoreworICAgIGF1dG8gbGF5ZXIgPSByZW5kZXJlci5s YXllcigpOworICAgIGlmICghbGF5ZXIgfHwgIWxheWVyLT5pc0NvbXBvc2l0ZWQoKSkKKyAgICAg ICAgcmV0dXJuIDA7CisKKyAgICByZXR1cm4gbGF5ZXItPmJhY2tpbmcoKS0+c2Nyb2xsaW5nTm9k ZUlERm9yUm9sZShTY3JvbGxDb29yZGluYXRpb25Sb2xlOjpTY3JvbGxpbmcpOworfQorCiAvLyBO b3RlIHRoYXQgdGhpcyByZXR1cm5zIHRoZSBTY3JvbGxpbmdOb2RlSUQgb2YgdGhlIHNjcm9sbGVy IHRoaXMgbGF5ZXIgaXMgZW1iZWRkZWQgaW4sIG5vdCB0aGUgbGF5ZXIncyBvd24gU2Nyb2xsaW5n Tm9kZUlEIGlmIGl0IGhhcyBvbmUuCiBTY3JvbGxpbmdOb2RlSUQgUmVuZGVyTGF5ZXJDb21wb3Np dG9yOjphc3luY1Njcm9sbGFibGVDb250YWluZXJOb2RlSUQoY29uc3QgUmVuZGVyT2JqZWN0JiBy ZW5kZXJlcikKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM YXllckNvbXBvc2l0b3IuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNv bXBvc2l0b3IuaAppbmRleCBkNmJiZjJmMzg3OWUxZTk1MzkzMzRjOTlhYjFiYjkxOGFlNWUyZGQz Li41YWE3ZmI5ZWIwODBiMGEwYjBmZjI0ODI1MjJkNWUzNGY2MGU0MjFhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5oCkBAIC0yMTksNiAr MjE5LDkgQEAgcHVibGljOgogICAgIC8vIE1heSByZXR1cm4gMCBmb3IgcG9zaXRpb24tZml4ZWQg Y29udGVudC4KICAgICBzdGF0aWMgU2Nyb2xsaW5nTm9kZUlEIGFzeW5jU2Nyb2xsYWJsZUNvbnRh aW5lck5vZGVJRChjb25zdCBSZW5kZXJPYmplY3QmKTsKIAorICAgIC8vIFJldHVybnMgdGhlIFNj cm9sbGluZ05vZGVJRCBmb3IgdGhlIGFzeW5jLXNjcm9sbGFibGUgbGF5ZXIgb3duZWQgYnkgdGhp cyByZW5kZXJlci4KKyAgICBXRUJDT1JFX0VYUE9SVCBzdGF0aWMgU2Nyb2xsaW5nTm9kZUlEIGFz eW5jU2Nyb2xsYWJsZU5vZGVJRChjb25zdCBSZW5kZXJMYXllck1vZGVsT2JqZWN0Jik7CisKICAg ICAvLyBXaGV0aGVyIGxheWVyJ3MgYmFja2luZyBuZWVkcyBhIGdyYXBoaWNzIGxheWVyIHRvIGNs aXAgei1vcmRlciBjaGlsZHJlbiBvZiB0aGUgZ2l2ZW4gbGF5ZXIuCiAgICAgc3RhdGljIGJvb2wg Y2xpcHNDb21wb3NpdGluZ0Rlc2NlbmRhbnRzKGNvbnN0IFJlbmRlckxheWVyJik7CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAppbmRleCA5NzQzYzg1ODMzYmQzOTNmNmIwZTM0NTM4 NjBhMDNhMThjNTM1ZDBlLi4zZTRkNTY2NzdhNTE3NTUxYmVkYTgyMTA2MTQxMDdlNGVjOWIxYjZi IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCkBAIC0zMDI3LDYgKzMwMjcsMjgg QEAgRXhjZXB0aW9uT3I8U3RyaW5nPiBJbnRlcm5hbHM6OnN5bmNocm9ub3VzU2Nyb2xsaW5nUmVh c29ucygpIGNvbnN0CiAgICAgcmV0dXJuIHBhZ2UtPnN5bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29u c0FzVGV4dCgpOwogfQogCitFeGNlcHRpb25PcjxTdHJpbmc+IEludGVybmFsczo6c3luY2hyb25v dXNTY3JvbGxpbmdSZWFzb25zRm9yU2Nyb2xsYWJsZUVsZW1lbnQoRWxlbWVudCYgZWxlbWVudCkg Y29uc3QKK3sKKyAgICBpZiAoIWVsZW1lbnQucmVuZGVyZXIoKSB8fCAhZWxlbWVudC5yZW5kZXJl cigpLT5pc1JlbmRlckxheWVyTW9kZWxPYmplY3QoKSkKKyAgICAgICAgcmV0dXJuIEV4Y2VwdGlv biB7IEludmFsaWRBY2Nlc3NFcnJvciB9OworCisgICAgYXV0byByZW5kZXJWaWV3ID0gZWxlbWVu dC5kb2N1bWVudCgpLnJlbmRlclZpZXcoKTsKKyAgICBpZiAoIXJlbmRlclZpZXcpCisgICAgICAg IHJldHVybiBFeGNlcHRpb24geyBJbnZhbGlkQWNjZXNzRXJyb3IgfTsKKworICAgIGF1dG8gcGFn ZSA9IGVsZW1lbnQuZG9jdW1lbnQoKS5wYWdlKCk7CisgICAgaWYgKCFwYWdlKQorICAgICAgICBy ZXR1cm4gRXhjZXB0aW9uIHsgSW52YWxpZEFjY2Vzc0Vycm9yIH07CisKKyAgICBhdXRvIHNjcm9s bGluZ0Nvb3JkaW5hdG9yID0gcGFnZS0+c2Nyb2xsaW5nQ29vcmRpbmF0b3IoKTsKKyAgICBpZiAo IXNjcm9sbGluZ0Nvb3JkaW5hdG9yKQorICAgICAgICByZXR1cm4gRXhjZXB0aW9uIHsgSW52YWxp ZEFjY2Vzc0Vycm9yIH07CisKKyAgICBhdXRvIHJlbmRlcmVyID0gZG93bmNhc3Q8UmVuZGVyTGF5 ZXJNb2RlbE9iamVjdD4oZWxlbWVudC5yZW5kZXJlcigpKTsKKyAgICBhdXRvIG5vZGVJRCA9IHJl bmRlclZpZXctPmNvbXBvc2l0b3IoKS5hc3luY1Njcm9sbGFibGVOb2RlSUQoKnJlbmRlcmVyKTsK KyAgICByZXR1cm4gc2Nyb2xsaW5nQ29vcmRpbmF0b3ItPnN5bmNocm9ub3VzU2Nyb2xsaW5nUmVh c29uc0FzVGV4dChub2RlSUQpOworfQorCiBFeGNlcHRpb25PcjxSZWY8RE9NUmVjdExpc3Q+PiBJ bnRlcm5hbHM6Om5vbkZhc3RTY3JvbGxhYmxlUmVjdHMoKSBjb25zdAogewogICAgIERvY3VtZW50 KiBkb2N1bWVudCA9IGNvbnRleHREb2N1bWVudCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvdGVzdGluZy9JbnRlcm5hbHMuaCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxz LmgKaW5kZXggYjc0NGRjZjg3MmM1OTQ4OWExYjI1ODgyNGI0OWZhYmNkYTIyZTZhZS4uMjMyYWQ0 Mzg2MzVjM2E3MTg0NGEyZTRkZTMwNjdlYjEzZTEwZjZlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0lu dGVybmFscy5oCkBAIC00MzgsNiArNDM4LDcgQEAgcHVibGljOgogICAgIEV4Y2VwdGlvbk9yPFN0 cmluZz4gc2Nyb2xsaW5nU3RhdGVUcmVlQXNUZXh0KCkgY29uc3Q7CiAgICAgRXhjZXB0aW9uT3I8 U3RyaW5nPiBzY3JvbGxpbmdUcmVlQXNUZXh0KCkgY29uc3Q7CiAgICAgRXhjZXB0aW9uT3I8U3Ry aW5nPiBzeW5jaHJvbm91c1Njcm9sbGluZ1JlYXNvbnMoKSBjb25zdDsKKyAgICBFeGNlcHRpb25P cjxTdHJpbmc+IHN5bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29uc0ZvclNjcm9sbGFibGVFbGVtZW50 KEVsZW1lbnQmKSBjb25zdDsKICAgICBFeGNlcHRpb25PcjxSZWY8RE9NUmVjdExpc3Q+PiBub25G YXN0U2Nyb2xsYWJsZVJlY3RzKCkgY29uc3Q7CiAKICAgICBFeGNlcHRpb25Pcjx2b2lkPiBzZXRF bGVtZW50VXNlc0Rpc3BsYXlMaXN0RHJhd2luZyhFbGVtZW50JiwgYm9vbCB1c2VzRGlzcGxheUxp c3REcmF3aW5nKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxz LmlkbCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmlkbAppbmRleCAzYjMwNzIw MjdhZmJkYTRjYWI0ZmE4OThiN2FiOTVhNTExNjNhNDI2Li43M2YzMjc5YjE3ZGY3Mjk2Yzg5YjY5 ZWFhZTU3ODhkODA5ZjAyZWQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0lu dGVybmFscy5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuaWRsCkBA IC01MjQsNiArNTI0LDcgQEAgZW51bSBUcmVlVHlwZSB7CiAgICAgRE9NU3RyaW5nIHNjcm9sbGlu Z1N0YXRlVHJlZUFzVGV4dCgpOwogICAgIERPTVN0cmluZyBzY3JvbGxpbmdUcmVlQXNUZXh0KCk7 CiAgICAgRE9NU3RyaW5nIHN5bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29ucygpOworICAgIERPTVN0 cmluZyBzeW5jaHJvbm91c1Njcm9sbGluZ1JlYXNvbnNGb3JTY3JvbGxhYmxlRWxlbWVudChFbGVt ZW50IGVsZW1lbnQpOwogICAgIERPTVJlY3RMaXN0IG5vbkZhc3RTY3JvbGxhYmxlUmVjdHMoKTsK IAogICAgIERPTVN0cmluZyByZXBhaW50UmVjdHNBc1RleHQoKTsK