226450 2021-05-30 20:56:50 -0700 Fix thread safety issues in OscillatorNode 2021-05-31 17:04:37 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez cdumez darin eric.carlson esprehn+autocc ews-watchlist ggaren glenn jer.noble kondapallykalyan philipj sam sergio webkit-bug-importer oldest_to_newest 1765315 0 cdumez 2021-05-30 20:56:50 -0700 Adopt thread safety annotations in OscillatorNode and fix bugs found by clang. 1765318 1 430172 cdumez 2021-05-30 21:09:10 -0700 Created attachment 430172 Patch 1765461 2 ews-feeder 2021-05-31 17:03:43 -0700 Committed r278285 (238322@main): <https://commits.webkit.org/238322@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430172. 1765463 3 webkit-bug-importer 2021-05-31 17:04:37 -0700 <rdar://problem/78695286> 430172 2021-05-30 21:09:10 -0700 2021-05-31 17:03:44 -0700 Patch bug-226450-20210530210909.patch text/plain 5641 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MjY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTJmNjY5ZTM1OGU4M2Vi YjcwNjRmZWE4NGY2MGUzMWQzMDg5MGNlYy4uNjM4MDg2YjFhNzRlZmM0NzFiZDQyMDI3NTc4M2Nh YzExMDQxMmY5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTA1LTMwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IHRocmVhZCBzYWZldHkg aXNzdWVzIGluIE9zY2lsbGF0b3JOb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjY0NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZG9wdCB0aHJlYWQgc2FmZXR5IGFubm90YXRpb25zIGluIE9zY2ls bGF0b3JOb2RlIGFuZCBmaXggYnVncyBmb3VuZCBieSBjbGFuZy4KKyAgICAgICAgSW4gcGFydGlj dWxhciwgcHJvcGFnYXRlc1NpbGVuY2UoKSB3YXMgZmFpbGluZyB0byBncmFiIHRoZSBsb2NrIGJl Zm9yZSBhY2Nlc3NpbmcKKyAgICAgICAgbV9wZXJpb2RpY1dhdmUsIHdoaWNoIGdldHMgbW9kaWZp ZWQgb24gdGhlIG1haW4gdGhyZWFkLgorCisgICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9Pc2Np bGxhdG9yTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpPc2NpbGxhdG9yTm9kZTo6Y3JlYXRl KToKKyAgICAgICAgKFdlYkNvcmU6Ok9zY2lsbGF0b3JOb2RlOjpzZXRUeXBlRm9yQmluZGluZ3Mp OgorICAgICAgICAoV2ViQ29yZTo6T3NjaWxsYXRvck5vZGU6OnByb3BhZ2F0ZXNTaWxlbmNlIGNv bnN0KToKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlvL09zY2lsbGF0b3JOb2RlLmg6CisgICAg ICAgICogTW9kdWxlcy93ZWJhdWRpby9Pc2NpbGxhdG9yTm9kZS5pZGw6CisKIDIwMjEtMDUtMzAg IENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggdGhyZWFkIHNh ZmV0eSBpc3N1ZXMgaW4gQ29udm9sdmVyTm9kZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy93ZWJhdWRpby9Pc2NpbGxhdG9yTm9kZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL3dlYmF1ZGlvL09zY2lsbGF0b3JOb2RlLmNwcAppbmRleCA5YTdhM2YzOTkyM2QwMmEwMGVm MTU0MTQ3MzMwOWI2OWZmZmEzMjRkLi45YzZhZWQxMjAzMWUyZWJhY2U1ZjQ0MTI1MmU4NDUwYzFl OWJhNzE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL09zY2ls bGF0b3JOb2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL09zY2ls bGF0b3JOb2RlLmNwcApAQCAtNzIsNyArNzIsNyBAQCBFeGNlcHRpb25PcjxSZWY8T3NjaWxsYXRv ck5vZGU+PiBPc2NpbGxhdG9yTm9kZTo6Y3JlYXRlKEJhc2VBdWRpb0NvbnRleHQmIGNvbnRleAog ICAgIGlmIChvcHRpb25zLnBlcmlvZGljV2F2ZSkKICAgICAgICAgb3NjaWxsYXRvci0+c2V0UGVy aW9kaWNXYXZlKCpvcHRpb25zLnBlcmlvZGljV2F2ZSk7CiAgICAgZWxzZSB7Ci0gICAgICAgIHJl c3VsdCA9IG9zY2lsbGF0b3ItPnNldFR5cGUob3B0aW9ucy50eXBlKTsKKyAgICAgICAgcmVzdWx0 ID0gb3NjaWxsYXRvci0+c2V0VHlwZUZvckJpbmRpbmdzKG9wdGlvbnMudHlwZSk7CiAgICAgICAg IGlmIChyZXN1bHQuaGFzRXhjZXB0aW9uKCkpCiAgICAgICAgICAgICByZXR1cm4gcmVzdWx0LnJl bGVhc2VFeGNlcHRpb24oKTsKICAgICB9CkBAIC05Nyw5ICs5NywxMCBAQCBPc2NpbGxhdG9yTm9k ZTo6fk9zY2lsbGF0b3JOb2RlKCkKICAgICB1bmluaXRpYWxpemUoKTsKIH0KIAotRXhjZXB0aW9u T3I8dm9pZD4gT3NjaWxsYXRvck5vZGU6OnNldFR5cGUoT3NjaWxsYXRvclR5cGUgdHlwZSkKK0V4 Y2VwdGlvbk9yPHZvaWQ+IE9zY2lsbGF0b3JOb2RlOjpzZXRUeXBlRm9yQmluZGluZ3MoT3NjaWxs YXRvclR5cGUgdHlwZSkKIHsKICAgICBBTFdBWVNfTE9HKExPR0lERU5USUZJRVIsIHR5cGUpOwor ICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7CiAKICAgICBpZiAodHlwZSA9PSBPc2NpbGxhdG9y VHlwZTo6Q3VzdG9tKSB7CiAgICAgICAgIGlmIChtX3R5cGUgIT0gT3NjaWxsYXRvclR5cGU6OkN1 c3RvbSkKQEAgLTQzOCw3ICs0MzksMTMgQEAgdm9pZCBPc2NpbGxhdG9yTm9kZTo6c2V0UGVyaW9k aWNXYXZlKFBlcmlvZGljV2F2ZSYgcGVyaW9kaWNXYXZlKQogCiBib29sIE9zY2lsbGF0b3JOb2Rl Ojpwcm9wYWdhdGVzU2lsZW5jZSgpIGNvbnN0CiB7Ci0gICAgcmV0dXJuICFpc1BsYXlpbmdPclNj aGVkdWxlZCgpIHx8IGhhc0ZpbmlzaGVkKCkgfHwgIW1fcGVyaW9kaWNXYXZlLmdldCgpOworICAg IEFTU0VSVChjb250ZXh0KCkuaXNBdWRpb1RocmVhZCgpKTsKKyAgICBpZiAoIWlzUGxheWluZ09y U2NoZWR1bGVkKCkgfHwgaGFzRmluaXNoZWQoKSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAg aWYgKCFtX3Byb2Nlc3NMb2NrLnRyeUxvY2soKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOyAvLyBB c3N1bWUgd2UgaGF2ZSBhIHBlcmlvZGljIHdhdmUgaWYgd2UgYXJlIHVuYWJsZSB0byBncmFiIHRo ZSBsb2NrLgorICAgIExvY2tlciBsb2NrZXIgeyBBZG9wdExvY2ssIG1fcHJvY2Vzc0xvY2sgfTsK KyAgICByZXR1cm4gIW1fcGVyaW9kaWNXYXZlLmdldCgpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBX ZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL09zY2ls bGF0b3JOb2RlLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL09zY2lsbGF0b3JO b2RlLmgKaW5kZXggNzQxNDE0N2FmMGM1ZmEzYWVhYjZiMDIzNjFhODYzZTI5MDM5OWJiNi4uYTY0 NjM1ZDMyNmNmODRlMGI1ODU1ZmZhMDhmMjkyNzZiNWVmZjY3NSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9Pc2NpbGxhdG9yTm9kZS5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vT3NjaWxsYXRvck5vZGUuaApAQCAtNDQsOCArNDQsOCBA QCBwdWJsaWM6CiAKICAgICBjb25zdCBjaGFyKiBhY3RpdmVET01PYmplY3ROYW1lKCkgY29uc3Qg ZmluYWwgeyByZXR1cm4gIk9zY2lsbGF0b3JOb2RlIjsgfQogCi0gICAgT3NjaWxsYXRvclR5cGUg dHlwZSgpIGNvbnN0IHsgcmV0dXJuIG1fdHlwZTsgfQotICAgIEV4Y2VwdGlvbk9yPHZvaWQ+IHNl dFR5cGUoT3NjaWxsYXRvclR5cGUpOworICAgIE9zY2lsbGF0b3JUeXBlIHR5cGVGb3JCaW5kaW5n cygpIGNvbnN0IHsgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsgcmV0dXJuIG1fdHlwZTsgfQorICAg IEV4Y2VwdGlvbk9yPHZvaWQ+IHNldFR5cGVGb3JCaW5kaW5ncyhPc2NpbGxhdG9yVHlwZSk7CiAK ICAgICBBdWRpb1BhcmFtKiBmcmVxdWVuY3koKSB7IHJldHVybiBtX2ZyZXF1ZW5jeS5nZXQoKTsg fQogICAgIEF1ZGlvUGFyYW0qIGRldHVuZSgpIHsgcmV0dXJuIG1fZGV0dW5lLmdldCgpOyB9CkBA IC02MiwxNSArNjIsMTUgQEAgcHJpdmF0ZToKICAgICBkb3VibGUgbGF0ZW5jeVRpbWUoKSBjb25z dCBmaW5hbCB7IHJldHVybiAwOyB9CiAKICAgICAvLyBSZXR1cm5zIHRydWUgaWYgdGhlcmUgYXJl IHNhbXBsZS1hY2N1cmF0ZSB0aW1lbGluZSBwYXJhbWV0ZXIgY2hhbmdlcy4KLSAgICBib29sIGNh bGN1bGF0ZVNhbXBsZUFjY3VyYXRlUGhhc2VJbmNyZW1lbnRzKHNpemVfdCBmcmFtZXNUb1Byb2Nl c3MpOworICAgIGJvb2wgY2FsY3VsYXRlU2FtcGxlQWNjdXJhdGVQaGFzZUluY3JlbWVudHMoc2l6 ZV90IGZyYW1lc1RvUHJvY2VzcykgV1RGX1JFUVVJUkVTX0xPQ0sobV9wcm9jZXNzTG9jayk7CiAK LSAgICBkb3VibGUgcHJvY2Vzc0FSYXRlKGludCwgZmxvYXQqIGRlc3RQLCBkb3VibGUgdmlydHVh bFJlYWRJbmRleCwgZmxvYXQqIHBoYXNlSW5jcmVtZW50cyk7Ci0gICAgZG91YmxlIHByb2Nlc3NL UmF0ZShpbnQsIGZsb2F0KiBkZXN0UCwgZG91YmxlIHZpcnR1YWxSZWFkSW5kZXgpOworICAgIGRv dWJsZSBwcm9jZXNzQVJhdGUoaW50LCBmbG9hdCogZGVzdFAsIGRvdWJsZSB2aXJ0dWFsUmVhZElu ZGV4LCBmbG9hdCogcGhhc2VJbmNyZW1lbnRzKSBXVEZfUkVRVUlSRVNfTE9DSyhtX3Byb2Nlc3NM b2NrKTsKKyAgICBkb3VibGUgcHJvY2Vzc0tSYXRlKGludCwgZmxvYXQqIGRlc3RQLCBkb3VibGUg dmlydHVhbFJlYWRJbmRleCkgV1RGX1JFUVVJUkVTX0xPQ0sobV9wcm9jZXNzTG9jayk7CiAKICAg ICBib29sIHByb3BhZ2F0ZXNTaWxlbmNlKCkgY29uc3QgZmluYWw7CiAKICAgICAvLyBPbmUgb2Yg dGhlIHdhdmVmb3JtIHR5cGVzIGRlZmluZWQgaW4gdGhlIGVudW0uCi0gICAgT3NjaWxsYXRvclR5 cGUgbV90eXBlOworICAgIE9zY2lsbGF0b3JUeXBlIG1fdHlwZTsgLy8gT25seSB1c2VkIG9uIHRo ZSBtYWluIHRocmVhZC4KICAgICAKICAgICAvLyBGcmVxdWVuY3kgdmFsdWUgaW4gSGVydHouCiAg ICAgUmVmUHRyPEF1ZGlvUGFyYW0+IG1fZnJlcXVlbmN5OwpAQCAtOTEsNyArOTEsNyBAQCBwcml2 YXRlOgogICAgIEF1ZGlvRmxvYXRBcnJheSBtX3BoYXNlSW5jcmVtZW50czsKICAgICBBdWRpb0Zs b2F0QXJyYXkgbV9kZXR1bmVWYWx1ZXM7CiAgICAgCi0gICAgUmVmUHRyPFBlcmlvZGljV2F2ZT4g bV9wZXJpb2RpY1dhdmU7CisgICAgUmVmUHRyPFBlcmlvZGljV2F2ZT4gbV9wZXJpb2RpY1dhdmUg V1RGX0dVQVJERURfQllfTE9DSyhtX3Byb2Nlc3NMb2NrKTsKIH07CiAKIFN0cmluZyBjb252ZXJ0 RW51bWVyYXRpb25Ub1N0cmluZyhPc2NpbGxhdG9yVHlwZSk7IC8vIEluIEpTT3NjaWxsYXRvck5v ZGUuY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL09zY2ls bGF0b3JOb2RlLmlkbCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vT3NjaWxsYXRv ck5vZGUuaWRsCmluZGV4IDJkMDI5ZmY4MzUyZjNjNjE0NDVmNzRjMmNjMDlmYjdkMDExYTBhMWYu LjkzNjk2YjRiNjBlMTMwZGVlOTgwOWJhYTk3M2Q2ZDE0YWUwOGM1OGQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vT3NjaWxsYXRvck5vZGUuaWRsCisrKyBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vT3NjaWxsYXRvck5vZGUuaWRsCkBAIC0zMSw3 ICszMSw3IEBACiBdIGludGVyZmFjZSBPc2NpbGxhdG9yTm9kZSA6IEF1ZGlvU2NoZWR1bGVkU291 cmNlTm9kZSB7CiAgICAgW0VuYWJsZWRCeVNldHRpbmc9V2ViQXVkaW9dIGNvbnN0cnVjdG9yIChC YXNlQXVkaW9Db250ZXh0IGNvbnRleHQsIG9wdGlvbmFsIE9zY2lsbGF0b3JPcHRpb25zIG9wdGlv bnMpOwogCi0gICAgYXR0cmlidXRlIE9zY2lsbGF0b3JUeXBlIHR5cGU7CisgICAgW0ltcGxlbWVu dGVkQXM9dHlwZUZvckJpbmRpbmdzXSBhdHRyaWJ1dGUgT3NjaWxsYXRvclR5cGUgdHlwZTsKIAog ICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBBdWRpb1BhcmFtIGZyZXF1ZW5jeTsgLy8gaW4gSGVydHoK ICAgICByZWFkb25seSBhdHRyaWJ1dGUgQXVkaW9QYXJhbSBkZXR1bmU7IC8vIGluIENlbnRzCg==