226449 2021-05-30 20:40:38 -0700 Fix thread safety issues in ConvolverNode 2021-05-31 17:10:21 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez cdumez darin eric.carlson esprehn+autocc ews-watchlist ggaren glenn jer.noble kondapallykalyan peng.liu6 philipj sam sergio webkit-bug-importer oldest_to_newest 1765311 0 cdumez 2021-05-30 20:40:38 -0700 Adopt thread safety annotations in ConvolverNode and fix bugs found by clang. 1765314 1 430170 cdumez 2021-05-30 20:47:41 -0700 Created attachment 430170 Patch 1765471 2 cdumez 2021-05-31 17:09:49 -0700 Committed r278289 (238326@main): <https://commits.webkit.org/238326@main> 1765472 3 webkit-bug-importer 2021-05-31 17:10:20 -0700 <rdar://problem/78695358> 430170 2021-05-30 20:47:41 -0700 2021-05-31 17:10:21 -0700 Patch bug-226449-20210530204740.patch text/plain 7226 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MjY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2M2YjZkNWI5ZGZhOTgw M2M5OTkyNDE1OGEzNWRlNGFhNWFmYjk3ZS4uOTJmNjY5ZTM1OGU4M2ViYjcwNjRmZWE4NGY2MGUz MWQzMDg5MGNlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDIxLTA1LTMwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IHRocmVhZCBzYWZldHkg aXNzdWVzIGluIENvbnZvbHZlck5vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIyNjQ0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkb3B0IHRocmVhZCBzYWZldHkgYW5ub3RhdGlvbnMgaW4gQ29udm9s dmVyTm9kZSBhbmQgZml4IGJ1Z3MgZm91bmQgYnkgY2xhbmcuCisgICAgICAgIEluIHBhcnRpY3Vs YXIsIHRoZSBmb2xsb3dpbmcgaXNzdWVzIHdlcmUgZm91bmQgYW5kIGZpeGVkOgorICAgICAgICAt IHRhaWxUaW1lKCkgLyBsYXRlbmN5VGltZSgpIHdlcmUgYWNjZXNzaW5nIG1fcmV2ZXJiIG9uIHRo ZSBhdWRpbyB0aHJlYWQgd2l0aG91dAorICAgICAgICAgIGxvY2tpbmcgZXZlbiB0aG91Z2ggbV9y ZXZlcmIgZ2V0cyBtb2RpZmllZCBvbiB0aGUgbWFpbiB0aHJlYWQuCisgICAgICAgIC0gY2hlY2tO dW1iZXJPZkNoYW5uZWxzRm9ySW5wdXQoKSB3YXMgYWNjZXNzaW5nIG1fYnVmZmVyIG9uIHRoZSBh dWRpbyB0aHJlYWQKKyAgICAgICAgICB3aXRob3V0IGxvY2tpbmcgZXZlbiB0aG91Z2ggbV9idWZm ZXIgZ2V0cyBtb2RpZmllZCBvbiB0aGUgbWFpbiB0aHJlYWQuCisKKyAgICAgICAgKiBNb2R1bGVz L3dlYmF1ZGlvL0NvbnZvbHZlck5vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29udm9sdmVy Tm9kZTo6Y3JlYXRlKToKKyAgICAgICAgKFdlYkNvcmU6OkNvbnZvbHZlck5vZGU6OnNldEJ1ZmZl ckZvckJpbmRpbmdzKToKKyAgICAgICAgKFdlYkNvcmU6OkNvbnZvbHZlck5vZGU6OnNldE5vcm1h bGl6ZUZvckJpbmRpbmdzKToKKyAgICAgICAgKFdlYkNvcmU6OkNvbnZvbHZlck5vZGU6OnRhaWxU aW1lIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkNvbnZvbHZlck5vZGU6OmxhdGVuY3lUaW1l IGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkNvbnZvbHZlck5vZGU6OmNoZWNrTnVtYmVyT2ZD aGFubmVsc0ZvcklucHV0KToKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlvL0NvbnZvbHZlck5v ZGUuaDoKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlvL0NvbnZvbHZlck5vZGUuaWRsOgorCiAy MDIxLTA1LTMwICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgRml4 IHRocmVhZCBzYWZldHkgaXNzdWVzIGluIEF1ZGlvQnVmZmVyU291cmNlTm9kZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9Db252b2x2ZXJOb2RlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQ29udm9sdmVyTm9kZS5jcHAKaW5kZXggYzJl NTYwZWRhNjc1M2MyOWU5YjgxZTFjNDU0ODFiMTRiMDdmZGExNy4uNGY5OTgwZDZiNDRlYmZmMGU0 NmEwZjY2MDhjMWEyMDg4ZWMyNTQ4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxl cy93ZWJhdWRpby9Db252b2x2ZXJOb2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L3dlYmF1ZGlvL0NvbnZvbHZlck5vZGUuY3BwCkBAIC02Myw5ICs2Myw5IEBAIEV4Y2VwdGlvbk9y PFJlZjxDb252b2x2ZXJOb2RlPj4gQ29udm9sdmVyTm9kZTo6Y3JlYXRlKEJhc2VBdWRpb0NvbnRl eHQmIGNvbnRleHQsCiAgICAgaWYgKHJlc3VsdC5oYXNFeGNlcHRpb24oKSkKICAgICAgICAgcmV0 dXJuIHJlc3VsdC5yZWxlYXNlRXhjZXB0aW9uKCk7CiAKLSAgICBub2RlLT5zZXROb3JtYWxpemUo IW9wdGlvbnMuZGlzYWJsZU5vcm1hbGl6YXRpb24pOworICAgIG5vZGUtPnNldE5vcm1hbGl6ZUZv ckJpbmRpbmdzKCFvcHRpb25zLmRpc2FibGVOb3JtYWxpemF0aW9uKTsKIAotICAgIHJlc3VsdCA9 IG5vZGUtPnNldEJ1ZmZlcihXVEZNb3ZlKG9wdGlvbnMuYnVmZmVyKSk7CisgICAgcmVzdWx0ID0g bm9kZS0+c2V0QnVmZmVyRm9yQmluZGluZ3MoV1RGTW92ZShvcHRpb25zLmJ1ZmZlcikpOwogICAg IGlmIChyZXN1bHQuaGFzRXhjZXB0aW9uKCkpCiAgICAgICAgIHJldHVybiByZXN1bHQucmVsZWFz ZUV4Y2VwdGlvbigpOwogCkBAIC0xMTAsNyArMTEwLDcgQEAgdm9pZCBDb252b2x2ZXJOb2RlOjpw cm9jZXNzKHNpemVfdCBmcmFtZXNUb1Byb2Nlc3MpCiAgICAgfQogfQogCi1FeGNlcHRpb25Pcjx2 b2lkPiBDb252b2x2ZXJOb2RlOjpzZXRCdWZmZXIoUmVmUHRyPEF1ZGlvQnVmZmVyPiYmIGJ1ZmZl cikKK0V4Y2VwdGlvbk9yPHZvaWQ+IENvbnZvbHZlck5vZGU6OnNldEJ1ZmZlckZvckJpbmRpbmdz KFJlZlB0cjxBdWRpb0J1ZmZlcj4mJiBidWZmZXIpCiB7CiAgICAgQVNTRVJUKGlzTWFpblRocmVh ZCgpKTsKICAgICAKQEAgLTE2MCwxOSArMTYwLDMzIEBAIEV4Y2VwdGlvbk9yPHZvaWQ+IENvbnZv bHZlck5vZGU6OnNldEJ1ZmZlcihSZWZQdHI8QXVkaW9CdWZmZXI+JiYgYnVmZmVyKQogICAgIHJl dHVybiB7IH07CiB9CiAKLUF1ZGlvQnVmZmVyKiBDb252b2x2ZXJOb2RlOjpidWZmZXIoKQorQXVk aW9CdWZmZXIqIENvbnZvbHZlck5vZGU6OmJ1ZmZlckZvckJpbmRpbmdzKCkgV1RGX0lHTk9SRVNf VEhSRUFEX1NBRkVUWV9BTkFMWVNJUwogewogICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7CiAg ICAgcmV0dXJuIG1fYnVmZmVyLmdldCgpOwogfQogCit2b2lkIENvbnZvbHZlck5vZGU6OnNldE5v cm1hbGl6ZUZvckJpbmRpbmdzKGJvb2wgbm9ybWFsaXplKQoreworICAgIEFTU0VSVChpc01haW5U aHJlYWQoKSk7CisgICAgbV9ub3JtYWxpemUgPSBub3JtYWxpemU7Cit9CisKIGRvdWJsZSBDb252 b2x2ZXJOb2RlOjp0YWlsVGltZSgpIGNvbnN0CiB7CisgICAgQVNTRVJUKGNvbnRleHQoKS5pc0F1 ZGlvVGhyZWFkKCkpOworICAgIGlmICghbV9wcm9jZXNzTG9jay50cnlMb2NrKCkpCisgICAgICAg IHJldHVybiBzdGQ6Om51bWVyaWNfbGltaXRzPGRvdWJsZT46OmluZmluaXR5KCk7CisgICAgTG9j a2VyIGxvY2tlciB7IEFkb3B0TG9jaywgbV9wcm9jZXNzTG9jayB9OwogICAgIHJldHVybiBtX3Jl dmVyYiA/IG1fcmV2ZXJiLT5pbXB1bHNlUmVzcG9uc2VMZW5ndGgoKSAvIHN0YXRpY19jYXN0PGRv dWJsZT4oc2FtcGxlUmF0ZSgpKSA6IDA7CiB9CiAKIGRvdWJsZSBDb252b2x2ZXJOb2RlOjpsYXRl bmN5VGltZSgpIGNvbnN0CiB7CisgICAgQVNTRVJUKGNvbnRleHQoKS5pc0F1ZGlvVGhyZWFkKCkp OworICAgIGlmICghbV9wcm9jZXNzTG9jay50cnlMb2NrKCkpCisgICAgICAgIHJldHVybiBzdGQ6 Om51bWVyaWNfbGltaXRzPGRvdWJsZT46OmluZmluaXR5KCk7CisgICAgTG9ja2VyIGxvY2tlciB7 IEFkb3B0TG9jaywgbV9wcm9jZXNzTG9jayB9OwogICAgIHJldHVybiBtX3JldmVyYiA/IG1fcmV2 ZXJiLT5sYXRlbmN5RnJhbWVzKCkgLyBzdGF0aWNfY2FzdDxkb3VibGU+KHNhbXBsZVJhdGUoKSkg OiAwOwogfQogCkBAIC0xOTksOSArMjEzLDE1IEBAIEV4Y2VwdGlvbk9yPHZvaWQ+IENvbnZvbHZl ck5vZGU6OnNldENoYW5uZWxDb3VudE1vZGUoQ2hhbm5lbENvdW50TW9kZSBtb2RlKQogdm9pZCBD b252b2x2ZXJOb2RlOjpjaGVja051bWJlck9mQ2hhbm5lbHNGb3JJbnB1dChBdWRpb05vZGVJbnB1 dCogaW5wdXQpCiB7CiAgICAgQVNTRVJUKGNvbnRleHQoKS5pc0F1ZGlvVGhyZWFkKCkgJiYgY29u dGV4dCgpLmlzR3JhcGhPd25lcigpKTsKKyAgICBzdGQ6Om9wdGlvbmFsPHVuc2lnbmVkPiBudW1i ZXJPZkJ1ZmZlckNoYW5uZWxzOworICAgIGlmIChtX3Byb2Nlc3NMb2NrLnRyeUxvY2soKSkgewor ICAgICAgICBMb2NrZXIgbG9ja2VyIHsgQWRvcHRMb2NrLCBtX3Byb2Nlc3NMb2NrIH07CisgICAg ICAgIGlmIChtX2J1ZmZlcikKKyAgICAgICAgICAgIG51bWJlck9mQnVmZmVyQ2hhbm5lbHMgPSBt X2J1ZmZlci0+bnVtYmVyT2ZDaGFubmVscygpOworICAgIH0KIAotICAgIGlmIChtX2J1ZmZlcikg ewotICAgICAgICB1bnNpZ25lZCBudW1iZXJPZk91dHB1dENoYW5uZWxzID0gY29tcHV0ZU51bWJl ck9mT3V0cHV0Q2hhbm5lbHMoaW5wdXQtPm51bWJlck9mQ2hhbm5lbHMoKSwgbV9idWZmZXItPm51 bWJlck9mQ2hhbm5lbHMoKSk7CisgICAgaWYgKG51bWJlck9mQnVmZmVyQ2hhbm5lbHMpIHsKKyAg ICAgICAgdW5zaWduZWQgbnVtYmVyT2ZPdXRwdXRDaGFubmVscyA9IGNvbXB1dGVOdW1iZXJPZk91 dHB1dENoYW5uZWxzKGlucHV0LT5udW1iZXJPZkNoYW5uZWxzKCksICpudW1iZXJPZkJ1ZmZlckNo YW5uZWxzKTsKIAogICAgICAgICBpZiAoaXNJbml0aWFsaXplZCgpICYmIG51bWJlck9mT3V0cHV0 Q2hhbm5lbHMgIT0gb3V0cHV0KDApLT5udW1iZXJPZkNoYW5uZWxzKCkpIHsKICAgICAgICAgICAg IC8vIFdlJ3JlIGFscmVhZHkgaW5pdGlhbGl6ZWQgYnV0IHRoZSBjaGFubmVsIGNvdW50IGhhcyBj aGFuZ2VkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9Db252 b2x2ZXJOb2RlLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0NvbnZvbHZlck5v ZGUuaAppbmRleCBjMmRlNGExZjIyNDgwZjM1YTIzM2E0NWMzOGE1ZmU1NTI5OTdlNDdmLi4zY2E1 MGJmMmVjOTAwYjU0MTc3ZGVkYjVkYmU4NzM5NTgyOTU1YWQ0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0NvbnZvbHZlck5vZGUuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0NvbnZvbHZlck5vZGUuaApAQCAtNDEsMTEgKzQxLDExIEBA IHB1YmxpYzoKICAgICAKICAgICB2aXJ0dWFsIH5Db252b2x2ZXJOb2RlKCk7CiAgICAgCi0gICAg RXhjZXB0aW9uT3I8dm9pZD4gc2V0QnVmZmVyKFJlZlB0cjxBdWRpb0J1ZmZlcj4mJik7Ci0gICAg QXVkaW9CdWZmZXIqIGJ1ZmZlcigpOworICAgIEV4Y2VwdGlvbk9yPHZvaWQ+IHNldEJ1ZmZlckZv ckJpbmRpbmdzKFJlZlB0cjxBdWRpb0J1ZmZlcj4mJik7CisgICAgQXVkaW9CdWZmZXIqIGJ1ZmZl ckZvckJpbmRpbmdzKCk7IC8vIE9ubHkgc2FmZSB0byBjYWxsIG9uIHRoZSBtYWluIHRocmVhZC4K IAotICAgIGJvb2wgbm9ybWFsaXplKCkgY29uc3QgeyByZXR1cm4gbV9ub3JtYWxpemU7IH0KLSAg ICB2b2lkIHNldE5vcm1hbGl6ZShib29sIG5vcm1hbGl6ZSkgeyBtX25vcm1hbGl6ZSA9IG5vcm1h bGl6ZTsgfQorICAgIGJvb2wgbm9ybWFsaXplRm9yQmluZGluZ3MoKSBjb25zdCBXVEZfSUdOT1JF U19USFJFQURfU0FGRVRZX0FOQUxZU0lTIHsgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsgcmV0dXJu IG1fbm9ybWFsaXplOyB9CisgICAgdm9pZCBzZXROb3JtYWxpemVGb3JCaW5kaW5ncyhib29sKTsK IAogICAgIEV4Y2VwdGlvbk9yPHZvaWQ+IHNldENoYW5uZWxDb3VudCh1bnNpZ25lZCkgZmluYWw7 CiAgICAgRXhjZXB0aW9uT3I8dm9pZD4gc2V0Q2hhbm5lbENvdW50TW9kZShDaGFubmVsQ291bnRN b2RlKSBmaW5hbDsKQEAgLTYwLDE0ICs2MCwxNCBAQCBwcml2YXRlOgogICAgIHZvaWQgcHJvY2Vz cyhzaXplX3QgZnJhbWVzVG9Qcm9jZXNzKSBmaW5hbDsKICAgICB2b2lkIGNoZWNrTnVtYmVyT2ZD aGFubmVsc0ZvcklucHV0KEF1ZGlvTm9kZUlucHV0KikgZmluYWw7CiAKLSAgICBzdGQ6OnVuaXF1 ZV9wdHI8UmV2ZXJiPiBtX3JldmVyYjsKLSAgICBSZWZQdHI8QXVkaW9CdWZmZXI+IG1fYnVmZmVy OworICAgIHN0ZDo6dW5pcXVlX3B0cjxSZXZlcmI+IG1fcmV2ZXJiIFdURl9HVUFSREVEX0JZX0xP Q0sobV9wcm9jZXNzTG9jayk7IC8vIE9ubHkgbW9kaWZpZWQgb24gdGhlIG1haW4gdGhyZWFkIGJ1 dCBhY2Nlc3NlZCBvbiB0aGUgYXVkaW8gdGhyZWFkLgorICAgIFJlZlB0cjxBdWRpb0J1ZmZlcj4g bV9idWZmZXIgV1RGX0dVQVJERURfQllfTE9DSyhtX3Byb2Nlc3NMb2NrKTsgLy8gT25seSBtb2Rp ZmllZCBvbiB0aGUgbWFpbiB0aHJlYWQgYnV0IGFjY2Vzc2VkIG9uIHRoZSBhdWRpbyB0aHJlYWQu CiAKICAgICAvLyBUaGlzIHN5bmNocm9uaXplcyBkeW5hbWljIGNoYW5nZXMgdG8gdGhlIGNvbnZv bHV0aW9uIGltcHVsc2UgcmVzcG9uc2Ugd2l0aCBwcm9jZXNzKCkuCiAgICAgbXV0YWJsZSBMb2Nr IG1fcHJvY2Vzc0xvY2s7CiAKICAgICAvLyBOb3JtYWxpemUgdGhlIGltcHVsc2UgcmVzcG9uc2Ug b3Igbm90LgotICAgIGJvb2wgbV9ub3JtYWxpemUgeyB0cnVlIH07CisgICAgYm9vbCBtX25vcm1h bGl6ZSB7IHRydWUgfTsgLy8gT25seSB1c2VkIG9uIHRoZSBtYWluIHRocmVhZC4KIH07CiAKIH0g Ly8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv d2ViYXVkaW8vQ29udm9sdmVyTm9kZS5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1 ZGlvL0NvbnZvbHZlck5vZGUuaWRsCmluZGV4IGQ4ZWZmNDhiMjc0YTZjNGUyMmM5M2IwMzExNDkw YjIyYTcyNTk3YmEuLjgxOWY3ZDlhZmEzNjQ4ZDUzZmIyYWU5ZDdkYmYzZjMxNGRmOGNjOTggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQ29udm9sdmVyTm9kZS5p ZGwKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9Db252b2x2ZXJOb2RlLmlk bApAQCAtMzEsNiArMzEsNiBAQAogXSBpbnRlcmZhY2UgQ29udm9sdmVyTm9kZSA6IEF1ZGlvTm9k ZSB7CiAgICAgW0VuYWJsZWRCeVNldHRpbmc9V2ViQXVkaW9dIGNvbnN0cnVjdG9yIChCYXNlQXVk aW9Db250ZXh0IGNvbnRleHQsIG9wdGlvbmFsIENvbnZvbHZlck9wdGlvbnMgb3B0aW9ucyk7CiAK LSAgICBhdHRyaWJ1dGUgQXVkaW9CdWZmZXI/IGJ1ZmZlcjsKLSAgICBhdHRyaWJ1dGUgYm9vbGVh biBub3JtYWxpemU7CisgICAgW0ltcGxlbWVudGVkQXM9YnVmZmVyRm9yQmluZGluZ3NdIGF0dHJp YnV0ZSBBdWRpb0J1ZmZlcj8gYnVmZmVyOworICAgIFtJbXBsZW1lbnRlZEFzPW5vcm1hbGl6ZUZv ckJpbmRpbmdzXSBhdHRyaWJ1dGUgYm9vbGVhbiBub3JtYWxpemU7CiB9Owo=