226443 2021-05-30 18:29:18 -0700 fix some comment typos 2021-05-30 20:11:16 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 heycam heycam changseok cmarcelo esprehn+autocc ews-watchlist fred.wang glenn jamesr kondapallykalyan luiz pdr sam simon.fraser tonikitoo webkit-bug-importer oldest_to_newest 1765284 0 heycam 2021-05-30 18:29:18 -0700 . 1765285 1 430160 heycam 2021-05-30 18:33:54 -0700 Created attachment 430160 Patch 1765307 2 ews-feeder 2021-05-30 20:10:07 -0700 Committed r278267 (238304@main): <https://commits.webkit.org/238304@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430160. 1765308 3 webkit-bug-importer 2021-05-30 20:11:16 -0700 <rdar://problem/78672800> 430160 2021-05-30 18:33:54 -0700 2021-05-30 20:10:08 -0700 Patch bug-226443-20210531113353.patch text/plain 5827 heycam U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2ODg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjAwMjM1NDA4NTZhZTI3 MGYzMzJhYWYwMmVkMWUxMGY5OWVhNTkyNy4uN2ZlMmRmM2I0M2VjNzE5NGE1MmY1ODU5YmVjNTgz Y2IzMmFkYjM4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTA1LTMwICBDYW1l cm9uIE1jQ29ybWFjayAgPGhleWNhbUBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IHNvbWUgY29t bWVudCB0eXBvcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjI2NDQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVHJpdmlhbCBmaXhlcyBmb3IgY29tbWVudCB0eXBvcyBJIG5vdGljZWQgb3ZlciB0aGUgcGFz dCBjb3VwbGUgb2YKKyAgICAgICAgbW9udGhzLgorCisgICAgICAgICogcGFnZS9zY3JvbGxpbmcv U2Nyb2xsaW5nU3RhdGVUcmVlLmg6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3Jh cGhpY3NDb250ZXh0Q0cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0Ojpk cmF3UGxhdGZvcm1JbWFnZSk6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OmRy YXdQbGF0Zm9ybVBhdHRlcm4pOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6aGl0VGVzdExpc3QpOgorICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJMYXllci5oOgorCiAyMDIxLTA1LTAyICBSb2IgQnVpcyAgPHJidWlz QGlnYWxpYS5jb20+CiAKICAgICAgICAgZ2V0UHJvcGVydHlWYWx1ZSBmb3IgdXJsIHBhdGggZG9l c24ndCByZXR1cm4gdGhlICIjIiBjaGFyYWN0ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1N0YXRlVHJlZS5oIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9zY3JvbGxpbmcvU2Nyb2xsaW5nU3RhdGVUcmVlLmgKaW5kZXggMDFjYzkwY2M3NTAwM2VjMDlh Njk2MmRhNjlmZTk5YzkyNzEzNjQ5Yy4uMDBhZjQxODI4M2NmNGJlNGNmZTk5OWVlYjM2NDIzNmNm YzJmZGFmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xs aW5nU3RhdGVUcmVlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xs aW5nU3RhdGVUcmVlLmgKQEAgLTM2LDcgKzM2LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogY2xh c3MgQXN5bmNTY3JvbGxpbmdDb29yZGluYXRvcjsKIGNsYXNzIFNjcm9sbGluZ1N0YXRlRnJhbWVT Y3JvbGxpbmdOb2RlOwogCi0vLyBUaGUgU2Nyb2xsaW5nU3RhdGVUcmVlIGlzIGEgdHJlZSB0aGF0 IG1hbmFnZWQgU2Nyb2xsaW5nU3RhdGVOb2Rlcy4gVGhlIG5vZGVzIGtlZXAgdHJhY2sgb2YgdGhl IGN1cnJlbnQKKy8vIFRoZSBTY3JvbGxpbmdTdGF0ZVRyZWUgaXMgYSB0cmVlIHRoYXQgbWFuYWdl cyBTY3JvbGxpbmdTdGF0ZU5vZGVzLiBUaGUgbm9kZXMga2VlcCB0cmFjayBvZiB0aGUgY3VycmVu dAogLy8gc3RhdGUgb2Ygc2Nyb2xsaW5nIHJlbGF0ZWQgcHJvcGVydGllcy4gV2hlbmV2ZXIgYW55 IHByb3BlcnRpZXMgY2hhbmdlLCB0aGUgc2Nyb2xsaW5nIGNvb3JkaW5hdG9yCiAvLyB3aWxsIGJl IGluZm9ybWVkIGFuZCB3aWxsIHNjaGVkdWxlIGEgdGltZXIgdGhhdCB3aWxsIGNsb25lIHRoZSBu ZXcgc3RhdGUgdHJlZSBhbmQgc2VuZCBpdCBvdmVyIHRvCiAvLyB0aGUgc2Nyb2xsaW5nIHRocmVh ZCwgYXZvaWRpbmcgbG9ja2luZy4gCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jZy9HcmFwaGljc0NvbnRleHRDRy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGljc0NvbnRleHRDRy5jcHAKaW5kZXggNzBmNmQwOGY1M2Q3 YmM4NTcwNmRhYzQ1YTA3YWIxZjA3ZGMyMTM1ZC4uZDU4ZjAyZWJjZjgxMjZhYWU4MDRjZGNjZGJi OTU0MzJjMDFkNjExNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2cvR3JhcGhpY3NDb250ZXh0Q0cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dENHLmNwcApAQCAtMzAzLDcgKzMwMyw3IEBAIHZv aWQgR3JhcGhpY3NDb250ZXh0OjpkcmF3UGxhdGZvcm1JbWFnZShjb25zdCBQbGF0Zm9ybUltYWdl UHRyJiBpbWFnZSwgY29uc3QgRmxvCiAgICAgaWYgKG9wdGlvbnMub3JpZW50YXRpb24oKSAhPSBJ bWFnZU9yaWVudGF0aW9uOjpOb25lKSB7CiAgICAgICAgIENHQ29udGV4dENvbmNhdENUTShjb250 ZXh0LCBvcHRpb25zLm9yaWVudGF0aW9uKCkudHJhbnNmb3JtRnJvbURlZmF1bHQoYWRqdXN0ZWRE ZXN0UmVjdC5zaXplKCkpKTsKICAgICAgICAgaWYgKG9wdGlvbnMub3JpZW50YXRpb24oKS51c2Vz V2lkdGhBc0hlaWdodCgpKSB7Ci0gICAgICAgICAgICAvLyBUaGUgZGVzdGluYXRpb24gcmVjdCB3 aWxsIGhhdmUgaXQncyB3aWR0aCBhbmQgaGVpZ2h0IGFscmVhZHkgcmV2ZXJzZWQgZm9yIHRoZSBv cmllbnRhdGlvbiBvZgorICAgICAgICAgICAgLy8gVGhlIGRlc3RpbmF0aW9uIHJlY3Qgd2lsbCBo YXZlIGl0cyB3aWR0aCBhbmQgaGVpZ2h0IGFscmVhZHkgcmV2ZXJzZWQgZm9yIHRoZSBvcmllbnRh dGlvbiBvZgogICAgICAgICAgICAgLy8gdGhlIGltYWdlLCBhcyBpdCB3YXMgbmVlZGVkIGZvciBw YWdlIGxheW91dCwgc28gd2UgbmVlZCB0byByZXZlcnNlIGl0IGJhY2sgaGVyZS4KICAgICAgICAg ICAgIGFkanVzdGVkRGVzdFJlY3QgPSBGbG9hdFJlY3QoYWRqdXN0ZWREZXN0UmVjdC54KCksIGFk anVzdGVkRGVzdFJlY3QueSgpLCBhZGp1c3RlZERlc3RSZWN0LmhlaWdodCgpLCBhZGp1c3RlZERl c3RSZWN0LndpZHRoKCkpOwogICAgICAgICB9CkBAIC0zODMsNyArMzgzLDcgQEAgdm9pZCBHcmFw aGljc0NvbnRleHQ6OmRyYXdQbGF0Zm9ybVBhdHRlcm4oY29uc3QgUGxhdGZvcm1JbWFnZVB0ciYg aW1hZ2UsIGNvbnN0IEYKICAgICBmbG9hdCB3ID0gQ0dJbWFnZUdldFdpZHRoKGltYWdlLmdldCgp KTsKICAgICBpZiAodyA9PSBpbWFnZVNpemUud2lkdGgoKSAmJiBoID09IGltYWdlU2l6ZS5oZWln aHQoKSAmJiAhc3BhY2luZy53aWR0aCgpICYmICFzcGFjaW5nLmhlaWdodCgpKSB7CiAgICAgICAg IC8vIEZJWE1FOiBDRyBzZWVtcyB0byBzbmFwIHRoZSBpbWFnZXMgdG8gaW50ZWdyYWwgc2l6ZXMu IFdoZW4gd2UgY2FyZSAoZS5nLiB3aXRoIGJvcmRlci1pbWFnZS1yZXBlYXQ6IHJvdW5kKSwKLSAg ICAgICAgLy8gd2Ugc2hvdWxkIHRpbGUgYWxsIGJ1dCB0aGUgbGFzdCwgYW5kIHN0ZXRjaCB0aGUg bGFzdCBpbWFnZSB0byBmaXQuCisgICAgICAgIC8vIHdlIHNob3VsZCB0aWxlIGFsbCBidXQgdGhl IGxhc3QsIGFuZCBzdHJldGNoIHRoZSBsYXN0IGltYWdlIHRvIGZpdC4KICAgICAgICAgQ0dDb250 ZXh0RHJhd1RpbGVkSW1hZ2UoY29udGV4dCwgRmxvYXRSZWN0KGFkanVzdGVkWCwgYWRqdXN0ZWRZ LCBzY2FsZWRUaWxlV2lkdGgsIHNjYWxlZFRpbGVIZWlnaHQpLCBzdWJJbWFnZS5nZXQoKSk7CiAg ICAgfSBlbHNlIHsKICAgICAgICAgc3RhdGljIGNvbnN0IENHUGF0dGVybkNhbGxiYWNrcyBwYXR0 ZXJuQ2FsbGJhY2tzID0geyAwLCBkcmF3UGF0dGVybkNhbGxiYWNrLCBwYXR0ZXJuUmVsZWFzZUNh bGxiYWNrIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCBh YjgyOWY2YWI3ZjBmOWNjMmQyNjY1YWE0YmFlZjVmYzIyNGYyMDY0Li42ZjlmYTE1MGI2ODE0Y2U4 YTAzMWQzNTYxMTA5ZjhjNjU3Mjk2NjNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJMYXllci5jcHAKQEAgLTE5NDEsNyArMTk0MSw3IEBAIFJlbmRlckxheWVyKiBSZW5kZXJMYXll cjo6ZW5jbG9zaW5nRmlsdGVyUmVwYWludExheWVyKCkgY29uc3QKICAgICByZXR1cm4gbnVsbHB0 cjsKIH0KIAotLy8gRklYTUU6IFRoaXMgbmVlZWRzIGEgYmV0dGVyIG5hbWUuCisvLyBGSVhNRTog VGhpcyBuZWVkcyBhIGJldHRlciBuYW1lLgogdm9pZCBSZW5kZXJMYXllcjo6c2V0RmlsdGVyQmFj a2VuZE5lZWRzUmVwYWludGluZ0luUmVjdChjb25zdCBMYXlvdXRSZWN0JiByZWN0KQogewogICAg IEFTU0VSVChyZXF1aXJlc0Z1bGxMYXllckltYWdlRm9yRmlsdGVycygpKTsKQEAgLTQzNDEsNyAr NDM0MSw3IEBAIFJlbmRlckxheWVyKiBSZW5kZXJMYXllcjo6aGl0VGVzdExpc3QoTGF5ZXJMaXN0 IGxheWVySXRlcmF0b3IsIFJlbmRlckxheWVyKiByb290CiAgICAgICAgIGF1dG8qIGhpdExheWVy ID0gY2hpbGRMYXllci0+aGl0VGVzdExheWVyKHJvb3RMYXllciwgdGhpcywgcmVxdWVzdCwgdGVt cFJlc3VsdCwgaGl0VGVzdFJlY3QsIGhpdFRlc3RMb2NhdGlvbiwgZmFsc2UsIHRyYW5zZm9ybVN0 YXRlLCB6T2Zmc2V0Rm9yRGVzY2VuZGFudHMpOwogCiAgICAgICAgIC8vIElmIGl0IGlzIGEgbGlz dC1iYXNlZCB0ZXN0LCB3ZSBjYW4gc2FmZWx5IGFwcGVuZCB0aGUgdGVtcG9yYXJ5IHJlc3VsdCBz aW5jZSBpdCBtaWdodCBoYWQgaGl0Ci0gICAgICAgIC8vIG5vZGVzIGJ1dCBub3QgbmVjZXNzZXJp bHkgaGFkIGhpdExheWVyIHNldC4KKyAgICAgICAgLy8gbm9kZXMgYnV0IG5vdCBuZWNlc3Nhcmls eSBoYWQgaGl0TGF5ZXIgc2V0LgogICAgICAgICBBU1NFUlQoIXJlc3VsdC5pc1JlY3RCYXNlZFRl c3QoKSB8fCByZXF1ZXN0LnJlc3VsdElzRWxlbWVudExpc3QoKSk7CiAgICAgICAgIGlmIChyZXF1 ZXN0LnJlc3VsdElzRWxlbWVudExpc3QoKSkKICAgICAgICAgICAgIHJlc3VsdC5hcHBlbmQodGVt cFJlc3VsdCwgcmVxdWVzdCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGF5ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oCmlu ZGV4IDEwZWE4MWJiYzQ5ZmI1Yjk3NTY1ZGE1MTA3NDhiYzRkNjcwNTYxMGYuLmEyNDQxMThiYjNk M2MxMjUzYTA0NDVkYjA5NzE4MjdiMzRmMzFlNzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJMYXllci5oCkBAIC02NTIsNyArNjUyLDcgQEAgcHVibGljOgogICAgIH07CiAKICAgICAv LyBUaGlzIG1ldGhvZCBmaWd1cmVzIG91dCBvdXIgbGF5ZXJCb3VuZHMgaW4gY29vcmRpbmF0ZXMg cmVsYXRpdmUgdG8KLSAgICAvLyB8cm9vdExheWVyfS4gIEl0IGFsc28gY29tcHV0ZXMgb3VyIGJh Y2tncm91bmQgYW5kIGZvcmVncm91bmQgY2xpcCByZWN0cworICAgIC8vIHxyb290TGF5ZXJ8LiBJ dCBhbHNvIGNvbXB1dGVzIG91ciBiYWNrZ3JvdW5kIGFuZCBmb3JlZ3JvdW5kIGNsaXAgcmVjdHMK ICAgICAvLyBmb3IgcGFpbnRpbmcvZXZlbnQgaGFuZGxpbmcuCiAgICAgLy8gUGFzcyBvZmZzZXRG cm9tUm9vdCBpZiBrbm93bi4KICAgICB2b2lkIGNhbGN1bGF0ZVJlY3RzKGNvbnN0IENsaXBSZWN0 c0NvbnRleHQmLCBjb25zdCBMYXlvdXRSZWN0JiBwYWludERpcnR5UmVjdCwgTGF5b3V0UmVjdCYg bGF5ZXJCb3VuZHMsCg==