226413 2021-05-28 19:50:18 -0700 Stop using UncheckedLock in JSC::dumpJITMemory() 2021-05-29 14:10:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez darin ews-watchlist ggaren keith_miller mark.lam msaboff saam sam tzagallo webkit-bug-importer oldest_to_newest 1765054 0 cdumez 2021-05-28 19:50:18 -0700 Stop using UncheckedLock in JSC::dumpJITMemory() as it is being phased out in favor of Lock, which supports Clang thread safety analysis. 1765055 1 430084 cdumez 2021-05-28 19:51:42 -0700 Created attachment 430084 Patch 1765127 2 ews-feeder 2021-05-29 14:09:22 -0700 Committed r278242 (238279@main): <https://commits.webkit.org/238279@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430084. 1765128 3 webkit-bug-importer 2021-05-29 14:10:17 -0700 <rdar://problem/78653082> 430084 2021-05-28 19:51:42 -0700 2021-05-29 14:09:23 -0700 Patch bug-226413-20210528195141.patch text/plain 5531 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MjMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 YmVlZDViZDUxYzA0M2I0ZTQ0N2FjYjNkYzM0MDkzZjczZGE1ZDg2Li40MzM5NDMzNjc2YzIyMDUw YWY3Zjk2NjU2ZmM1ZDQ5NGRiZWIyMmVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMS0wNS0yOCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgor CisgICAgICAgIFN0b3AgdXNpbmcgVW5jaGVja2VkTG9jayBpbiBKU0M6OmR1bXBKSVRNZW1vcnko KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2NDEz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3RvcCB1 c2luZyBVbmNoZWNrZWRMb2NrIGluIEpTQzo6ZHVtcEpJVE1lbW9yeSgpIGFzIGl0IGlzIGJlaW5n IHBoYXNlZCBvdXQgaW4gZmF2b3Igb2YgTG9jaywKKyAgICAgICAgd2hpY2ggc3VwcG9ydHMgQ2xh bmcgdGhyZWFkIHNhZmV0eSBhbmFseXNpcy4KKworICAgICAgICAqIGppdC9FeGVjdXRhYmxlQWxs b2NhdG9yLmNwcDoKKyAgICAgICAgKEpTQzo6ZHVtcEpJVE1lbW9yeSk6CisKIDIwMjEtMDUtMjgg IENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBTdG9wIHVzaW5nIFVu Y2hlY2tlZExvY2sgaW4gSlNDOjpXYXNtQ2FsbGVlUmVnaXN0cnkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5jcHAgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuY3BwCmluZGV4IDgzNDUzYTE0ZTg2 MTkyYTU2YzY0Y2ZiMzRkMDZlNjExYjc1OWZkOWYuLjBiZmFjYzc2MzBiYmRjNmM4NTQxYmE2NTAy OTc4YWQwZjRmOGM0MDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhl Y3V0YWJsZUFsbG9jYXRvci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVj dXRhYmxlQWxsb2NhdG9yLmNwcApAQCAtMTAzNCw2NyArMTAzNCw3MiBAQCB2b2lkIGR1bXBKSVRN ZW1vcnkoY29uc3Qgdm9pZCogZHN0LCBjb25zdCB2b2lkKiBzcmMsIHNpemVfdCBzaXplKQogICAg IFJFTEVBU0VfQVNTRVJUKE9wdGlvbnM6OmR1bXBKSVRNZW1vcnlQYXRoKCkpOwogCiAjaWYgT1Mo REFSV0lOKQotICAgIHN0YXRpYyBpbnQgZmQgPSAtMTsKKyAgICBzdGF0aWMgTG9jayBkdW1wSklU TWVtb3J5TG9jazsKKyAgICBzdGF0aWMgaW50IGZkIFdURl9HVUFSREVEX0JZX0xPQ0soZHVtcEpJ VE1lbW9yeUxvY2spID0gLTE7CiAgICAgc3RhdGljIHVpbnQ4X3QqIGJ1ZmZlcjsKICAgICBzdGF0 aWMgY29uc3RleHByIHNpemVfdCBidWZmZXJTaXplID0gZml4ZWRFeGVjdXRhYmxlTWVtb3J5UG9v bFNpemU7Ci0gICAgc3RhdGljIHNpemVfdCBvZmZzZXQgPSAwOwotICAgIHN0YXRpYyBVbmNoZWNr ZWRMb2NrIGR1bXBKSVRNZW1vcnlMb2NrOwotICAgIHN0YXRpYyBib29sIG5lZWRzVG9GbHVzaCA9 IGZhbHNlOwotICAgIHN0YXRpYyBhdXRvIGZsdXNoID0gW10oY29uc3QgQWJzdHJhY3RMb2NrZXIm KSB7Ci0gICAgICAgIGlmIChmZCA9PSAtMSkgewotICAgICAgICAgICAgU3RyaW5nIHBhdGggPSBP cHRpb25zOjpkdW1wSklUTWVtb3J5UGF0aCgpOwotICAgICAgICAgICAgcGF0aCA9IHBhdGgucmVw bGFjZSgiJXBpZCIsIFN0cmluZzo6bnVtYmVyKGdldEN1cnJlbnRQcm9jZXNzSUQoKSkpOwotICAg ICAgICAgICAgZmQgPSBvcGVuKEZpbGVTeXN0ZW06OmZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbihw YXRoKS5kYXRhKCksIE9fQ1JFQVQgfCBPX1RSVU5DIHwgT19BUFBFTkQgfCBPX1dST05MWSB8IE9f RVhMT0NLIHwgT19OT05CTE9DSywgMDY2Nik7Ci0gICAgICAgICAgICBSRUxFQVNFX0FTU0VSVChm ZCAhPSAtMSk7CisgICAgc3RhdGljIHNpemVfdCBvZmZzZXQgV1RGX0dVQVJERURfQllfTE9DSyhk dW1wSklUTWVtb3J5TG9jaykgPSAwOworICAgIHN0YXRpYyBib29sIG5lZWRzVG9GbHVzaCBXVEZf R1VBUkRFRF9CWV9MT0NLKGR1bXBKSVRNZW1vcnlMb2NrKSA9IGZhbHNlOworICAgIHN0YXRpYyBM YXp5TmV2ZXJEZXN0cm95ZWQ8UmVmPFdvcmtRdWV1ZT4+IGZsdXNoUXVldWU7CisgICAgc3RydWN0 IER1bXBKSVQgeworICAgICAgICBzdGF0aWMgdm9pZCBmbHVzaCgpIFdURl9SRVFVSVJFU19MT0NL KGR1bXBKSVRNZW1vcnlMb2NrKQorICAgICAgICB7CisgICAgICAgICAgICBpZiAoZmQgPT0gLTEp IHsKKyAgICAgICAgICAgICAgICBTdHJpbmcgcGF0aCA9IE9wdGlvbnM6OmR1bXBKSVRNZW1vcnlQ YXRoKCk7CisgICAgICAgICAgICAgICAgcGF0aCA9IHBhdGgucmVwbGFjZSgiJXBpZCIsIFN0cmlu Zzo6bnVtYmVyKGdldEN1cnJlbnRQcm9jZXNzSUQoKSkpOworICAgICAgICAgICAgICAgIGZkID0g b3BlbihGaWxlU3lzdGVtOjpmaWxlU3lzdGVtUmVwcmVzZW50YXRpb24ocGF0aCkuZGF0YSgpLCBP X0NSRUFUIHwgT19UUlVOQyB8IE9fQVBQRU5EIHwgT19XUk9OTFkgfCBPX0VYTE9DSyB8IE9fTk9O QkxPQ0ssIDA2NjYpOworICAgICAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJUKGZkICE9IC0xKTsK KyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIDo6d3JpdGUoZmQsIGJ1ZmZlciwgb2Zmc2V0KTsK KyAgICAgICAgICAgIG9mZnNldCA9IDA7CisgICAgICAgICAgICBuZWVkc1RvRmx1c2ggPSBmYWxz ZTsKKyAgICAgICAgfQorCisgICAgICAgIHN0YXRpYyB2b2lkIGVucXVldWVGbHVzaCgpIFdURl9S RVFVSVJFU19MT0NLKGR1bXBKSVRNZW1vcnlMb2NrKQorICAgICAgICB7CisgICAgICAgICAgICBp ZiAobmVlZHNUb0ZsdXNoKQorICAgICAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICAgICAg bmVlZHNUb0ZsdXNoID0gdHJ1ZTsKKyAgICAgICAgICAgIGZsdXNoUXVldWUuZ2V0KCktPmRpc3Bh dGNoQWZ0ZXIoU2Vjb25kcyhPcHRpb25zOjpkdW1wSklUTWVtb3J5Rmx1c2hJbnRlcnZhbCgpKSwg W10geworICAgICAgICAgICAgICAgIExvY2tlciBsb2NrZXIgeyBkdW1wSklUTWVtb3J5TG9jayB9 OworICAgICAgICAgICAgICAgIGlmICghbmVlZHNUb0ZsdXNoKQorICAgICAgICAgICAgICAgICAg ICByZXR1cm47CisgICAgICAgICAgICAgICAgZmx1c2goKTsKKyAgICAgICAgICAgIH0pOworICAg ICAgICB9CisKKyAgICAgICAgc3RhdGljIHZvaWQgd3JpdGUoY29uc3Qgdm9pZCogc3JjLCBzaXpl X3Qgc2l6ZSkgV1RGX1JFUVVJUkVTX0xPQ0soZHVtcEpJVE1lbW9yeUxvY2spCisgICAgICAgIHsK KyAgICAgICAgICAgIGlmIChVTkxJS0VMWShvZmZzZXQgKyBzaXplID4gYnVmZmVyU2l6ZSkpCisg ICAgICAgICAgICAgICAgZmx1c2goKTsKKyAgICAgICAgICAgIG1lbWNweShidWZmZXIgKyBvZmZz ZXQsIHNyYywgc2l6ZSk7CisgICAgICAgICAgICBvZmZzZXQgKz0gc2l6ZTsKKyAgICAgICAgICAg IGVucXVldWVGbHVzaCgpOwogICAgICAgICB9Ci0gICAgICAgIHdyaXRlKGZkLCBidWZmZXIsIG9m ZnNldCk7Ci0gICAgICAgIG9mZnNldCA9IDA7Ci0gICAgICAgIG5lZWRzVG9GbHVzaCA9IGZhbHNl OwogICAgIH07CiAKICAgICBzdGF0aWMgc3RkOjpvbmNlX2ZsYWcgb25jZTsKLSAgICBzdGF0aWMg TGF6eU5ldmVyRGVzdHJveWVkPFJlZjxXb3JrUXVldWU+PiBmbHVzaFF1ZXVlOwogICAgIHN0ZDo6 Y2FsbF9vbmNlKG9uY2UsIFtdIHsKICAgICAgICAgYnVmZmVyID0gYml0d2lzZV9jYXN0PHVpbnQ4 X3QqPihtYWxsb2MoYnVmZmVyU2l6ZSkpOwogICAgICAgICBmbHVzaFF1ZXVlLmNvbnN0cnVjdChX b3JrUXVldWU6OmNyZWF0ZSgianNjLmR1bXBKSVRNZW1vcnkucXVldWUiLCBXb3JrUXVldWU6OlR5 cGU6OlNlcmlhbCwgV29ya1F1ZXVlOjpRT1M6OkJhY2tncm91bmQpKTsKICAgICAgICAgc3RkOjph dGV4aXQoW10gewogICAgICAgICAgICAgTG9ja2VyIGxvY2tlciB7IGR1bXBKSVRNZW1vcnlMb2Nr IH07Ci0gICAgICAgICAgICBmbHVzaChsb2NrZXIpOworICAgICAgICAgICAgRHVtcEpJVDo6Zmx1 c2goKTsKICAgICAgICAgICAgIGNsb3NlKGZkKTsKICAgICAgICAgICAgIGZkID0gLTE7CiAgICAg ICAgIH0pOwogICAgIH0pOwogCi0gICAgc3RhdGljIGF1dG8gZW5xdWV1ZUZsdXNoID0gW10oY29u c3QgQWJzdHJhY3RMb2NrZXImKSB7Ci0gICAgICAgIGlmIChuZWVkc1RvRmx1c2gpCi0gICAgICAg ICAgICByZXR1cm47Ci0KLSAgICAgICAgbmVlZHNUb0ZsdXNoID0gdHJ1ZTsKLSAgICAgICAgZmx1 c2hRdWV1ZS5nZXQoKS0+ZGlzcGF0Y2hBZnRlcihTZWNvbmRzKE9wdGlvbnM6OmR1bXBKSVRNZW1v cnlGbHVzaEludGVydmFsKCkpLCBbXSB7Ci0gICAgICAgICAgICBMb2NrZXIgbG9ja2VyIHsgZHVt cEpJVE1lbW9yeUxvY2sgfTsKLSAgICAgICAgICAgIGlmICghbmVlZHNUb0ZsdXNoKQotICAgICAg ICAgICAgICAgIHJldHVybjsKLSAgICAgICAgICAgIGZsdXNoKGxvY2tlcik7Ci0gICAgICAgIH0p OwotICAgIH07Ci0KLSAgICBzdGF0aWMgYXV0byB3cml0ZSA9IFtdKGNvbnN0IEFic3RyYWN0TG9j a2VyJiBsb2NrZXIsIGNvbnN0IHZvaWQqIHNyYywgc2l6ZV90IHNpemUpIHsKLSAgICAgICAgaWYg KFVOTElLRUxZKG9mZnNldCArIHNpemUgPiBidWZmZXJTaXplKSkKLSAgICAgICAgICAgIGZsdXNo KGxvY2tlcik7Ci0gICAgICAgIG1lbWNweShidWZmZXIgKyBvZmZzZXQsIHNyYywgc2l6ZSk7Ci0g ICAgICAgIG9mZnNldCArPSBzaXplOwotICAgICAgICBlbnF1ZXVlRmx1c2gobG9ja2VyKTsKLSAg ICB9OwotCiAgICAgTG9ja2VyIGxvY2tlciB7IGR1bXBKSVRNZW1vcnlMb2NrIH07CiAgICAgdWlu dDY0X3QgdGltZSA9IG1hY2hfYWJzb2x1dGVfdGltZSgpOwogICAgIHVpbnQ2NF90IGRzdDY0ID0g Yml0d2lzZV9jYXN0PHVpbnRwdHJfdD4oZHN0KTsKICAgICB1aW50NjRfdCBzaXplNjQgPSBzaXpl OwogICAgIFRyYWNlU2NvcGUoRHVtcEpJVE1lbW9yeVN0YXJ0LCBEdW1wSklUTWVtb3J5U3RvcCwg dGltZSwgZHN0NjQsIHNpemU2NCk7Ci0gICAgd3JpdGUobG9ja2VyLCAmdGltZSwgc2l6ZW9mKHRp bWUpKTsKLSAgICB3cml0ZShsb2NrZXIsICZkc3Q2NCwgc2l6ZW9mKGRzdDY0KSk7Ci0gICAgd3Jp dGUobG9ja2VyLCAmc2l6ZTY0LCBzaXplb2Yoc2l6ZTY0KSk7Ci0gICAgd3JpdGUobG9ja2VyLCBz cmMsIHNpemUpOworICAgIER1bXBKSVQ6OndyaXRlKCZ0aW1lLCBzaXplb2YodGltZSkpOworICAg IER1bXBKSVQ6OndyaXRlKCZkc3Q2NCwgc2l6ZW9mKGRzdDY0KSk7CisgICAgRHVtcEpJVDo6d3Jp dGUoJnNpemU2NCwgc2l6ZW9mKHNpemU2NCkpOworICAgIER1bXBKSVQ6OndyaXRlKHNyYywgc2l6 ZSk7CiAjZWxzZQogICAgIFVOVVNFRF9QQVJBTShkc3QpOwogICAgIFVOVVNFRF9QQVJBTShzcmMp Owo=