22641 2008-12-03 18:26:59 -0800 Calling pauseTransitionAtTimeOnElementWithId() with garbage property name asserts 2008-12-04 12:44:48 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser pol oldest_to_newest 101287 0 simon.fraser 2008-12-03 18:26:59 -0800 If a LayoutTest calls pauseTransitionAtTimeOnElementWithId() with an unrecognized property name, like: layoutTestController.pauseTransitionAtTimeOnElementWithId("foopy", 0.5, "target"); it asserts here: ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) (/Volumes/InternalData/Development/webkit/WebKit.git/WebKitBuild/Debug/JavaScriptCore.framework/PrivateHeaders/HashTable.h:455 void WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::checkKey(const T&) [with T = int, HashTranslator = WTF::IdentityHashTranslator<int, std::pair<int, WTF::RefPtr<WebCore::ImplicitAnimation> >, WTF::IntHash<unsigned int> >, Key = int, Value = std::pair<int, WTF::RefPtr<WebCore::ImplicitAnimation> >, Extractor = WTF::PairFirstExtractor<std::pair<int, WTF::RefPtr<WebCore::ImplicitAnimation> > >, HashFunctions = WTF::IntHash<unsigned int>, Traits = WTF::PairHashTraits<WTF::HashTraits<int>, WTF::HashTraits<WTF::RefPtr<WebCore::ImplicitAnimation> > >, KeyTraits = WTF::HashTraits<int>]) 101289 1 25732 pol 2008-12-03 19:01:57 -0800 Created attachment 25732 Patch v1 101373 2 pol 2008-12-04 12:44:48 -0800 Sending WebCore/ChangeLog Sending WebCore/page/animation/CompositeAnimation.cpp Transmitting file data .. Committed revision 39002. 25732 2008-12-03 19:01:57 -0800 2008-12-03 19:34:00 -0800 Patch v1 Patch.txt text/plain 1832 pol ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzQ5NGFjMi4uNjBlMjFkZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOC0xMi0wMyAgUGllcnJlLU9saXZp ZXIgTGF0b3VyICA8cG9sQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXhlZCBwYXVzZVRyYW5zaXRpb25BdFRpbWVPbkVsZW1lbnRX aXRoSWQoKSBpbiBEUlQgYXNzZXJ0aW5nIHdoZW4gcGFzc2VkIGludmFsaWQgcHJvcGVydHkgbmFt ZQorICAgICAgICBhbmQgcG90ZW50aWFsIHNpbWlsYXIgaXNzdWUgd2l0aCBwYXVzZUFuaW1hdGlv bkF0VGltZU9uRWxlbWVudFdpdGhJZCgpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjY0MQorCisgICAgICAgICogcGFnZS9hbmltYXRpb24vQ29t cG9zaXRlQW5pbWF0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvbXBvc2l0ZUFuaW1hdGlv blByaXZhdGU6OnBhdXNlQW5pbWF0aW9uQXRUaW1lKToKKyAgICAgICAgKFdlYkNvcmU6OkNvbXBv c2l0ZUFuaW1hdGlvblByaXZhdGU6OnBhdXNlVHJhbnNpdGlvbkF0VGltZSk6CisKIDIwMDgtMTIt MDMgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJ1YmJlci1zdGFt cGVkIGJ5IERhdmlkIEh5YXR0LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9D b21wb3NpdGVBbmltYXRpb24uY3BwIGIvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9Db21wb3NpdGVB bmltYXRpb24uY3BwCmluZGV4IGIzZTQ3ZDAuLmI5NjI4ODcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv cGFnZS9hbmltYXRpb24vQ29tcG9zaXRlQW5pbWF0aW9uLmNwcAorKysgYi9XZWJDb3JlL3BhZ2Uv YW5pbWF0aW9uL0NvbXBvc2l0ZUFuaW1hdGlvbi5jcHAKQEAgLTUxOCw2ICs1MTgsOSBAQCB2b2lk IENvbXBvc2l0ZUFuaW1hdGlvblByaXZhdGU6OnNldFdhaXRpbmdGb3JTdHlsZUF2YWlsYWJsZShi b29sIHdhaXRpbmcpCiAKIGJvb2wgQ29tcG9zaXRlQW5pbWF0aW9uUHJpdmF0ZTo6cGF1c2VBbmlt YXRpb25BdFRpbWUoY29uc3QgQXRvbWljU3RyaW5nJiBuYW1lLCBkb3VibGUgdCkKIHsKKyAgICBp ZiAoIW5hbWUpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgIFJlZlB0cjxLZXlmcmFtZUFu aW1hdGlvbj4ga2V5ZnJhbWVBbmltID0gbV9rZXlmcmFtZUFuaW1hdGlvbnMuZ2V0KG5hbWUuaW1w bCgpKTsKICAgICBpZiAoIWtleWZyYW1lQW5pbSB8fCAha2V5ZnJhbWVBbmltLT5ydW5uaW5nKCkp CiAgICAgICAgIHJldHVybiBmYWxzZTsKQEAgLTUzMyw2ICs1MzYsOSBAQCBib29sIENvbXBvc2l0 ZUFuaW1hdGlvblByaXZhdGU6OnBhdXNlQW5pbWF0aW9uQXRUaW1lKGNvbnN0IEF0b21pY1N0cmlu ZyYgbmFtZSwgZAogCiBib29sIENvbXBvc2l0ZUFuaW1hdGlvblByaXZhdGU6OnBhdXNlVHJhbnNp dGlvbkF0VGltZShpbnQgcHJvcGVydHksIGRvdWJsZSB0KQogeworICAgIGlmICgocHJvcGVydHkg PCBmaXJzdENTU1Byb3BlcnR5KSB8fCAocHJvcGVydHkgPj0gZmlyc3RDU1NQcm9wZXJ0eSArIG51 bUNTU1Byb3BlcnRpZXMpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKICAgICBJbXBsaWNpdEFu aW1hdGlvbiogaW1wbEFuaW0gPSBtX3RyYW5zaXRpb25zLmdldChwcm9wZXJ0eSkuZ2V0KCk7CiAg ICAgaWYgKCFpbXBsQW5pbSB8fCAhaW1wbEFuaW0tPnJ1bm5pbmcoKSkKICAgICAgICAgcmV0dXJu IGZhbHNlOwo=