226403 2021-05-28 16:05:10 -0700 add window.internals.log() 2021-06-09 20:23:58 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 heycam heycam ap thorton webkit-bug-importer oldest_to_newest 1764982 0 heycam 2021-05-28 16:05:10 -0700 I found it useful while debugging tests to have a way to output logging from within the test. 1764984 1 430067 heycam 2021-05-28 16:08:44 -0700 Created attachment 430067 Patch 1765023 2 430067 ap 2021-05-28 17:14:52 -0700 Comment on attachment 430067 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430067&action=review > Source/WebCore/ChangeLog:9 > + Useful for interleaving some output generated from within a test with > + WebCore logging. Could you please elaborate on how the behavior is different from window.console.log? Is this to have something in the system log? 1765036 3 heycam 2021-05-28 17:39:30 -0700 This is specifically to add something to stderr. When I was debugging a test with WebCore logging enabled, I wanted to add some markers to stderr before and after the JS stuff that I was interested in. 1765037 4 430079 heycam 2021-05-28 17:43:04 -0700 Created attachment 430079 Patch 1766976 5 webkit-bug-importer 2021-06-04 16:06:20 -0700 <rdar://problem/78890214> 1768411 6 430079 thorton 2021-06-09 17:46:10 -0700 Comment on attachment 430079 Patch Does not seem outrageous to have a way to get to WTFLogAlways from internals. 1768448 7 ews-feeder 2021-06-09 20:23:55 -0700 Committed r278690 (238664@main): <https://commits.webkit.org/238664@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430079. 430067 2021-05-28 16:08:44 -0700 2021-05-28 17:43:00 -0700 Patch bug-226403-20210529090842.patch text/plain 2465 heycam U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGQ2ZWYwYzAzZGM5NTFm MGVmOTEyMjIyMDFlM2QyYzQ5NmY1ZTAwMS4uNDU4YzUzMTY1OTI0NGYzY2QxOTY0ODczZjRhNmEy MjRhNzlhNGFkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA1LTI4ICBDYW1l cm9uIE1jQ29ybWFjayAgPGhleWNhbUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHdpbmRvdy5p bnRlcm5hbHMubG9nKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIyNjQwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFVzZWZ1bCBmb3IgaW50ZXJsZWF2aW5nIHNvbWUgb3V0cHV0IGdlbmVyYXRlZCBmcm9t IHdpdGhpbiBhIHRlc3Qgd2l0aAorICAgICAgICBXZWJDb3JlIGxvZ2dpbmcuCisKKyAgICAgICAg KiB0ZXN0aW5nL0ludGVybmFscy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnRlcm5hbHM6Omxv Zyk6CisgICAgICAgICogdGVzdGluZy9JbnRlcm5hbHMuaDoKKyAgICAgICAgKiB0ZXN0aW5nL0lu dGVybmFscy5pZGw6CisKIDIwMjEtMDUtMjggIEplYW4tWXZlcyBBdmVuYXJkICA8anlhQGFwcGxl LmNvbT4KIAogICAgICAgICBBZGQgTWVkaWFTZXNzaW9uLmNhbGxBY3Rpb25IYW5kbGVyCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKaW5kZXggMmYxNDM2MWY4OTZhYzg0MzkxNWQ5ZTQ5 MDk3OGJkNDkyYjMyYjBiMi4uNDc5Y2RjZjFjMzIwNzE1YTgyZDIxOWM4OWZjZDFmNGY3M2RhZmJl NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcApAQCAtNzY3LDYgKzc2NywxMSBA QCBTdHJpbmcgSW50ZXJuYWxzOjpkZXNjcmlwdGlvbihKU0M6OkpTVmFsdWUgdmFsdWUpCiAgICAg cmV0dXJuIHRvU3RyaW5nKHZhbHVlKTsKIH0KIAordm9pZCBJbnRlcm5hbHM6OmxvZyhjb25zdCBT dHJpbmcmIHZhbHVlKQoreworICAgIFdURkxvZ0Fsd2F5cygiJXMiLCB2YWx1ZS51dGY4KCkuZGF0 YSgpKTsKK30KKwogYm9vbCBJbnRlcm5hbHM6OmlzUHJlbG9hZGVkKGNvbnN0IFN0cmluZyYgdXJs KQogewogICAgIERvY3VtZW50KiBkb2N1bWVudCA9IGNvbnRleHREb2N1bWVudCgpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuaCBiL1NvdXJjZS9XZWJDb3Jl L3Rlc3RpbmcvSW50ZXJuYWxzLmgKaW5kZXggMTg0NTY0NjQ2MWVkYzMxZmE5ZjU5Y2U3MGYwMWE1 OWNlYWEwNjc0Ny4uNzI1ZDNjNTM3MDUyMmVlZjI2ZjQwNDA4MjU5OGVkZTlkMDE3NTk2MSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5oCkBAIC0xNzAsNiArMTcwLDcgQEAgcHVibGljOgog ICAgIGJvb2wgbm9kZU5lZWRzU3R5bGVSZWNhbGMoTm9kZSYpOwogICAgIFN0cmluZyBzdHlsZUNo YW5nZVR5cGUoTm9kZSYpOwogICAgIFN0cmluZyBkZXNjcmlwdGlvbihKU0M6OkpTVmFsdWUpOwor ICAgIHZvaWQgbG9nKGNvbnN0IFN0cmluZyYpOwogCiAgICAgYm9vbCBpc1ByZWxvYWRlZChjb25z dCBTdHJpbmcmIHVybCk7CiAgICAgYm9vbCBpc0xvYWRpbmdGcm9tTWVtb3J5Q2FjaGUoY29uc3Qg U3RyaW5nJiB1cmwpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5h bHMuaWRsIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuaWRsCmluZGV4IGY3Nzc2 NjU4YjI0ZTE0ZGQ3YWY1ZGFkNjg1OTc0NDE2NmY3YjAzZjQuLmE5YmU3M2MzM2E2MTM0YWJhODNh NDU1ODJkOGExYTEzNzEzYmQyZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rlc3Rpbmcv SW50ZXJuYWxzLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5pZGwK QEAgLTI4MCw2ICsyODAsNyBAQCBlbnVtIFRyZWVUeXBlIHsKICAgICBib29sZWFuIG5vZGVOZWVk c1N0eWxlUmVjYWxjKE5vZGUgbm9kZSk7CiAgICAgRE9NU3RyaW5nIHN0eWxlQ2hhbmdlVHlwZShO b2RlIG5vZGUpOwogICAgIERPTVN0cmluZyBkZXNjcmlwdGlvbihhbnkgdmFsdWUpOworICAgIHVu ZGVmaW5lZCBsb2coRE9NU3RyaW5nIHZhbHVlKTsKIAogICAgIC8vIEFuaW1hdGVkIGltYWdlIHBh dXNpbmcgdGVzdGluZy4KICAgICBib29sZWFuIGhhc1BhdXNlZEltYWdlQW5pbWF0aW9ucyhFbGVt ZW50IGVsZW1lbnQpOwo= 430079 2021-05-28 17:43:04 -0700 2021-06-09 20:23:57 -0700 Patch bug-226403-20210529104302.patch text/plain 2697 heycam U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGQ2ZWYwYzAzZGM5NTFm MGVmOTEyMjIyMDFlM2QyYzQ5NmY1ZTAwMS4uM2FkZDdjMjIxYzAwZTFiNjJhODkzMWNiNzhlYjA0 MThkNmYxNWVlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTA1LTI4ICBDYW1l cm9uIE1jQ29ybWFjayAgPGhleWNhbUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHdpbmRvdy5p bnRlcm5hbHMubG9nKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIyNjQwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIHdpbmRvdy5pbnRlcm5hbHMubG9nKCkgd3JpdGVzIG91dHB1dCB0byBzdGRlcnIgdXNp bmcgV1RGTG9nQWx3YXlzLgorICAgICAgICBUaGlzIG1heSBiZSB1c2VmdWwgZm9yIGludGVybGVh dmluZyBzb21lIG91dHB1dCBnZW5lcmF0ZWQgZnJvbSB3aXRoaW4gYQorICAgICAgICB0ZXN0IHdp dGggV2ViQ29yZSBsb2dnaW5nLCB3aGljaCBhbHNvIGdvZXMgdG8gc3RkZXJyLiBjb25zb2xlLmxv ZygpCisgICAgICAgIGRvZXNuJ3Qgd29yayBmb3IgdGhpcywgc2luY2UgdGhhdCBnb2VzIHRvIHN0 ZG91dCBhbmQgaXMgY2FwdHVyZWQgYXMKKyAgICAgICAgdGhlIHRlc3Qgb3V0cHV0LgorCisgICAg ICAgICogdGVzdGluZy9JbnRlcm5hbHMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW50ZXJuYWxz Ojpsb2cpOgorICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxzLmg6CisgICAgICAgICogdGVzdGlu Zy9JbnRlcm5hbHMuaWRsOgorCiAyMDIxLTA1LTI4ICBKZWFuLVl2ZXMgQXZlbmFyZCAgPGp5YUBh cHBsZS5jb20+CiAKICAgICAgICAgQWRkIE1lZGlhU2Vzc2lvbi5jYWxsQWN0aW9uSGFuZGxlcgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwIGIvU291cmNl L1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCmluZGV4IDJmMTQzNjFmODk2YWM4NDM5MTVk OWU0OTA5NzhiZDQ5MmIzMmIwYjIuLjQ3OWNkY2YxYzMyMDcxNWE4MmQyMTljODlmY2QxZjRmNzNk YWZiZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKQEAgLTc2Nyw2ICs3Njcs MTEgQEAgU3RyaW5nIEludGVybmFsczo6ZGVzY3JpcHRpb24oSlNDOjpKU1ZhbHVlIHZhbHVlKQog ICAgIHJldHVybiB0b1N0cmluZyh2YWx1ZSk7CiB9CiAKK3ZvaWQgSW50ZXJuYWxzOjpsb2coY29u c3QgU3RyaW5nJiB2YWx1ZSkKK3sKKyAgICBXVEZMb2dBbHdheXMoIiVzIiwgdmFsdWUudXRmOCgp LmRhdGEoKSk7Cit9CisKIGJvb2wgSW50ZXJuYWxzOjppc1ByZWxvYWRlZChjb25zdCBTdHJpbmcm IHVybCkKIHsKICAgICBEb2N1bWVudCogZG9jdW1lbnQgPSBjb250ZXh0RG9jdW1lbnQoKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmggYi9Tb3VyY2UvV2Vi Q29yZS90ZXN0aW5nL0ludGVybmFscy5oCmluZGV4IDE4NDU2NDY0NjFlZGMzMWZhOWY1OWNlNzBm MDFhNTljZWFhMDY3NDcuLjcyNWQzYzUzNzA1MjJlZWYyNmY0MDQwODI1OThlZGU5ZDAxNzU5NjEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuaApAQCAtMTcwLDYgKzE3MCw3IEBAIHB1Ymxp YzoKICAgICBib29sIG5vZGVOZWVkc1N0eWxlUmVjYWxjKE5vZGUmKTsKICAgICBTdHJpbmcgc3R5 bGVDaGFuZ2VUeXBlKE5vZGUmKTsKICAgICBTdHJpbmcgZGVzY3JpcHRpb24oSlNDOjpKU1ZhbHVl KTsKKyAgICB2b2lkIGxvZyhjb25zdCBTdHJpbmcmKTsKIAogICAgIGJvb2wgaXNQcmVsb2FkZWQo Y29uc3QgU3RyaW5nJiB1cmwpOwogICAgIGJvb2wgaXNMb2FkaW5nRnJvbU1lbW9yeUNhY2hlKGNv bnN0IFN0cmluZyYgdXJsKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50 ZXJuYWxzLmlkbCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmlkbAppbmRleCBm Nzc3NjY1OGIyNGUxNGRkN2FmNWRhZDY4NTk3NDQxNjZmN2IwM2Y0Li5hOWJlNzNjMzNhNjEzNGFi YTgzYTQ1NTgyZDhhMWExMzcxM2JkMmVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS90ZXN0 aW5nL0ludGVybmFscy5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMu aWRsCkBAIC0yODAsNiArMjgwLDcgQEAgZW51bSBUcmVlVHlwZSB7CiAgICAgYm9vbGVhbiBub2Rl TmVlZHNTdHlsZVJlY2FsYyhOb2RlIG5vZGUpOwogICAgIERPTVN0cmluZyBzdHlsZUNoYW5nZVR5 cGUoTm9kZSBub2RlKTsKICAgICBET01TdHJpbmcgZGVzY3JpcHRpb24oYW55IHZhbHVlKTsKKyAg ICB1bmRlZmluZWQgbG9nKERPTVN0cmluZyB2YWx1ZSk7CiAKICAgICAvLyBBbmltYXRlZCBpbWFn ZSBwYXVzaW5nIHRlc3RpbmcuCiAgICAgYm9vbGVhbiBoYXNQYXVzZWRJbWFnZUFuaW1hdGlvbnMo RWxlbWVudCBlbGVtZW50KTsK