226398 2021-05-28 14:44:44 -0700 Crash in HTMLConverter::_addLinkForElement() 2021-06-03 01:42:18 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified macOS 11 RESOLVED FIXED InRadar P2 Normal --- 1 julian_a_gonzalez webkit-unassigned ews-watchlist mifenton rniwa wenson_hsieh oldest_to_newest 1764942 0 julian_a_gonzalez 2021-05-28 14:44:44 -0700 e.g. 0 HTMLConverter::_addLinkForElement(WebCore::Element&, _NSRange)+1430 1 HTMLConverter::_exitElement(WebCore::Element&, long, unsigned long)+391 2 HTMLConverter::_traverseNode(WebCore::Node&, unsigned int, bool)+850 3 HTMLConverter::_traverseNode(WebCore::Node&, unsigned int, bool)+1166 4 HTMLConverter::_traverseNode(WebCore::Node&, unsigned int, bool)+1166 5 HTMLConverter::convert()+362 6 WebCore::attributedString(WebCore::SimpleRange const&)+275 7 WebCore::selectionAsAttributedString(WebCore::Document const&)+286 8 WebCore::Editor::writeSelectionToPasteboard(WebCore::Pasteboard&)+334 9 WebCore::Editor::performCutOrCopy(WebCore::Editor::EditorActionSpecifier)+1402 <rdar://problem/78216316> 1764944 1 430058 julian_a_gonzalez 2021-05-28 14:49:35 -0700 Created attachment 430058 Patch 1765096 2 430058 rniwa 2021-05-29 11:28:13 -0700 Comment on attachment 430058 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430058&action=review > Source/WebCore/editing/cocoa/HTMLConverter.mm:2219 > - _exitElement(element, depth, startIndex); > + if (startIndex <= [_attrStr length]) It seems that we don't even want to call _processElement when this condition isn't met? 1765686 3 julian_a_gonzalez 2021-06-01 11:16:42 -0700 (In reply to Ryosuke Niwa from comment #2) > Comment on attachment 430058 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=430058&action=review > > > Source/WebCore/editing/cocoa/HTMLConverter.mm:2219 > > - _exitElement(element, depth, startIndex); > > + if (startIndex <= [_attrStr length]) > > It seems that we don't even want to call _processElement when this condition > isn't met? When the call to _processElement happens, startIndex is within the bounds of [_attrStr length]. The operations inside the else block right above here cause this condition to be violated (this code assuming that [_attrStr length] does not change is the bug). 1765918 4 430058 rniwa 2021-06-02 02:04:06 -0700 Comment on attachment 430058 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430058&action=review >>> Source/WebCore/editing/cocoa/HTMLConverter.mm:2219 >>> + if (startIndex <= [_attrStr length]) >> >> It seems that we don't even want to call _processElement when this condition isn't met? > > When the call to _processElement happens, startIndex is within the bounds of [_attrStr length]. The operations inside the else block right above here cause this condition to be violated (this code assuming that [_attrStr length] does not change is the bug). I see. In that case, I think we just need to adjust startIndex instead of avoid calling _exitElement. > LayoutTests/editing/pasteboard/cut-paste-mouse-event.html:9 > +function styleonload() { Can we call this runTest or something? > LayoutTests/editing/pasteboard/cut-paste-mouse-event.html:12 > + document.createEvent("MouseEvent").initMouseEvent("1", document.execCommand("paste", false), 0, null, 0, document.execCommand("cut", false)); Surely creating MouseEvent is nothing to do with this crash? As far as I just tested, this should work: document.execCommand("selectAll", false); document.execCommand("createLink", false, "test"); document.execCommand("cut", false); 1766185 5 430412 julian_a_gonzalez 2021-06-02 15:29:07 -0700 Created attachment 430412 Patch 1766199 6 430412 rniwa 2021-06-02 16:11:42 -0700 Comment on attachment 430412 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430412&action=review > Source/WebCore/editing/cocoa/HTMLConverter.mm:-2201 > - NSUInteger startIndex = [_attrStr length]; Oh neat. 1766239 7 rniwa 2021-06-02 17:41:17 -0700 WK1 failures looks real: --- /Volumes/Data/worker/macOS-Catalina-Release-WK1-Tests-EWS/build/layout-test-results/editing/mac/attributed-string/anchor-element-expected.txt +++ /Volumes/Data/worker/macOS-Catalina-Release-WK1-Tests-EWS/build/layout-test-results/editing/mac/attributed-string/anchor-element-actual.txt @@ -27,7 +27,6 @@ NSColor: #0000ee (sRGB) NSFont: Times-Roman 16.00 pt. NSKern: 0pt - NSLink: https://webkit.org/ NSStrokeColor: #0000ee (sRGB) NSStrokeWidth: 0 NSUnderline: true 1766240 8 430412 rniwa 2021-06-02 17:44:49 -0700 Comment on attachment 430412 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=430412&action=review > Source/WebCore/editing/cocoa/HTMLConverter.mm:2218 > - _exitElement(element, depth, startIndex); > + _exitElement(element, depth, [_attrStr length]); Oh, this isn't quite right. startIndex is named so because we're adding more stuff to _attrStr. What's wrong with the existing code is that startIndex can be less than [_attrStr length]. So I think we need to use std::min(startIndex, [_attrStr length]) here. 1766241 9 430412 rniwa 2021-06-02 17:45:09 -0700 Comment on attachment 430412 Patch r- because of the aforementioned WK1 test failures. 1766262 10 430434 julian_a_gonzalez 2021-06-02 19:15:21 -0700 Created attachment 430434 Patch 1766274 11 rniwa 2021-06-02 20:51:51 -0700 Let's wait for other EWSs to catch up. 1766294 12 ews-feeder 2021-06-03 00:09:36 -0700 Committed r278398 (238423@main): <https://commits.webkit.org/238423@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430434. 430058 2021-05-28 14:49:35 -0700 2021-06-02 15:29:04 -0700 Patch bug-226398-20210528144934.patch text/plain 3825 julian_a_gonzalez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3OTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDM2NzNmODA2ZjE2ZTFh MWQ2ZDgyZWI3MjE1NTY3MTE3MGMwZTMxZi4uYzVmOTYxYjcxYjY3MDM0ZDhjNDFmYjM0NzFjNGZh ZjA4M2QyOWYwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA1LTI4ICBKdWxp YW4gR29uemFsZXogIDxqdWxpYW5fYV9nb256YWxlekBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jh c2ggaW4gSFRNTENvbnZlcnRlcjo6X2FkZExpbmtGb3JFbGVtZW50KCkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjM5OAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoaWxlIHRyYXZlcnNpbmcgYSBub2Rl LCBkb24ndCBleGl0IGFuIGVsZW1lbnQgd2hlbiB0aGUgc3RhcnRJbmRleCBpcworICAgICAgICBu b3cgb3V0c2lkZSB0aGUgYm91bmRzIG9mIHRoZSBhdHRyaWJ1dGUgc3RyaW5nLgorCisgICAgICAg IFRlc3Q6IGVkaXRpbmcvcGFzdGVib2FyZC9jdXQtcGFzdGUtbW91c2UtZXZlbnQuaHRtbAorCisg ICAgICAgICogZWRpdGluZy9jb2NvYS9IVE1MQ29udmVydGVyLm1tOgorICAgICAgICAoSFRNTENv bnZlcnRlcjo6X3RyYXZlcnNlTm9kZSk6CisKIDIwMjEtMDUtMjQgIERhcmluIEFkbGVyICA8ZGFy aW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBTdHJpbmdCdWlsZGVyOjphcHBlbmRMaXRl cmFsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2NvY29hL0hUTUxDb252ZXJ0 ZXIubW0gYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2NvY29hL0hUTUxDb252ZXJ0ZXIubW0KaW5k ZXggZDQ1ZjViNzQ4MGQ1ODNkOGQ5OTVmZGI1YjI1ZmQwYzYwMzY0ZmU1Ny4uZDk0ZWJiMjJjM2Jk ZDFkMDMzNDMzYTBiZTU1ZDk5MmQ4OGRhMjYwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv ZWRpdGluZy9jb2NvYS9IVE1MQ29udmVydGVyLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRp bmcvY29jb2EvSFRNTENvbnZlcnRlci5tbQpAQCAtMjIxNiw3ICsyMjE2LDggQEAgdm9pZCBIVE1M Q29udmVydGVyOjpfdHJhdmVyc2VOb2RlKE5vZGUmIG5vZGUsIHVuc2lnbmVkIGRlcHRoLCBib29s IGVtYmVkZGVkKQogICAgICAgICAgICAgICAgICAgICAgICAgY2hpbGQgPSBuZXh0U2libGluZ0lu Q29tcG9zZWRUcmVlSWdub3JpbmdVc2VyQWdlbnRTaGFkb3coKmNoaWxkKTsKICAgICAgICAgICAg ICAgICAgICAgfQogICAgICAgICAgICAgICAgIH0KLSAgICAgICAgICAgICAgICBfZXhpdEVsZW1l bnQoZWxlbWVudCwgZGVwdGgsIHN0YXJ0SW5kZXgpOworICAgICAgICAgICAgICAgIGlmIChzdGFy dEluZGV4IDw9IFtfYXR0clN0ciBsZW5ndGhdKQorICAgICAgICAgICAgICAgICAgICBfZXhpdEVs ZW1lbnQoZWxlbWVudCwgZGVwdGgsIHN0YXJ0SW5kZXgpOwogICAgICAgICAgICAgfQogICAgICAg ICB9CiAgICAgfSBlbHNlIGlmIChub2RlLm5vZGVUeXBlKCkgPT0gTm9kZTo6VEVYVF9OT0RFKQpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CmluZGV4IGUwNzU5ZWI4M2IzMjhhMDA2ZmIyZjY3NjY3ZDAwZTVlNmI5OWI2ZTEuLjA4ZWM3Mzdl NTA5NjJiMDE3MGIwOWUwZmFjMzJlYjgzZDRmZWM4NTcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAyMS0wNS0yOCAgSnVsaWFuIEdvbnphbGV6ICA8anVsaWFuX2FfZ29uemFsZXpAYXBwbGUuY29t PgorCisgICAgICAgIENyYXNoIGluIEhUTUxDb252ZXJ0ZXI6Ol9hZGRMaW5rRm9yRWxlbWVudCgp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjYzOTgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSB0 ZXN0IGZvciB0aGlzIGNyYXNoZXIuCisKKyAgICAgICAgKiBlZGl0aW5nL3Bhc3RlYm9hcmQvY3V0 LXBhc3RlLW1vdXNlLWV2ZW50LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZWRpdGlu Zy9wYXN0ZWJvYXJkL2N1dC1wYXN0ZS1tb3VzZS1ldmVudC5odG1sOiBBZGRlZC4KKwogMjAyMS0w NS0yNCAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgW0xh eW91dFRlc3RzXSBEZWxldGUgdW51c2VkIGpxdWVyeSByZXNvdXJjZXMKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2VkaXRpbmcvcGFzdGVib2FyZC9jdXQtcGFzdGUtbW91c2UtZXZlbnQtZXhwZWN0 ZWQudHh0IGIvTGF5b3V0VGVzdHMvZWRpdGluZy9wYXN0ZWJvYXJkL2N1dC1wYXN0ZS1tb3VzZS1l dmVudC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZjQzODEwMjVhMDVmZDhkMWI0MWE2YThiYTY2 ZjQ4YjVjZTM1OWYxMAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvcGFz dGVib2FyZC9jdXQtcGFzdGUtbW91c2UtZXZlbnQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAK K1RoaXMgdGVzdCBwYXNzZXMgaWYgV2ViS2l0IGRvZXMgbm90IGNyYXNoLiBQQVNTCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQvY3V0LXBhc3RlLW1vdXNlLWV2ZW50 Lmh0bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQvY3V0LXBhc3RlLW1vdXNlLWV2 ZW50Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uYjgzMGM4NDNiODFmYjkwNTJkNTU4OGJiNzRlMjkxZGE4MWVm ZWU3ZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvcGFzdGVib2FyZC9j dXQtcGFzdGUtbW91c2UtZXZlbnQuaHRtbApAQCAtMCwwICsxLDI3IEBACis8IURPQ1RZUEUgaHRt bD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAg IHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworCitkb2N1bWVudC5kZXNpZ25Nb2RlID0gJ29uJzsK K2Z1bmN0aW9uIHN0eWxlb25sb2FkKCkgeworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJzZWxl Y3RBbGwiLCBmYWxzZSk7CisgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoImNyZWF0ZUxpbmsiLCBm YWxzZSwgInRlc3QiKTsKKyAgICBkb2N1bWVudC5jcmVhdGVFdmVudCgiTW91c2VFdmVudCIpLmlu aXRNb3VzZUV2ZW50KCIxIiwgZG9jdW1lbnQuZXhlY0NvbW1hbmQoInBhc3RlIiwgZmFsc2UpLCAw LCBudWxsLCAwLCBkb2N1bWVudC5leGVjQ29tbWFuZCgiY3V0IiwgZmFsc2UpKTsKKyAgICBkb2N1 bWVudC53cml0ZSgnVGhpcyB0ZXN0IHBhc3NlcyBpZiBXZWJLaXQgZG9lcyBub3QgY3Jhc2guIFBB U1MnKTsKK30KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8L2E+CitUaGlzIHRlc3QgcGFz c2VzIGlmIFdlYktpdCBkb2VzIG5vdCBjcmFzaC4KKzxzdHlsZSBvbmxvYWQ9InN0eWxlb25sb2Fk KCkiPjwvc3R5bGU+Cis8L2E+Cis8b2wgY29udGVudGVkaXRhYmxlPSJmYWxzZSIgaGlkZGVuPSJo aWRkZW4iPgorPGxpPjwvbGk+Cis8L29sPgorPGlmcmFtZT48L2lmcmFtZT4KKzwvYm9keT4KKzwv aHRtbD4K 430412 2021-06-02 15:29:07 -0700 2021-06-02 19:15:19 -0700 Patch bug-226398-20210602152906.patch text/plain 4198 julian_a_gonzalez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3OTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDM2NzNmODA2ZjE2ZTFh MWQ2ZDgyZWI3MjE1NTY3MTE3MGMwZTMxZi4uMGE5NDFmMGExMWJmZWQ2MTA3MzcxMTFkZmU5YmNh NzdmNjg3NzhlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA2LTAyICBKdWxp YW4gR29uemFsZXogIDxqdWxpYW5fYV9nb256YWxlekBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jh c2ggaW4gSFRNTENvbnZlcnRlcjo6X2FkZExpbmtGb3JFbGVtZW50KCkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjM5OAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoaWxlIHRyYXZlcnNpbmcgYSBub2Rl LCBleGl0IGFuIGVsZW1lbnQgd2l0aCBhIHN0YXJ0SW5kZXgKKyAgICAgICAgdGhhdCBpcyBhbHdh eXMgaW5zaWRlIHRoZSBib3VuZHMgb2YgdGhlIGF0dHJpYnV0ZSBzdHJpbmcuCisKKyAgICAgICAg VGVzdDogZWRpdGluZy9wYXN0ZWJvYXJkL3NlbGVjdC1hbGwtbGluay1jdXQuaHRtbAorCisgICAg ICAgICogZWRpdGluZy9jb2NvYS9IVE1MQ29udmVydGVyLm1tOgorICAgICAgICAoSFRNTENvbnZl cnRlcjo6X3RyYXZlcnNlTm9kZSk6CisKIDIwMjEtMDUtMjQgIERhcmluIEFkbGVyICA8ZGFyaW5A YXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBTdHJpbmdCdWlsZGVyOjphcHBlbmRMaXRlcmFs CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2NvY29hL0hUTUxDb252ZXJ0ZXIu bW0gYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2NvY29hL0hUTUxDb252ZXJ0ZXIubW0KaW5kZXgg ZDQ1ZjViNzQ4MGQ1ODNkOGQ5OTVmZGI1YjI1ZmQwYzYwMzY0ZmU1Ny4uOTAxYWI1YjRlMTI1MTMz YTExY2Q2ZTVlNjM3MDA5ZDAzN2MyOTFiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRp dGluZy9jb2NvYS9IVE1MQ29udmVydGVyLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcv Y29jb2EvSFRNTENvbnZlcnRlci5tbQpAQCAtMjE5OCw3ICsyMTk4LDYgQEAgdm9pZCBIVE1MQ29u dmVydGVyOjpfdHJhdmVyc2VOb2RlKE5vZGUmIG5vZGUsIHVuc2lnbmVkIGRlcHRoLCBib29sIGVt YmVkZGVkKQogICAgIH0gZWxzZSBpZiAoaXM8RWxlbWVudD4obm9kZSkpIHsKICAgICAgICAgRWxl bWVudCYgZWxlbWVudCA9IGRvd25jYXN0PEVsZW1lbnQ+KG5vZGUpOwogICAgICAgICBpZiAoX2Vu dGVyRWxlbWVudChlbGVtZW50LCBlbWJlZGRlZCkpIHsKLSAgICAgICAgICAgIE5TVUludGVnZXIg c3RhcnRJbmRleCA9IFtfYXR0clN0ciBsZW5ndGhdOwogICAgICAgICAgICAgaWYgKF9wcm9jZXNz RWxlbWVudChlbGVtZW50LCBkZXB0aCkpIHsKICAgICAgICAgICAgICAgICBpZiAoYXV0byogc2hh ZG93Um9vdCA9IHNoYWRvd1Jvb3RJZ25vcmluZ1VzZXJBZ2VudFNoYWRvdyhlbGVtZW50KSkgLy8g VHJhdmVyc2UgdGhyb3VnaCBzaGFkb3cgcm9vdCB0byBkZXRlY3Qgc3RhcnQgYW5kIGVuZC4KICAg ICAgICAgICAgICAgICAgICAgX3RyYXZlcnNlTm9kZSgqc2hhZG93Um9vdCwgZGVwdGggKyAxLCBl bWJlZGRlZCk7CkBAIC0yMjE2LDcgKzIyMTUsNyBAQCB2b2lkIEhUTUxDb252ZXJ0ZXI6Ol90cmF2 ZXJzZU5vZGUoTm9kZSYgbm9kZSwgdW5zaWduZWQgZGVwdGgsIGJvb2wgZW1iZWRkZWQpCiAgICAg ICAgICAgICAgICAgICAgICAgICBjaGlsZCA9IG5leHRTaWJsaW5nSW5Db21wb3NlZFRyZWVJZ25v cmluZ1VzZXJBZ2VudFNoYWRvdygqY2hpbGQpOwogICAgICAgICAgICAgICAgICAgICB9CiAgICAg ICAgICAgICAgICAgfQotICAgICAgICAgICAgICAgIF9leGl0RWxlbWVudChlbGVtZW50LCBkZXB0 aCwgc3RhcnRJbmRleCk7CisgICAgICAgICAgICAgICAgX2V4aXRFbGVtZW50KGVsZW1lbnQsIGRl cHRoLCBbX2F0dHJTdHIgbGVuZ3RoXSk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9 IGVsc2UgaWYgKG5vZGUubm9kZVR5cGUoKSA9PSBOb2RlOjpURVhUX05PREUpCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTA3 NTllYjgzYjMyOGEwMDZmYjJmNjc2NjdkMDBlNWU2Yjk5YjZlMS4uMDVhZGM1YWExMDhhMjI4ZmE0 ZjVmZjQ5ODRiNTdhZWQ1NDcyZDVlMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTA2LTAy ICBKdWxpYW4gR29uemFsZXogIDxqdWxpYW5fYV9nb256YWxlekBhcHBsZS5jb20+CisKKyAgICAg ICAgQ3Jhc2ggaW4gSFRNTENvbnZlcnRlcjo6X2FkZExpbmtGb3JFbGVtZW50KCkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjM5OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIHRlc3QgZm9yIHRo aXMgY3Jhc2hlci4KKworICAgICAgICAqIGVkaXRpbmcvcGFzdGVib2FyZC9zZWxlY3QtYWxsLWxp bmstY3V0LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZWRpdGluZy9wYXN0ZWJvYXJk L3NlbGVjdC1hbGwtbGluay1jdXQuaHRtbDogQWRkZWQuCisKIDIwMjEtMDUtMjQgIEpvbmF0aGFu IEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIFtMYXlvdXRUZXN0c10gRGVs ZXRlIHVudXNlZCBqcXVlcnkgcmVzb3VyY2VzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0 aW5nL3Bhc3RlYm9hcmQvc2VsZWN0LWFsbC1saW5rLWN1dC1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQvc2VsZWN0LWFsbC1saW5rLWN1dC1leHBlY3RlZC50eHQK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uZjQzODEwMjVhMDVmZDhkMWI0MWE2YThiYTY2ZjQ4YjVjZTM1OWYxMAotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvcGFzdGVib2FyZC9zZWxlY3QtYWxs LWxpbmstY3V0LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitUaGlzIHRlc3QgcGFzc2VzIGlm IFdlYktpdCBkb2VzIG5vdCBjcmFzaC4gUEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRp dGluZy9wYXN0ZWJvYXJkL3NlbGVjdC1hbGwtbGluay1jdXQuaHRtbCBiL0xheW91dFRlc3RzL2Vk aXRpbmcvcGFzdGVib2FyZC9zZWxlY3QtYWxsLWxpbmstY3V0Lmh0bWwKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYjk0 YmY3YjFmYzg2ZmE0YWEwNzdkMWUxMWNkMjA4YTY0MjQ2ODYwNQotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2VkaXRpbmcvcGFzdGVib2FyZC9zZWxlY3QtYWxsLWxpbmstY3V0Lmh0bWwK QEAgLTAsMCArMSwyNyBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlw dD4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsK KworZG9jdW1lbnQuZGVzaWduTW9kZSA9ICdvbic7CitmdW5jdGlvbiBydW50ZXN0KCkgeworICAg IGRvY3VtZW50LmV4ZWNDb21tYW5kKCJzZWxlY3RBbGwiLCBmYWxzZSk7CisgICAgZG9jdW1lbnQu ZXhlY0NvbW1hbmQoImNyZWF0ZUxpbmsiLCBmYWxzZSwgInRlc3QiKTsKKyAgICBkb2N1bWVudC5l eGVjQ29tbWFuZCgiY3V0IiwgZmFsc2UpOworICAgIGRvY3VtZW50LndyaXRlKCdUaGlzIHRlc3Qg cGFzc2VzIGlmIFdlYktpdCBkb2VzIG5vdCBjcmFzaC4gUEFTUycpOworfQorPC9zY3JpcHQ+Cis8 L2hlYWQ+Cis8Ym9keT4KKzwvYT4KK1RoaXMgdGVzdCBwYXNzZXMgaWYgV2ViS2l0IGRvZXMgbm90 IGNyYXNoLgorPHN0eWxlIG9ubG9hZD0icnVudGVzdCgpIj48L3N0eWxlPgorPC9hPgorPG9sIGNv bnRlbnRlZGl0YWJsZT0iZmFsc2UiIGhpZGRlbj0iaGlkZGVuIj4KKzxsaT48L2xpPgorPC9vbD4K KzxpZnJhbWU+PC9pZnJhbWU+Cis8L2JvZHk+Cis8L2h0bWw+Cg== 430434 2021-06-02 19:15:21 -0700 2021-06-03 01:42:18 -0700 Patch bug-226398-20210602191520.patch text/plain 3663 julian_a_gonzalez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc3OTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDM2NzNmODA2ZjE2ZTFh MWQ2ZDgyZWI3MjE1NTY3MTE3MGMwZTMxZi4uMGE5NDFmMGExMWJmZWQ2MTA3MzcxMTFkZmU5YmNh NzdmNjg3NzhlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA2LTAyICBKdWxp YW4gR29uemFsZXogIDxqdWxpYW5fYV9nb256YWxlekBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jh c2ggaW4gSFRNTENvbnZlcnRlcjo6X2FkZExpbmtGb3JFbGVtZW50KCkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjM5OAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoaWxlIHRyYXZlcnNpbmcgYSBub2Rl LCBleGl0IGFuIGVsZW1lbnQgd2l0aCBhIHN0YXJ0SW5kZXgKKyAgICAgICAgdGhhdCBpcyBhbHdh eXMgaW5zaWRlIHRoZSBib3VuZHMgb2YgdGhlIGF0dHJpYnV0ZSBzdHJpbmcuCisKKyAgICAgICAg VGVzdDogZWRpdGluZy9wYXN0ZWJvYXJkL3NlbGVjdC1hbGwtbGluay1jdXQuaHRtbAorCisgICAg ICAgICogZWRpdGluZy9jb2NvYS9IVE1MQ29udmVydGVyLm1tOgorICAgICAgICAoSFRNTENvbnZl cnRlcjo6X3RyYXZlcnNlTm9kZSk6CisKIDIwMjEtMDUtMjQgIERhcmluIEFkbGVyICA8ZGFyaW5A YXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBTdHJpbmdCdWlsZGVyOjphcHBlbmRMaXRlcmFs CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2NvY29hL0hUTUxDb252ZXJ0ZXIu bW0gYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2NvY29hL0hUTUxDb252ZXJ0ZXIubW0KaW5kZXgg ZDQ1ZjViNzQ4MGQ1ODNkOGQ5OTVmZGI1YjI1ZmQwYzYwMzY0ZmU1Ny4uY2YwNGZiYTQ0ODQ1NTYw YTU1ZmZiZWFiM2Q0YTVhOTNjM2NhNTg3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRp dGluZy9jb2NvYS9IVE1MQ29udmVydGVyLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcv Y29jb2EvSFRNTENvbnZlcnRlci5tbQpAQCAtMjIxNiw3ICsyMjE2LDcgQEAgdm9pZCBIVE1MQ29u dmVydGVyOjpfdHJhdmVyc2VOb2RlKE5vZGUmIG5vZGUsIHVuc2lnbmVkIGRlcHRoLCBib29sIGVt YmVkZGVkKQogICAgICAgICAgICAgICAgICAgICAgICAgY2hpbGQgPSBuZXh0U2libGluZ0luQ29t cG9zZWRUcmVlSWdub3JpbmdVc2VyQWdlbnRTaGFkb3coKmNoaWxkKTsKICAgICAgICAgICAgICAg ICAgICAgfQogICAgICAgICAgICAgICAgIH0KLSAgICAgICAgICAgICAgICBfZXhpdEVsZW1lbnQo ZWxlbWVudCwgZGVwdGgsIHN0YXJ0SW5kZXgpOworICAgICAgICAgICAgICAgIF9leGl0RWxlbWVu dChlbGVtZW50LCBkZXB0aCwgc3RkOjptaW4oc3RhcnRJbmRleCwgW19hdHRyU3RyIGxlbmd0aF0p KTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0gZWxzZSBpZiAobm9kZS5ub2RlVHlw ZSgpID09IE5vZGU6OlRFWFRfTk9ERSkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBlMDc1OWViODNiMzI4YTAwNmZiMmY2NzY2 N2QwMGU1ZTZiOTliNmUxLi4wNWFkYzVhYTEwOGEyMjhmYTRmNWZmNDk4NGI1N2FlZDU0NzJkNWUx IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDYtMDIgIEp1bGlhbiBHb256YWxleiAgPGp1 bGlhbl9hX2dvbnphbGV6QGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCBpbiBIVE1MQ29udmVy dGVyOjpfYWRkTGlua0ZvckVsZW1lbnQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjI2Mzk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWRkIGEgdGVzdCBmb3IgdGhpcyBjcmFzaGVyLgorCisgICAgICAg ICogZWRpdGluZy9wYXN0ZWJvYXJkL3NlbGVjdC1hbGwtbGluay1jdXQtZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL3Bhc3RlYm9hcmQvc2VsZWN0LWFsbC1saW5rLWN1dC5o dG1sOiBBZGRlZC4KKwogMjAyMS0wNS0yNCAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBs ZS5jb20+CiAKICAgICAgICAgW0xheW91dFRlc3RzXSBEZWxldGUgdW51c2VkIGpxdWVyeSByZXNv dXJjZXMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvcGFzdGVib2FyZC9zZWxlY3Qt YWxsLWxpbmstY3V0LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2VkaXRpbmcvcGFzdGVib2Fy ZC9zZWxlY3QtYWxsLWxpbmstY3V0LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5mNDM4MTAyNWEw NWZkOGQxYjQxYTZhOGJhNjZmNDhiNWNlMzU5ZjEwCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZWRpdGluZy9wYXN0ZWJvYXJkL3NlbGVjdC1hbGwtbGluay1jdXQtZXhwZWN0ZWQudHh0 CkBAIC0wLDAgKzEgQEAKK1RoaXMgdGVzdCBwYXNzZXMgaWYgV2ViS2l0IGRvZXMgbm90IGNyYXNo LiBQQVNTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQvc2VsZWN0 LWFsbC1saW5rLWN1dC5odG1sIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9wYXN0ZWJvYXJkL3NlbGVj dC1hbGwtbGluay1jdXQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iOTRiZjdiMWZjODZmYTRhYTA3N2QxZTEx Y2QyMDhhNjQyNDY4NjA1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9w YXN0ZWJvYXJkL3NlbGVjdC1hbGwtbGluay1jdXQuaHRtbApAQCAtMCwwICsxLDI3IEBACis8IURP Q1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy50ZXN0UnVu bmVyKQorICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworCitkb2N1bWVudC5kZXNpZ25Nb2Rl ID0gJ29uJzsKK2Z1bmN0aW9uIHJ1bnRlc3QoKSB7CisgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQo InNlbGVjdEFsbCIsIGZhbHNlKTsKKyAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgiY3JlYXRlTGlu ayIsIGZhbHNlLCAidGVzdCIpOworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJjdXQiLCBmYWxz ZSk7CisgICAgZG9jdW1lbnQud3JpdGUoJ1RoaXMgdGVzdCBwYXNzZXMgaWYgV2ViS2l0IGRvZXMg bm90IGNyYXNoLiBQQVNTJyk7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPC9hPgor VGhpcyB0ZXN0IHBhc3NlcyBpZiBXZWJLaXQgZG9lcyBub3QgY3Jhc2guCis8c3R5bGUgb25sb2Fk PSJydW50ZXN0KCkiPjwvc3R5bGU+Cis8L2E+Cis8b2wgY29udGVudGVkaXRhYmxlPSJmYWxzZSIg aGlkZGVuPSJoaWRkZW4iPgorPGxpPjwvbGk+Cis8L29sPgorPGlmcmFtZT48L2lmcmFtZT4KKzwv Ym9keT4KKzwvaHRtbD4K