226388 2021-05-28 11:53:29 -0700 Fix LikelyDenseUnsignedIntegerSet::clear() 2021-05-28 13:17:53 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 226258 1 rmorisset rmorisset benjamin cdumez cmarcelo ews-watchlist mark.lam webkit-bug-importer oldest_to_newest 1764867 0 rmorisset 2021-05-28 11:53:29 -0700 There are two problems with it: 1) It calls BitVector::clearAll(), which does not free any memory. Instead, it should call BitVector::~BitVector(), then do a placement new of a fresh BitVector (to get it back to its inline condition) 2) More problematically, it changes m_size before calling isBitVector() which relies crucially on the value of m_size. So it is going to believe that it is in BitVector mode even when it is actually in HashSet mode. 1764872 1 rmorisset 2021-05-28 11:57:18 -0700 rdar://78607433 1764875 2 430037 rmorisset 2021-05-28 12:02:48 -0700 Created attachment 430037 Patch 1764883 3 430037 mark.lam 2021-05-28 12:38:41 -0700 Comment on attachment 430037 Patch r=me 1764897 4 430037 rmorisset 2021-05-28 13:05:39 -0700 Comment on attachment 430037 Patch Thanks for the review. Landing this as the wincairo failure is very clearly unrelated. 1764903 5 ews-feeder 2021-05-28 13:17:50 -0700 Committed r278224 (238262@main): <https://commits.webkit.org/238262@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430037. 430037 2021-05-28 12:02:48 -0700 2021-05-28 13:17:52 -0700 Patch patch226388 text/plain 2882 rmorisset ZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg NzA2MTI1YTIyZDQyLi42MWZiNDhmNjU4OTYgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9n CisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMDUtMjggIFJv YmluIE1vcmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KKworICAgICAgICBGaXggTGlrZWx5 RGVuc2VVbnNpZ25lZEludGVnZXJTZXQ6OmNsZWFyKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNjM4OAorICAgICAgICByZGFyOi8vNzg2MDc0MzMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVz cy9zdGFjay1hbGxvY2F0aW9uLXJlZ3Jlc3Npb24uanM6IEFkZGVkLgorICAgICAgICAoZm9vKToK KwogMjAyMS0wNS0yMiAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAK ICAgICAgICAgU3VwcG9ydCBFcmdvbm9taWMgQnJhbmQgQ2hlY2tzIHByb3Bvc2FsIChgI3ggaW4g b2JqYCkKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL3N0YWNrLWFsbG9jYXRpb24tcmVncmVz c2lvbi5qcyBiL0pTVGVzdHMvc3RyZXNzL3N0YWNrLWFsbG9jYXRpb24tcmVncmVzc2lvbi5qcwpu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAuLjlkNGQwZmJlNzM3MwotLS0g L2Rldi9udWxsCisrKyBiL0pTVGVzdHMvc3RyZXNzL3N0YWNrLWFsbG9jYXRpb24tcmVncmVzc2lv bi5qcwpAQCAtMCwwICsxLDggQEAKKy8vQCByZXF1aXJlT3B0aW9ucygiLS1mb3JjZUVhZ2VyQ29t cGlsYXRpb249MSIpCisKK2Z1bmN0aW9uIGZvbygpIHsKK2ZvciAobGV0IGEwIGluICdhJykKK2Zv ciAobGV0IGExIGluICdhJykKK2ZvciAobGV0IGk9MDsgaTwxMDAwMDAwMDAwOyBpKyspOworfQor Zm9vKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCmluZGV4IGQ2NDczZGM4NzNmOC4uMjZhM2RiYzRiNmYyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV1RGL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDIxLTA1LTI4ICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBhcHBsZS5jb20+CisK KyAgICAgICAgRml4IExpa2VseURlbnNlVW5zaWduZWRJbnRlZ2VyU2V0OjpjbGVhcigpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjYzODgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBhcmUgdHdv IHByb2JsZW1zIHdpdGggaXQ6CisgICAgICAgIDEpIEl0IGNhbGxzIEJpdFZlY3Rvcjo6Y2xlYXJB bGwoKSwgd2hpY2ggZG9lcyBub3QgZnJlZSBhbnkgbWVtb3J5LgorICAgICAgICBJbnN0ZWFkLCBp dCBzaG91bGQgY2FsbCBCaXRWZWN0b3I6On5CaXRWZWN0b3IoKSwgdGhlbiBkbyBhIHBsYWNlbWVu dCBuZXcgb2YgYSBmcmVzaCBCaXRWZWN0b3IgKHRvIGdldCBpdCBiYWNrIHRvIGl0cyBpbmxpbmUg Y29uZGl0aW9uKQorICAgICAgICAyKSBNb3JlIHByb2JsZW1hdGljYWxseSwgaXQgY2hhbmdlcyBt X3NpemUgYmVmb3JlIGNhbGxpbmcgaXNCaXRWZWN0b3IoKSB3aGljaCByZWxpZXMgY3J1Y2lhbGx5 IG9uIHRoZSB2YWx1ZSBvZiBtX3NpemUuCisgICAgICAgIFNvIGl0IGlzIGdvaW5nIHRvIGJlbGll dmUgdGhhdCBpdCBpcyBpbiBCaXRWZWN0b3IgbW9kZSBldmVuIHdoZW4gaXQgaXMgYWN0dWFsbHkg aW4gSGFzaFNldCBtb2RlLgorCisgICAgICAgICogd3RmL0xpa2VseURlbnNlVW5zaWduZWRJbnRl Z2VyU2V0Lmg6CisgICAgICAgIChXVEY6Okxpa2VseURlbnNlVW5zaWduZWRJbnRlZ2VyU2V0Ojpj bGVhcik6CisKIDIwMjEtMDUtMjcgIFNhaWQgQWJvdS1IYWxsYXdhICA8c2FpZEBhcHBsZS5jb20+ CiAKICAgICAgICAgVmFsdWVzIG9mIGtleVNwbGluZXMgY29udHJvbCBwb2ludHMgbXVzdCBhbGwg YmUgaW4gdGhlIHJhbmdlIDAgdG8gMQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvTGlrZWx5 RGVuc2VVbnNpZ25lZEludGVnZXJTZXQuaCBiL1NvdXJjZS9XVEYvd3RmL0xpa2VseURlbnNlVW5z aWduZWRJbnRlZ2VyU2V0LmgKaW5kZXggODhlM2Y0NTEwOTU2Li4wMjEwZjk0MjhlNmMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0xpa2VseURlbnNlVW5zaWduZWRJbnRlZ2VyU2V0LmgKKysr IGIvU291cmNlL1dURi93dGYvTGlrZWx5RGVuc2VVbnNpZ25lZEludGVnZXJTZXQuaApAQCAtNzcs MTUgKzc3LDE0IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgY2xlYXIoKQogICAgIHsKKyAgICAgICAg aWYgKGlzQml0VmVjdG9yKCkpCisgICAgICAgICAgICBtX2lubGluZS5iaXRWZWN0b3IufkJpdFZl Y3RvcigpOworICAgICAgICBlbHNlCisgICAgICAgICAgICBtX2lubGluZS5oYXNoU2V0Ln5IYXNo U2V0KCk7CisgICAgICAgIG5ldyAoTm90TnVsbCwgJm1faW5saW5lLmJpdFZlY3RvcikgQml0VmVj dG9yOwogICAgICAgICBtX3NpemUgPSAwOwogICAgICAgICBtX21pbiA9IDA7CiAgICAgICAgIG1f bWF4ID0gMDsKLSAgICAgICAgaWYgKGlzQml0VmVjdG9yKCkpCi0gICAgICAgICAgICBtX2lubGlu ZS5iaXRWZWN0b3IuY2xlYXJBbGwoKTsKLSAgICAgICAgZWxzZSB7Ci0gICAgICAgICAgICBtX2lu bGluZS5oYXNoU2V0Ln5IYXNoU2V0KCk7Ci0gICAgICAgICAgICBuZXcgKE5vdE51bGwsICZtX2lu bGluZS5iaXRWZWN0b3IpIEJpdFZlY3RvcjsKLSAgICAgICAgfQogICAgIH0KIAogICAgIGJvb2wg Y29udGFpbnMoSW5kZXhUeXBlIHZhbHVlKSBjb25zdAo=