226370 2021-05-28 03:26:26 -0700 [WPE] Correctly compute wheel event phase for 2D axis events 2021-05-28 08:57:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zan zan alex aperez clord webkit-bug-importer oldest_to_newest 1764719 0 zan 2021-05-28 03:26:26 -0700 [WPE] Correctly compute wheel event phase for 2D axis events 1764720 1 429999 zan 2021-05-28 03:30:08 -0700 Created attachment 429999 Patch 1764728 2 429999 aperez 2021-05-28 04:41:29 -0700 Comment on attachment 429999 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429999&action=review > Source/WebKit/UIProcess/API/wpe/WPEView.cpp:177 > +#if WPE_CHECK_VERSION(1, 5, 0) Would it make sense to remove the check and require libwpe 1.6.0+ unconditionally? Version 1.6.0 is a bit over a year old, so when WPE WebKit 2.34.0 hits the shelves by then it would be 1.5 years. I have no strong preference yet about whether to keep this one check or not, I only wanted to raise the question :) 1764757 3 429999 zan 2021-05-28 08:10:43 -0700 Comment on attachment 429999 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429999&action=review >> Source/WebKit/UIProcess/API/wpe/WPEView.cpp:177 >> +#if WPE_CHECK_VERSION(1, 5, 0) > > Would it make sense to remove the check and require libwpe 1.6.0+ unconditionally? > Version 1.6.0 is a bit over a year old, so when WPE WebKit 2.34.0 hits the shelves > by then it would be 1.5 years. > > I have no strong preference yet about whether to keep this one check or not, I only > wanted to raise the question :) This patch has to go into the 2.32 branch as-is. Decisions about minimum deps and when to remove these guards can wait for at least three more months. 1764758 4 ews-feeder 2021-05-28 08:11:05 -0700 zan@falconsigh.net does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/Tools/Scripts/webkitpy/common/config/contributors.json. Rejecting attachment 429999 from commit queue. 1764770 5 ews-feeder 2021-05-28 08:56:25 -0700 Committed r278198 (238241@main): <https://commits.webkit.org/238241@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429999. 1764771 6 webkit-bug-importer 2021-05-28 08:57:16 -0700 <rdar://problem/78619944> 429999 2021-05-28 03:30:08 -0700 2021-05-28 08:56:26 -0700 Patch bug-226370-20210528123006.patch text/plain 4353 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjc4MTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ1NmQzOGFjOWEwNGYxNGU0 Nzc3OGZhNzg3ZWRkMTcwMzg2NjFjOGQuLjUyYTRmYjNiNjc3Zjg3M2RlYTFlNjdjZGM2NmU0MjVm N2QwZDdlMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjEtMDUtMjggIFphbiBEb2Jl cnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdIENvcnJlY3RseSBj b21wdXRlIHdoZWVsIGV2ZW50IHBoYXNlIGZvciAyRCBheGlzIGV2ZW50cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI2MzcwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgMkQtY2FwYWJsZSB3cGVfaW5wdXRf YXhpc19ldmVudCBvYmplY3RzIGRvbid0IGhhdmUgdXNhYmxlIGF4aXMgYW5kIGRlbHRhCisgICAg ICAgIHZhbHVlcyBzZXQgb24gdGhlIGJhc2Ugc3RydWN0LCBidXQga2VlcCBhbGwgdGhhdCBpbmZv cm1hdGlvbiBvbiB0aGUgbW9yZQorICAgICAgICBkZXRhaWxlZCB3cGVfaW5wdXRfYXhpc18yZF9l dmVudCBzdHJ1Y3QuCisKKyAgICAgICAgRm9yIHN1Y2ggZXZlbnRzLCB0aGUgY29ycmVjdCBwaGFz ZSB0aGVuIGhhcyB0byBiZSBzcGVjaWFsLWNhc2VkLAorICAgICAgICBvdGhlcndpc2UgdGhlIGRl ZmF1bHQgZGV0ZXJtaW5hdGlvbiBtYXJrcyBib3RoIGF4ZXMgYXMgaW5hY3RpdmUgYW5kIG9ubHkK KyAgICAgICAgUGhhc2VFbmRlZCBldmVudHMgYXJlIGRpc3BhdGNoZWQgaW50byB0aGUgZW5naW5l LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS93cGUvV1BFVmlldy5jcHA6CisgICAgICAgIChX S1dQRTo6bV9iYWNrZW5kKToKKwogMjAyMS0wNS0yNyAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hz aWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbR1BVIFByb2Nlc3NdIEFkZCBkZWJ1ZyBsb2dnaW5n IGFyb3VuZCBzb21lIHNoYXJlZCBkaXNwbGF5IGxpc3QgY29kZXBhdGhzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL1dQRVZpZXcuY3BwIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL3dwZS9XUEVWaWV3LmNwcAppbmRleCBlNjk5NWUyNjJkY2U3YWI0MTFk MmEyYjc3YzNhZjkxMTM2ZmZlNDY5Li5kYzJiOGE4YTY1NjBiZjQ5MTVlMGQwNTU2MTM5MWIwMmZh MGM3Zjc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL1dQRVZp ZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvV1BFVmlldy5jcHAK QEAgLTE2Nyw2ICsxNjcsMjcgQEAgVmlldzo6VmlldyhzdHJ1Y3Qgd3BlX3ZpZXdfYmFja2VuZCog YmFja2VuZCwgY29uc3QgQVBJOjpQYWdlQ29uZmlndXJhdGlvbiYgYmFzZUMKICAgICAgICAgICAg ICAgICBIb3Jpem9udGFsCiAgICAgICAgICAgICB9OwogCisgICAgICAgICAgICAvLyBXZSB0cmVh dCBhbiBheGlzIG1vdGlvbiBldmVudCB3aXRoIGEgdmFsdWUgb2YgemVybyB0byBiZSBlcXVpdmFs ZW50CisgICAgICAgICAgICAvLyB0byBhICdzdG9wJyBldmVudC4gTW90aW9uIGV2ZW50cyB3aXRo IHplcm8gbW90aW9uIGRvbid0IGV4aXN0IG5hdHVyYWxseSwKKyAgICAgICAgICAgIC8vIHNvIHRo aXMgYWxsb3dzIGEgYmFja2VuZCB0byBleHByZXNzICdzdG9wJyBldmVudHMgd2l0aG91dCBjaGFu Z2luZyBBUEkuCisgICAgICAgICAgICAvLyBUaGUgd2hlZWwgZXZlbnQgcGhhc2UgaXMgYWRqdXN0 ZWQgYWNjb3JkaW5nbHkuCisgICAgICAgICAgICBXZWJXaGVlbEV2ZW50OjpQaGFzZSBwaGFzZSA9 IFdlYldoZWVsRXZlbnQ6OlBoYXNlOjpQaGFzZUNoYW5nZWQ7CisgICAgICAgICAgICBXZWJXaGVl bEV2ZW50OjpQaGFzZSBtb21lbnR1bVBoYXNlID0gV2ViV2hlZWxFdmVudDo6UGhhc2U6OlBoYXNl Tm9uZTsKKworI2lmIFdQRV9DSEVDS19WRVJTSU9OKDEsIDUsIDApCisgICAgICAgICAgICBpZiAo ZXZlbnQtPnR5cGUgJiB3cGVfaW5wdXRfYXhpc19ldmVudF90eXBlX21hc2tfMmQpIHsKKyAgICAg ICAgICAgICAgICBhdXRvKiBldmVudDJEID0gcmVpbnRlcnByZXRfY2FzdDxzdHJ1Y3Qgd3BlX2lu cHV0X2F4aXNfMmRfZXZlbnQqPihldmVudCk7CisgICAgICAgICAgICAgICAgdmlldy5tX2hvcml6 b250YWxTY3JvbGxBY3RpdmUgPSAhIWV2ZW50MkQtPnhfYXhpczsKKyAgICAgICAgICAgICAgICB2 aWV3Lm1fdmVydGljYWxTY3JvbGxBY3RpdmUgPSAhIWV2ZW50MkQtPnlfYXhpczsKKyAgICAgICAg ICAgICAgICBpZiAoIXZpZXcubV9ob3Jpem9udGFsU2Nyb2xsQWN0aXZlICYmICF2aWV3Lm1fdmVy dGljYWxTY3JvbGxBY3RpdmUpCisgICAgICAgICAgICAgICAgICAgIHBoYXNlID0gV2ViV2hlZWxF dmVudDo6UGhhc2U6OlBoYXNlRW5kZWQ7CisKKyAgICAgICAgICAgICAgICBhdXRvJiBwYWdlID0g dmlldy5wYWdlKCk7CisgICAgICAgICAgICAgICAgcGFnZS5oYW5kbGVXaGVlbEV2ZW50KFdlYktp dDo6TmF0aXZlV2ViV2hlZWxFdmVudChldmVudCwgcGFnZS5kZXZpY2VTY2FsZUZhY3RvcigpLCBw aGFzZSwgbW9tZW50dW1QaGFzZSkpOworICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAg ICAgIH0KKyNlbmRpZgorCiAgICAgICAgICAgICBzd2l0Y2ggKGV2ZW50LT5heGlzKSB7CiAgICAg ICAgICAgICBjYXNlIFZlcnRpY2FsOgogICAgICAgICAgICAgICAgIHZpZXcubV9ob3Jpem9udGFs U2Nyb2xsQWN0aXZlID0gISFldmVudC0+dmFsdWU7CkBAIC0xNzYsMTQgKzE5NywxNiBAQCBWaWV3 OjpWaWV3KHN0cnVjdCB3cGVfdmlld19iYWNrZW5kKiBiYWNrZW5kLCBjb25zdCBBUEk6OlBhZ2VD b25maWd1cmF0aW9uJiBiYXNlQwogICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAg fQogCi0gICAgICAgICAgICAvLyBXZSB0cmVhdCBhbiBheGlzIG1vdGlvbiBldmVudCB3aXRoIGEg dmFsdWUgb2YgemVybyB0byBiZSBlcXVpdmFsZW50Ci0gICAgICAgICAgICAvLyB0byBhICdzdG9w JyBldmVudC4gTW90aW9uIGV2ZW50cyB3aXRoIHplcm8gbW90aW9uIGRvbid0IGV4aXN0IG5hdHVy YWxseSwKLSAgICAgICAgICAgIC8vIHNvIHRoaXMgYWxsb3dzIGEgYmFja2VuZCB0byBleHByZXNz ICdzdG9wJyBldmVudHMgd2l0aG91dCBjaGFuZ2luZyBBUEkuCi0gICAgICAgICAgICBhdXRvJiBw YWdlID0gdmlldy5wYWdlKCk7Ci0gICAgICAgICAgICBpZiAoZXZlbnQtPnZhbHVlKQotICAgICAg ICAgICAgICAgIHBhZ2UuaGFuZGxlV2hlZWxFdmVudChXZWJLaXQ6Ok5hdGl2ZVdlYldoZWVsRXZl bnQoZXZlbnQsIHBhZ2UuZGV2aWNlU2NhbGVGYWN0b3IoKSwgV2ViV2hlZWxFdmVudDo6UGhhc2U6 OlBoYXNlQ2hhbmdlZCwgV2ViV2hlZWxFdmVudDo6UGhhc2U6OlBoYXNlTm9uZSkpOwotICAgICAg ICAgICAgZWxzZSBpZiAoIXZpZXcubV9ob3Jpem9udGFsU2Nyb2xsQWN0aXZlICYmICF2aWV3Lm1f dmVydGljYWxTY3JvbGxBY3RpdmUpCi0gICAgICAgICAgICAgICAgcGFnZS5oYW5kbGVXaGVlbEV2 ZW50KFdlYktpdDo6TmF0aXZlV2ViV2hlZWxFdmVudChldmVudCwgcGFnZS5kZXZpY2VTY2FsZUZh Y3RvcigpLCBXZWJXaGVlbEV2ZW50OjpQaGFzZTo6UGhhc2VFbmRlZCwgV2ViV2hlZWxFdmVudDo6 UGhhc2U6OlBoYXNlTm9uZSkpOworICAgICAgICAgICAgYm9vbCBzaG91bGREaXNwYXRjaCA9ICEh ZXZlbnQtPnZhbHVlOworICAgICAgICAgICAgaWYgKCF2aWV3Lm1faG9yaXpvbnRhbFNjcm9sbEFj dGl2ZSAmJiAhdmlldy5tX3ZlcnRpY2FsU2Nyb2xsQWN0aXZlKSB7CisgICAgICAgICAgICAgICAg c2hvdWxkRGlzcGF0Y2ggPSB0cnVlOworICAgICAgICAgICAgICAgIHBoYXNlID0gV2ViV2hlZWxF dmVudDo6UGhhc2U6OlBoYXNlRW5kZWQ7CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIGlm IChzaG91bGREaXNwYXRjaCkgeworICAgICAgICAgICAgICAgIGF1dG8mIHBhZ2UgPSB2aWV3LnBh Z2UoKTsKKyAgICAgICAgICAgICAgICBwYWdlLmhhbmRsZVdoZWVsRXZlbnQoV2ViS2l0OjpOYXRp dmVXZWJXaGVlbEV2ZW50KGV2ZW50LCBwYWdlLmRldmljZVNjYWxlRmFjdG9yKCksIHBoYXNlLCBt b21lbnR1bVBoYXNlKSk7CisgICAgICAgICAgICB9CiAgICAgICAgIH0sCiAgICAgICAgIC8vIGhh bmRsZV90b3VjaF9ldmVudAogICAgICAgICBbXSh2b2lkKiBkYXRhLCBzdHJ1Y3Qgd3BlX2lucHV0 X3RvdWNoX2V2ZW50KiBldmVudCkK